26 Commits

Author SHA1 Message Date
Bo Anderson
e3372e2a14 Lazily require some heavy files 2020-08-20 02:05:17 +01:00
Mike McQuaid
3a91c37e66
Fix RuboCop checks. 2020-08-19 17:12:32 +01:00
Markus Reiter
3b2a9c3b55
Merge pull request #8335 from waldyrious/show-cask-descs-in-info-command
Show cask description in `brew cask info` command
2020-08-14 00:52:27 +02:00
Waldir Pimenta
53932185e6 Show cask description as None if not present 2020-08-13 22:21:10 +01:00
Waldir Pimenta
619af6a723 Show cask description in brew cask info command 2020-08-13 22:21:10 +01:00
Markus Reiter
b48bc316e0 Use CLI::Parser for cask commands. 2020-08-13 05:15:15 +02:00
Markus Reiter
6c050492ee Pass args to Analytics instead of using global args. 2020-07-25 03:57:43 +02:00
Mike McQuaid
ac0665daff
Refer to default branch in links with HEAD
Anywhere we can use `blob/master` we can use `blob/HEAD` instead. This
will make life easier if we ever rename our default branch in future
(once/if Git and GitHub provides the necessary tooling to do so).
2020-06-25 11:38:40 +01:00
Tharun
aeede8374f fixed review changes 2020-05-19 21:41:02 +05:30
Tharun
139ca1d374 Updated analytics method name for cask info 2020-05-17 00:31:12 +05:30
Mike McQuaid
12a0c281ea
cask/cmd/info: fix brew style, refactor. 2019-07-16 21:10:21 +01:00
Isabell (Issy) Long
7a367980b6
Add a blank line between brew cask info output for multiple casks
- `brew info` adds a blank line between info output for multiple
  formulae. This replicates that display for `brew cask info`, as
  requested in Issue 6126.
2019-05-13 19:45:08 +01:00
Mike McQuaid
fc6bd2ea1c
Fixup more frozen string handling. 2019-04-20 14:07:29 +09:00
Mike McQuaid
36dbad3922
Add frozen_string_literal to all files. 2019-04-20 13:27:36 +09:00
Mike McQuaid
86f43f79ee
Enable/fix optional Ruby frozen string literal usage
Combined with https://github.com/Homebrew/homebrew-test-bot/pull/247
this will test Homebrew's use of frozen strings in CI. After this we
will then enable it for Homebrew developers and eventually all Homebrew
users.
2019-04-19 10:30:41 +09:00
Zach Auten
e9b17b8593 Replaced 'unless nil' with 'if' 2019-03-16 12:59:15 -04:00
Zach Auten
75b9eec7ef Renamed print_caveats, updated an info_spec test to macos only 2019-03-11 21:20:02 -04:00
Zach Auten
18a20986e7 Addressed style issues 2019-03-06 18:06:50 -05:00
Zach Auten
fe643758d7 Updated get_info
- get_info builds info string by appending helper functions
  - removed unnecessary returns
  - fixed indentation in missing_formula
  - reduced size of regex in info_spec
  - missing_formula will indicate when it finds a cask with same name
2019-03-06 00:27:48 -05:00
Zach Auten
330ae8c6fa print_caveats and get_info return heredocs 2019-02-24 21:53:04 -05:00
Zach Auten
ed80b60834 Fixed installation info output and imports 2019-02-21 21:08:57 -05:00
Zach Auten
554106d2e0 Updated missing formula cask reason
- search_for_cask in missing_formula renamed to is_a_cask_reason
    - is_a_cask calls new getInfo method in cask/cmd/info.rb to return info
      string
    - self.info in info.rb now calls getInfo and puts return value
    - added ohai_title to return the ohai printout for only titles, so that
      ohai printout could be added to the getInfo return string without
      calling puts.
    - refactored ohai to use ohai_title
    - updated info_spec.rb cask info test to be more specific when
      matching stderr.
    - is_a_cask_reason will respect 'silent'
    - refactored print_caveats to return instead of print
2019-02-18 03:33:57 -05:00
Markus Reiter
e9b9ea49a1 Update to RuboCop 0.59.1. 2018-09-17 03:45:59 +02:00
Markus Reiter
a84a1c63db Rename Hbc module to Cask. 2018-09-06 09:30:52 +02:00
Mike McQuaid
1ae2326984
Rename Cask::CLI to Cask::Cmd. 2018-09-04 09:56:58 +01:00
Mike McQuaid
1d86d7a7c7
cask: move cask/cli to cask/cmd. 2018-09-04 09:56:57 +01:00