6393 Commits

Author SHA1 Message Date
Jack Nagel
401bc1c6c7 The rack variable is only used inside the block now 2014-06-26 22:36:49 -05:00
Jack Nagel
301f1b20e6 Remove a dead branch from ARGV.kegs
rack cannot be nil at the point where FormulaUnavailableError is raised,
so we don't need a branch to deal with that.
2014-06-26 22:28:00 -05:00
Jack Nagel
dce7b04ea5 Simplify NoSuchKegError condition
dirs will be empty if the rack directory does not exist.
2014-06-26 22:26:13 -05:00
Jack Nagel
de81350b42 Keg no longer inherits from Pathname 2014-06-26 20:07:11 -05:00
Jack Nagel
62b29e7686 Give Keg#link_dir parameter a more descriptive name 2014-06-26 18:49:08 -05:00
Jack Nagel
64d5aef0bc Fix keg method visibility
Only link_dir needs to be protected
2014-06-26 18:45:34 -05:00
Jack Nagel
001b2ee471 Reuse existing keg object 2014-06-26 17:21:10 -05:00
Jack Nagel
3e35aacbbb Remove dead code 2014-06-26 17:20:00 -05:00
Jack Nagel
2f2f9f185f Deprecate Keg#fname 2014-06-26 16:10:15 -05:00
Jack Nagel
85b6953816 Pass strings, not keg objects, to exec 2014-06-26 14:15:58 -05:00
Mike McQuaid
7673c40f25 brew.rb: handle single usage flag case. 2014-06-26 09:27:22 +01:00
Mike McQuaid
f61633a076 brew: guard --help with nil cmd. 2014-06-26 09:24:07 +01:00
Mike McQuaid
7ecffd2771 brew.rb: handle -—help for internal/external cmds.
Only display —-help for internal commands and not for external ones;
they can handle the flag themselves.

Closes Homebrew/homebrew#26675.
References Homebrew/homebrew#26755.
Closes Homebrew/homebrew#30300.
2014-06-26 08:37:25 +01:00
Jack Nagel
51326e0b63 Extend with a module instead of aliasing on the singleton class 2014-06-25 11:19:00 -05:00
Mike McQuaid
e24c5a750a tap_migrations: apple-gcc42 moved to dupes. 2014-06-25 15:13:30 +01:00
Mike McQuaid
49658cd46b brew-versions: move to Contributions.
Eventually we'll move Contributions to a tap too.

Closes Homebrew/homebrew#30298.
2014-06-25 09:35:37 +01:00
Jack Nagel
2daabe9863 Fix uninitialized constant error in GitHub.open
The error handling depends on side effects of `require "net/https"`,
so it should be wrapped in an explicit begin block.

cf. Homebrew/homebrew#30407.
2014-06-24 21:01:04 -05:00
Jack Nagel
3d69e5ab7b Rename Keg#fname to Keg#name 2014-06-24 19:09:09 -05:00
Jack Nagel
def6b1eaf7 Use Keg#uninstall to clean up kegs 2014-06-24 09:56:37 -05:00
Jack Nagel
acf76f3f55 Add module for logging filesystem leaks in tests 2014-06-23 23:28:25 -05:00
Jack Nagel
5ab65d0b25 Make the test tmpdir a constant 2014-06-23 23:24:45 -05:00
Jack Nagel
b98f7277a4 Keg#unlink only removes a linked keg entry *for that keg* 2014-06-23 22:55:23 -05:00
Jack Nagel
cf19ccb436 The linked keg entry is foremost a symlink 2014-06-23 22:55:23 -05:00
Jack Nagel
892e763b0b Initialize linked_keg_record in the Keg constructor 2014-06-23 22:55:23 -05:00
Jack Nagel
76e86891e4 Remove opt link in Keg#uninstall 2014-06-23 22:34:41 -05:00
Jack Nagel
de24d73172 Use Keg#uninstall to uninstall kegs 2014-06-23 22:34:41 -05:00
Jack Nagel
bcfc9d8cf7 Remove linked kegs directory when empty 2014-06-23 22:34:41 -05:00
Jack Nagel
f222ca04fd Remove pin directory when empty 2014-06-23 22:34:41 -05:00
Jack Nagel
35b9a00706 Fix file leak in lock tests 2014-06-23 22:34:05 -05:00
Jack Nagel
f25f6fbb39 Fix directory leaks in formula prefix tests 2014-06-23 22:11:40 -05:00
Jack Nagel
88165986e8 Clear cache after patching tests 2014-06-23 22:11:39 -05:00
Jack Nagel
63d3a17f2b Fix test class name collision 2014-06-23 22:11:39 -05:00
Jack Nagel
9a6d2a31d9 Fix directory leak in test_cleanup 2014-06-23 22:11:39 -05:00
Jack Nagel
c2337771f7 Clear cache after checksum verification tests 2014-06-23 22:11:39 -05:00
Jack Nagel
98e01d2b83 Fix directory leak in test_argv 2014-06-23 22:11:39 -05:00
Jack Nagel
4d14cafaa5 Fix directory leak in test_cleaner 2014-06-23 22:11:39 -05:00
Jack Nagel
45840f43a2 Clear cache after formula install tests 2014-06-23 22:11:39 -05:00
Jack Nagel
9f03b28573 Fix directory leak in test_pathname_version 2014-06-23 22:11:39 -05:00
Jack Nagel
f9fd3f46d4 Explicitly create top-level directories for tests 2014-06-23 22:11:39 -05:00
Jack Nagel
04f504546c Give the temporary test directory a prefix 2014-06-23 18:58:58 -05:00
Jack Nagel
3dbcba0c03 Call original backtick using super 2014-06-23 18:50:55 -05:00
Jack Nagel
43cb0b9141 Use Dir.mktmpdir to create temp directory for tests 2014-06-23 18:42:27 -05:00
Jack Nagel
8d12684efe Pass repository path into the updater 2014-06-23 18:41:50 -05:00
Jack Nagel
61e633426a Remove obsolete constant
Formula that use this do not load anymore.
2014-06-22 19:33:21 -05:00
Jack Nagel
20d544085a Use a more descriptive variable name 2014-06-22 18:43:14 -05:00
Jack Nagel
0fda322e0e Use Pathname#split 2014-06-22 18:38:30 -05:00
Shaun Jackman
42c20b0979 Move the compiler-selecting methods to ENV/shared
Closes Homebrew/homebrew#30210.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-06-22 18:30:15 -05:00
Jack Nagel
4d9d01893e Move deprecated Formula class methods to compat
These have all been moved to Formulary.
2014-06-22 15:03:17 -05:00
Jack Nagel
90183877ff Simplify extending Formula with Enumerable 2014-06-22 15:03:17 -05:00
Jack Nagel
4b0255f7aa Keep DSL related code in one place 2014-06-22 15:03:17 -05:00