6393 Commits

Author SHA1 Message Date
Jack Nagel
e717508b7b audit: access the homepage attribute once 2014-09-14 15:43:20 -05:00
Jack Nagel
f3b7c3236b Consistently call name on formula instead of relying on to_s 2014-09-14 11:19:30 -05:00
Jack Nagel
976bb9b057 Print each line of --env output atomically 2014-09-14 01:39:38 -05:00
Jack Nagel
529b060dbb Remove unnecessary conditional
If ARGV.named.empty?, then ARGV.formulae.map(&:name) == [].
2014-09-14 01:26:45 -05:00
Jack Nagel
081036c81c Remove InstallationError superclass
None of these subclasses share any behavior other than what is inherited
from RuntimeError, so we can just get rid of the superclass.
2014-09-14 01:10:20 -05:00
Jack Nagel
909c2bd59e Replace loop + delete with array difference 2014-09-13 20:04:05 -05:00
Jack Nagel
2332e6525d Remove unused attribute from BuildError 2014-09-13 19:49:27 -05:00
Jack Nagel
a607c71123 Pass the ENV hash into the BuildError constructor 2014-09-13 19:47:30 -05:00
Jack Nagel
20516ee39b Use the superclass properly 2014-09-12 21:31:48 -05:00
Jack Nagel
1f3bbe64e0 Make parameter names match superclass parameter names 2014-09-12 21:31:48 -05:00
Jack Nagel
c85c165fe9 Remove default argument from Homebrew::InstallationError
This class is never instantiated directly, and all subclasses
initializers have different signatures and do not rely on this.
2014-09-12 21:26:24 -05:00
Jack Nagel
1ace6f147d Make exception subclasses use their superclass properly 2014-09-12 21:24:56 -05:00
Jack Nagel
ddeac0284b Don't use undent on keg-only reasons
It will cut off the beginning of any interpolated lines.

Fixes Homebrew/homebrew#32259.
2014-09-12 20:54:41 -05:00
Jack Nagel
759b6ce1a9 Use safe_system when invoking install_name_tool 2014-09-11 23:26:48 -05:00
Jack Nagel
1e537b5797 Use multiple-argument form of quiet_system 2014-09-11 23:25:18 -05:00
Jack Nagel
28c1c4ee15 Use only strings in ENV.x11 2014-09-11 16:56:21 -05:00
Jack Nagel
1c5995776f The build environment should only deal with strings 2014-09-11 16:50:56 -05:00
Jack Nagel
c98fe91f13 Don't directly assign Pathname objects to environment variables
Fixes Homebrew/homebrew#32234.
2014-09-11 16:50:56 -05:00
Jack Nagel
c5885757e5 Store the object itself in the failed download set
Patches don't respond to "name".
2014-09-10 22:09:15 -05:00
Mike McQuaid
9531ecc72a Use bundler for test gem dependencies.
Closes Homebrew/homebrew#31986.
References Homebrew/homebrew#31981.
2014-09-10 13:29:14 +01:00
Dominyk Tiller
8205ebabcb Prefer Xcode 6.1 on 10.10
More Yosemite changes. Within two weeks or so, Xcode should be made
available on the App Store, at which point 10.9 will need to go from
“5.1.1” to “6.0” but whilst Yosemite is in Beta *everyone* should be
using the Xcode Beta builds according to Apple, so Yosemite should be
on 6.1 for the foreseeable, even when Apple releases Xcode 6.0 to 10.9
& below. 6.1 is still using the same Clang version number at this point.

Closes Homebrew/homebrew#32201.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-09-10 00:44:37 -05:00
Jack Nagel
4fd78c9690 Provide more information about link errors
References Homebrew/homebrew#32046.
2014-09-09 14:26:36 -05:00
Johnathan Conley
0d154a991d Add :osxfuse dependency to support binary install.
add :osxfuse symbolic dependency
add ConflictsWithFuseForOsx requirement for osxfuse/fuse4x/fuse4x-kext

Closes Homebrew/homebrew#31975.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2014-09-09 10:17:03 +01:00
Jack Nagel
6a3a370603 Fix file descriptor leak 2014-09-08 19:50:32 -05:00
Jack Nagel
9321873eef Use predicate method and eliminate local 2014-09-08 19:50:15 -05:00
Jack Nagel
f6eedf9464 Avoid early return 2014-09-08 19:50:13 -05:00
Jack Nagel
fbc5d6c31f Remove haskell-platform
The latest version haskell-platform features an entirely different
build system that does not play well with Homebrew, so it is being
removed in favor of the ghc and cabal-install formulae.

The binary installer can also be used instead:
  https://www.haskell.org/platform/mac.html

Closes Homebrew/homebrew#31609.
2014-09-08 16:35:26 -05:00
Mike McQuaid
f4d87d41be test.pcap: add pcap fixture. 2014-09-08 09:05:23 +01:00
Jack Nagel
691f962b0d Fix file descriptor leak in Formula#system 2014-09-07 20:41:18 -05:00
Jack Nagel
6b423c8cfb Make sure redirected stdout and stderr share the same offset
This fixes broken output like this:

  Error: No such file or directory - non_existent_file
  ee/src/tree-1.7.0.tgz
  Already downloaded: /Library/Caches/Homebrew/tree-1.7.0.tgz
  ==> Verifying tree-1.7.0.tgz checksum
  tar xf /Library/Caches/Homebrew/tree-1.7.0.tgz
2014-09-07 20:25:12 -05:00
Jack Nagel
758608815f Move gnunet to the boneyard
Closes Homebrew/homebrew#30418.
2014-09-07 19:00:31 -05:00
Michael Hackner
8d23a43f12 Fix brew list when combining --pinned and --versions
Fixes Homebrew/homebrew#32067
Closes Homebrew/homebrew#32099.
Closes Homebrew/homebrew#32134.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-09-07 18:55:02 -05:00
Jack Nagel
b544f3e5f1 Clear GOBIN in environment setup
Closes Homebrew/homebrew#32014.
2014-09-07 18:39:00 -05:00
Jack Nagel
24a133f119 gist-logs: send an Accept header with the request 2014-09-07 17:41:55 -05:00
Jack Nagel
08c581d5e7 gist-logs: extract methods 2014-09-07 17:34:13 -05:00
Jack Nagel
793b58a686 gist-logs: always post config and doctor output
Closes Homebrew/homebrew#32145.
2014-09-07 17:12:21 -05:00
Jack Nagel
1dd924b9bd gist-logs: remove unnecessary exception class 2014-09-07 16:19:20 -05:00
Jack Nagel
c0c5298ae5 gist-logs: pull ternary out of hash literal 2014-09-07 16:12:02 -05:00
Jack Nagel
832f88fbc1 gist-logs: simplify setting the post path 2014-09-07 16:09:42 -05:00
Jack Nagel
944ac75b24 Use Formula#tap to get the repository name 2014-09-07 16:06:47 -05:00
Jack Nagel
269405995e Simplify getting the list of doctor checks 2014-09-07 14:20:37 -05:00
Jack Nagel
20923363c9 Avoid intermediate array 2014-09-07 14:07:12 -05:00
Jack Nagel
d0ecd08c90 Avoid intermediate array 2014-09-07 14:07:06 -05:00
Jack Nagel
829b6289f5 brew-test-bot: check for hg in requirements 2014-09-07 12:53:50 -05:00
Jack Nagel
51ffcc761f Fix typo 2014-09-07 12:39:09 -05:00
Jack Nagel
4652be33b9 brew-test-bot: install hg before fetching if necessary 2014-09-07 12:32:40 -05:00
Jack Nagel
50f0146f51 brew-test-bot: less code in begin block 2014-09-07 12:31:46 -05:00
Josh Larson
a316a07251 Fix comma splice in outdated brew message
Closes Homebrew/homebrew#32123.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-09-06 00:29:16 -05:00
Jack Nagel
23c73e2147 Remove unnecessary closed? guard
The debugger can't jump back to this point, so we don't have to worry
about this code executing twice.
2014-09-05 16:56:07 -05:00
Jack Nagel
fd0ba6904f Less code in begin block 2014-09-05 15:36:08 -05:00