admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
6,826 Commits 15 Branches 471 Tags
Commit Graph

5601 Commits

Author SHA1 Message Date
Adam Vandenberg
9055c1e361 add scons helper 2014-02-25 20:29:08 -08:00
Adam Vandenberg
c189dd6e20 only get counts if needed 2014-02-25 20:24:34 -08:00
Adam Vandenberg
f5cc07dfea add more documentation 2014-02-25 20:24:34 -08:00
Adam Vandenberg
0bdce89d65 fix incorrect comment 2014-02-25 20:24:34 -08:00
Adam Vandenberg
3a4a529453 remove charset.alias directly 2014-02-25 20:24:34 -08:00
Jack Nagel
d848a6c5fd Add nil check to partially address Homebrew/homebrew#26563 2014-02-24 23:26:11 -05:00
Jack Nagel
403fdc7523 Implement fails_with_llvm compat method in terms of fails_with 2014-02-24 23:26:11 -05:00
Jack Nagel
9cd95bc0b7 Remove unused variable 2014-02-23 23:04:44 -05:00
Adam Vandenberg
ed56bdd046 update doc 2014-02-23 15:53:26 -08:00
Adam Vandenberg
1f86923ec2 ignore skip_clean :all 2014-02-23 15:53:26 -08:00
Adam Vandenberg
9559e162b2 Cleaner: do work in clean instead of constructor 2014-02-23 15:53:25 -08:00
Adam Vandenberg
3b24d9f0be latest xcode is 5.0.2 
Closes Homebrew/homebrew#26943.
 2014-02-23 13:15:53 -08:00
Adam Vandenberg
fab5e1d905 add doctor check for HOMEBREW_KEEP_INFO 2014-02-23 08:31:03 -08:00
Adam Vandenberg
bb5a2b587e Always keep info files 
Closes Homebrew/homebrew#26659.
 2014-02-23 08:30:50 -08:00
Jack Nagel
85feea33c0 Hoist assignment to simplify a conditional 2014-02-22 21:39:38 -05:00
Jack Nagel
a836602024 create: make conditional more obvious 2014-02-22 20:17:04 -05:00
Jack Nagel
d1dd4b0e67 create: pull requires out of method 2014-02-22 20:17:04 -05:00
Jack Nagel
101066cf71 Update method call 2014-02-22 20:17:04 -05:00
Jack Nagel
9d3b9edb4d Remove download_strategy from SoftwareSpec 2014-02-22 20:17:04 -05:00
Mike McQuaid
cf0a3fe93e bottle: detail what a new regex should match. 2014-02-22 17:15:28 +00:00
Mike McQuaid
0f2d1d7f72 bottle_version: add x264. 2014-02-22 17:15:15 +00:00
Mike McQuaid
ac81d3b0d8 bottle_version: improve test filenames. 2014-02-22 17:14:51 +00:00
Jack Nagel
b96411052e Use reader method 2014-02-22 11:17:50 -05:00
Jack Nagel
a2372ad539 Use standard assignment since #initialize is only called once 2014-02-22 11:17:04 -05:00
Jack Nagel
e3e14a0cdf Eliminate nil check on path parameter 2014-02-21 20:07:41 -05:00
Jack Nagel
d31bee2e5b Avoid ancestors.include?, klass1 < klass2 is faster 2014-02-21 00:46:03 -05:00
Jack Nagel
da87bdc2e5 Cache generated class names 2014-02-21 00:46:03 -05:00
Jack Nagel
41a9ba8259 Move Formula.class_s to Formulary 2014-02-21 00:46:03 -05:00
Jack Nagel
fb350bad0f Remove downloader from Formula 2014-02-21 00:41:07 -05:00
Jack Nagel
662560e40d Remove test with too much implementation knowledge 2014-02-21 00:41:07 -05:00
Jack Nagel
129e25032b Move methods to a more logical place 2014-02-21 00:41:07 -05:00
Jack Nagel
19ca1bb601 Access bottle directly in FormulaInstaller 2014-02-21 00:41:07 -05:00
Josh Tilles
2225ebc44e Adapt to Git 1.9's submodule foreach changes 
Closes Homebrew/homebrew#26871.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2014-02-21 00:05:42 -05:00
Jack Nagel
ccb216c9c7 Delegate downloader to active_spec instead of storing it in an ivar 2014-02-20 13:45:13 -05:00
Jack Nagel
3aa06a701d Consistently pass path into Formula constructor 2014-02-20 13:31:37 -05:00
Jack Nagel
abbed076f0 Pass path into the Formula constructor 
When the path argument to the Formula constructor is omitted, the
instance's path attribute is created using the Formula.path class
method. However, we have already done this work, so we can just pass it
into the constructor.

This translates to one less call to Pathname#to_s per formula, or about
2600 calls when running `brew readall`.
 2014-02-19 16:53:18 -05:00
Jack Nagel
1f39d6c2d1 Eliminate some Pathname -> String -> Pathname conversions 2014-02-19 16:53:18 -05:00
Jack Nagel
7591b79d7d Push expand_path call down into FromPathLoader 2014-02-19 16:53:18 -05:00
cadrpear
f43bb0c292 Fix building universal binaries on 32-bit CPUs 
[jn: style, update comment]

Closes Homebrew/homebrew#25728.
Fixes Homebrew/homebrew#26834.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2014-02-19 14:15:03 -05:00
Jack Nagel
a1d2aa0f69 Stop exporting HOMEBREW_VERBOSE to build environment 
This flag no longer affects the output of the compiler wrappers, since
everything is buffered by the build process rather than each individual
tool.

Additionally, this is a user-facing knob that affects ARGV.verbose?, and
the combination of these two issues broke the --quieter feature.
 2014-02-18 21:46:26 -05:00
Jack Nagel
8d4d56c8db Use standard curl progress output in verbose mode 
Closes Homebrew/homebrew#26818.
 2014-02-18 16:03:52 -05:00
Jack Nagel
9b8cff1484 Tweak DownloadError message to include wrapped exception 2014-02-18 15:08:03 -05:00
Jack Nagel
c9784c1857 Collapse begin..end into def..end and use else clause 2014-02-18 15:08:03 -05:00
Drew Rodman
d63ef14794 Add DownloadError to catch a broader range of resource download errors. 
Adding a broader exception class allows for errors raised in Resource.fetch
to be caught in upgrade and prevent the process from being killed when
a download fails. This should resolve issue 18364.

Fixes Homebrew/homebrew#18364.
Closes Homebrew/homebrew#26618.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2014-02-18 15:08:03 -05:00
Jack Nagel
ca0eff67fa Inline static exception text to remove a rescue 2014-02-18 13:27:35 -05:00
Jack Nagel
7bdaa7ffe1 search: use a queue to collect errors 
The threading in the tap search code makes handling errors difficult. If
an API-related error is raised in one thread, it is likely to be raised
in each of the rest as well. This results in duplicated error messages,
which is ugly and bad UX.

This patch adds a synchronized queue to collect these exceptions. The
first one added to the queue is re-raised after all operations are
complete.

It's not ideal, but it's minimally invasive and I don't have the energy
or time to do a rewrite.
 2014-02-16 23:19:09 -05:00
Jack Nagel
ea7415237c Add helpful error message for authentication failures 2014-02-16 23:19:09 -05:00
Jack Nagel
3cbb49930c Move error text and helper into error class 2014-02-16 23:19:09 -05:00
Jack Nagel
24cbb4fd2e Add a more useful message when ratelimit is exceeded 2014-02-16 23:11:17 -05:00
Jack Nagel
f7cda3cdb6 Make GitHub::Error a RuntimeError to suppress backtrace 2014-02-16 22:24:33 -05:00