5601 Commits

Author SHA1 Message Date
Misty De Meo
0475dbe5cc LD64Dependency: super before setting env proc
Otherwise super will overwrite @env_proc with the default value.
2014-03-23 15:32:34 -07:00
Jack Nagel
da0df8eabe Expose some keg methods 2014-03-23 16:01:44 -05:00
Misty De Meo
497123f7ec LD64Dependency: adjust initializer signature
The method signature of Dependency changed in
1fdf69b90382c43493a5f62f0020729289db6c70, however LD64Dependency was
missed in the update. This resulted in failures in merge_repeats(),
which creates many dependency objects using all three arguments.
2014-03-22 18:50:54 -07:00
Jack Nagel
543f2a68e9 Don't send, just call the method directly 2014-03-22 13:16:16 -05:00
Jack Nagel
26c93c9544 Drop inaccurate comment
require "time"
  Time.parse(Time.now.to_s)
2014-03-22 13:16:16 -05:00
Jack Nagel
f0966cf6b6 Use canonicalized path for loaded install receipts 2014-03-22 11:48:49 -05:00
Jack Nagel
b4e5401e66 Try to find install receipt when keg is unlinked
This roughly matches the logic we use to determine the active keg in
ARGV.kegs.
2014-03-22 11:47:07 -05:00
Jack Nagel
a8eb84812a Write install receipts atomically 2014-03-22 11:13:33 -05:00
Jack Nagel
26fe9df9b2 Preserve permissions when using Pathname#atomic_write 2014-03-22 10:58:28 -05:00
Mike McQuaid
c34ed98eaf dependency_collector: use ArgumentError exception.
Avoids errors with `brew versions` when bottling.

References Homebrew/homebrew#27615.
2014-03-22 10:31:00 +00:00
Mike McQuaid
3b0eef09e9 Remove unnecessary swearing. 2014-03-22 10:14:20 +00:00
Jack Nagel
f760ee2751 audit: #{prefix}/Frameworks -> #{frameworks} 2014-03-21 20:09:56 -05:00
Ian Lancaster
58456a5469 audit: suggest proper if build.with(out) usage
Closes Homebrew/homebrew#27759.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2014-03-21 17:07:27 +00:00
Jack Nagel
04f887dc18 Always build from source when given --interactive
Closes Homebrew/homebrew#27716.
2014-03-19 22:46:15 -05:00
Jack Nagel
dc8218fdb5 audit: catch new style gist URLs 2014-03-19 18:24:10 -05:00
Geoff Nixon
9bbe38aa59 audit: fix gist patch URL regex
Closes Homebrew/homebrew#27255.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>

Conflicts:
	Library/Homebrew/cmd/audit.rb
2014-03-19 18:24:08 -05:00
Jack Nagel
7f33a84ce6 Expand paths before making relative symlink
Fixes Homebrew/homebrew#27702.
Fixes Homebrew/homebrew#27704.
2014-03-19 15:57:39 -05:00
Jack Nagel
c613ff0fad Fix copy/paste error
Fixes Homebrew/homebrew#27685.
2014-03-18 22:59:44 -05:00
Jack Nagel
45bdeadd94 Set bottle download strategy directly
We know what strategy we want, so going through DownloadStrategyDetector
is wasted work. Now we can remove those patterns from the detector and
have two fewer branches each time through.
2014-03-18 21:28:33 -05:00
Jack Nagel
aaea4d236a Reorder download strategy symbols by frequency 2014-03-18 21:28:33 -05:00
Jack Nagel
eace29a50e Reorder download strategy regexps by frequency 2014-03-18 21:28:29 -05:00
Jack Nagel
aa7ed10968 Make relative symlinks in Pathname#install_symlink
Closes Homebrew/homebrew#27672.
2014-03-18 19:03:25 -05:00
Jack Nagel
4353f4fc97 Detect absolute symlinks during bottle relocation check 2014-03-18 19:03:24 -05:00
Jack Nagel
e0c1f5aef6 Remove redundant method
This already happens in the superclass.
2014-03-18 14:46:43 -05:00
Jack Nagel
7af46a5ed0 Always use CurlDownloadStrategy for legacy patches
Fixes Homebrew/homebrew#27671.
2014-03-18 14:24:32 -05:00
Mike McQuaid
8dcadc54d2 python_dependency: no brewed python for bottles 2014-03-18 12:08:12 +00:00
Misty De Meo
ab4f9e57ae Don't check issues on Ruby 1.8.6
The system certs are too old to be able to read from Github, so
don't try to use the Github API on 1.8.6 either.
2014-03-17 11:52:11 -07:00
Mike McQuaid
f115260a29 bottle_version: support lz4 style. 2014-03-17 10:35:53 +00:00
Adam Vandenberg
6a13c9e434 which is supposed to return a pathname 2014-03-16 16:05:15 -07:00
Adam Vandenberg
844e94526e return found path directly in which 2014-03-16 11:52:11 -07:00
kynnjo
5f8e78150e utils.rb:which: bug fix
Closes Homebrew/homebrew#27524.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
2014-03-16 11:49:35 -07:00
Jack Nagel
c84c8b1d0e Set patch name on initialization 2014-03-15 22:40:14 -05:00
Jack Nagel
e0216d95af Prefer opt prefix over linked keg entry when picking active keg 2014-03-15 16:57:37 -05:00
Jack Nagel
3b3b782ba9 Add an extra sanity check 2014-03-15 16:56:51 -05:00
Jack Nagel
13f8c7ab95 Refactor ARGV.kegs 2014-03-15 16:56:40 -05:00
Jack Nagel
088c774d87 diy: warn when detected name is an alias
cf. Homebrew/homebrew#22778.
2014-03-15 12:55:14 -05:00
Jack Nagel
30b4961dde Modernize brew diy 2014-03-15 12:55:14 -05:00
Jack Nagel
e236901e56 Use canonicalized name in NoSuchKegError message
cf. Homebrew/homebrew#22778.
2014-03-15 12:55:14 -05:00
Jack Nagel
eab90dcb56 Rewrite brew reinstall
Fixes Homebrew/homebrew#23928.
2014-03-15 10:53:03 -05:00
Jack Nagel
4e48560701 Detect build-time deps from resource downloads 2014-03-14 23:46:20 -05:00
Jack Nagel
a867cb4305 Use Formula#system and existing error handling in scons helper
Fixes Homebrew/homebrew#27553.
2014-03-14 16:41:57 -05:00
Jack Nagel
251bd707a2 Remove use of Forwardable from ExternalPatch 2014-03-14 16:16:53 -05:00
Mike McQuaid
afec712a86 python_dependency: move bottle check into method. 2014-03-14 18:21:29 +00:00
Jack Nagel
d294d2e210 Fix the debug implementation of Resource#stage as well 2014-03-14 13:05:09 -05:00
Jack Nagel
1599e9b059 Fix Resource#stage method signature in debug mode
Fixes Homebrew/homebrew#27554.
2014-03-14 12:54:17 -05:00
Jack Nagel
72e0d9806b Ensure patch cache path is unique even when checksum is missing 2014-03-14 12:38:06 -05:00
Jack Nagel
c91c2c10d8 Add inspect methods to patch classes 2014-03-13 21:35:41 -05:00
Jack Nagel
a5a78ce3c6 Drop version from cached patch filenames 2014-03-13 21:35:41 -05:00
Jack Nagel
4f051abc3e Teach audit about new patches implementation 2014-03-13 21:35:41 -05:00
Jack Nagel
86cdd812a2 Teach fetch to download patches 2014-03-13 21:35:41 -05:00