admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
6,826 Commits 15 Branches 471 Tags
Commit Graph

5601 Commits

Author SHA1 Message Date
Jack Nagel
86b3090d4d Passing an empty array to puts prints nothing 2014-07-19 23:59:44 -05:00
Jack Nagel
7078af8218 Pass the string directly to the output method 2014-07-19 23:50:59 -05:00
Jack Nagel
d2aeadb1cd Pass array to puts instead of iterating over it 2014-07-19 23:36:02 -05:00
Jack Nagel
c18eea6a17 Default to stdout since other code calls this method 2014-07-19 23:28:56 -05:00
Jack Nagel
74ad97ce7f Remove intermediate method 2014-07-19 22:55:49 -05:00
Jack Nagel
010bd2783e Allow verbose config to be written to any IO object 2014-07-19 22:33:59 -05:00
Jack Nagel
c0579443f2 Don't mess with stdout when writing build config to a file 2014-07-19 22:33:00 -05:00
Jack Nagel
26b8c5a27d Improve pull request URL regexp 
- use a regexp literal and avoid escaping forward slashes
 - escape the period in "github.com"
 - match only hex characters in the commit part
 - allow hyphen in usernames and repo names, matching what we allow for
   tap names
 - avoid unnecessary capture
 2014-07-19 20:25:32 -05:00
Maurus Cuelenaere
efcfbcc98b Fix checking out recursive git submodules 
When nested submodules appear in a git repository, the `git submodule foreach
git checkout-index ..` command would fail because it would checkout at the root
directory instead of in its parent(s)' folder.

Eg: root/submodule1/submodule2 would be checked out in root/submodule2

Closes Homebrew/homebrew#30841.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2014-07-18 21:02:56 -05:00
Jack Nagel
6f02314cba Add a factory method that accepts a formula object 2014-07-18 15:15:12 -05:00
Jack Nagel
49a97c280a Ask the filename object for the prefix 2014-07-18 15:15:12 -05:00
Jack Nagel
1cc3747094 Move bottle URL construction to the bottle object 2014-07-18 15:15:11 -05:00
Jack Nagel
a87d2108ea Move bottle filename construction to a class 2014-07-18 15:14:57 -05:00
Jack Nagel
7d28a6c54b exec_editor with no arguments should not silently succeed 2014-07-18 12:36:26 -05:00
Jack Nagel
a5895ad1fe Check nil? || empty? instead of to_s.empty? 2014-07-18 11:43:37 -05:00
Jack Nagel
3439703c65 Drop pointless to_s call 2014-07-18 11:43:37 -05:00
Jack Nagel
598e7010f9 Remove dead code 
This method is identical to the superclass implementation.
 2014-07-17 21:55:21 -05:00
Jack Nagel
44fcb24606 Spell out "formula" in parameter name 2014-07-17 20:46:39 -05:00
Jack Nagel
b08c070481 Only ask for the stem once 2014-07-17 19:55:58 -05:00
Jack Nagel
22038d5269 Remove special case for now-deprecated GitHub URLs 2014-07-17 15:18:13 -05:00
Jack Nagel
07003f43ca Call size on the path 2014-07-17 15:01:27 -05:00
Jack Nagel
ddefbe2c85 Use locals instead of repeatedly converting pathnames to strings 2014-07-17 15:01:26 -05:00
Jack Nagel
ecc9407fed Remove deprecated options from brew-diy 2014-07-17 12:24:03 -05:00
Jack Nagel
8df33f7446 diy: use configure as the heuristic for autotools 
Closes Homebrew/homebrew#30912.
 2014-07-17 12:14:17 -05:00
Phillip Calvin
d4b6d8ec96 Remove commentary from error message 
It might be best not to use the word "lame" here, as it's often considered to be an ableist slur.

Closes Homebrew/homebrew#30915.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2014-07-17 12:11:57 -05:00
Jack Nagel
4295e76d3f Remove more dead code 2014-07-16 23:22:04 -05:00
Jack Nagel
28f0e5c4fd Don't raise when converting the tag to a version fails 2014-07-16 21:11:48 -05:00
Jack Nagel
596f3ba0a0 Raise ArgumentError when a symbol can't be mapped to a version 
The fact that this is implemented as a hash lookup is an implementation
detail, so don't let the KeyError bubble up.
 2014-07-16 21:11:48 -05:00
Jack Nagel
a554b5c9b7 Rename test 2014-07-16 21:11:48 -05:00
Jack Nagel
ab41071d2b Separate tag matching and checksum lookup 2014-07-16 21:11:48 -05:00
Jack Nagel
005f41c02a Use [] on the instance rather than the wrapped hash 2014-07-16 18:54:19 -05:00
Jack Nagel
8044c4524b Rename variable 2014-07-16 18:54:19 -05:00
Jack Nagel
dc3bcf22a3 Mark private methods as private 2014-07-16 18:54:19 -05:00
Jack Nagel
3c366a56d7 Add key? to BottleCollector 2014-07-16 18:54:19 -05:00
Jack Nagel
197dbe5601 Remove dead code 
Formula objects are always constructed with an explicit name, so we no
longer need to special case an empty name or the name "__UNKNOWN__".
 2014-07-16 18:30:52 -05:00
Jack Nagel
33eed80ccc Rename fetch_bottle_for to fetch_checksum_for 2014-07-16 14:52:18 -05:00
Jack Nagel
68326805ae Implement []= on BottleCollector 2014-07-15 21:55:14 -05:00
Jack Nagel
26f4a78825 No need to set the URL for dependency test 2014-07-15 20:18:25 -05:00
Jack Nagel
8a777e65c4 Ensure that all required keys are passed to bottle_filename 2014-07-15 17:05:15 -05:00
Jack Nagel
a3dad588a8 Remove default tag value from bottle_filename 
We always call this method with an explicit tag.
 2014-07-15 17:05:15 -05:00
Jack Nagel
771bc2978c Eagerly set the download strategy 2014-07-15 13:42:03 -05:00
Adam Vandenberg
de42ad52a5 Move pjsip to the boneyard. 
Will accept an updated pull request to update this to the current version.

Closes Homebrew/homebrew#27235.
 2014-07-13 22:09:31 -07:00
Jack Nagel
08891e77b6 Remove default value from bottle_url options parameter 
To construct a URL, we need options to pass to bottle_filename, so this
method should error out if none are given.
 2014-07-13 19:29:36 -05:00
Jack Nagel
272cb4db26 Remove default value from bottle_suffix parameter 
We always call this method with an argument, so we can simplify it.
 2014-07-13 19:29:36 -05:00
Jack Nagel
644904736e Inline method so we don't merge and unpack options twice 2014-07-13 19:29:36 -05:00
Jack Nagel
0323226256 Inline method that just wraps a constant 2014-07-13 18:41:14 -05:00
Adam Vandenberg
12fe7e2771 nudge formatting 
Needed for Emacs' ruby highlighting to work past this point in the file.
 2014-07-13 12:04:45 -07:00
Jack Nagel
74ae43c690 Use accessor method in test 2014-07-13 13:07:36 -05:00
Jack Nagel
237fa3164d Use a hash to cache compiler version lookups 2014-07-13 10:50:56 -05:00
Jack Nagel
fe0c018a1a No need to cache lookup that is only done once 2014-07-13 10:50:56 -05:00