4691 Commits

Author SHA1 Message Date
Douglas Eichelberger
89c7117b30 Resolve dependable_spec violation 2023-01-22 17:26:44 -08:00
Douglas Eichelberger
ea832538f7 Resolve compiler_selector_spec violation 2023-01-22 17:26:44 -08:00
Douglas Eichelberger
d30ba99612 Resolve compiler_failure_spec violation 2023-01-22 17:26:44 -08:00
Douglas Eichelberger
bd62afde91 Resolve cmd/update-report_spec violation 2023-01-22 17:09:55 -08:00
Douglas Eichelberger
a83623e4cf Resolve cask/pkg_spec violation 2023-01-22 17:09:55 -08:00
Douglas Eichelberger
585098a9b9 Resolve cask/installer_spec violation 2023-01-22 17:09:55 -08:00
Douglas Eichelberger
357807fbac Resolve cask/artifact/pkg_spec violation 2023-01-22 17:09:55 -08:00
Douglas Eichelberger
d4c550bae7 Resolve cache_store_spec violation 2023-01-22 17:09:55 -08:00
Douglas Eichelberger
6c9d0d5424 remove RSpec/VerifiedDoubles todos 2023-01-22 17:02:29 -08:00
Mike McQuaid
d1be288418
some needs_network specs: temporarily disable.
These are absurdly flaky right now so let's disable them.
2023-01-20 17:41:07 +00:00
Mike McQuaid
4cf365f6c9
Merge pull request #14371 from dawidd6/os-specific-service
Allow defining service run command per platform
2023-01-20 15:21:47 +00:00
Mike McQuaid
200cf75233
Merge pull request #14389 from samford/add-options-to_s-method
Options: Add #to_s method
2023-01-20 15:21:18 +00:00
Sam Ford
dac82eb2c2
Options: Add #to_s method
`Options` objects are converted to a string in some circumstances but
this produces output like `#<Options:0x0000000102592c90>`.

For example, formulae.brew.sh contains analytics entries with
incomprehensible names like `adns #<Options:0x0000000102592c90>`.
This shortcoming is apparent when compared to other entries like
`adns --HEAD`.

The `Option` class has a `#to_s` method that returns the `flag`, so
this commit simply adds an `Options#to_s` method that calls `#to_s`
on each `Option` object in `@options` and joins them using spaces.
This should produce more useful output when an `Options` object is
converted to a string (e.g., `--first --second`).
2023-01-19 12:40:50 -05:00
Sean Molenaar
59ebdab2b7
analytics: switch to InfluxDB for logging 2023-01-19 18:15:27 +01:00
Dawid Dziurla
0d0c98de29
Allow defining service run command per platform 2023-01-19 11:36:37 +01:00
Mike McQuaid
344d32bf7f
Merge pull request #14368 from Kentzo/fix-cask-backup
cask: fix writability check backing up an artifact
2023-01-19 09:58:03 +00:00
Mike McQuaid
5a4e226b2a
Merge pull request #14372 from samford/rubocops-caveats-disallow-ansi-escape-codes
rubocops/caveats: Disallow ANSI escape codes
2023-01-19 09:56:19 +00:00
Mike McQuaid
653b349c8b
Change HOMEBREW_INSTALL_FROM_API update frequency
This doesn't need to be nearly as often for HOMEBREW_INSTALL_FROM_API users because we're getting the latest information from the API when needed rather than just at `brew update` time.
2023-01-18 15:11:42 +00:00
Sam Ford
a1993b9086
rubocops/caveats: Disallow ANSI escape codes
Formula caveats text appears on formulae.brew.sh but escape
characters, as used in ANSI escape codes, should not appear in HTML.
This commit adds a RuboCop to disallow escape characters in the
caveats text.
2023-01-16 01:30:19 -05:00
Ilya Kulakov
3d16112b14 cask: fix writability check backing up an artifact 2023-01-13 15:30:14 -08:00
Mike McQuaid
aa077d5f86
Merge pull request #14316 from alebcay/reproducible-gzip
utils: add reproducible_gzip helper function
2023-01-12 09:36:06 +00:00
Douglas Eichelberger
b4ed7b9924 Add tests 2023-01-11 09:04:09 -08:00
Kevin
dbf0e28f6b
Merge pull request #14344 from apainintheneck/allow-cask-switch-for-dev-cmds-on-linux
Allow --cask for linux dev cmds
2023-01-09 21:33:04 -08:00
apainintheneck
ad57705029 All --cask for linux dev cmds
This ability was removed around a month
ago but needs to be added back in.

Developers want to be able to use the
`bump` and `audit` commands when on Linux.
This is especially useful for CI.
2023-01-08 17:34:52 -08:00
Caleb Xu
f6474c5048
utils: prepare for deprecation of Utils.gzip 2023-01-06 22:58:53 -05:00
Caleb Xu
c75adc8238
utils/gzip: introduce new module 2023-01-06 22:58:22 -05:00
Rylan Polster
08529c38a6
Expand testing of Homebrew::API 2023-01-06 02:46:21 -05:00
Rylan Polster
a81710542f
Merge pull request #14324 from Rylan12/flight-blocks-cask-api
Include `*flight` block source in cask API
2023-01-03 11:44:53 -05:00
Mike McQuaid
077e9dccaf
Merge pull request #14322 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-1.42.0
build(deps): bump rubocop from 1.41.1 to 1.42.0 in /Library/Homebrew
2023-01-03 13:34:05 +00:00
Rylan Polster
7ca5a5d9a7
Simplify require "method_source" calls 2023-01-02 17:41:36 -05:00
Kevin
2e0b18f762
Merge pull request #14315 from apainintheneck/better-error-cask-on-linux
cli/parser: Better error message for cask on linux
2023-01-02 13:21:56 -08:00
Rylan Polster
2d5d132713
Include *flight block source in cask API 2023-01-02 14:33:33 -05:00
Mike McQuaid
6a25229567
brew style --fix 2023-01-02 19:18:51 +00:00
Mike McQuaid
585d10fdc8
Merge pull request #14313 from apainintheneck/fix-brew-prof
cmd/prof: Fix gem errors
2023-01-02 19:14:03 +00:00
apainintheneck
d8c2e311ab Use odie instead of bare exception
The reason that odie works well here
is that it doesn't print a stacktrace
or get caught and print the help page.
2023-01-02 10:59:08 -08:00
Kevin
073c004ef3
Add :needs_network to brew prof tests
They need network access to download the profiler gems.

Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2023-01-02 10:02:51 -08:00
apainintheneck
a8384c0ce7 cli/parser: Better error message for cask on linux
1. Validate options before constraint violations. This allows
us to error out when --cask is passed on Linux before getting
a constraint violation when --cask and --formula are set.
2. Skip printing the help page when --cask is passed on Linux.
2022-12-31 12:34:18 -08:00
apainintheneck
d318c56013 Add integration tests for profiler 2022-12-30 19:37:32 -08:00
Mike McQuaid
5994f165f5
Merge pull request #14123 from bevanjkay/cask-wildcard-launchctl
cask/artifact/abstract_uninstall: allow wildcard entries for launchctl
2022-12-29 19:26:53 +00:00
Bevan Kay
3bdab156c2
add additional test 2022-12-29 12:54:21 +11:00
Rylan Polster
d316819f0c
Add tests 2022-12-28 16:10:26 -05:00
Rylan Polster
a504d2c1aa
Check for loose Hardware::CPU method calls 2022-12-28 16:10:26 -05:00
Mike McQuaid
1a21c7e7ef
Merge pull request #13658 from bevanjkay/extract-plist-installerpath
unversioned_cask_checker: check installer artifacts
2022-12-28 15:05:26 +00:00
Bevan Kay
db9d48a7ec
fix tests 2022-12-28 12:50:16 +11:00
Bevan Kay
e0f067bab8
Update tests 2022-12-28 11:49:37 +11:00
Kevin
740f9ddcc6
Merge pull request #14260 from apainintheneck/cleanup-search-module
Cleanup search module
2022-12-20 18:09:34 -08:00
Branch Vincent
db6d3156f2
python: reinstate pip's --no-binary 2022-12-19 23:25:53 -08:00
Carlo Cabrera
4bcd166956
Merge pull request #14239 from orf/enable-wheel-cache
Allow pip to use the local wheel cache while installing dependencies
2022-12-20 13:15:43 +08:00
Bevan Kay
01f865f93a
update test 2022-12-19 14:35:31 +11:00
apainintheneck
47b3f6fe6e Stop including/extending search.rb
- Instead use class methods.
- This is better than use it as a mixin
  when only a small number of methods are
  used in each class or module.
- It also allows us to conditionally
  require it in `brew install`.
- Removed unused search require in descriptions.rb.
2022-12-17 11:08:13 -08:00