2560 Commits

Author SHA1 Message Date
Issy Long
33d3aef295
dev-cmd/contributions: Only one email is allowed currently
Co-authored-by: Rylan Polster <rslpolster@gmail.com>
2022-08-03 16:53:43 +01:00
Issy Long
8a67ce76b5
dev-cmd/contributions: Appease brew typecheck 2022-08-03 16:53:42 +01:00
Issy Long
441df3d866
dev-cmd/contributions: Switch --email to be a named arg
- This way we can do the more intuitive:

```
$ brew contributions --repos=brew,core rslpolster@gmail.com
Person rslpolster@gmail.com directly authored 1580 commits and co-authored 125 commits to brew, core in all time.
```
2022-08-03 16:53:41 +01:00
Issy Long
c330ea4e3b
dev-cmd/contributions: Split git_log_cmd into two methods
- Otherwise it's quite involved and a bit hard to read.
2022-08-03 16:53:40 +01:00
Issy Long
fef9a286fe
dev-cmd/contributions: Simplify find_repo_path_for_repo
Co-authored-by: Rylan Polster <rslpolster@gmail.com>
2022-08-03 16:53:39 +01:00
Issy Long
503b51c54f
dev-cmd/contributions: Better error messages for bad --repos
```
$ brew contributions --email=me@issyl0.co.uk --repos=coreeeee
Error: Unsupported repo: coreeeee. Try one of brew, core, cask, bundle.

$ brew untap homebrew/bundle
$ brew contributions --email=me@issyl0.co.uk --repos=bundle
Error: Couldn't find repo bundle locally. Do you have it tapped?
```
2022-08-03 16:53:38 +01:00
Issy Long
0355c60787
dev-cmd/contributions: Retrieve a user's repo contributions over time
- Before each AGM it's currently a manual process for a PLC member to
  search commit logs and GitHub to figure out who contributed to
  Homebrew, so who should remain a member.
- I noticed that [looking at commits for a
  user](https://github.com/Homebrew/homebrew-core/commits?author=issyl0&since=2022-01-01&until=2023-01-01)
  would not count `Co-Authored-By`, which happens a lot now there's an
  autosquash action on PRs in `Homebrew/homebrew-core`, say if someone
  fixed a formula's build or tests or whatever and then the PR got
  auto-merged.
- Here's `brew contributions` that uses `git log` to be able to go back
  through all time or a specific time period (`--from`, `--to`). It's up
  to individual PLC discretion for "activity", but it does at least go
  some way to automating the data retrieval.
- Example (I can use my username as `--email` because my username is in
  all of the email addresses that I use for committing to Homebrew):

```
$ brew contributions --email=issyl0 --repos=brew,core
Person issyl0 directly authored 732 commits and co-authored 31 commits to brew, core in all time.
```
2022-08-03 16:53:37 +01:00
Mohammad Zain Abbas
1abb51f2e8
Merge branch 'Homebrew:master' into mohammad 2022-08-03 15:33:35 +02:00
Michka Popoff
756c2b2c52
github/pr-pull: fix/improve parameters
Fixes #13634
2022-08-03 14:13:50 +02:00
Carlo Cabrera
b2cf1822fa
Fix brew style 2022-08-02 22:53:29 +08:00
Carlo Cabrera
8a169364a8
pr-pull: fix typo
Error: tried to create Proc object without a block
    Do not report this issue until you've run `brew update` and tried again.
    /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/pr-pull.rb:372:in `proc'
    /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/pr-pull.rb:372:in `pr_check_conflicts'
    /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/pr-pull.rb:439:in `block in pr_pull'
    /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/pr-pull.rb:429:in `each'
    /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/pr-pull.rb:429:in `pr_pull'
    /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:93:in `<main>'
    Error: Process completed with exit code 1.

https://github.com/Homebrew/homebrew-core/runs/7634004090?check_suite_focus=true#step:10:15
2022-08-02 22:46:30 +08:00
Michka Popoff
374c3985d6
pr-pull: check for conflicts with long running builds
This change will prevent us having to run some long running builds
multiple times and to rely on luck to get things merged without conflicts.

The check takes less than 30 secondes on my local setup.
2022-08-01 23:34:06 +02:00
Mohammad Zain Abbas
eb2dcf7ea9
Update livecheck command: Casks don't have resource blocks
Co-authored-by: Nanda H Krishna <me@nandahkrishna.com>
2022-07-31 12:29:20 +05:00
Mohammad Zain Abbas
825707a219 Refactored a bit 2022-07-27 20:54:28 +02:00
Mohammad Zain Abbas
a8c1c0c841 Updated description for resource's option in livecheck command 2022-07-27 18:19:14 +02:00
Mohammad Zain Abbas
32659afdbe Updated livecheck command for resources 2022-07-27 13:53:54 +02:00
Mohammad Zain Abbas
eee457f8b9
Merge branch 'Homebrew:master' into mohammad 2022-07-27 13:27:48 +02:00
Mohammad Zain Abbas
bc687c6358 Added check resources_only 2022-07-24 15:47:15 +02:00
Mohammad Zain Abbas
54558f9bd3 Merge branch 'mohammad' of https://github.com/mohammadzainabbas/brew into mohammad 2022-07-24 14:14:43 +02:00
Mohammad Zain Abbas
ebf52091eb Check only formulas with resources 2022-07-24 14:14:10 +02:00
Mohammad Zain Abbas
96a7ff1019
Merge branch 'Homebrew:master' into mohammad 2022-07-24 13:39:59 +02:00
Alexander Bayandin
4f3a7125ef
bump-formula-pr: even more precise tag replacement 2022-07-22 14:18:33 +01:00
Mohammad Zain Abbas
0ee69e2c63 Refractoring for livecheckable resources 2022-07-21 20:02:15 +02:00
Bo Anderson
e4264c9f35
Replace sorbet-runtime-stub with sorbet-runtime 2022-07-19 23:43:14 +01:00
Mohammad Zain Abbas
3e8cf6c8f8
Merge branch 'Homebrew:master' into mohammad 2022-07-18 15:10:08 +02:00
Mohammad Zain Abbas
4aa3cc6c97 Minor 2022-07-18 15:03:05 +02:00
Mohammad Zain Abbas
2d231a3478 More compact way to get livecheckable resources 2022-07-18 14:49:32 +02:00
Mohammad Zain Abbas
f8320c89ed Selected all livecheckable resources 2022-07-18 14:42:43 +02:00
Mohammad Zain Abbas
82057003a7 Selected all formulas with livecheckable resources 2022-07-18 14:36:27 +02:00
Mohammad Zain Abbas
ad1a9b5970 Fetched all formulas with livecheckable resources 2022-07-18 14:07:33 +02:00
Mohammad Zain Abbas
dba5754c9f Filter out resources with livecheck block: Work in progress 2022-07-18 14:03:40 +02:00
Mohammad Zain Abbas
8ef6118ba0 Work in progress: Fetch all resources with livecheck block 2022-07-17 13:02:22 +02:00
Mohammad Zain Abbas
59165ed3ec Get all resources in all formulae 2022-07-17 12:47:20 +02:00
Mohammad Zain Abbas
7156c95b82 Added --resources option in livecheck cmd 2022-07-17 12:45:29 +02:00
Bo Anderson
676b88c5c4
dev-cmd/update-test: test against merge-base rather than latest master 2022-07-16 02:28:26 +01:00
danielnachun
b137d4ae00
bottle.rb: make GCC relocatable again 2022-07-11 01:25:16 -07:00
Alexander Bayandin
cfa63e9b86
bump-formula-pr: more precise tag/version replacement 2022-07-06 11:45:19 -04:00
Michka Popoff
0815a4481a
Merge pull request #13494 from Bo98/bottle-dep-fix
Fix `Keg.bottle_dependencies` including unneeded build dependencies
2022-06-30 22:26:09 +02:00
Mike McQuaid
22d6af1258
Manual brew style fixes. 2022-06-30 08:56:21 +01:00
Mike McQuaid
2d5eab2e1c
brew style --fix 2022-06-30 08:56:21 +01:00
Bo Anderson
2ddce84225
Remove Keg.relocation_formulae
We no longer use any formulae for relocation.
2022-06-30 03:39:29 +01:00
Sam Ford
283ff9e3ad
bump-formula-pr: handle url with specs hash
The existing `bump-formula-pr` regexes expect a `url` string to only
be followed by a newline. However, `url` also accepts a `specs` hash,
which can appear after the `url` string. For example:

```
url "https://www.example.com/1.2.3.tar.gz", using: :homebrew_curl
```

This commit modifies the regexes to capture anything after the `url`
string and before the newline. This works for the aforementioned
example, where the trailing hash is on the same line, but it won't
work if the hash appears on a subsequent line. For example:

```
url "https://www.example.com/1.2.3.tar.gz",
  using: :homebrew_curl
```
2022-06-24 19:26:16 -04:00
apainintheneck
3b65ecaf4c livecheck: fix path to livecheck watchlist 2022-06-21 17:57:19 -07:00
Bo Anderson
02164a35db
Use ORIGINAL_PATHS over envs; reject nil PATH 2022-06-17 19:47:57 +01:00
Bo Anderson
8ada737d40
Encapsulate ENV["SHELL"] usage 2022-06-17 19:47:57 +01:00
Bo Anderson
40bbdc659e
Fix some Style/FetchEnvVar offences 2022-06-17 19:47:57 +01:00
Bo Anderson
cd73e6bac5
Introduce more Ruby constants for values set by brew.sh 2022-06-17 19:47:57 +01:00
Bo Anderson
0a1762bd14
Use RUBY_PATH and HOMEBREW_RUBY_EXEC_ARGS more universally 2022-06-17 19:47:56 +01:00
Bo Anderson
a2033c397e
Use EnvConfig methods over direct ENV access 2022-06-17 19:47:56 +01:00
Bo Anderson
f5dc7a571f
Fix Style/ObjectThen offences 2022-06-17 19:47:55 +01:00