admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
37,659 Commits 15 Branches 471 Tags
Commit Graph

37659 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Issy Long
8910d5a479
Remove the single-element array in everything.json used for Cask tests 
```
  1) Cask::Cask#to_h when loaded from cask file returns expected hash
     Failure/Error: expect(JSON.pretty_generate(hash)).to eq(expected_json)

Diff:
       @@ -28,9 +28,7 @@
              "uninstall": [
                {
                  "launchctl": "com.every.thing.agent",
       -          "delete": [
       -            "/Library/EverythingHelperTools"
       -          ],
       +          "delete": "/Library/EverythingHelperTools",
                  "kext": "com.every.thing.driver",
                  "signal": [
                    [
       @@ -103,7 +101,7 @@
          ],
          "ruby_source_path": "Casks/everything.rb",
          "ruby_source_checksum": {
       -    "sha256": "b2707d1952f02c3fa566b7ad2a707a847a959d36f51d3dee642dbe5deec12f27"
       +    "sha256": "0c4af571cce1632fc6a3dcf3e75ba82a3283077ef12399428192c26f9d6f779b"
          }
        }
     # ./test/cask/cask_spec.rb:225:in `block (4 levels) in <top (required)>'
     # ./test/support/helper/spec/shared_context/homebrew_cask.rb:53:in `block (2 levels) in <top (required)>'
```
 2024-01-21 01:32:15 +00:00
Issy Long
eec7a96fbe
Use Ruby 3.1's intersect\? method 2024-01-20 00:38:34 +00:00
Issy Long
e9bcb64000
Double quotes not single 2024-01-20 00:35:40 +00:00
Bevan J. Kay
779f1bba7d
Move comments in tandem with the lines they belong to 2024-01-20 00:03:34 +00:00
Issy Long
dae9b0cd53
very wip and bad comment handling 2024-01-18 12:53:23 +00:00
Issy Long
e4b4af4c45
Add a failing test for comments moving with the alphabetization 2024-01-14 21:32:50 +00:00
Issy Long
2c9e6e425b
Autofix Cask/ArrayAlphabetization offenses in test fixtures 2024-01-14 20:57:08 +00:00
Issy Long
338e30ff9b
There are more arrays that contain non-alphabetizeable commands 2024-01-14 20:55:51 +00:00
Issy Long
6a1cb62b42
Appease RuboCop 2024-01-14 20:55:22 +00:00
Issy Long
9070f6d829
Check uninstall too, avoiding arrays containing commands 2024-01-02 23:31:13 +00:00
Issy Long
fb124f92ed
Ignore non-zap trash methods 2023-12-22 00:41:56 +00:00
Issy Long
b9f13fc35d
Better detection and replacement of non-alphabetized arrays 
- Use `sort_by` to sort the array, rather than comparing each element
  to the next.
- This doesn't error with complaints about clobbering at all when run on
  `homebrew/cask`, hurray. And it also handles interpolations correctly,
  rather than ignoring them.

Co-authored-by: Bevan Kay <email@bevankay.me>
 2023-12-22 00:26:38 +00:00
Issy Long
f34accfcde
Make the test expect_offense calls consistent with other tests 2023-12-22 00:20:02 +00:00
Issy Long
f4754baa00
Ignore zap trash stanzas with interpolation 
- Interpolating the version into a path is a common pattern, but the interpolations
  trip up the alphabetization autocorrect quite spectacularly, so let's
  ignore them (for now?).
 2023-12-22 00:19:03 +00:00
Issy Long
73b3ace77c
Apparently N is alphabetically before c; downcase the comparison 2023-12-21 01:25:18 +00:00
Issy Long
8cf58e36e6
Add a new RuboCop for alphabetizing zap trash array elements 
- Part of issue 16323.
- Previously this was being done manually by Cask maintainers.
- While we're here, enforce that the `zap trash` path is not in `[]` if
  it only contains a single element.
- This is buggy on actual Casks, hence the draft PR.
 2023-12-19 23:42:08 +00:00
Patrick Linnane
ff899e5b3f
Merge pull request #16357 from Homebrew/dependabot/bundler/Library/Homebrew/parallel-1.24.0 
build(deps-dev): bump parallel from 1.23.0 to 1.24.0 in /Library/Homebrew
4.2.0 		2023-12-18 08:58:27 -08:00
Patrick Linnane
bd3461345e
Merge pull request #16356 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-rails-2.23.0 
build(deps-dev): bump rubocop-rails from 2.22.2 to 2.23.0 in /Library/Homebrew
 2023-12-18 08:58:11 -08:00
BrewTestBot
a297162ead
Update RBI files for parallel. 
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
 2023-12-18 16:36:31 +00:00
BrewTestBot
5636457248
Update RBI files for rubocop-rails. 
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
 2023-12-18 16:33:14 +00:00
BrewTestBot
35a27d444a
brew vendor-gems: commit updates. 2023-12-18 16:30:46 +00:00
BrewTestBot
7b9b49d11f
brew vendor-gems: commit updates. 2023-12-18 16:29:36 +00:00
dependabot[bot]
5a5f1b52fc
build(deps-dev): bump parallel in /Library/Homebrew 
Bumps [parallel](https://github.com/grosser/parallel) from 1.23.0 to 1.24.0.
- [Commits](https://github.com/grosser/parallel/compare/v1.23.0...v1.24.0)

---
updated-dependencies:
- dependency-name: parallel
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-12-18 16:27:46 +00:00
dependabot[bot]
aa09726d00
build(deps-dev): bump rubocop-rails in /Library/Homebrew 
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails) from 2.22.2 to 2.23.0.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases)
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.22.2...v2.23.0)

---
updated-dependencies:
- dependency-name: rubocop-rails
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-12-18 16:26:45 +00:00
Bo Anderson
b72421e258
Merge pull request #16352 from Rylan12/fix-cask-discontinued-api-generation 
Re-add some `discontinued?` checks for casks
 2023-12-18 01:42:21 +00:00
Rylan Polster
fe74f5925a
Merge pull request #16353 from Homebrew/sorbet-files-update 
sorbet: Update RBI files.
 2023-12-17 20:38:03 -05:00
BrewTestBot
1359ebc025
sorbet: Update RBI files. 
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow.
 2023-12-18 00:27:17 +00:00
Eric Knibbe
eb5f7fb32b
Merge pull request #16314 from EricFromCanada/bump-skipped-deprecated-disabled 2023-12-17 19:20:54 -05:00
Rylan Polster
25b753fe51
Re-add some discontinued? checks for casks 2023-12-17 19:07:37 -05:00
Eric Knibbe
4259e2ad96
cmd/bump: indicate deprecated or skipped formulae/casks 2023-12-17 16:50:02 -05:00
Rylan Polster
4793677123
Merge pull request #16292 from Rylan12/cask-deprecate-disable 
Add `deprecate!` and `disable!` to casks
 2023-12-17 15:03:39 -05:00
Mike McQuaid
3431996146
Merge pull request #16350 from Homebrew/sponsors-maintainers-man-completions 
Update manpage and completions.
 2023-12-17 15:59:48 +00:00
Mike McQuaid
fb7f1a2c4d
Merge pull request #16349 from unshare/homepage-ua 
Work around recent Akamai/Microsoft issues
 2023-12-17 15:58:01 +00:00
BrewTestBot
4470edd1f2
Update manpage and completions. 
Autogenerated by the [sponsors-maintainers-man-completions](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/sponsors-maintainers-man-completions.yml) workflow.
 2023-12-17 15:35:39 +00:00
Mike McQuaid
4776c191da
Merge pull request #16345 from razvanazamfirei/update-cask-documentation 
create: modify cask template
 2023-12-17 15:34:44 +00:00
Mike McQuaid
7dfbaec9d4
docs/Acceptable-Casks: capitalise Apple Silicon. 2023-12-17 15:22:44 +00:00
Issy Long
7e328d8f0a
Merge pull request #16346 from issyl0/dont-forget-about-rubocop-comments 
Fix new `Style/MutableConstant` RuboCop offenses for Ruby 3.1
 2023-12-17 10:58:33 +00:00
Rylan Polster
c21b8bd68a
Fix deprecation message 
Co-authored-by: Bo Anderson <mail@boanderson.me>
 2023-12-16 23:10:20 -05:00
Rylan Polster
6431822e7b
Apply feedback 2023-12-16 20:18:35 -05:00
Rylan Polster
472dd95b16
Fix cask loading from the API 
Co-authored-by: Kevin <apainintheneck@gmail.com>
 2023-12-16 20:08:26 -05:00
Rylan Polster
c5f33aaf99
Load nil reasons from API correctly 2023-12-16 20:01:47 -05:00
Rylan Polster
40d3ab6a5d
Add tests and fix brew typecheck 2023-12-16 20:01:47 -05:00
Rylan Polster
7eb3f1a314
Replace discontinued? with deprecated? 2023-12-16 20:01:47 -05:00
Rylan Polster
53c1e6ecdb
Add deprecate! and disable! to cask stanza order 2023-12-16 20:01:47 -05:00
Rylan Polster
641a80475e
Update cask logic to handle deprecations and disables 2023-12-16 20:01:47 -05:00
Rylan Polster
036723a668
Add deprecate! and disable! methods to the Cask DSL 2023-12-16 20:01:46 -05:00
Valentin Kulesh
06155ff6e0
Work around recent Akamai/Microsoft issues 
At the moment, Microsoft Office and related casks fail audit due to
failure to fetch a product homepage from the main Microsoft site
(https://www.microsoft.com/) served by Akamai CDN.
The failure is severe and weird: no status code is received as the
connection is reset.
The analysis revealed the issue is linked to `User-Agent` and
`Accept-Language` headers parsing. Homebrew uses involved user agent
strings and has language hardcoded as `en`.
The simplest workaround is to use a simple user agent string when checking
homepage availability if the cask is in an audit exceptions list.

Merging this would fix Microsoft Office updates (including
https://github.com/Homebrew/homebrew-cask/pull/162671)
 2023-12-16 22:20:17 +03:00
Bo Anderson
a60c58c798
Merge pull request #16347 from jeroen/upload-artifact 
Fix "an artifact with this name already exists on the workflow run"
 2023-12-16 13:50:34 +00:00
Jeroen Ooms
29cf01d442 Fix workflow for duplicate names 2023-12-16 14:36:12 +01:00
Issy Long
149b0e4f31
Fix new Style/MutableConstant RuboCop offenses for Ruby 3.1 
- A follow-up to de592af20bbff5bcb548d2474f0722e59ff1129a, resetting the previous disabled comments too.
 2023-12-16 11:57:06 +00:00