10501 Commits

Author SHA1 Message Date
Mike McQuaid
dc81898331 travis: use Xcode 8.1 on Sierra.
For code coverage from `brew test-bot`.
2016-12-04 14:14:11 +00:00
Mike McQuaid
52691cd0de Merge pull request #1611 from MikeMcQuaid/bash-test-race
bash_test: handle race condition.
2016-12-03 16:36:37 +00:00
Mike McQuaid
3f6d31dee1 bash_test: handle race condition.
Other tests may delete Bash files (e.g. `shcmd.sh`) while tests are
ongoing so ensure this doesn't cause a test failure.
2016-12-03 15:59:05 +00:00
Mike McQuaid
35d2610ee1 Merge pull request #1610 from MikeMcQuaid/fs_leak_logger_mkpath
fs_leak_logger: use more permissive mkpath.
2016-12-03 15:53:15 +00:00
Mike McQuaid
c560c47202 fs_leak_logger: use more permissive mkpath.
This avoids a race condition occurring here.
2016-12-03 15:04:02 +00:00
Mike McQuaid
0d8fc920d6 tap-new: use latest Travis CI recommended config.
Pretty sure no-one cares about this except me but this works
consistently across a variety of different taps and is faster than the
old version.
2016-12-03 13:47:52 +00:00
Bob W. Hogg
f7e5a85c2b uninstall_test: require testing_env 2016-12-02 19:41:38 -08:00
Baptiste Fontaine
bff8e8440e update.sh: Use full path to pkill
Fixes #1600.
2016-12-01 20:59:42 +01:00
Mike McQuaid
0f529dae10 Merge pull request #1573 from sorin-ionescu/fix-xcode-version-comparison
Fix macOS version comparison
2016-11-28 08:46:20 +00:00
Bob W. Hogg
227e69048a dependency_collector: Make ant_dep and xz_dep public
They were already public on macOS, but they were made
private by mistake on all other platforms.
DependencyCollector.tar_needs_xz_dependency? depends
on xz_dep being public, so there's no turning back now :(
2016-11-28 03:09:34 +00:00
Mike McQuaid
84b3c57086 Merge pull request #1581 from MikeMcQuaid/rubocop-exclude-vendor
rubocop: exclude more files.
2016-11-27 08:25:17 +00:00
Mike McQuaid
019b12063d Merge pull request #1574 from MikeMcQuaid/tap-new-travis-update
tap-new: cleanup and update Travis configuration.
2016-11-26 22:20:20 +00:00
Mike McQuaid
726045b2f4 rubocop: exclude more files.
We never want to check these for any e.g. taps that use them.
2016-11-26 21:29:02 +00:00
Sorin Ionescu
282c0a30b6 Fix macOS version comparison 2016-11-26 13:59:55 -05:00
Mike McQuaid
3e3df9568e Merge pull request #1580 from MikeMcQuaid/fix-uses-test
uses_test: don't rely on output order.
2016-11-26 18:16:40 +00:00
Mike McQuaid
e330047ff9 diagnostic: silence a Jenkins doctor warning.
Allow our Jenkins CI testing for Homebrew/brew to live outside of
`/usr/local` without complaint (as it's not using any binary packages
anyway).
2016-11-26 16:32:48 +00:00
Mike McQuaid
22b121c4c1 tap-new: cleanup and update Travis configuration.
- Use macOS Sierra 10.12 and Xcode 8.
- Add indentation.
2016-11-26 16:30:43 +00:00
Mike McQuaid
b851935484 uses_test: don't rely on output order.
I've seen this vary.
2016-11-26 16:21:27 +00:00
Mike McQuaid
d41e2ea5e8 update-report: allow skipping analytics message.
This is used by the install script so it can simplify it's logic and
make the analytics messaging more prominent.
2016-11-26 15:14:21 +00:00
Mike McQuaid
5dd8f45cb8 Merge pull request #1577 from MikeMcQuaid/more-analytics-tweaks
update-report: further tweak analytics output.
2016-11-26 14:31:45 +00:00
Mike McQuaid
118f052057 Merge pull request #1576 from MikeMcQuaid/diagnostic-allow-outdated-travis
diagnostic: silence outdated Travis Xcode warning.
2016-11-26 14:03:25 +00:00
Mike McQuaid
3469190c30 update-report: further tweak analytics output.
There were some bugs with the use of `HOMEBREW_NO_ANALYTICS_THIS_RUN`
and some output glitches I missed with the previous PR (#1575).
2016-11-26 13:58:41 +00:00
Mike McQuaid
025e53c321 diagnostic: silence outdated Travis Xcode warning.
This doesn't add any value and stops us from testing `brew doctor` and
others from running `brew doctor` on Travis CI.
2016-11-26 13:09:59 +00:00
Mike McQuaid
7cd5ddfa65 update-report: further improve analytics messaging
- Don't output the analytics message and mark it as read if
`HOMEBREW_NO_ANALYTICS_THIS_RUN` is set. This mostly simplifies the
installer code where we can display the message ourselves there rather
than having `brew update` print it out sometimes and not others (i.e.
when there's no system Git installed).
- Use the shell's audible bell to nudge people to actually read this
message (and give them less excuse to complain when they don't).
- Add an extra newline and bold all the analytics messaging so it's
more visible in the output.
2016-11-26 12:56:02 +00:00
Mike McQuaid
771ae5c528 Revert "Merge pull request #1562 from woodruffw/check-admin-group"
This reverts commit 7f13b37b903564e2a64cea982d6b84d1aa6b800b, reversing
changes made to 62e0ecdaafbc6779205908c7ab191c884473afd6.
2016-11-25 16:44:33 +00:00
Mike McQuaid
64cb52ef3e Revert "Merge pull request #1567 from cesarandreu/fix-diagnostic-conditonal"
This reverts commit 89c3348923c3450d8d32f1252abd53209b39c288, reversing
changes made to 7f13b37b903564e2a64cea982d6b84d1aa6b800b.
2016-11-25 16:44:30 +00:00
Cesar Andreu
3b53418a2b Fix early exit condition for check_for_member_of_admin_group 2016-11-25 02:30:50 -08:00
Mike McQuaid
7f13b37b90 Merge pull request #1562 from woodruffw/check-admin-group
diagnostic: check if the user is a member of the admin group.
2016-11-25 08:11:03 +00:00
Mike McQuaid
62e0ecdaaf Merge pull request #1559 from MikeMcQuaid/unsupported-better-exceptions
exceptions: better handle unsupported macOS versions.
2016-11-24 21:15:39 +00:00
William Woodruff
bb0e683bc4
diagnostic: check if the user is a member of the admin group.
Non-administrative users are unable to run `brew linkapps` (and possibly other
commands) under normal circumstances.
2016-11-24 12:26:50 -05:00
Josh Hagins
949a3b62e7 Merge pull request #1547 from umireon/cask-uninstall-symlink
cask: Delete package dir if it is symlink on the uninstall
2016-11-24 12:16:42 -05:00
Tse Kit Yam
2279751103 Fix broken link 2016-11-24 18:26:01 +08:00
Mike McQuaid
3c77faeb14 exceptions: better handle unsupported macOS versions.
Don’t fail on `OS::ISSUES_URL` being missing (which happens on
unsupported macOS versions) and instead tell people to not file issues.
2016-11-24 08:54:38 +00:00
Shaun Jackman
8a3481ee1d Do not remove unknown bottle tags 2016-11-23 10:36:09 -08:00
Mike McQuaid
641b0b53f7 Merge pull request #1549 from umireon/osxfuse-paths-with-requirement
osxfuse_requirement: add library and include paths
2016-11-23 11:45:32 +00:00
Mike McQuaid
1980af52de audit: allow deprecated options on new @ formulae.
As these may be migrations from another tap where we want to migrate
options across correctly.
2016-11-23 11:03:10 +00:00
Kaito Udagawa
00b18c3587 osxfuse_requirement: add library and include paths
In the installation whose prefix is other than /usr/local,
osxfuse library and include path must explicitly be specified during build.
Although brew's pkg-config is configured to prepend appropriates paths,
the prepended paths (/usr/local) supercede the original HOMEBREW_PREFIX.
This behavior will cause the linker to select libraries outside brew's tree.

By adding /usr/local to HOMEBREW_LIBRARY_PATHS, superenv ensures that appears
only after the HOMEBREW_PREFIX, and thus fixes this problem.

HOMEBREW_INCLUDE_PATHS is also configured like keg-only Formulae.
2016-11-22 23:52:26 +09:00
Mike McQuaid
c3f959d6af Merge pull request #1542 from woodruffw/deprecate-utils-json
compat: deprecate Utils::JSON in favor of corelib JSON.
2016-11-21 18:45:20 +00:00
Kaito Udagawa
63e7fb5cae cask: Delete package dir if it is symlink on the uninstall
When a Formula is converted into a Cask (e.g. osxfuse),
a symlink remains at the place of package dir.
This change ensure to remove such leftovers.
2016-11-22 03:10:42 +09:00
Markus Reiter
c7267b123d Merge pull request #1502 from reitermarkus/load-metadata-cask-file
Load cask file in `.metadata` directory directly.
2016-11-21 10:43:15 +01:00
Markus Reiter
cc7541cbc4 Merge pull request #1535 from umireon/cask-pkg-choice
Cask: Add the choices option to pkg stanza
2016-11-21 10:25:30 +01:00
Mike McQuaid
b9d0d7719a cc: don't filter -fopenmp for non-llvm_clang.
We can filter it just for Clang and let it be used by anything else.
2016-11-21 08:50:01 +00:00
Mike McQuaid
28a00e9d6c development_tools: return llvm_clang Version class.
This was implemented before the rest of the file was refactored.
2016-11-21 08:49:29 +00:00
Mike McQuaid
a3f03e2066 development_tools: use begin/end
A more widely used style than relying on `if`/`else` returns.
2016-11-21 08:49:04 +00:00
Mike McQuaid
c1688be780 version/null: add inspect method.
This makes it easier to identify null versions when inspecting them.
2016-11-21 08:48:26 +00:00
Mike McQuaid
1710973792 Merge pull request #1540 from woodruffw/audit-check-blacklist
audit: check formula name against blacklisted names.
2016-11-21 07:52:05 +00:00
William Woodruff
d07b9ed7f2
Replace Utils::JSON with corelib JSON calls. 2016-11-20 20:06:25 -05:00
William Woodruff
54d18cee17
compat: deprecate Utils::JSON in favor of corelib JSON. 2016-11-20 15:02:47 -05:00
Kaito Udagawa
df635c8259 cask: compact the code 2016-11-21 04:13:29 +09:00
Mike McQuaid
947b850035 Merge pull request #1130 from aw1621107/allow-brew-llvm-for-openmp
Prefer brewed Clang over gcc-6 for needs :openmp
2016-11-20 12:38:28 +00:00