Mike McQuaid
889fc81906
Merge pull request #3449 from MikeMcQuaid/diagostic-fix-paths
...
diagnostic: fix paths usage.
2017-11-17 19:50:04 +00:00
Mike McQuaid
a582be054c
official_taps: migrate nginx.
2017-11-17 19:47:58 +00:00
Mike McQuaid
9ebf338804
diagnostic: fix paths usage.
...
- Don't allow taking an argument. This doesn't work and never has as it
caches the result regardless of the argument.
- Don't rely on the PATH to check for external commands.
2017-11-17 17:41:58 +00:00
Shaun Jackman
6da95d882d
vendor-install: Observe HOMEBREW_STDERR
...
Suppress stderr unless HOMEBREW_STDERR is set.
2017-11-16 11:08:50 -08:00
Mike McQuaid
5241d07474
environment filtering: pass through TRAVIS vars.
...
We use these internally so let's map them to `HOMEBREW_` variables.
2017-11-13 10:01:54 +00:00
Mike McQuaid
441c212f2d
Merge pull request #3416 from zmwangx/bump-formula-pr-fix-message
...
bump-formula-pr: --message: add newlines before and after hr
2017-11-10 17:53:10 +00:00
Mike McQuaid
ee4172159b
Merge pull request #3377 from maxim-belkin/extend-pathname
...
pathname: new methods and improvements
2017-11-10 17:49:27 +00:00
Markus Reiter
5318907d93
Merge pull request #3432 from reitermarkus/delegate-class
...
Refactor `DependsOn` with `DelegateClass`.
2017-11-10 18:29:28 +01:00
Mike McQuaid
4d4722c97c
Remove more uses of EOS.undent.
2017-11-10 14:22:39 +00:00
Mike McQuaid
219f9691ef
Merge pull request #3292 from claui/add-audit-test-cases
...
Add tests for `FormulaAuditor#audit_deps`
2017-11-10 13:34:56 +00:00
Maxim Belkin
de0b93f912
pathname: improvements, cleanups, and new methods
...
- atomic_write: close file before renaming to prevent error:
'Device or resource busy'
- ensure_writable: preserve executable bit
- new elf? and dynamic? methods
2017-11-07 14:18:25 -06:00
Mike McQuaid
ccf933f31c
Merge pull request #3435 from MikeMcQuaid/auto-update-checked
...
Use HOMEBREW_AUTO_UPDATE_CHECKED variable.
2017-11-07 08:26:19 +00:00
Mike McQuaid
3ad4dcafd7
Merge pull request #3427 from MikeMcQuaid/bump-formula-pr-env-filtering-github
...
bump-formula-pr: use GitHub vars under env filter.
2017-11-07 08:12:53 +00:00
Mike McQuaid
b96ded7ca4
Merge pull request #3430 from commitay/hash-order
...
brew list 'filtered_list': pass explicit sort to handle APFS
2017-11-07 08:03:48 +00:00
Mike McQuaid
5f301755c0
Use HOMEBREW_AUTO_UPDATE_CHECKED variable.
...
Rather than reusing `HOMEBREW_NO_AUTO_UPDATE` to indicate that we've
already made a check. This allows `HOMEBREW_NO_AUTO_UPDATE` to be
displayed properly by `brew config`.
2017-11-07 08:01:51 +00:00
Mike McQuaid
127bdfdc71
bump-formula-pr: use HOMEBREW_BROWSER.
2017-11-07 07:54:34 +00:00
Mike McQuaid
9358f678a3
Clear/mask passwords as well as tokens.
2017-11-07 07:54:34 +00:00
Mike McQuaid
3f8f2c6726
bump-formula-pr: use GitHub vars under env filter.
...
Ensure that the various variables are passed through and reset
correctly. If we end up doing this in a bunch of places we may add some
helpers to simplify this.
2017-11-07 07:54:34 +00:00
Mike McQuaid
2ad1799308
os/mac/diagnostic: fix XQuartz message.
...
Fixes #3434 .
2017-11-07 07:39:10 +00:00
ilovezfs
4cc72cf3be
Merge pull request #3409 from DomT4/xcode
...
Xcode 9.1 Updates.
2017-11-06 23:22:50 -08:00
commitay
ac799d9f2d
brew list --pinned: pass explicit sort to handle APFS
2017-11-07 12:35:40 +10:00
Markus Reiter
bd0b763292
Refactor DependsOn
with DelegateClass
.
2017-11-06 21:13:39 +01:00
commitay
ccecdab4cd
brew list --versions: pass explicit sort to handle APFS
2017-11-06 20:27:23 +10:00
Mike McQuaid
e300713f25
xcode: check Xcode installed before using version.
...
This avoids infinite recursion described in:
https://github.com/Homebrew/brew/pull/3422#issuecomment-342001451
2017-11-05 20:22:01 +00:00
Mike McQuaid
ffe523a7a8
Merge pull request #3422 from MikeMcQuaid/null-versions
...
mac/xcode: compare with existing Version class.
2017-11-05 19:11:50 +00:00
Mike McQuaid
bef4213ffc
Merge pull request #3423 from MikeMcQuaid/commands-refactoring-fix
...
Refactor command handling code
2017-11-05 16:09:20 +00:00
Mike McQuaid
195f77abb0
MACOS_*VERSION: move to compat.
2017-11-05 15:40:46 +00:00
Mike McQuaid
603d6fd1f5
ENV/super: simplify version checks.
2017-11-05 15:39:43 +00:00
Mike McQuaid
8c6defd9cf
diagnostic: simplify version checks.
2017-11-05 15:39:43 +00:00
Mike McQuaid
b69d71edea
system_config: handle new non-string Xcode version
2017-11-05 15:39:43 +00:00
Mike McQuaid
77e3e7e4d9
version: support to_i.
...
This is needed for existing MacOS::Xcode.version calls that relied on
this returning a string. It mirrors similar behaviour for to_f.
2017-11-05 15:39:43 +00:00
Mike McQuaid
389188ac4f
mac/xquartz: compare with existing Version class.
2017-11-05 15:39:43 +00:00
Mike McQuaid
600d58f4ca
mac/xcode: compare with existing Version class.
...
Additionally, return null versions when it makes sense to do so. This
means that comparisons on the Xcode/CLT version do not need to be
guarded on whether Xcode/CLT is installed.
2017-11-05 15:39:43 +00:00
Mike McQuaid
7a68b4a3f9
Refactor command handling code
...
Don’t rely on having external commands always present in the PATH in
order to find them. Instead, provide an accessory method to Tap so
they can be added and used when needed.
While we’re here, do some general refactoring and cleanup of the
command code in these places.
2017-11-05 15:37:57 +00:00
Mike McQuaid
5bf0584308
Merge pull request #3420 from MikeMcQuaid/config-env-output
...
system_config: output most HOMEBREW_* variables.
2017-11-05 15:36:06 +00:00
Mike McQuaid
4892465fc4
system_config: output most HOMEBREW_* variables.
...
Exclude the boring ones and exclude some that are already printed that
are just using their default values. HOMEBREW_PREFIX is the only one
where we’re always interested in the output to quickly communicate it.
2017-11-05 14:45:36 +00:00
Mike McQuaid
1b69848119
system_config: output curl path and version.
2017-11-05 14:45:36 +00:00
Mike McQuaid
b369593cbd
utils: correctly handle empty user gem env.
2017-11-05 14:45:36 +00:00
Mike McQuaid
f999a57620
brew.sh: cleanup some environment pollution.
2017-11-05 14:45:36 +00:00
Mike McQuaid
a7d74e0f53
curl: unset SSL_CERT_FILE.
2017-11-05 14:45:26 +00:00
Mike McQuaid
b9d9e63743
spec_helper: fix etc leak.
...
Fix the `etc/bash_completion.d/_brew_services` leak from the new
bash completion in the Homebrew/homebrew-services tap.
2017-11-05 13:20:08 +00:00
Mike McQuaid
2af98133ba
Merge pull request #3407 from DomT4/x11
...
xquartz: add new versions + mark latest
2017-11-03 18:28:46 +00:00
Mike McQuaid
872bd4f703
Merge pull request #3395 from GauthamGoli/parameters-audit-regex-fix
...
lines_cop: Update regex patterns to prevent false positives
2017-11-03 17:48:09 +00:00
Mike McQuaid
c6f40d5864
Merge pull request #3385 from MikeMcQuaid/path-fixes-cleanup
...
Fix and cleanup some PATH usage.
2017-11-03 17:45:57 +00:00
Mike McQuaid
29f81812cc
brew.rb: cleanup PATH setup.
...
Avoid adding all the tap commands to the PATH when not necessary.
2017-11-03 14:50:17 +00:00
Mike McQuaid
f0b25b5482
requirement: convert Cellar path to opt path.
2017-11-03 14:50:17 +00:00
Mike McQuaid
5de7ec394b
requirement: don't add /usr/local/{bin,sbin}.
...
This should be considered a requirement bug if it's added.
2017-11-03 14:50:17 +00:00
Mike McQuaid
c843fd2f12
requirement: prepend rather than append PATH.
...
Otherwise this ends up behind e.g. `/usr/bin` so is pretty useless.
2017-11-03 14:50:17 +00:00
Zhiming Wang
04367c4daf
bump-formula-pr: --message: add newlines before and after hr
...
Without an empty line before the horizontal rule (---), "Created with `brew
bump-formula-pr`." is treated as a setext header.
The newline before the hr is not part of the heredoc because putting it in
would trip up Rubocop.
2017-11-03 10:02:26 -04:00
Markus Reiter
4eeac6f884
Merge pull request #3389 from amyspark/hacktoberfest-single-zap
...
Check that a single uninstall_* and zap stanza is defined
2017-11-03 13:23:08 +01:00