admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
16,100 Commits 15 Branches 471 Tags
Commit Graph

14224 Commits

Author SHA1 Message Date
Markus Reiter
13d9305fad Cache Tty.width, since it is used heavily because of ohai. 2018-06-15 13:56:08 +02:00
Luca Favatella
ece34dbe26 cask doctor: fix for non-standard installation location in ~ 
Symptom (relevant portions):
```
$ brew cask doctor
==> Homebrew-Cask Version
Homebrew-Cask 1.6.7-56-g9ebcef7
Homebrew/homebrew-cask (git revision fc24e; last commit 2018-06-09)
==> macOS
10.13.5
==> SIP
Enabled
...
==> Homebrew-Cask Install Location
<NONE>
==> Homebrew-Cask Staging Location
~/homebrew/Caskroom
...
==> Environment Variables
HOMEBREW_CASK_OPTS="--appdir=~/Applications"
LC_ALL="en_US.UTF-8"
PATH="/usr/bin:/bin:/usr/sbin:/sbin:~/homebrew/Library/Homebrew/shims/scm"
SHELL="/bin/bash"
Cask's Doctor Checkup: failed
 - The staging path ~/homebrew/Caskroom does not exist.
Error: There are some problems with your setup.
```

Analysis:

* The source code is
  [this](9ebcef785e/Library/Homebrew/cask/lib/hbc/cli/doctor.rb (L63-L66)).

* The issue is reproducible in `brew irb`:

```
$ ls -dl ~/homebrew/Caskroom
drwxrwxr-x  10 luca  admin  340  9 Jun 16:22 /Users/luca/homebrew/Caskroom
$ ( cd ~ && pwd; )
/Users/luca
$ ls -dl /Users/luca/homebrew/Caskroom
drwxrwxr-x  10 luca  admin  340  9 Jun 16:22 /Users/luca/homebrew/Caskroom
$ brew irb
==> Interactive Homebrew Shell
Example commands available with: brew irb --examples
irb(main):001:0> Pathname.new("~/homebrew/Caskroom").exist?
=> false
irb(main):002:0> Pathname.new("/Users/luca/homebrew/Caskroom").exist?
=> true
```
 2018-06-14 23:58:03 +01:00
Luca Favatella
cac30f6186 cask doctor: delete unused render_* methods 2018-06-14 23:56:35 +01:00
Markus Reiter
502b393d66 Fix tests. 2018-06-14 22:45:20 +02:00
Markus Reiter
b45996dada Don’t use ohai for SystemCommand output. 2018-06-14 22:45:20 +02:00
Mike McQuaid
9b21422b72
Merge pull request #4334 from mistydemeo/mojave_clt_headers 
Mojave: require CLT header package
 2018-06-14 09:13:25 +01:00
Mike McQuaid
c6b6b31d66
Merge pull request #4304 from apjanke/rspec-implies-non-formula-files 
brew style: assume file args are non-formulae when passed --rspec
 2018-06-14 09:11:42 +01:00
Misty De Meo
e5212d74a6 Diagnostic: require CLT headers on 10.14 2018-06-13 17:24:32 -07:00
Misty De Meo
95e3754b95 SystemConfig: print header status if appropriate 2018-06-13 17:24:32 -07:00
Misty De Meo
296f3c309e CLT: add checks for the header package 2018-06-13 17:24:32 -07:00
Andrew Janke
c0b7aa00e4 brew style: assume files under Library are no-formulae 2018-06-13 14:06:23 -04:00
Mike McQuaid
e39b6f5891
Merge pull request #4329 from MikeMcQuaid/linkage-cache-developers 
brew.sh: enable linkage cache for developers.
 2018-06-13 09:06:24 +01:00
ilovezfs
42f5c2e4da
Merge pull request #4336 from ilovezfs/bump-formula-pr-fix-mirror 
bump-formula-pr: don't unset --mirror= value
 2018-06-13 00:37:14 -07:00
Markus Reiter
05c392423e
Merge pull request #4332 from apjanke/exclude-vendor-simplecov 
rubocop: exclude .simplecov under vendor
 2018-06-13 08:11:00 +02:00
Markus Reiter
c7549f476a Refactor .simplecov. 2018-06-13 07:17:30 +02:00
ilovezfs
6563043c75 bump-formula-pr: don't unset --mirror= value 2018-06-12 18:09:10 -07:00
Andrew Janke
abb917f381 rubocop: exclude .simplecov under vendor 2018-06-12 18:00:50 -04:00
commitay
dee0028d1b
Merge pull request #4310 from commitay/remove-checkpoint 
remove appcast checkpoints
 2018-06-12 23:37:26 +10:00
William Woodruff
dabf5c40a1
formula_installer: require "install" 2018-06-11 22:19:11 -04:00
dependabot[bot]
250449982a
Bump rspec-retry from 0.6.0 to 0.6.1 in /Library/Homebrew/test 
Bumps [rspec-retry](https://github.com/noredink/rspec-retry) from 0.6.0 to 0.6.1.
- [Release notes](https://github.com/noredink/rspec-retry/releases)
- [Changelog](https://github.com/NoRedInk/rspec-retry/blob/master/changelog.md)
- [Commits](https://github.com/noredink/rspec-retry/compare/v0.6.0...v0.6.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2018-06-11 20:34:59 +00:00
Mike McQuaid
34ae75d511 brew.sh: enable linkage cache for developers. 
This seems stable on CI so I think we can expose it to more people.
 2018-06-11 20:10:40 +01:00
William Woodruff
ab568800a7
formula_installer: Check for bottle_unneeded 2018-06-11 10:38:32 -04:00
Mike McQuaid
3081390ff8
Merge pull request #4327 from reitermarkus/dependency-order-cop 
Support constants in `DependencyOrder` cop.
 2018-06-11 08:59:35 +01:00
Mike McQuaid
0dd33fdb91
Merge pull request #4326 from reitermarkus/rubocop-stderr 
Add `stderr` output to exception.
 2018-06-11 08:59:05 +01:00
William Woodruff
96ff4102c8
formula_installer: Don't check devtools if pouring 2018-06-11 00:45:25 -04:00
commitay
7a48e04d07 internal_audit_modified_casks: remove appcast 2018-06-11 13:15:32 +10:00
commitay
c3ac638b9f appcast: remove calculate_checkpoint 2018-06-11 13:15:32 +10:00
commitay
dbeed9e583 test fixtures: update/remove appcast checkpoints 2018-06-11 13:15:32 +10:00
commitay
0980de4cb0 _appcast_checkpoint: remove 2018-06-11 13:15:30 +10:00
commitay
c68526ac09 audit: remove appcast checkpoints 2018-06-11 13:14:00 +10:00
commitay
727413da3c manpage: remove _appcast_checkpoint 2018-06-11 13:14:00 +10:00
Markus Reiter
343a5b45a9
Merge pull request #4315 from reitermarkus/remove-ensure-cache 
Remove `Hbc.init`.
 2018-06-11 04:53:42 +02:00
Markus Reiter
b9ba631982 Support constants in DependencyOrder cop. 2018-06-11 04:23:52 +02:00
Markus Reiter
fdb2406b20 Add failing spec for DependencyOrder cop. 2018-06-11 04:21:06 +02:00
Markus Reiter
aaddce4743 Add stderr output to exception. 2018-06-11 03:18:47 +02:00
ilovezfs
5614f114ef
Merge pull request #4322 from ilovezfs/formula_installer-postinstall-spec 
formula_installer: don't pass spec arguments from ARGV to postinstall
 2018-06-10 06:53:31 -07:00
ilovezfs
fda353e827 formula_installer: don't pass spec arguments from ARGV to postinstall 
Postinstall should be executed with the spec of the target formula not
the spec argument from ARGV, otherwise the prefix can be incorrect. In
other words, if the stable version of a dependency gets installed,
postinstall for the dependency should use the prefix of the dependency's
stable version, not the prefix of its devel or head version.

Fixes #2941.
 2018-06-10 04:29:34 -07:00
commitay
3329a9f6d8 text_cop: require cargo to use install instead of build 2018-06-10 16:42:19 +10:00
Markus Reiter
1d27c5f79a Don't create Caskroom.path for tests. 2018-06-09 11:32:49 +02:00
Markus Reiter
767ebe6ab6 Fail brew cask upgrade early if Cask is not installed. 2018-06-09 11:27:44 +02:00
Markus Reiter
488149242b Remove Hbc.init. 2018-06-09 11:18:40 +02:00
Markus Reiter
b2f67c6d77 Remove the need for ensure_cache_exists. 2018-06-09 11:13:37 +02:00
Markus Reiter
1c153f7781 Remove Locations module. 2018-06-09 10:14:13 +02:00
Markus Reiter
12ab263784 Remove Hbc.default_tap. 2018-06-09 10:13:28 +02:00
Markus Reiter
fee2b56e14 Rename Cask tap for specs. 2018-06-09 10:03:21 +02:00
Markus Reiter
3d423b0587 Add path method to Caskroom and Cache. 2018-06-09 09:52:48 +02:00
Markus Reiter
458a1e7903 Remove Locations module. 2018-06-09 09:01:09 +02:00
Markus Reiter
61bcec42a8
Merge pull request #4306 from reitermarkus/cask-search 
Refactor `brew cask search`.
 2018-06-08 14:18:32 +02:00
commitay
abdf6cae2f audit: fix typo 2018-06-08 16:53:49 +10:00
Markus Reiter
04cb105e46 Unset HOMEBREW_NO_EMOJI for all tests. 2018-06-07 18:42:30 +02:00