157 Commits

Author SHA1 Message Date
Mike McQuaid
8d01cda922
Merge pull request #5925 from MikeMcQuaid/more-deprecations
Deprecate tap pinning (and remove `odisabled`)
2019-04-03 09:00:06 +01:00
Mike McQuaid
6987fb4d05
upgrade: make clear formula options are used (not install options). 2019-04-02 08:20:28 +01:00
Mike McQuaid
d12e39633c
Remove odisabled. 2019-04-01 15:07:50 +01:00
Mike McQuaid
45243fe449
Revert "Fix Infinite Recursion in upgradable_dependents and broken_dependents" 2019-02-26 16:49:17 +00:00
Frizlab
c27ba5c4bd Print a warning when a recursive upgradable or broken dependant has been found 2019-02-16 14:40:29 +01:00
Frizlab
b4f76db37c Fix infinite recursion in upgradable_dependents and broken_dependents 2019-02-16 00:04:12 +01:00
Gautham Goli
ba057ad239
Fixes #5663 2019-02-04 08:40:05 +01:00
Mike McQuaid
267d721988
Note HOMEBREW_NO_INSTALL_CLEANUP in the help/manual 2019-02-03 09:34:00 +01:00
Mike McQuaid
6cb7a00f2d
cmd: remove --help headers and tweak docs. 2019-01-30 21:39:28 +00:00
Mike McQuaid
867b155479
Add missing conflicts to command options. 2019-01-29 19:39:41 +00:00
Mike McQuaid
9eabcdad7d
Make install/reinstall/upgrade options more consistent. 2019-01-29 19:25:59 +00:00
Gautham Goli
22c2b06fa5
cmd/upgrade: Use CLI::Parser to parse args 2019-01-29 16:58:44 +00:00
Mike McQuaid
eed1444d61
Update deprecations and cleanup
- Move `odeprecated` to `odisabled`
- Remove `odisabled`
- Enable automatic cleanup on install/reinstall/upgrade.
2019-01-23 21:57:40 +00:00
Mike McQuaid
a24197bcc9
Fix some bottling logic
- We've never supported `devel` bottles so don't bother outputting their
  status to `brew info`
- Don't `brew upgrade` or `brew reinstall` bottles if they were
  previously built as a bottle unless there's no bottles defined at all
  (rather than there was no compatible bottles). Fixes #5532.
2019-01-14 16:47:07 +00:00
Mike McQuaid
170c5493a4
Update deprecations
- Add some `odeprecated`
- Make some `odeprecated` now `odisabled`
- Remove `odisabled` code.
- Remove old update migrations
- Remove GCC 4.0 compiler
- Remove Tiger-only code
- Remove 32-bit-only code
- Remove use of LD64
- Remove GCC 4.3 - 4.8 support.
2019-01-08 19:13:46 +00:00
Mike McQuaid
8144667a71
Cleanup periodically if HOMEBREW_INSTALL_CLEANUP is set.
This will become the default in a later version of Homebrew but has an
opt-out through HOMEBREW_NO_INSTALL_CLEANUP.

Also, always cleanup files older than 120 days and set the general
default value for "old" logs, casks etc. to 30 days.
2019-01-03 16:23:44 +00:00
Jarek Wojciechowski
51ca60d6d5 add formula cleanup to install and reinstall 2018-10-29 11:23:32 -04:00
Jarek Wojciechowski
18f8adbd5c test and add HOMEBREW_INSTALL_CLEANUP to upgrade 2018-10-23 15:46:07 -04:00
EricFromCanada
20167e5f1b Adjust comments to tidy API docs output. 2018-10-18 21:42:43 -04:00
Markus Reiter
16618d0fc7 Use ActiveSupport’s #pluralize and #to_sentence. 2018-10-07 23:10:56 +02:00
Markus Reiter
e9b9ea49a1 Update to RuboCop 0.59.1. 2018-09-17 03:45:59 +02:00
L. E. Segovia
d442905719
Upgrade: implement linkage repair
After upgrading existing kegs, we now search and upgrade their
dependents as well. If any are detected that have broken linkage, they
are reinstalled from source.

If there are any formulae in the dependents tree that are pinned, they
are only reinstalled if they're not outdated; in all cases, a suitable
message is printed detailing the kegs that will be acted upon.
2018-09-12 19:28:02 +00:00
JBallin
520b5a103a Clarify that --cleanup only runs on formulae which were just upgraded 2018-08-16 09:28:24 -07:00
JBallin
526262fca5 Change <formula> to <formulae> to match the suggested inputs 2018-08-16 09:28:24 -07:00
Markus Reiter
03b93da296 Use option parser for brew cleanup. 2018-08-08 13:11:16 +02:00
Mike McQuaid
bd5131d710
Merge pull request #4392 from MikeMcQuaid/more-deprecation-disabled
Disable more deprecations.
2018-07-15 14:48:00 +01:00
Andrew Janke
0a2d8c3d4d Add --display-times option to install, reinstall, and upgrade 2018-07-14 11:06:03 -04:00
Mike McQuaid
5c6ef3d920 Disable more deprecations.
- Turn more old `odeprecated` into `odisabled`
- Remove more old `odisabled`
- Remove code for older Ruby versions
2018-07-14 16:00:50 +01:00
Andrew Janke
c644392a85 Display collected caveats at end of install or upgrade 2018-07-12 20:41:32 -04:00
Andrew Janke
8b55cb5ecb Refactor commands to remove "require cmd/help" 2018-06-07 04:59:59 -04:00
Mike McQuaid
cffa5a9864 Disable/delete/add more deprecations
Move various `odeprecated` to `odisabled` and delete uses of
`odisabled`.
2018-04-08 14:57:17 -07:00
Mike McQuaid
5b68bb84d2 cmd/upgrade: output the outdated version.
This makes it clearer what version is being updated to what version.
2018-03-30 15:00:45 +01:00
Mike McQuaid
96ff688b9d upgrade: make pinned error have correct exit code.
Also, display before saying "no packages to upgrade".

Fixes #3936.
2018-03-16 20:31:20 +00:00
Mike McQuaid
e817bba18d upgrade: add HOMEBREW_UPGRADE_CLEANUP variable.
Allow users to specify they want `brew upgrade --cleanup` to always be
run when they run `brew upgrade`.
2018-03-12 11:05:06 +00:00
Peter Powell
e71b2d1737 upgrade: fix the man page wrongly saying that it will upgrade pins.
This is incorrect as in order to upgrade a pinned package it must
first be unpinned.
2018-03-10 12:07:13 +00:00
Mike McQuaid
e03f07f302 Rubocop 0.53.0 automatic fixes. 2018-03-08 14:10:02 +00:00
Teddy Wing
ee004cb9c7 cmd/upgrade: Change build.build_bottle? to build.bottle?
I received the following error when attempting to use the `upgrade`
command on a tap:

    $ brew tap teddywing/passextract https://github.com/teddywing/Passextract.git
    $ brew upgrade --verbose teddywing/passextract/passextract
    Updating Homebrew...

    ==> Upgrading 1 outdated package, with result:
    teddywing/passextract/passextract 0.4.0
    Error: Calling build.build_bottle? is disabled!
    Use build.bottle? instead.
    /usr/local/Homebrew/Library/Homebrew/cmd/upgrade.rb:121:in `upgrade_formula'
    Or, even better, submit a PR to fix it!

Change the method call to use the (presumably) newer version.
2018-03-04 12:38:33 +01:00
Chayoung You
b05d69f600
Format identifiers in oh1 2018-02-09 18:00:29 +09:00
Mike McQuaid
3a2e6b82fd Make pinning more robust
Don’t autoremove pins on uninstall or upgrade and note this in the
manpage.
2018-02-05 10:59:11 +00:00
Mike McQuaid
de0fedeb09 upgrade --all: use odeprecated. 2018-01-21 13:39:14 +00:00
Mike McQuaid
838a3f1996 reinstall/upgrade: stop unlinked kegs being sticky
It's not possible to determine the difference between a non-keg-only
keg that failed to link and one that wasn't linked by us intentionally.

To avoid additional complexity of storing this logic in another place
let's back out this relatively new functionality; sticky keg-only links
is a better and more desirable behaviour anyway.
2018-01-10 16:43:21 +00:00
Mike McQuaid
9ed1ed3c05 upgrade: fix UnsatisfiedRequirements exit code. 2018-01-09 09:07:37 +00:00
Mike McQuaid
dbeebcaef5 upgrade: skip formula if upgrade fails.
Rather than blocking the rest of the formulae from being installed by
`brew upgrade` print the requirement failure messages (already done) and
an error stating requirements weren't satisfied and then continue to
upgrade the rest of the formulae.
2018-01-08 14:38:10 +00:00
Mike McQuaid
7eb1fd6671 reinstall/upgrade: document use of options.
To avoid user confusion e.g. #3606.
2017-12-30 21:23:33 +00:00
L. E. Segovia
9603e39f16 Rename whole build_options block (copypaste from reinstall) 2017-12-02 20:04:03 +00:00
L. E. Segovia
da764c6d6c Delete --ignore-dependencies additions 2017-12-02 20:03:38 +00:00
L. E. Segovia
4dfe6e32e4 Let the upgrade command add new build flags 2017-12-02 17:14:46 +00:00
L. E. Segovia
5f5e689752 Remember --ignore-dependencies when installing and upgrading 2017-12-02 13:41:11 +00:00
Markus Reiter
9bee9ca575 Use “squiggly” heredocs. 2017-10-18 14:39:09 +02:00
Markus Reiter
175ca909ee Clean up code style and remove .rubocop_todo.yml. 2017-10-08 16:10:37 +02:00