1010 Commits

Author SHA1 Message Date
Michael
7ac157703f
change ' to " to allow 2019-04-06 09:30:59 +01:00
Mike McQuaid
51e473891f
cask: improve JSON output consistency.
Replace the use of HOME or HOMEBREW_PREFIX in the output strings with
variable versions. This is particularly useful on formulae.brew.sh.
2019-03-27 15:59:38 +00:00
Zach Auten
e9b17b8593 Replaced 'unless nil' with 'if' 2019-03-16 12:59:15 -04:00
Zach Auten
75b9eec7ef Renamed print_caveats, updated an info_spec test to macos only 2019-03-11 21:20:02 -04:00
Zach Auten
18a20986e7 Addressed style issues 2019-03-06 18:06:50 -05:00
Zach Auten
dd4daa247f Merge branch 'master' of https://github.com/Homebrew/brew into brew-info-display-casks 2019-03-06 17:56:22 -05:00
Zach Auten
fe643758d7 Updated get_info
- get_info builds info string by appending helper functions
  - removed unnecessary returns
  - fixed indentation in missing_formula
  - reduced size of regex in info_spec
  - missing_formula will indicate when it finds a cask with same name
2019-03-06 00:27:48 -05:00
Markus Reiter
42d90f8bd9 Use same logic for installer script: and uninstall script:. 2019-03-03 06:21:11 +01:00
Zach Auten
330ae8c6fa print_caveats and get_info return heredocs 2019-02-24 21:53:04 -05:00
Zach Auten
ed80b60834 Fixed installation info output and imports 2019-02-21 21:08:57 -05:00
Mike McQuaid
e095da4d01
rubocop: enable Layout/EmptyLineAfterGuardClause. 2019-02-21 12:55:49 +00:00
Mike McQuaid
d64429a736
rubocop: enable Style/IfUnlessModifier. 2019-02-21 12:55:49 +00:00
Zach Auten
554106d2e0 Updated missing formula cask reason
- search_for_cask in missing_formula renamed to is_a_cask_reason
    - is_a_cask calls new getInfo method in cask/cmd/info.rb to return info
      string
    - self.info in info.rb now calls getInfo and puts return value
    - added ohai_title to return the ohai printout for only titles, so that
      ohai printout could be added to the getInfo return string without
      calling puts.
    - refactored ohai to use ohai_title
    - updated info_spec.rb cask info test to be more specific when
      matching stderr.
    - is_a_cask_reason will respect 'silent'
    - refactored print_caveats to return instead of print
2019-02-18 03:33:57 -05:00
Markus Reiter
713453cc2f
Merge pull request #5745 from reitermarkus/cask-edit
Allow editing broken casks.
2019-02-16 10:20:56 +01:00
Markus Reiter
5536432c4f Allow editing broken casks. 2019-02-15 22:05:28 +01:00
Markus Reiter
cd03c0f86d Retry merging once after 5 seconds. 2019-02-15 19:48:12 +01:00
Markus Reiter
68e0c5f904 Check for write access instead of HOMEBREW_DEVELOPER. 2019-02-15 16:27:37 +01:00
Markus Reiter
57fefff942 Add brew cask automerge command. 2019-02-15 16:27:37 +01:00
Markus Reiter
3bf7e5bce5 Remove Cask::Config#write. 2019-02-15 10:09:14 +01:00
Markus Reiter
4c6d0ba069 Rename dirs.json to config.json. 2019-02-15 10:09:14 +01:00
Markus Reiter
bcdb4a3f32 Add Cask::Config::canonicalize. 2019-02-15 10:09:14 +01:00
Markus Reiter
defbf7d74c Don’t ignore other arguments in HOMEBREW_CASK_OPTS. 2019-02-15 10:09:14 +01:00
Markus Reiter
190ff7558a Use saved cask config for reinstall/upgrade/uninstall. 2019-02-15 10:09:14 +01:00
Markus Reiter
fda6e0cab3 Split cask config into three tiers. 2019-02-15 10:09:14 +01:00
Markus Reiter
1e1ce1c471 Save config file for casks. 2019-02-15 10:09:14 +01:00
Markus Reiter
0fcc62db31 Run uninstall rmdir: after uninstalling artifacts. 2019-02-08 01:09:48 +01:00
Markus Reiter
e09eaf5b31 Only use sudo if it is actually needed. 2019-02-07 21:45:48 +01:00
Markus Reiter
2090f057a0 Create parent directory for artifacts with sudo if necessary. 2019-02-06 21:20:51 +01:00
Markus Reiter
d22c2eca9e Refactor ConflictsWith to be a DelegateClass(Hash). 2019-01-27 21:48:12 +01:00
Markus Reiter
d0202f692f
Merge pull request #5597 from cmbernard333/feature/homebrew-cask-json-error
Added missing method to_a to Cask::DSL:ConflictsWith class.
2019-01-27 19:03:28 +01:00
Christian Bernard
97ca5932cf Updated Cask::Cask#to_h to call Conflicts#to_h instead of to_a. Updated ConflictsWith#to_h to iterate over VALID_KEYS. 2019-01-26 10:15:45 -07:00
Christian Bernard
cadb193e3b Update to convert pairs to hash k=>v during to_a in Cask::DSL::ConflictsWith#to_a 2019-01-25 08:05:13 -07:00
Mike McQuaid
c1d5a601c7
Merge pull request #5595 from vitorgalvao/CaskSha256MismatchError-link-to-fix
CaskSha256MismatchError: link to fix
2019-01-24 12:44:48 +00:00
Christian Bernard
57fd624d25 Fix style issues based on brew style guide 2019-01-23 12:21:15 -07:00
Vítor Galvão
ffe4c6bcef CaskSha256MismatchError: link to fix 2019-01-23 18:57:19 +00:00
Christian Bernard
e722a906f4 Added missing method to_a to Cask::DSL:ConflictsWith class. 2019-01-23 11:45:19 -07:00
Markus Reiter
e472c35880 Remove unneeded cleanup. 2019-01-13 20:29:52 +01:00
Markus Reiter
3435202f91 Fix missing require. 2019-01-13 20:26:46 +01:00
Mike McQuaid
efc3c0c4c0
Use bundle install in more places.
This provides a more consistent version for `rubocop` than relying on
`Homebrew.install_gem_setup_path!` (and we really want `brew style` to
provide consistent output).
2019-01-08 15:08:21 +00:00
Mike McQuaid
149ded30aa
Merge pull request #5417 from vitorgalvao/cask-malware
Cask: remove malware caveat
2018-12-18 08:13:58 +00:00
Vítor Galvão
55084dd8ab Cask: remove malware caveat 2018-12-18 02:29:27 +00:00
Vítor Galvão
b33d29f49a Cask: use browser UA when checking for homepage HTTPS availability 2018-12-13 15:24:40 +00:00
Vítor Galvão
dff0320f8c Cask: Remove check on sha-only change 2018-12-03 17:13:09 +00:00
L. E. Segovia
3b79b4d079
More styling fixes 2018-11-24 11:21:52 +00:00
L. E. Segovia
62fd4a2e00
Use .blank? 2018-11-24 02:02:53 +00:00
L. E. Segovia
5a2743b50d
Merge branch 'master' into gitjiro-improved 2018-11-24 01:01:40 +00:00
Markus Reiter
04908dcb19 Fix RuboCop for Casks. 2018-11-12 05:01:33 +01:00
Mike McQuaid
109e974c38
Cleanup rubocop-cask references. 2018-11-08 15:54:47 +00:00
Markus Reiter
785ffb1b2c Refactor tests for uninstall stanza. 2018-11-07 18:44:52 +01:00
Markus Reiter
f61b963744 Improve application quitting. 2018-11-07 18:44:52 +01:00