admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
4,361 Commits 15 Branches 471 Tags
Commit Graph

3517 Commits

Author SHA1 Message Date
Jack Nagel
83d4ac5092 Remove "double negative" condition 2013-10-22 13:31:14 -05:00
Jack Nagel
63e1c71c50 Eagerly initialize formula specs 
Declarations of dependencies, options, and resources in the DSL only
apply to specs that have already been initialized. For example, given
this snippet:

  url ...
  sha1 ...

  depends_on 'foo'

  devel do
    url ...
    sha1 ...
  end

The dependency 'foo' will be recorded for the stable spec, but not the
devel spec, since it was not initialized prior to the call to
depends_on.

While it is considered best practice to declare all specs (stable,
devel, head, and bottle) prior to other declarations, there is nothing
that enforces this ordering, so when it happens it can be confusing and
hard to debug.

To prevent this, we can initialize all specs up front. This comes with
a performance penalty for commands that load all formulae into memory,
but that is probably outweighed by what we gain in correctness.

Fixes Homebrew/homebrew#23425.
 2013-10-22 13:31:08 -05:00
Mike McQuaid
98b28f5ac3 Different regex for user/tap/formula and user/tap. 
Closes Homebrew/homebrew#23430.
 2013-10-22 11:58:40 +01:00
Misty De Meo
de871a4daf Fix bottle_tag tests 2013-10-21 18:07:06 -07:00
Misty De Meo
2ac9afcc77 Bottles: add Leopard/PPC tags 2013-10-21 18:06:46 -07:00
Misty De Meo
28c9330abb Update Leopard/Tiger bottle tags 
* PPC bottles are in the os_cpu format, e.g. :tiger_g3
* Intel bottles are the bare cat, as usual
* 64-bit bottles have _64 appended to them, e.g. :tiger_g5_64 or :leopard_64
 2013-10-21 13:52:49 -07:00
Mike McQuaid
b7000aec37 install: silently ignore already tapped taps. 2013-10-21 20:16:57 +01:00
Mike McQuaid
1cb7eca3a5 tap: use dedicated exception for already tapped. 2013-10-21 20:16:41 +01:00
Mike McQuaid
0055e4dc5f install: fix trying to tap local bottles. 2013-10-21 19:49:09 +01:00
Mike McQuaid
c71492561f install: tap if full tap formula format given. 
Closes Homebrew/homebrew#23411.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2013-10-21 18:53:24 +01:00
Mike McQuaid
077f09e4ea global: unify tap regex. 
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2013-10-21 18:53:24 +01:00
Misty De Meo
b31f6c0099 OS::Mac: Add Xcode 2.5 compiler 2013-10-20 00:41:08 -07:00
Misty De Meo
a79bc02620 MacOS.gcc_build_version: find GCC when unlinked 
MacOS.gcc_42_build_version was returning nil if apple-gcc42 was
installed but unlinked, which was disjoint with how other parts of
Homebrew tried to see if it was present.
 2013-10-19 23:13:50 -07:00
Jack Nagel
4d6dd40bad Make non-libs warning less judgmental 2013-10-19 21:30:57 -05:00
Jack Nagel
72e9cbdac7 Fix truncation of printed paths in cellar audits 2013-10-19 21:30:20 -05:00
Jack Nagel
27f7e3503f Move verbose ENV setup out of brew.rb 2013-10-19 10:41:09 -05:00
Mike McQuaid
6551643127 HOMEBREW_GIT_ETC: fix nil etc bug. 2013-10-19 14:24:33 +01:00
Mike McQuaid
ee7869b056 formula: fix git_etc bash_completion handling. 2013-10-19 13:54:49 +01:00
Jack Nagel
e33c01aab5 libextractor: add runtime dependency on libtool 
Fixes Homebrew/homebrew#23306.
 2013-10-18 20:14:16 -05:00
Jack Nagel
f2738dbe96 Extract repeated conditional to a method 2013-10-18 13:38:19 -05:00
Jack Nagel
943978a955 Make condition clearer using names 2013-10-18 13:38:18 -05:00
Jack Nagel
273f5b2ddd Merge XQuartz and X11 modules 2013-10-18 13:38:18 -05:00
Jack Nagel
8887fe7606 Move MacOS modules under OS::Mac namespace 
Closes Homebrew/homebrew#23138.
 2013-10-18 13:38:07 -05:00
Jack Nagel
805472946b Rename MacOS to OS::Mac 2013-10-18 12:56:51 -05:00
Jack Nagel
c511d7d2f4 Add OS.mac? and OS.linux? 2013-10-18 12:56:51 -05:00
Misty De Meo
45e7f0ccb0 Allow older non-Apple GCCs to build things 2013-10-16 18:43:56 -07:00
Jack Nagel
ba06e2504c Don't print multiple deps messages when only installing one dep 2013-10-16 15:34:43 -05:00
Stan
4d086e8394 add pin/unpin to help 
Closes Homebrew/homebrew#23267.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
 2013-10-16 06:08:19 -07:00
Mike McQuaid
8b5b220d88 tap: don't print warning for apple-gcc42 failure. 
This should be a temporary workaround until we get a grip on some
Mavericks/Xcode 5.0 issues with e.g. ghc and go (stuff in core
that currently needs GCC at runtime). These formulae both have
Clang fixes in development.

Things that needs GCC at compile-time should be booted from core.

References Homebrew/homebrew#22872.
References Homebrew/homebrew-dupes#229
 2013-10-16 08:40:41 +01:00
Mike McQuaid
a64e9d4f0a audit: fix go audit problems. 2013-10-16 08:36:32 +01:00
Jack Nagel
e9d608587d Remove audit check for XZ 
Any formula with a URL that ends in ".xz" now gets this dependency
automatically, so this check no longer does anything.
 2013-10-15 22:56:04 -05:00
Jack Nagel
3df31557c8 Avoid the need to defensively flatten tags array 2013-10-15 13:26:23 -05:00
Jack Nagel
31e0bf61fa Pathname: removed unused method alias 2013-10-14 22:05:30 -05:00
Jack Nagel
5ae32d5a79 Remove pointless assertion 2013-10-14 21:46:52 -05:00
Jack Nagel
d87f1fb5ec Assert on state, not something that didn't happen 2013-10-14 21:46:21 -05:00
Misty De Meo
cb18dedce4 superenv: add gcc-4.0 to superenv 2013-10-13 19:00:33 -07:00
Jack Nagel
bf93748c6a CurlDownloadStrategy: no need to to_s, name should never be nil 2013-10-12 20:19:21 -05:00
Mike McQuaid
cf2a8913c5 git_etc: create etc if it doesn't exist. 2013-10-12 10:54:16 +01:00
Jack Nagel
167017f89a Resource: do not mutate passed-in specs hash 2013-10-11 20:21:41 -05:00
Jack Nagel
40c0ed8a9a SubversionDownloadStrategy: don't mutate URL string 2013-10-11 19:26:14 -05:00
Jack Nagel
284a3716ea CurlDownloadStrategy: dup mirror list before mutating it 2013-10-11 19:14:52 -05:00
Mike McQuaid
28a20b70fc icu4c: add bottle regex. 2013-10-11 08:40:19 +01:00
Jack Nagel
3f0a409ec5 GitDownloadStrategy: remove redundant use of nostdout 2013-10-11 00:21:25 -05:00
Jack Nagel
9705e922e3 GitDownloadStrategy: remove redundant use of :quiet_flag 2013-10-11 00:21:25 -05:00
Jack Nagel
90b1102f1a GitDownloadStrategy: @@git is always a string, so inline it 2013-10-11 00:21:24 -05:00
Jack Nagel
069d5d2dce SubversionDownloadStrategy: @@svn is always a string, so inline it 2013-10-11 00:21:24 -05:00
Jack Nagel
932091f9e0 VCSDownloadStrategy: pull construction of @clone into superclass 2013-10-11 00:21:23 -05:00
Jack Nagel
ed7f8faed2 VCSDownloadStrategy: rename checkout_name to cache_filename 2013-10-11 00:21:23 -05:00
Jack Nagel
dd719e7ca6 Move cached_location up to VCSDownloadStrategy 2013-10-10 11:24:36 -05:00
Jack Nagel
1626282c45 download_strategy: rename @co to @clone for uniformity 2013-10-10 11:24:35 -05:00