28944 Commits

Author SHA1 Message Date
Sam Ford
13b349b4ae
Refactor #find_versions parameters in strategies 2021-08-16 12:01:32 -04:00
Mike McQuaid
90494ed8a3
Merge pull request #11852 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-1.19.0
build(deps): bump rubocop from 1.18.4 to 1.19.0 in /Library/Homebrew
2021-08-16 14:25:04 +01:00
Mike McQuaid
7bade41572
rubocop.yml: fix #: usage.
Also, do some automatic reformating.
2021-08-16 13:58:13 +01:00
Mike McQuaid
f5bad82990
Merge pull request #11858 from Homebrew/bump-force-homebrew-on-linux
bump-formula-pr: use default remote if forcing Homebrew on Linux
2021-08-16 13:09:34 +01:00
Rylan Polster
ea2e40c69a
Add Cask::Cask#source to return cask's source code 2021-08-14 16:18:13 -04:00
Rylan Polster
99635bf3ae
Remove need for homebrew/cask to be tapped 2021-08-14 16:17:26 -04:00
Rylan Polster
c32223a89c
Add cask-source API 2021-08-14 01:59:04 -04:00
Benjamin Denhartog
65a755a160
Dockerfile: use relative paths when in the /home/linuxbrew directory
Because the `WORKDIR` instruction specifies the home directory of the
`linuxbrew` user, there is no need to use absolute paths to reference
paths within the home directory, nor is there a need to call `cd` (this
is actually an anti-pattern [0]) to move into a subdirectory before
creating folders.

[0]: https://github.com/hadolint/hadolint/wiki/DL3003
2021-08-13 23:53:49 -06:00
Dawid Dziurla
df086d618e
bump-formula-pr: use default remote if forcing Homebrew on Linux 2021-08-13 22:56:05 +02:00
Nanda H Krishna
0e63fb8200
Merge pull request #11857 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-ast-1.10.0
build(deps): bump rubocop-ast from 1.9.1 to 1.10.0 in /Library/Homebrew
3.2.7
2021-08-14 00:02:07 +05:30
BrewTestBot
d30773f81e
Update RBI files for rubocop-ast. 2021-08-13 18:08:49 +00:00
BrewTestBot
e8c005c177
brew vendor-gems: commit updates. 2021-08-13 18:06:29 +00:00
dependabot[bot]
be922631e0
build(deps): bump rubocop-ast from 1.9.1 to 1.10.0 in /Library/Homebrew
Bumps [rubocop-ast](https://github.com/rubocop-hq/rubocop-ast) from 1.9.1 to 1.10.0.
- [Release notes](https://github.com/rubocop-hq/rubocop-ast/releases)
- [Changelog](https://github.com/rubocop/rubocop-ast/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop-ast/compare/v1.9.1...v1.10.0)

---
updated-dependencies:
- dependency-name: rubocop-ast
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-08-13 18:03:58 +00:00
Bo Anderson
e8b82bbe1e
Fix brew style 2021-08-13 13:49:52 +01:00
Bo Anderson
c5de106c26
Merge pull request #11853 from Homebrew/dependabot/bundler/Library/Homebrew/sorbet-0.5.9033
build(deps-dev): bump sorbet from 0.5.9030 to 0.5.9033 in /Library/Homebrew
2021-08-12 19:37:52 +01:00
BrewTestBot
9589416fd4
Update RBI files for rubocop. 2021-08-12 18:11:22 +00:00
BrewTestBot
02d6cba752
brew vendor-gems: commit updates. 2021-08-12 18:08:56 +00:00
BrewTestBot
7e08abe374
brew vendor-gems: commit updates. 2021-08-12 18:08:30 +00:00
dependabot[bot]
f820dbd711
build(deps-dev): bump sorbet in /Library/Homebrew
Bumps [sorbet](https://github.com/sorbet/sorbet) from 0.5.9030 to 0.5.9033.
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

---
updated-dependencies:
- dependency-name: sorbet
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-08-12 18:06:02 +00:00
dependabot[bot]
0fe3b7cf14
build(deps): bump rubocop from 1.18.4 to 1.19.0 in /Library/Homebrew
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.18.4 to 1.19.0.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop/compare/v1.18.4...v1.19.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-08-12 18:05:49 +00:00
Nanda H Krishna
afc5804cbe
Merge pull request #11720 from nandahkrishna/formula-branch-audit
resource_auditor: add audit for HEAD default branch
2021-08-12 19:52:21 +05:30
Sam Ford
694645e91c
Merge pull request #11842 from samford/livecheck/refactor-strategy-block-handling
Refactor livecheck strategy block handling
2021-08-12 10:15:02 -04:00
Connor Mann
057137c760
Merge pull request #11849 from cnnrmnn/revision-secondary-sort
Add revision secondary sort to `resolve_latest_keg`
2021-08-12 10:13:53 -04:00
Nanda H Krishna
5191199957
resource_auditor: use if instead of unless
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2021-08-12 19:28:06 +05:30
Connor Mann
92717b6f6f
Update Library/Homebrew/cli/named_args.rb
Co-authored-by: Rylan Polster <rslpolster@gmail.com>
2021-08-12 09:16:23 -04:00
Mike McQuaid
9fe642759c
Merge pull request #11818 from sudoforge/docker-remove-extraneous-commands
Dockerfile: remove extraneous permission modification commands
2021-08-12 13:42:31 +01:00
Nanda H Krishna
f69f9be233
Add allowlist, make branch: mandatory 2021-08-12 12:43:22 +05:30
Nanda H Krishna
d75320069f
resource_auditor: add audit for HEAD default branch 2021-08-12 12:43:21 +05:30
Connor Mann
a566c53db8
Add resolve_latest_keg revision secondary sort 2021-08-11 20:07:28 -04:00
Sam Ford
c59d5db631
Remove unnecessary require statements 2021-08-11 19:06:00 -04:00
Sam Ford
c936a9420e
Improve documentation comments 2021-08-11 19:05:59 -04:00
Sam Ford
f2bd39ccef
Add additional method signatures to strategies 2021-08-11 19:05:59 -04:00
Sam Ford
7e07010f06
Improve standardization of strategy tests 2021-08-11 19:05:59 -04:00
Sam Ford
56dd89114d
Standardize valid strategy block return types
Valid `strategy` block return types currently vary between
strategies. Some only accept a string whereas others accept a string
or array of strings. [`strategy` blocks also accept a `nil` return
(to simplify early returns) but this was already standardized across
strategies.]

While some strategies only identify one version by default (where a
string is an appropriate return type), it could be that a strategy
block identifies more than one version. In this situation, the
strategy would need to be modified to accept (and work with) an
array from a `strategy` block.

Rather than waiting for this to become a problem, this modifies all
strategies to standardize on allowing `strategy` blocks to return a
string or array of strings (even if only one of these is currently
used in practice). Standardizing valid return types helps to further
simplify the mental model for `strategy` blocks and reduce cognitive
load.

This commit extracts related logic from `#find_versions` into
methods like `#versions_from_content`, which is conceptually similar
to `PageMatch#page_matches` (renamed to `#versions_from_content`
for consistency). This allows us to write tests for the related code
without having to make network requests (or stub them) at this point.
In general, this also helps to better align the structure of
strategies and how the various `#find_versions` methods work with
versions.

There's still more planned work to be done here but this is a step
in the right direction.
2021-08-11 19:05:57 -04:00
Sam Ford
cf79ced740
Rework how strategy constants are identified
Up to this point, we've had to rely on making `Strategy` constants
private to ensure that the only available constants are strategies.
With the current setup, the existence of a constant that's not a
strategy would break `Strategy#strategies` and
`Livecheck#livecheck_strategy_names`.

Instead, we can achieve the same goal by skipping over constants
that aren't a class. Other than saving us from having to make these
constants private, this is necessary to be able to create a
`Strategy` constant that can be used in all strategies.
2021-08-11 18:25:34 -04:00
Nanda H Krishna
cd900ef71e
Merge pull request #11848 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-ast-1.9.1
build(deps): bump rubocop-ast from 1.9.0 to 1.9.1 in /Library/Homebrew
2021-08-12 00:05:34 +05:30
BrewTestBot
37e1d3cb71
Update RBI files for rubocop-ast. 2021-08-11 18:10:53 +00:00
BrewTestBot
8fd6f9735b
brew vendor-gems: commit updates. 2021-08-11 18:08:35 +00:00
dependabot[bot]
6333d0af30
build(deps): bump rubocop-ast from 1.9.0 to 1.9.1 in /Library/Homebrew
Bumps [rubocop-ast](https://github.com/rubocop-hq/rubocop-ast) from 1.9.0 to 1.9.1.
- [Release notes](https://github.com/rubocop-hq/rubocop-ast/releases)
- [Changelog](https://github.com/rubocop/rubocop-ast/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop-ast/compare/v1.9.0...v1.9.1)

---
updated-dependencies:
- dependency-name: rubocop-ast
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-08-11 18:04:48 +00:00
Benjamin Denhartog
ae14ab0ba0
Dockerfile: remove extraneous permission modification commands
These are no longer necessary due to the fact that the second `RUN`
instruction runs as the `linuxbrew` user (as of commit
77afe94446e78e688ebde7a5e2b1249fc0a4afcd).
2021-08-11 11:22:07 -06:00
Mike McQuaid
bee3e6725c
Merge pull request #10769 from Bo98/big-sur-sdk
Migrating to the MacOSX11.sdk symlink
2021-08-11 15:21:00 +01:00
Bo Anderson
9686ebe355
os/mac/diagnostic: prevent some double diagostic failures 2021-08-11 14:19:22 +01:00
Bo Anderson
49f789d492
os/mac/xcode: bump minimum CLT version to 12.5 2021-08-11 14:19:22 +01:00
Bo Anderson
dae1d89780
os/mac/sdk: use MacOSX11.sdk symlink 2021-08-11 14:19:22 +01:00
Nanda H Krishna
8fa1903be5
Merge pull request #11846 from Homebrew/update-man-completions
Update maintainers, manpage and completions.
2021-08-11 18:00:16 +05:30
BrewTestBot
33e5cd8ba4
Update maintainers, manpage and completions.
Autogenerated by the [update-man-completions](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/update-man-completions.yml) workflow.
2021-08-11 12:06:15 +00:00
Dustin Rodrigues
025d212db6
Merge pull request #11845 from dtrodrigues/typecheck-silicon 2021-08-11 08:04:12 -04:00
Carlo Cabrera
2d2aff3250
Merge pull request #11832 from AkihiroSuda/arch-allowlist 2021-08-11 19:19:34 +08:00
Dustin Rodrigues
c6bb748ea9
typecheck: allow typecheck command to run on Apple Silicon 2021-08-11 06:42:02 -04:00
Mike McQuaid
f38783ad4a
Merge pull request #11771 from Homebrew/dependabot/bundler/Library/Homebrew/sorbet-0.5.6519
build(deps-dev): bump sorbet from 0.5.6274 to 0.5.9030 in /Library/Homebrew
2021-08-11 11:17:27 +01:00