2297 Commits

Author SHA1 Message Date
Nuno Cruces
9740510650 Revert "brew tap-new: tests.yml workflow fails with casks"
This reverts commit 20d59effd6a1c3f6268284a6735c562dfe428821.
2021-06-09 19:11:42 +01:00
Bo Anderson
9938621f23
Merge pull request #11470 from Bo98/unbottled-arch
dev-cmd/unbottled: fix arch requirement handling
2021-06-09 14:01:06 +01:00
Rylan Polster
08b44afcdf
cli/parser: allow options to be hidden 2021-06-08 22:02:32 -04:00
Nuno Cruces
20d59effd6
brew tap-new: tests.yml workflow fails with casks
Running `brew test-bot --only-tap-syntax` fails on `ubuntu-latest` if any casks are added later to the tap, since casks are macOS only.
2021-06-08 13:09:27 +01:00
Nanda H Krishna
99702b2475
Merge pull request #11497 from nandahkrishna/remove-publish-flag
`brew pr-{pull,upload}`: remove `--no-publish` flag
2021-06-08 17:33:22 +05:30
Mike McQuaid
c4d69dd2e9
Revert "fix(vendor-gems): redirect bundler stdout to stderr" 2021-06-07 14:51:07 +01:00
Nanda H Krishna
b607fb0712
brew pr-{pull,upload}: remove --no-publish flag
The `--no-publish` flag isn't used anywhere since we removed all the
Bintray code. Also, the `--no-upload` flag used in `pr-pull` doesn't
apply the bottle commit, so its description has been modified.
2021-06-07 15:13:29 +05:30
Gibson Fahnestock
07d571bebc
fix(vendor-gems): redirect bundler stdout to stderr
When running brew commands and interpreting the output, e.g. running
`brew livecheck --json`, it's necessary to stop other programs Homebrew
happens to execute from writing logging output to stdout. Most programs
don't do this, but `bundle install` does seem to.

To reproduce the issue you can run:

```shell
git -C "$(brew --prefix)" clean -ffdx Library/Homebrew/vendor
stdout=$(HOMEBREW_FORCE_VENDOR_RUBY=1 brew livecheck --newer-only --json --cask $(brew --repo homebrew/cask)/Casks/grid.rb)
echo "^^^ was stderr, >>> is stdout: $stdout"
```

If you run it without this change it will print a bunch of output like
this to the stdout before printing out the livecheck JSON output:

```text
Using bundler 1.17.3
Fetching byebug 11.1.3
Fetching coderay 1.1.3
Installing byebug 11.1.3 with native extensions
Installing coderay 1.1.3
Fetching colorize 0.8.1
Installing colorize 0.8.1

[
  # Contents of the JSON block.
]
```

With this change the stdout from `bundle install` will be redirected to
brew's stderr, meaning only the JSON goes to stdout, and the rest goes
to stderr.
2021-06-03 11:18:23 +01:00
Rylan Polster
023063d6a2
bottle: calculate rebuild correctly when removing bottle :unneeded 2021-06-01 11:39:07 -04:00
Bo Anderson
984226d5b5
dev-cmd/unbottled: fix arch requirement handling 2021-05-31 15:24:20 +01:00
Bo Anderson
7ae9cc3467
Merge pull request #11440 from scpeters/extract_downcased_version
extract: use downcased version in filename
2021-05-27 15:07:56 +01:00
Rylan Polster
d0f5a0832e
Merge pull request #11397 from cnnrmnn/add-link-head
Add `brew link --HEAD`
2021-05-26 11:46:58 -04:00
Steve Peters
2655014951
extract: use downcased version in filename
Formula filenames are required to be lowercase, so the
extract command should downcase version before
using it to construct the filename. I noticed this while
extracting tbb@2020, which has version 2020_U3
and resulted in tbb@2020_U3.rb
2021-05-25 23:20:15 -07:00
Nanda H Krishna
ba17e2b8c1
dev-cmd/update-maintainers: fix require
Use require "dev-cmd/generate-man-completions" instead of require "dev-cmd/man".
2021-05-22 05:57:19 +05:30
Connor Mann
2bfdbc6b39 Rename missed to_keg 2021-05-19 12:59:53 -04:00
Mike McQuaid
2bd71ffb30
/dev-cmd/pr-publish: tweak wording.
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
2021-05-19 11:36:59 +01:00
WingLim
ddcb0519b6 feat: add branch param 2021-05-19 18:06:21 +08:00
Connor Mann
d46881c5e2 Rename to_kegs to to_keg 2021-05-18 09:52:19 -04:00
Rylan Polster
7c68b1738b
Merge pull request #11332 from Rylan12/relocate-paths-at-start
keg_relocate: only replace matches at the start of a path
2021-05-13 12:19:06 -04:00
Rylan Polster
4457dc904b
Cleanup using suggestions from code review 2021-05-13 11:02:39 -04:00
Bo Anderson
6d31408606
dev-cmd/bottle: make gzip creation consistent across platforms 2021-05-12 14:21:38 +01:00
Mike McQuaid
b914411ac8
Delete Bintray code
Remove all code related to Bintray. It no longer works so there's no
point keeping it around.

Some of this could arguably be deprecated/disabled first/instead but:
I'm not sure I see the sense in keeping stuff around that's known to be
broken.
2021-05-12 13:37:18 +01:00
Rylan Polster
5f781770b4
Extract Keg::text_matches_in_file from bottle command 2021-05-11 14:26:14 -04:00
Rylan Polster
fe7f80f647
Refactor out and correctly create path regex 2021-05-11 14:26:14 -04:00
Rylan Polster
fd3730a531
bottle: allow links to pkgconfig directory in HOMEBREW_REPOSITORY 2021-05-11 14:26:14 -04:00
Rylan Polster
9ddb531249
bottle: update keg_contain? to match correctly 2021-05-11 14:26:14 -04:00
Nanda H Krishna
8e1c9234e3
dev-cmd/bump: fix empty array check 2021-05-09 18:07:33 +05:30
Rylan Polster
acebeab9cb
bottle: improve style of rebuild fallback
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2021-05-05 08:27:58 -04:00
Rylan Polster
da27c70323
bottle: properly set rebuild for new formulae 2021-05-04 23:10:40 -04:00
Nanda H Krishna
0ed2f6423f
Merge pull request #11308 from nandahkrishna/rename-brew-man
Rename `brew man` to `brew generate-manpages`
2021-05-04 23:02:39 +05:30
Mike McQuaid
7c52c30312
Merge pull request #11293 from bluelabsio/latest-version-only
bottle: Only consider latest rebuild
2021-05-04 17:01:34 +01:00
Chris Wegrzyn
aa3e623b28 Omit warning, as brew audit already covers this 2021-05-04 09:50:42 -04:00
Chris Wegrzyn
570b62dd75 prev_f -> upstream_f 2021-05-04 09:41:53 -04:00
Bo Anderson
f174d4363f
extend/pathname: limit write override to a refinement 2021-05-04 14:20:20 +01:00
Nanda H Krishna
ca11dc92ca
dev-cmd/generate-man-completions: update description
Co-authored-by: Rylan Polster <rslpolster@gmail.com>
2021-05-04 18:38:55 +05:30
Nanda H Krishna
b9b83edc1a
dev-cmd: rename brew man to brew generate-man-completions 2021-05-04 18:32:42 +05:30
Chris Wegrzyn
9ab44b8b6a bottle: just check origin/HEAD for rebuild 2021-05-03 10:07:30 -04:00
Chris Wegrzyn
056c9bb37f Only consider latest rebuild 2021-05-03 10:07:29 -04:00
Mike McQuaid
08926fb1ec
dev-cmd: run Homebrew.install_bundler_gems! earlier.
Run `Homebrew.install_bundler_gems!` a bit earlier for some developer
commands to avoid printing gem installation output in the middle of
normal developer command output.
2021-04-30 12:00:28 +01:00
Mike McQuaid
2fa973bb3b
Merge pull request #11259 from bluelabsio/bottle-root-url-specs
dev-cmd/bottle: Support adding root_url specs to bottle spec
2021-04-29 19:54:53 +01:00
Chris Wegrzyn
68852c9162 Style fix 2021-04-29 12:51:15 -04:00
Chris Wegrzyn
ee8dc058d8 Better help text 2021-04-29 12:37:22 -04:00
Chris Wegrzyn
ffbabfd238 Rename download-strategy to root-url-using 2021-04-29 12:37:20 -04:00
Chris Wegrzyn
76607bbb6f Simplify conditional as suggested
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2021-04-29 12:35:50 -04:00
Chris Wegrzyn
3f60c95425 --download-strategy instead of --root-url-spec 2021-04-29 12:35:48 -04:00
Chris Wegrzyn
4025dce097 Support adding root_url specs in bottle output 2021-04-29 12:34:03 -04:00
Mike McQuaid
dcf03173e9
dev-cmd/bottle: remove double [tag].
Fixes https://github.com/Homebrew/brew/pull/11283#discussion_r623181245
2021-04-29 17:08:23 +01:00
Mike McQuaid
7ba634ccb4
Merge pull request #11283 from MikeMcQuaid/no_bottle_changes_error_handling
dev-cmd/bottle: handle empty collector tags.
2021-04-29 16:32:35 +01:00
Michka Popoff
1a27e4fd4a
Merge pull request #11278 from iMichka/bottle
bottle: do not fail on missing bottle block
2021-04-29 17:22:39 +02:00
Mike McQuaid
f9589429d6
dev-cmd/bottle: handle empty collector tags.
Fixes https://github.com/Homebrew/homebrew-core/runs/2467738434?check_suite_focus=true#step:6:458
2021-04-29 16:00:22 +01:00