I assume that we want to encourage people hosting
their own bottles to serve them using `https`.
This PR has a trivial change in the example.
We may consider adding some text to the `root_url`
description with a discussion of security.
Also use https://example.com instead of
http://mikemcquaid.com in bottle example.
ClosesHomebrew/homebrew#44651.
Signed-off-by: Xu Cheng <xucheng@me.com>
`chown -R` should be sufficient. There is no obvious reason to chown the top-level directory as a separate command.
ClosesHomebrew/homebrew#44554.
Signed-off-by: Tim D. Smith <git@tim-smith.us>
Bottles for VTK and ITK python are no more provided.
ITK can be wrapped with Python since version 4.8, so this tap
is no more needed. Using the vanilla homebrew VTK and ITK formulas is
the way to go.
ClosesHomebrew/homebrew#44467.
Signed-off-by: Alex Dunn <dunn.alex@gmail.com>
There are plenty of IO operations inside Tap object, and it will be more
when implementing formula alias reverse look up(e.g. list all of alias
names for a formula). So let's cache them.
Some benchmark:
$ time brew info $(brew ruby -e 'puts Formula.tap_names') > /dev/null
Before: 6.40s user 2.42s system 96% cpu 9.134 total
After: 4.75s user 0.77s system 97% cpu 5.637 total
ClosesHomebrew/homebrew#44377.
Signed-off-by: Xu Cheng <xucheng@me.com>
When a PR is merged during the test, the commit tree will be looked like
this:
master PR
\ /
\ /
|
root
The start_revision will be poined to the commit used to merging PR,
instead of common root commit. As result, `git diff-tree start end`
will list file changes both in PR and master branch, which later
contributes to additional formulae are tested in some Travis builds.
To fix the problem, we use `git merge-base` to get common ancestor as
the real start_revision.
ClosesHomebrew/homebrew#44379.
Signed-off-by: Xu Cheng <xucheng@me.com>
If a PR is edited(e.g. force pushed) during the build.
TRAVIS_COMMIT will be lost. Refetching the merge ref wouldn't
help this situation as well. Since Travis already have reset
$TRAVIS_BUILD_DIR to the commit we need to test, let's use it to
determine TRAVIS_COMMIT directly.
Ref: https://github.com/travis-ci/travis-ci/issues/2666
We previously set `ignore_deps?` as true for DependencyInstaller to
avoid duplicated dependencies resolution. (See a9fc82aea30506eeacbddeb8b53fb85de8acb9d4)
However, this will cause problem when pouring bottle of a dependency is
failed. In this case, it will try to build dependency from source but
failed due to uninstalled build deps for this formula.
Another disadvantage for using `ignore_deps?` hack is we cannot
distinguish users passing `--ignore-dependencies` flag from we are in
`DependencyInstaller`.
So, let's differentiate these using `skip_deps_check?`
When there's absolute symlinks in a linked directory in the `keg`
(e.g. `bin`)that point to the `Cellar` or `opt` then linking the `keg`
will fail before the `Cellar` or `opt` has been linked.
ClosesHomebrew/homebrew#44306.
ClosesHomebrew/homebrew#44329.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
`brew bottle --verbose` outputs all the matches for a string found
in the files inside the Cellar. Instead of outputting all of these just
output the first 100.
ClosesHomebrew/homebrew#44266.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
IO#gets will only return for every new lines, which will be bad for
`brew install` since we print dots in single line.
ClosesHomebrew/homebrew#44264.
Signed-off-by: Xu Cheng <xucheng@me.com>
