William Woodruff
057a6c5f9b
add multi subject test
...
Signed-off-by: William Woodruff <william@yossarian.net>
2024-12-05 14:26:30 -05:00
Carlo Cabrera
7b74bf07fd
Fix attestation test failures
2024-10-04 16:00:29 +08:00
William Woodruff
09c12d817e
Revert "attestation: specialize error when gh is old"
2024-08-12 15:53:17 -04:00
William Woodruff
be8ee6ea22
fixup attestation_spec
...
Signed-off-by: William Woodruff <william@yossarian.net>
2024-08-12 15:10:18 -04:00
William Woodruff
5e0e0d56af
attestation: remove gh version detection
...
I'm declaring bankruptcy on this entire approach:
1. We can attempt to match on versions, but this will fail
when the version of `gh` installed is built from `HEAD`
or similar.
2. We can match on dates instead (since `gh --version` also includes
the date), but this is even more brittle + implies a support
contract we don't actually have (we don't actually want
to say we support random dated builds between public releases
of `gh`).
This moves us back to a simpler approach: if `gh` is present,
we use it. If `gh` is not present, we attempt to install it
with `ensure_executable!`. If the user's `gh` is present but too old,
it'll fail during attestation verification with a reasonable error,
which IMO is fine for now since this is all still in beta.
Signed-off-by: William Woodruff <william@yossarian.net>
2024-07-29 13:13:55 -04:00
Bo Anderson
131b930d89
attestation: only fallback to backfill on 404
2024-07-23 16:59:52 +01:00
Nanda H Krishna
45f853ef61
Merge pull request #17793 from Homebrew/fix-frozen-array-modification-errors
...
Avoid frozen array errors in `brew upgrade`
2024-07-19 09:58:57 -04:00
apainintheneck
5a37a77a7b
Add tests for new sort_formulae_for_install method
...
These are integration tests but they should complete relatively
quickly anyway since we're not installing anything.
2024-07-18 21:38:43 -07:00
Bo Anderson
16d547b030
attestation: handle bad configurations better
2024-07-18 16:11:25 +01:00
Nanda H Krishna
6db608f43f
Ensure that the gh formula is sufficiently new
2024-07-17 14:48:53 -04:00
Nanda H Krishna
8839ccfe72
Fix tests for attestations
2024-07-17 14:48:53 -04:00
Nanda H Krishna
802eb54e87
Fix tests for attestations
2024-07-17 14:48:50 -04:00
Bo Anderson
f40330c42d
attestation: avoid touching working directory
2024-07-17 19:18:09 +01:00
William Woodruff
ad1500ad60
Apply suggestions from code review
2024-07-14 16:30:12 -04:00
Nanda H Krishna
1ae21d2731
attestation: improve error message when gh is too old
2024-07-14 16:12:56 -04:00
William Woodruff
6cfe118ae3
attestation: don't dupe stderr
...
Silences `system_command!`'s own stderr handling,
since we do it independently.
Signed-off-by: William Woodruff <william@yossarian.net>
2024-07-13 15:30:21 -04:00
William Woodruff
b92de887ee
attestation_spec: add :all tag test
...
Signed-off-by: William Woodruff <william@yossarian.net>
2024-06-06 11:35:43 -04:00
William Woodruff
83caa42876
attestation_spec: style fix
...
Signed-off-by: William Woodruff <william@yossarian.net>
2024-06-06 11:30:11 -04:00
William Woodruff
8d0e6eafc3
attestation: handle :all bottles
...
Signed-off-by: William Woodruff <william@yossarian.net>
2024-06-06 11:23:03 -04:00
William Woodruff
3319e9956d
attestation: drop workflow check on core attestation
...
Signed-off-by: William Woodruff <william@yossarian.net>
2024-05-18 10:04:53 -04:00
William Woodruff
f78a8882d9
attestation: redact secret in environment
...
Signed-off-by: William Woodruff <william@yossarian.net>
2024-05-14 14:32:23 -04:00
William Woodruff
7e43e5aafe
attestation_spec: another auth case
...
Signed-off-by: William Woodruff <william@yossarian.net>
2024-05-03 13:17:31 -04:00
William Woodruff
2aa3d77f72
attestation_spec: fixup
...
Signed-off-by: William Woodruff <william@yossarian.net>
2024-05-03 13:01:02 -04:00
Joseph Sweeney
883c1e9907
Update attestation tests
2024-04-30 10:16:57 -04:00
William Woodruff
faa00c8c79
handle backfilled attestation subjects correctly
...
Signed-off-by: William Woodruff <william@yossarian.net>
2024-04-11 16:44:57 -04:00
William Woodruff
e2b5d93198
more attestation coverage
...
Signed-off-by: William Woodruff <william@yossarian.net>
2024-04-11 13:39:13 -04:00
William Woodruff
480e48b75d
attestation_spec: simplify gh_executable test
...
Signed-off-by: William Woodruff <william@yossarian.net>
2024-04-10 18:02:56 -04:00
William Woodruff
990b7d77d6
attestation: fix a missing arg, add initial specs
...
Signed-off-by: William Woodruff <william@yossarian.net>
2024-04-10 17:57:01 -04:00
