admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
37,846 Commits 15 Branches 471 Tags
Commit Graph

327 Commits

Author SHA1 Message Date
Mike McQuaid
cc6c6afffb
test/dev-cmd: add more parseable arguments tests. 2019-03-27 14:22:30 +00:00
Mike McQuaid
1e5cfcc028
Separate tap tests into separate, correct files. 2019-03-27 13:35:42 +00:00
Mike McQuaid
aa44509be9
Test dev-cmd *_args methods 
Also, add a few missing invocations.
 2019-03-27 13:35:42 +00:00
Mike McQuaid
59d680a626
dev-cmd: only one integration test per command. 
Integration tests are useful in detecting breakages but much slower so
let's only use one per command and install formula outside the
integration test framework (which is also slow).
 2019-03-27 09:45:48 +00:00
Mike McQuaid
3615f891f7
tap-new: improve output. 
Note the tap path.

References #5901.
 2019-03-23 12:41:35 +00:00
Shaun Jackman
82da3b43cc audit: Keg-only :provided_by_macos dep okay on Linux 
Disable this brew audit error on Linux:
* Dependency 'zlib' may be unnecessary as it is provided by macOS;
try to build this formula without it.
 2019-03-02 13:29:49 -08:00
Mike McQuaid
17f3ee1957
Improve Bundler cleanup 
Rather than trying to be smart and doing this ourselves in `brew cleanup` let’s just installed Bundler somewhere it doesn’t try to clean itself up and use `bundle install --cleanup` when we need cleanup done.

Also, use `ohai` and `odie` when possible as they look nicer.
 2019-02-27 14:02:46 +00:00
Mike McQuaid
fcfabfb3c6
dev-cmd/pull_spec: require Homebrew/homebrew-core for subtest. 2019-02-25 17:21:09 +00:00
Claudia
5be80a78f6
Use Homebrew-controlled domain for Cask dummy URLs 
In a number of Cask specs, the value of the `homepage` stanza is currently set
to https://example.com. As of 2018-11-28, the TLS certificate served by
example.com seems to be expired, possibly due to an oversight on ICANN’s side.

While the certificate is certainly going to be renewed soon, it would be
desirable for Homebrew’s test result to be less dependent on ICANN’s actions.
This commit changes the homepages of all test Casks to http://brew.sh, whose
domain and TLS certificate are both controlled by Homebrew.
 2018-11-28 20:51:55 +01:00
Steven Peters
7116b74705 dev-cmd/bottle: require arg for --root-url 2018-10-29 14:54:37 -07:00
Mike McQuaid
303f9579d6
Merge pull request #5075 from EricFromCanada/cmd-help-new 
docs: conversion & review of Homebrew::CLI::Parser help in dev-cmd/
 2018-10-20 11:53:55 +01:00
EricFromCanada
ddf057f3dd dev-cmd/: edit help text and descriptions. 2018-10-19 13:12:11 -04:00
commitay
0a3ad268a0 audit: check versioned formulae for keg_only :versioned_formula 2018-10-17 23:52:42 +10:00
commitay
c2bf97bdee audit: use core_tap instead of official_tap 2018-10-12 09:12:12 +10:00
Markus Reiter
943e227ca1 Retry all specs with :needs_network. 2018-09-14 16:57:14 +02:00
Caleb Xu
0e080eba97 extract: simplify integration tests 2018-08-25 10:51:31 -04:00
Caleb Xu
9ab3ff4a41 extract: add spec/integration test 2018-08-24 11:42:11 -04:00
Caleb Xu
875885dda6 Add a starter file for spec 2018-08-21 10:17:23 -04:00
Markus Reiter
ad150e7595
Merge pull request #4611 from retokromer/patch-1 
use `https://` rather than `http://`
 2018-08-06 20:30:35 +02:00
Markus Reiter
d33241bc11 Use -- for bottles. 2018-08-06 17:59:51 +02:00
Reto Kromer
456571b15d fix more insecure protocols 2018-08-06 16:50:42 +02:00
Shaun Jackman
1b688a3a25 Relocate bottles on Linux using patchelf 
Ensure patchelf is installed to pour bottles and build bottles.
 2018-07-12 10:21:26 -07:00
Markus Reiter
7762ce32aa Use more descriptive heredoc names. 2018-07-11 18:15:30 +02:00
Mike McQuaid
6f5c8b8509 linkage: enable cache by default. 
This has not been causing any issues in CI or for `master` users so
let's now enable it by default for everyone.
 2018-06-29 19:57:39 +01:00
Markus Reiter
d98c45b2d3 Fix code style in audit spec. 2018-06-02 03:46:55 +02:00
Mike McQuaid
97645d061d
Merge pull request #3720 from AndrewMcBurney/cache-optimization 
Cache optimization for `brew linkage` command.
 2018-05-24 09:14:02 +01:00
Andrew R. McBurney
a9606b4a18 Added trivial integration tests for brew linkage. 2018-05-23 13:00:05 -04:00
Mike McQuaid
f6bf989378 Remove some integration tests 
We have an awful lot of integration tests and they are (comparatively)
really slow. Let's kill those that test edge case conditions and focus
on those that test that our functionality works as expected. Edge cases
can be better tested with unit tests.
 2018-05-23 14:41:31 +01:00
Gautham Goli
26e77dd75c new-formula: Don't fail CI instead comment on PR about audit violations 2018-04-30 10:59:20 +05:30
Markus Reiter
5195e72242
Merge pull request #4064 from elyscape/tap-autoupdate 
Support enabling auto-updates for non-GitHub taps
 2018-04-24 20:54:08 +02:00
Eli Young
8734848829 Support enabling auto-updates for non-GitHub taps 2018-04-24 11:10:48 -07:00
Markus Reiter
33a9521576 Fix MissingFormula namespacing. 2018-04-22 17:27:44 +02:00
Mike McQuaid
49038a2cd9 Remove mentions to official taps 
There are none remaining. We don’t want PHP to get the deprecated
messages until all formulae have been deleted so that will be in a
later PR.
 2018-03-31 13:42:33 +01:00
Mike McQuaid
5e1806e796 test: rubocop-rspec style auto-corrects. 
There’s too many warnings to start enabling `rubocop-rspec` by default
but let’s at least apply the cleanups it does automatically.
 2018-03-25 13:30:37 +01:00
Steven Peters
db615a419a dev-cmd/ruby: fix path to dev-cmd/irb and add test 2018-02-28 09:31:29 -08:00
Mike McQuaid
c57ab279ba Use rspec-retry in flaky brew tests. 
We have a few tests that are intermittently flaky. Let's try this to see
if we can get them a bit more reliable.
 2018-02-13 09:34:25 +00:00
William Woodruff
3f43f60a2a
audit: Warn on new formulae containing binary URLs 2018-02-06 08:44:56 -05:00
Mike McQuaid
fab0ea6fda Deprecate Homebrew/homebrew-science 2018-01-01 09:33:43 +00:00
Mike McQuaid
4d4722c97c Remove more uses of EOS.undent. 2017-11-10 14:22:39 +00:00
Mike McQuaid
219f9691ef
Merge pull request #3292 from claui/add-audit-test-cases 
Add tests for `FormulaAuditor#audit_deps`
 2017-11-10 13:34:56 +00:00
Shaun Jackman
f9d42659ea pull: Fix pull --bottle 1234 
Fix the error:
Error: undefined method `casecmp' for nil:NilClass
 2017-10-22 08:52:16 -07:00
Claudia
e0bb978cc9 Add tests for FormulaAuditor#audit_deps 
These tests cover a few aspects of the `FormulaAuditor#audit_deps`
method. The main focus is the part where FormulaAuditor checks for
dependencies on formulas which are tagged `keg_only` with the
`:provided_by_macos` reason.

For this particular kind of `keg_only` formulas, we expect
`brew audit --new-formula` to fail with a problem message like:

> Dependency 'bc' may be unnecessary as it is provided by
> macOS; try to build this formula without it.

For more details, see the relevant discussion:

[1] https://github.com/Homebrew/homebrew-core/pull/14067#issuecomment-335046151

[2] https://github.com/Homebrew/brew/pull/3290#issuecomment-335052140
 2017-10-20 14:08:22 +02:00
Markus Reiter
9bee9ca575 Use “squiggly” heredocs. 2017-10-18 14:39:09 +02:00
Gautham Goli
4ec26aea40 audit: Port audit_class to rubocop, add tests and autocorrect 2017-09-04 23:43:42 +05:30
Gautham Goli
affd9055c2 audit: Port classname and template comments audit rules from line_problems method to rubocop 2017-08-06 02:28:58 +05:30
Markus Reiter
2ad3a87045 Silence all specs by default. 2017-07-29 20:25:37 +02:00
JCount
d5838c7e80 pull_spec: use stable, non-fork PR for patch expectation 2017-06-04 15:41:50 -04:00
Gautham Goli
cf848a14d2 audit: Port audit_caveats method to rubocop and add tests 2017-05-31 22:59:48 +05:30
Mike McQuaid
90c971625e Merge pull request #2704 from MikeMcQuaid/jenkins-brew-sh 
Update jenkins.brew.sh links.
 2017-05-30 20:28:50 +01:00
Mike McQuaid
9032574038 Update jenkins.brew.sh links. 
These previously, incorrectly pointed to bot.brew.sh.

Fixes #2703.
 2017-05-30 19:14:40 +01:00