Caleb Xu
713aedb6ed
Fix code review requests
2018-08-21 10:17:23 -04:00
Caleb Xu
260867627b
Switch back to monkey-patching
...
Also gsub! some particular formula contents to work around older
formulae ("brewkit" isn't around anymore, and url is expected to
be a method, not an instance variable).
2018-08-21 10:17:23 -04:00
Caleb Xu
95abdf9662
Use refinements instead of general monkey-patching
2018-08-21 10:17:23 -04:00
Caleb Xu
ff8b5f8c5a
extract: rework to search through old/deleted formulae
...
- Removed use of FormulaVersions - it's generally too brittle for our uses. We
now interface directly with the Git repo via utils/git and monkeypatch the
formula loading process where needed.
- Really old formulae (that specify fields as instance vars instead of methods)
still need more work to be supported; they don't work here quite yet.
- Properly handles deleted/removed formulae from Homebrew/homebrew-core.
Additional work is still needed to search through Homebrew/legacy-homebrew if
this functionality is desired.
2018-08-21 10:17:23 -04:00
Caleb Xu
1003aa72c9
Additional fixups for extract command
...
- Rework command line options
- Make specifying a version optional
- Remove stdout option and require a tap to be specified
- Do not allow user to extract into homebrew/core
- Rework new class name generation to use existing Formulary tools
2018-08-21 10:17:23 -04:00
Caleb Xu
bd2ac70c0f
Fix style issues in extract command
2018-08-21 10:17:23 -04:00
Caleb Xu
055460884b
Fix up extract command
...
- Move from cmd to dev-cmd
- Add --stdout flag
- Add sanity checks for args/flags
- Minor rewording on error messages
2018-08-21 10:17:23 -04:00
Caleb Xu
2952a9bf74
Add new extract command to retrieve old versions of formulae
2018-08-21 10:17:23 -04:00
Markus Reiter
664bd9ac0f
Merge pull request #4728 from reitermarkus/languages
...
Ignore unparsable system languages.
2018-08-21 10:58:22 +02:00
Markus Reiter
556e76b037
Use cp
instead of FileUtils.copy_entry
.
2018-08-20 19:06:55 +02:00
Markus Reiter
48dcf19169
Ignore unparsable system languages.
2018-08-19 22:10:20 +02:00
Mike McQuaid
c9aa25e6d2
Merge pull request #4722 from kabel/remove-chdir-twice
...
Remove the chdir call that was already moved to the ancestor
2018-08-19 16:21:20 +01:00
commitay
84216f5aa8
conflicts_cop: remove node@
from whitelist
2018-08-19 17:35:23 +10:00
Mike McQuaid
b2bfa6247f
Merge pull request #4678 from sjackman/mdfind
...
OS::Mac.mdfind: No need to guard on OS.mac?
2018-08-18 12:06:05 +01:00
Mike McQuaid
b87f2f55c8
Merge pull request #4716 from woodruffw/curl-git-dev-paths
...
brew.sh: Allow developers to specify curl/git paths
2018-08-18 12:05:29 +01:00
Mike McQuaid
bab5b02293
Merge pull request #4620 from brianmorton/hbc_analytics
...
Add analytics to cask installs
2018-08-18 09:33:36 +01:00
Mike McQuaid
077e9f0c53
hbc/installer: don't send analytics for private taps.
2018-08-18 08:48:49 +01:00
Mike McQuaid
b068e4b927
update-report: tweak cask analytics messaging.
2018-08-18 08:26:44 +01:00
Mike McQuaid
7df5b7057e
Revert "Use JSON to marshal errors from children"
2018-08-18 08:20:13 +01:00
Kevin Abel
584cced003
Remove the chdir call that was already moved to the ancestor
...
528b4b367ed2a4026c321e2f2e503ace4548b9d2 moved the chdir definition to
the parent class and call it in the parent's stage. chdir was getting
called twice for archives with two nested directories.
2018-08-17 23:13:23 -05:00
Brian Morton
7ced0be133
Merge branch 'master' into hbc_analytics
2018-08-17 16:18:40 -07:00
William Woodruff
5c90833f0a
Use JSON to marshal errors from children
2018-08-17 15:23:08 -04:00
William Woodruff
a7816eea6e
brew.sh: Remove whitespace
2018-08-17 15:20:05 -04:00
William Woodruff
60741c5c25
brew.sh: Integrate curl/git path checks into main checks
2018-08-17 15:17:14 -04:00
William Woodruff
479f82904b
brew.sh: Allow developers to specify curl/git paths
...
This introduces the HOMEBREW_CURL_PATH and HOMEBREW_GIT_PATH
variables, which are used to populate HOMEBREW_CURL and HOMEBREW_GIT,
respectively, when in developer mode (HOMEBREW_DEVELOPER).
Both paths are expected to be valid executables and must
have the executable bit set.
2018-08-17 14:59:07 -04:00
Jonathan Chang
25d0c020c9
audit: don't error when test block is missing
2018-08-16 16:42:08 -04:00
Jonathan Chang
a5a6da5861
Merge pull request #4698 from jonchang/audit-scope
...
audit: fixes for test checks
2018-08-16 14:45:51 -04:00
Jonathan Chang
ca59377a90
audit: add autocorrect and tests for test checks
2018-08-16 12:43:50 -04:00
Jonathan Chang
5f981a8722
tests: add test for test calls audit cop
2018-08-16 12:43:13 -04:00
Jonathan Chang
2487345460
audit: fixes for test checks
2018-08-16 12:43:13 -04:00
JBallin
520b5a103a
Clarify that --cleanup only runs on formulae which were just upgraded
2018-08-16 09:28:24 -07:00
JBallin
526262fca5
Change <formula> to <formulae> to match the suggested inputs
2018-08-16 09:28:24 -07:00
Markus Reiter
efd1884c2e
Hide lockfiles being cleaned up again.
2018-08-16 12:45:17 +02:00
Mike McQuaid
40fc520a45
brew.rb: only output "Kernel.exit" in debugging mode.
...
This doesn't seem to make sense for `--verbose`.
2018-08-16 09:58:39 +01:00
Claudia
61db35f77d
brew style
2018-08-16 09:01:46 +02:00
Brian Morton
ea29158a4d
update git config key for analytics bool
2018-08-16 08:19:11 +02:00
Brian Morton
1b51456b4c
fix module path to ::Utils::Anlytics
2018-08-16 08:18:23 +02:00
Brian Morton
77c242548e
update variable name and msg string per comments
2018-08-16 08:18:23 +02:00
Brian Morton
37f1ae61b2
add cask analytics msg on brew update
2018-08-16 08:16:33 +02:00
Brian Morton
6701c207e0
add anlytics to cask installs
2018-08-16 08:10:07 +02:00
Shaun Jackman
0fcf8abf32
Merge pull request #4696 from sjackman/any-skip-relocation
...
BottleSpecification: Do not skip bottle relocation on Linux
2018-08-15 11:42:20 -07:00
Mike McQuaid
205fdc09db
Merge pull request #4692 from GauthamGoli/gh-api-exception-handling
...
utils/github: Exception handling
2018-08-15 19:06:05 +01:00
Shaun Jackman
294db31849
BottleSpecification: Do not skip bottle relocation on Linux
...
Bottles must be relocated on Linux to find the brewed glibc and gcc.
2018-08-15 10:23:55 -07:00
Shaun Jackman
8a1fa28f9c
KegOnlyReason: Reasons related to macOS valid only on macOS
2018-08-15 10:14:17 -07:00
Dominyk Tiller
2060eb233d
Merge pull request #4676 from DomT4/10xDevTools
...
10x/Mojave: update dev tool expected versions
2018-08-15 16:40:51 +01:00
Gautham Goli
54033d320b
utils/github: Raise exceptions if status code != 200 or exit code is not 0
2018-08-15 20:57:22 +05:30
Markus Reiter
e6b45842e8
Refactor odeprecated
.
2018-08-15 12:16:02 +02:00
Shaun Jackman
27fb8befd0
check_non_libraries: *.so.* is valid on Linux
2018-08-14 14:50:10 -07:00
Shaun Jackman
2c68176ac2
Merge pull request #4686 from sjackman/x11-requirement
...
X11Requirement: Recent X11 client is sufficient
2018-08-14 14:31:11 -07:00
Shaun Jackman
421ba101b4
test/ENV: Fix prepend_path for Linuxbrew
...
This test fails on Ubuntu, because /usr/libexec does not exist.
2018-08-14 12:24:39 -07:00