6868 Commits

Author SHA1 Message Date
Jack Nagel
aaaab946ec Make inreplace errors fatal
Closes Homebrew/homebrew#32649.
Closes Homebrew/homebrew#32703.
2014-09-28 01:11:31 -05:00
Jack Nagel
1c71fb4287 Drop executable bits from imported commands
Closes Homebrew/homebrew#32743.
2014-09-27 23:57:03 -05:00
Jack Nagel
54ac9c560a Revert "Add test for inreplace sub!/gsub! with hash argument"
Ruby 1.8 doesn't support this, so we don't officially support it (yet).

This reverts commit 7d5eb6f5e2da42c1378fefb63fde55cae97a3909.
2014-09-27 23:53:01 -05:00
Jack Nagel
14594741e1 Add test for inreplace sub!/gsub! with hash argument 2014-09-27 23:31:08 -05:00
Jack Nagel
9f9f5bf31c Add test for inreplace sub!/gsub! 2014-09-27 23:31:08 -05:00
Jack Nagel
cb69f339b8 Intercept calls to sub! in inreplace blocks 2014-09-27 19:11:40 -05:00
Jack Nagel
50b900daf3 Don't warn about tap conflicts during pruning
Fixes Homebrew/homebrew#32710.
2014-09-27 12:17:22 -05:00
Jack Nagel
e409aa3084 Clean up inreplace regexps
- use literal syntax
 - escape interpolated variables
 - remove intermediate variables
 - remove unnecessary capture
2014-09-26 22:35:37 -05:00
Jack Nagel
701691c261 Add missing test for inreplace with tabs 2014-09-26 22:01:00 -05:00
Jack Nagel
c0cb58177e Fix formatting in inreplace tests 2014-09-26 21:55:26 -05:00
Adam Vandenberg
95d16ef1ba don't clean libexec 2014-09-26 18:22:19 -07:00
Jack Nagel
fb1250a012 Rescue any SystemCallError from atomic_write 2014-09-25 14:34:38 -05:00
Adam Vandenberg
aea849109d Redact electric-fence
Closes Homebrew/homebrew#31203.
2014-09-24 20:03:34 -07:00
Jack Nagel
799a2a456e Use Dir.glob and array operations to remove whitelisted files 2014-09-24 19:58:10 -05:00
Jack Nagel
586756209c Dir.exist? is not in 1.8 2014-09-24 17:51:36 -05:00
Jack Nagel
612da7c3b0 Make sure the directory exists before chdir 2014-09-24 17:40:17 -05:00
Jack Nagel
0d370bc329 Revert "Revert "Whitelist MacFuse headers""
This reverts commit e81b82cc725ede00c1292a50a076bb8a652ccecd.
2014-09-24 17:40:17 -05:00
Jack Nagel
e603704e41 Revert "Revert "Simplify unbrewed file whitelists""
This reverts commit 338a451a47c884eb9ca96d7b0023417a1eaa4d3d.
2014-09-24 17:40:17 -05:00
Jack Nagel
1bd76b9a6e Revert "Revert "Whitelist OSXFuse headers""
This reverts commit f96ed45fe19855d0f8acc37d5d77d16d607dfce3.
2014-09-24 17:40:16 -05:00
Jack Nagel
ad8556ccea Revert "Revert "Match whitelisted files using fnmatch""
This reverts commit 91be9f5344d5931ddae6e4f905c18a607fa9e9f1.
2014-09-24 17:40:16 -05:00
Mike McQuaid
dfce2bb7c7 brew-man: Rubify, make an internal command.
Closes Homebrew/homebrew#32472.
2014-09-24 15:23:33 -07:00
Mike McQuaid
86ded7833c brew-cleanup-installed: Rubify, make internal cmd. 2014-09-24 15:22:59 -07:00
Mike McQuaid
3b8a6c0724 brew-tap-readme: make an internal command. 2014-09-24 15:22:51 -07:00
Mike McQuaid
8b6978b54d Move manpage to Homebrew (from Contributions).
As this is something we support and update.
2014-09-24 15:22:51 -07:00
Mike McQuaid
af8a9ff502 brew-aspell-dictionaries: make a developer command 2014-09-24 15:22:51 -07:00
Mike McQuaid
ce6d76ed1c brew-switch: make an internal command. 2014-09-24 15:22:51 -07:00
Mike McQuaid
3a432bcc2a brew-pull: make an internal command. 2014-09-24 15:22:46 -07:00
Mike McQuaid
706e8abe29 brew-gist-logs: make an internal command. 2014-09-24 15:22:46 -07:00
Mike McQuaid
7989b2169f brew-test-bot: fix error detection logic. 2014-09-24 15:22:46 -07:00
Mike McQuaid
b7c9025d93 brew-test-bot: make an internal command. 2014-09-24 15:22:37 -07:00
Mike McQuaid
bd8559c791 brew: add contributed tap commands to PATH.
This means that taps root and `cmd` directories are added to the PATH.

This should enable migration of some of our contributed commands into
taps (e.g. `homebrew-boneyard`) and make it easy for third parties to
be able to maintain these. It might also make stuff easier for existing
tools like e.g. `brew-cask` and `boxen`.

Closes Homebrew/homebrew#32471.
2014-09-24 15:14:16 -07:00
Mike McQuaid
05739585d1 Generate RDoc documentation.
This is currently still very messy and we probably want to work out the
best way to declare what parts of our DSL/what files are "public".

Still, even if this is a WIP I'd rather get something committed sooner
rather than later and start iterating on this as a replacement for
`example_formula.rb` and the formula cookbook.

To test:
```bash
cd $(brew --prefix)/Library/Homebrew && \
  rdoc formula.rb requirement.rb utils.rb &&\
  open doc/index.html
```

Closes Homebrew/homebrew#32470.
2014-09-24 15:08:10 -07:00
Mike McQuaid
2df9b0e7ff Revert "Match whitelisted files using fnmatch"
This reverts commit f9c8b5e1da7ac09c85a6ebf9a94624bb9c60bed5.

Closes Homebrew/homebrew#32609.
Closes Homebrew/homebrew#32613.
2014-09-24 15:03:07 -07:00
Mike McQuaid
bc5117b88d Revert "Whitelist OSXFuse headers"
This reverts commit f05d29e3fd0d056b78da6a0b0247e64f91014e04.
2014-09-24 15:03:06 -07:00
Mike McQuaid
068b21db19 Revert "Simplify unbrewed file whitelists"
This reverts commit 2885a92612173f480303b03da1da739eb68550d7.
2014-09-24 15:03:05 -07:00
Mike McQuaid
f9bc7788d2 Revert "Whitelist MacFuse headers"
This reverts commit 6319cac687fa722a1d005fe056e0dac22d91ef9c.
2014-09-24 15:03:04 -07:00
Jack Nagel
959327958c Whitelist MacFuse headers 2014-09-24 15:09:26 -05:00
Jack Nagel
892d7dc130 Simplify unbrewed file whitelists
Only the keys of the hashes are used, so we can just use arrays and
comments instead.
2014-09-24 15:08:19 -05:00
Jack Nagel
f9d5dbb19b Whitelist OSXFuse headers 2014-09-24 14:00:39 -05:00
Jack Nagel
71b0c773ec Match whitelisted files using fnmatch 2014-09-24 14:00:39 -05:00
Jack Nagel
e5c42895a8 Add doctor check for unbrewed header files 2014-09-24 13:16:33 -05:00
Jack Nagel
7b396a5e99 Note that the JDK is required for java dependencies
Closes Homebrew/homebrew#32224.
2014-09-23 20:06:09 -05:00
chdiza
22d8380b05 audit: make has_DATA? ignore commented-out lines
Before this change, audit would detect commented-out lines
containing the string 'DATA' as if there were no commenting.
Then it could complain, e.g., problem "'DATA' was found, but no
'__END__'", which would be a false alarm in that circumstance.

Closes Homebrew/homebrew#32568.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-09-23 15:19:13 -05:00
Jack Nagel
d7dddc8f08 Audit for outdated devel versions 2014-09-23 13:04:55 -05:00
Jack Nagel
d4fad50e76 Update CLT version check 2014-09-21 14:19:48 -05:00
Mike McQuaid
409a7bce96 XQuartz 2.7.7 2014-09-21 10:15:05 -07:00
Mike McQuaid
d4f8931027 Xcode 6.0.1 2014-09-21 10:15:05 -07:00
Jack Nagel
3de77e4e1a Stop recording the fails_with cause internally
The string passed as the cause is currently unused, so we don't need to
actually store it.
2014-09-21 00:57:32 -05:00
Dominyk Tiller
e582d2c87e Boneyarding Metalua
Proposing that we toss Metalua into the boneyard. Reasons:

1) It is hard-coded to look for Lua & Luac binaries, which are
obviously now pointing at Lua (5.2). I tried tweaking those hard-coded
lines with inreplace and had some success, but it still broke on
finding Luac. It complies ‘successfully’, but it won’t do very much.

2) There’s been no stable Metalua release for 5 years.

3) The HEAD build hasn’t worked in at least 8 months because the github
has moved away from compile scripts in favour of becoming Luarocks.

4) Honestly, interest in Metalua seems to be pretty low. If nobody has
noticed the HEAD build has been dead for 8 months…?

I feel like we’d be better scrapping this and pointing people at the
new Luarocks available for Metalua, which are on versions 0.7.2-1
compared to our shipped 0.5-rc2.
2014-09-20 21:44:05 -07:00
Jack Nagel
2d16f8c202 Make Pathname#atomic_write truly atomic
As we know, files cannot be moved across filesystems atomically. In that
case, FileUtils.mv will make a copy. But if we create the temp file in
the same directory as the target, we can avoid this and use File.rename
directly.

Additionally, the rename should be the absolute last step, so that the
original file is preserved if altering ownership and permissions fails.
2014-09-20 17:11:16 -05:00