Mike McQuaid
97645d061d
Merge pull request #3720 from AndrewMcBurney/cache-optimization
...
Cache optimization for `brew linkage` command.
2018-05-24 09:14:02 +01:00
Andrew R. McBurney
ddb7f06e9f
Fixed rubocop
offenses from brew style
.
2018-05-22 12:54:54 -04:00
Mike McQuaid
44f5d3ec79
Refactor cache store code.
2018-05-22 14:46:14 +01:00
Andrew R. McBurney
010207b982
Changed cache usage behavior.
...
1. Running `brew linkage some_package` does not set the cache.
2. Running `brew linkage --cached some_package` when `DatabaseCache.empty?` returns `true` should build the cache.
3. Running `brew linkage --cached some_package` when `DatabaseCache.empty?` returns `false` should use the cache.
2018-05-21 17:36:30 -04:00
Markus Reiter
42db173851
Get rid of unnecessary cd
s.
2018-05-21 20:44:25 +02:00
Markus Reiter
c4c00e4ede
Use safe_system
instead of Utils.popen_read
.
2018-05-21 01:43:49 +02:00
Markus Reiter
b109e6da5d
Handle Tap migration in Tap#initialize
.
2018-05-21 01:43:49 +02:00
Andrew R. McBurney
e93e8f3266
Lazily load db of type DBM
instance variable for DatabaseCache
so the corresponding database file isn't created in the .use
block for a DatabaseCache
.
2018-05-18 16:37:01 -04:00
Andrew R. McBurney
cd6f89ca76
Made DatabaseCache.new
private, and changes instances in code that call it to use DatabaseCache.use
instead.
2018-05-18 10:06:30 -04:00
Maxim Belkin
e5435dfeb7
Cross-platform diagnostics.
2018-05-14 04:44:15 -05:00
Andrew R. McBurney
d3120c0206
Use cache if HOMEBREW_LINKAGE_CACHE
exists in formula_cellar_checks
and formula
. Make functions private in LinkageChecker
.
2018-05-06 15:55:33 -04:00
AndrewMcBurney
a756af3b32
Fixed style issue offenses from brew style
.
2018-04-25 10:27:03 -04:00
AndrewMcBurney
27e5d1aee5
Merge remote-tracking branch 'origin/master' into cache-optimization
2018-04-25 10:04:36 -04:00
Mike McQuaid
8035afcc36
linkage_checker: fix generic pathname calls.
2018-04-25 12:08:33 +01:00
AndrewMcBurney
916247b920
Merge remote-tracking branch 'origin/master' into cache-optimization
2018-04-24 16:49:51 -04:00
Mike McQuaid
4a03145c1c
linkage: fix --test exit code.
...
Ensure that a non-zero exit code is set both for missing random dylibs
and random missing dependencies.
Additionally, while we are here, drastically trim down the public
interface for this class to the bare minimum and allow getting the
output from `display_test_output` as a variable.
Fixes issue mentioned by @ilovezfs in:
https://github.com/Homebrew/brew/pull/3940#issuecomment-383794520
2018-04-24 09:52:51 +01:00
Markus Reiter
5e2d4d52ba
Refactor OsxfuseRequirement
spec.
2018-04-20 19:11:22 +02:00
Markus Reiter
b91628a614
Refactor Hardware::CPU
spec.
2018-04-20 19:11:22 +02:00
Mike McQuaid
6fab4e1805
x11_requirement: move download to base class.
...
No reason to have it in macOS class and keeps consistent output with
`brew info` on Linux.
2018-04-18 11:18:29 +01:00
Mike McQuaid
a4bada575a
requirements: define cask on base class.
...
The `cask` attribute doesn't make as much sense on Linux but can be
ignored there. The advantage of this change is that (like #4086 ) it
allows figuring out the relevant cask for a formulae requirement on a
Linux machine.
2018-04-18 09:55:44 +01:00
AndrewMcBurney
e5eaf57856
Fixed broken test due to changing usage of DatabaseCache
to block usage.
2018-04-09 14:19:07 -04:00
AndrewMcBurney
dcdd16237c
Merge remote-tracking branch 'origin/master' into cache-optimization
2018-04-09 13:49:58 -04:00
Mike McQuaid
cffa5a9864
Disable/delete/add more deprecations
...
Move various `odeprecated` to `odisabled` and delete uses of
`odisabled`.
2018-04-08 14:57:17 -07:00
Mike McQuaid
9fca172d03
Fix HOMEBREW_RUBY_WARNINGS="-w"
...
Fix various circular requirements, method redefinitions, etc.
2018-04-07 20:28:56 +01:00
Mike McQuaid
1376b9e41c
diagnostic: remove missing check.
2018-04-02 19:31:36 +01:00
Mike McQuaid
9b1bd5f45a
system_config: don’t output std/superenv vars.
2018-04-02 09:40:39 +01:00
Mike McQuaid
7095738d1d
Remove config/doctor checks we no longer need
...
A bunch of these were needed before superenv, environment filtering or
on now long-unsupported versions of macOS.
2018-04-02 09:40:39 +01:00
Gautham Goli
164f47a108
irb: Use Parser to parse args
2018-03-24 22:18:50 +05:30
commitay
540f1545c3
Merge pull request #3886 from commitay/java-10
...
java_requirement, cask dsl caveats: java 10
2018-03-21 09:00:24 +10:00
Mike McQuaid
82e82b7fbc
install: add --include-test option.
...
Allow at `install` (or `install --only-dependencies`) time to specify
that test dependencies should be installed. This will allow simplifying
code in `brew test-bot`.
This could also be made an environment variable if desired by
maintainers.
2018-03-15 13:37:34 +00:00
AndrewMcBurney
bc76a8afcb
Changed default behavior of brew linkage
command to build cache instead of using cached output. Cached output may be printed with --cached
flag.
2018-03-14 16:36:56 -04:00
Mike McQuaid
e03f07f302
Rubocop 0.53.0 automatic fixes.
2018-03-08 14:10:02 +00:00
Mike McQuaid
eee6e98d90
Merge pull request #3840 from aw1621107/prefer-xcode-libcxx
...
Add macOS libs ahead of brewed llvm libs in lib search path
2018-03-07 16:03:26 +00:00
Mike McQuaid
740e89d2f3
super: tweak LLVM refactoring.
2018-03-07 15:00:08 +00:00
commitay
8ac3f23b27
java_requirement comment
2018-03-07 19:55:23 +10:00
commitay
032efdebda
java_requirement
2018-03-07 08:20:24 +10:00
AndrewMcBurney
831fcfa5dd
Merge remote-tracking branch 'origin/master' into cache-optimization
2018-03-06 11:46:23 -05:00
Mike McQuaid
7cb6ebf3fb
super: refactor LLVM path addition.
2018-03-06 08:44:47 +00:00
Alyssa Ross
84dda31e82
Add tests for ENV#clear_sensitive_environment!
2018-03-01 17:48:08 +00:00
Shaun Jackman
97932c1abf
Move linkage_checker from os/mac to generic
2018-02-28 11:18:27 -08:00
AndrewMcBurney
d7765dd223
Separated os/mac/cache_store.rb
into cache_store.rb
and os/mac/linkage_cache_store.rb
.
2018-02-28 10:39:15 -05:00
Alex Wang
7b94842610
Split ternary for PATH building into if/else cases
2018-02-28 09:26:15 -05:00
Mike McQuaid
2205f62ec6
irb: add pry support.
...
Make `brew irb` optionally support `pry`. While doing so, also make it a `dev-cmd`.
2018-02-28 11:36:23 +00:00
AndrewMcBurney
14256faa47
Added flag to flush_cache
in LinkageChecker
. Format ruby hash as JSON string before storing in dbm
.
2018-02-27 13:05:19 -05:00
Alex Wang
bfa474857a
Add macOS libs ahead of brewed llvm libs in lib search path
...
This ensures that libraries that are built with brewed LLVM but not
included in the Command Line Tools/Xcode (e.g. libomp) can be found
during a build, while still using system libraries for the essential
stuff (e.g. libc++)
2018-02-26 18:35:34 -05:00
AndrewMcBurney
4bc6459ed7
Removed redundant documentation, use database_cache as a block, and use symbolic keys over string keys in function calls.
2018-02-25 12:14:11 -05:00
Maxim Belkin
5536f49305
Cross-platform java detection
2018-02-22 18:32:21 +00:00
Maxim Belkin
f8874004c2
Make 'xz' and 'cvs' dependencies conditional
2018-02-21 14:11:35 +00:00
Maxim Belkin
14d7a7a08c
Code refactoring 4.0
2018-02-20 21:33:38 +00:00
Maxim Belkin
d25fc5ce50
Code refactoring
2018-02-19 09:54:36 +00:00