13848 Commits

Author SHA1 Message Date
Gautham Goli
67a1235487
Merge pull request #4207 from GauthamGoli/switch-constraints
cli_parser: Add depends_on, required_for and conflicts for switch options
2018-05-25 14:28:00 +05:30
Gautham Goli
0d53002dbc cli_parser: Add depends and conflicts for switch options 2018-05-25 04:05:45 +05:30
Mike McQuaid
0408b78a23 tests: remove linkage cache env.
Otherwise this will mess with `brew tests`.
2018-05-24 15:09:41 +01:00
Mike McQuaid
63aacd71d3 linkage_checker: fix bad instance variable usage. 2018-05-24 14:53:03 +01:00
Mike McQuaid
4c365ea353 spec_helper: don't truncate output expectations.
It's really useful to be able to see the full output particularly when
a backtrace is in it.
2018-05-24 14:53:03 +01:00
Mike McQuaid
0c216bc5b8 spec_helper: don't truncate output expectations.
It's really useful to be able to see the full output particularly when
a backtrace is in it.
2018-05-24 14:28:20 +01:00
Mike McQuaid
97645d061d
Merge pull request #3720 from AndrewMcBurney/cache-optimization
Cache optimization for `brew linkage` command.
2018-05-24 09:14:02 +01:00
commitay
dc96e6f735
Merge pull request #4170 from commitay/new-formulae-options
audit: new formulae should not have options
2018-05-24 07:16:11 +10:00
Andrew R. McBurney
a9606b4a18 Added trivial integration tests for brew linkage. 2018-05-23 13:00:05 -04:00
Mike McQuaid
24025a3ab5
Merge pull request #4202 from MikeMcQuaid/remove-some-integration-tests
Remove some integration tests
2018-05-23 15:07:46 +01:00
Mike McQuaid
f6bf989378 Remove some integration tests
We have an awful lot of integration tests and they are (comparatively)
really slow. Let's kill those that test edge case conditions and focus
on those that test that our functionality works as expected. Edge cases
can be better tested with unit tests.
2018-05-23 14:41:31 +01:00
Mike McQuaid
63ffbd3298
Merge pull request #4161 from alyssais/pull-gpg
Fix brew pull with git commit.gpgsign enabled
2018-05-23 14:21:40 +01:00
commitay
c297d39420 audit: add back new formulae condition for patches 2018-05-23 07:36:59 +10:00
Alyssa Ross
bdfbc70c87
pull: only add gpg to path if enabled in git 2018-05-22 23:35:50 +02:00
Andrew R. McBurney
218a7362dc Fixed failing tests. 2018-05-22 15:31:58 -04:00
Andrew R. McBurney
91f7a5eb76 Added unit tests for CacheStoreDatabase and LinkageCacheStore. 2018-05-22 15:01:56 -04:00
Andrew R. McBurney
ddb7f06e9f Fixed rubocop offenses from brew style. 2018-05-22 12:54:54 -04:00
Mike McQuaid
c7aa286336 audit: tweak line length/style. 2018-05-22 14:52:02 +01:00
Mike McQuaid
44f5d3ec79 Refactor cache store code. 2018-05-22 14:46:14 +01:00
Gautham Goli
38c832b029 audit: exit with code 1 if regular audit errors or new formula audit errors when comment is not created 2018-05-22 19:14:18 +05:30
Gautham Goli
b01446d059 audit: Add condition check on new_formula_audits 2018-05-22 17:55:40 +05:30
commitay
9d55fed15f audit: new formulae should not have options 2018-05-22 19:39:14 +10:00
Mike McQuaid
3794d53575
Merge pull request #3835 from GauthamGoli/bot-comment
audit:  `--new-formula`, Don't fail CI instead comment on PR about audit violations
2018-05-22 10:26:13 +01:00
Mike McQuaid
8401cffe41 audit: remove "new formula" from messaging. 2018-05-22 09:55:41 +01:00
Andrew R. McBurney
010207b982 Changed cache usage behavior.
1. Running `brew linkage some_package` does not set the cache.
2. Running `brew linkage --cached some_package` when `DatabaseCache.empty?` returns `true` should build the cache.
3. Running `brew linkage --cached some_package` when `DatabaseCache.empty?` returns `false` should use the cache.
2018-05-21 17:36:30 -04:00
Markus Reiter
42db173851 Get rid of unnecessary cds. 2018-05-21 20:44:25 +02:00
Andrew R. McBurney
360a301503 Fix file path issue caused by dbm implicitly appending .db to end of file path provided. 2018-05-21 12:27:53 -04:00
Mike McQuaid
f904017d72
Merge pull request #4187 from commitay/virtualenv
python_virtualenv_constants: update virtualenv to 16.0.0
2018-05-21 17:17:17 +01:00
Mike McQuaid
1c91c83eac Merge branch 'master' into bot-comment 2018-05-21 17:16:19 +01:00
Mike McQuaid
e2968c7889 Various cleanup and fixes.
Rename some variables and use existing regexes and a single variable.
2018-05-21 15:36:26 +01:00
Mike McQuaid
5c3ec3e7ca
Merge pull request #4174 from reitermarkus/cask-tap-migration
Add compatibility layer for handling Cask Tap migration.
2018-05-21 14:45:14 +01:00
Markus Reiter
c53a52daee Move --version logic into cmd/--version.rb. 2018-05-21 05:35:44 +02:00
commitay
16fbcd09da
Merge pull request #4188 from commitay/cask-audit-uninstall
cask audit: installer and pkg require uninstall
2018-05-21 10:25:19 +10:00
Markus Reiter
deaa8bf003 Use module Compat style. 2018-05-21 01:43:49 +02:00
Markus Reiter
c623b0295c Use ... instead of ellipsis and only output if TTY. 2018-05-21 01:43:49 +02:00
Markus Reiter
b4de801a01 Support both Homebrew and caskroom for now. 2018-05-21 01:43:49 +02:00
Markus Reiter
c4c00e4ede Use safe_system instead of Utils.popen_read. 2018-05-21 01:43:49 +02:00
Markus Reiter
b109e6da5d Handle Tap migration in Tap#initialize. 2018-05-21 01:43:49 +02:00
Markus Reiter
ff8d14fe2a Add compatibility layer to convert caskroom/* to homebrew/cask(-*). 2018-05-21 01:43:49 +02:00
commitay
1ae2cf9709 cask audit: installer and pkg require uninstall 2018-05-19 12:38:52 +10:00
Andrew R. McBurney
e93e8f3266 Lazily load db of type DBM instance variable for DatabaseCache so the corresponding database file isn't created in the .use block for a DatabaseCache. 2018-05-18 16:37:01 -04:00
Markus Reiter
5e773353fa
Merge pull request #4184 from reitermarkus/utils
Remove unused `include Utils`.
2018-05-18 19:47:07 +02:00
Markus Reiter
54270e9214
Merge pull request #4186 from reitermarkus/compat
Clean up `compat`.
2018-05-18 18:52:07 +02:00
Andrew R. McBurney
cd6f89ca76 Made DatabaseCache.new private, and changes instances in code that call it to use DatabaseCache.use instead. 2018-05-18 10:06:30 -04:00
Markus Reiter
5b7831f06f Use module Compat for everything. 2018-05-18 13:35:41 +02:00
commitay
db56b1add5 python_virtualenv_constants: update virtualenv to 16.0.0 2018-05-18 12:05:55 +10:00
commitay
f2feb326f9 cask upgrade: ensure cache exists 2018-05-18 08:18:39 +10:00
Andrew R. McBurney
ddd2ec05d8 Added static use method for DatabaseCache. 2018-05-17 16:56:59 -04:00
Andrew R. McBurney
4fb14d5c86 break if database_cache.empty? 2018-05-17 16:35:35 -04:00
Markus Reiter
a6d9d45ec3 Clean up compat. 2018-05-17 19:13:37 +02:00