Mike McQuaid
1d794cd8c2
Merge pull request #15445 from binury/master
...
Add brew deps `--missing` arg
2023-05-18 15:08:48 +01:00
Bo Anderson
a3c96126cf
service: fix API compatibility break
2023-05-18 14:57:47 +01:00
Carlo Cabrera
6ac868a035
Merge pull request #15440 from carlocab/download-artifact-refactor
...
Refactor GitHub artifact downloads out of `dev-cmd/pr-pull`
2023-05-18 21:27:36 +08:00
Mike McQuaid
857dbfb2ea
Merge pull request #15455 from MikeMcQuaid/formulary_presence
...
formulary: use a lot more `.presence`.
2023-05-18 13:28:18 +01:00
Mike McQuaid
77f94ba5bf
formulary: use a lot more .presence
.
...
Addresses regression in https://github.com/Homebrew/brew/pull/15396 .
Fixes https://github.com/Homebrew/homebrew-core/issues/131284
Fixes https://github.com/Homebrew/homebrew-core/issues/131287
Fixes https://github.com/Homebrew/homebrew-bundle/issues/1205
2023-05-18 13:14:52 +01:00
Mike McQuaid
d70ebaea3d
Merge pull request #15409 from TheMDev/master
...
Download Strategy Dependency Missing Case
2023-05-18 13:09:57 +01:00
Kevin
946478aed4
Merge pull request #15396 from apainintheneck/custom-service-name
...
Custom service name
2023-05-17 22:09:31 -07:00
apainintheneck
f2adbf6613
service: change custom name DSL
...
After some discussion, we decided to change the DSL to get rid of
the `plist_name` and `service_name` methods which aren't meaningful
for most users.
The new DSL looks like this:
```rb
service do
name macos: "name", linux: "name"
end
```
I also updated some specs here to reflect these changes.
There was some talk about maybe deprecating `plist_name` and `service_name`
but I think that's outside of the scope of this PR so I'm leaving
them as is for now. One benefit of this is that everything here is backwards
compatible.
2023-05-17 21:54:32 -07:00
Michael Wagner
78c07fd0e1
Fix Missing Download Strategy And Dependency
2023-05-17 16:30:00 -05:00
Robin Ury
dddec94fd7
Change: --skip-installed to --missing
2023-05-17 14:57:26 -05:00
Robin Ury
9b884942d7
Change: skip-installed description for clarity
2023-05-17 13:59:38 -05:00
Robin Ury
db84725c7b
Fix: strict args exception for uses
2023-05-17 13:53:19 -05:00
Robin Ury
6aa9a0e57b
Add brew deps --skip-installed
arg
2023-05-17 13:53:19 -05:00
Carlo Cabrera
4c0912d95c
utils/github/artifacts: minor improvements
2023-05-17 23:54:45 +08:00
Carlo Cabrera
d7870bb24d
Move artifact download code to separate file
...
This will help avoid mutually-recursive `require`s.
2023-05-17 23:48:58 +08:00
Markus Reiter
a97e63efbf
Fix tests on generic OS.
2023-05-17 15:26:46 +02:00
Markus Reiter
486c3765ce
Add --os=all
and --arch=all
options.
2023-05-17 15:26:46 +02:00
Carlo Cabrera
43b6d79a4c
cleanup: handle GitHub Actions artifacts
...
Implemented based on feedback from #15440 .
2023-05-17 21:11:16 +08:00
Carlo Cabrera
9260bd97e8
GitHubArtifactDownloadStrategy: fix initialize
signature
2023-05-17 21:11:16 +08:00
Carlo Cabrera
ee6ef00a73
GitHubArtifactDownloadStrategy: set cache properly
...
Co-authored-by: Bo Anderson <mail@boanderson.me>
2023-05-17 21:11:16 +08:00
Carlo Cabrera
d372eb86ca
utils/github: remove unnecessary chdir
call
...
The only existing caller already has the requested directory as the
workign directory, so this is currently not needed.
2023-05-17 21:11:15 +08:00
Carlo Cabrera
05337cbb79
Refactor GitHub artifact downloads out of dev-cmd/pr-pull
...
I plan to use these in `test-bot` to download built bottles from
previous CI runs.
2023-05-17 21:11:15 +08:00
Mike McQuaid
81c56a5e53
Merge pull request #15444 from Homebrew/sorbet-files-update
...
sorbet: Update RBI files.
2023-05-17 12:32:55 +01:00
BrewTestBot
df335e36f5
sorbet: Update RBI files.
...
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml ) workflow.
2023-05-17 00:26:39 +00:00
Sam Ford
104d30d231
Finish renaming GithubRelease to GithubReleases
2023-05-16 16:08:18 -04:00
Sean Molenaar
940b63cad3
chore: rename GitHubRelease to GitHubReleases
2023-05-16 14:19:01 -04:00
Sam Ford
bed4737826
GithubRelease: Add tests
...
This adds tests to cover all of the strategy outside of the
`#find_versions` method, which we don't currently test because it
involves a network request.
2023-05-16 14:19:00 -04:00
Sam Ford
a2fb2b00fd
GithubRelease: Simplify block handling
...
The `#versions_from_content` method requires a regex and this will be
enforced by the type signature, so we don't have to check for the
presence of a regex when handling a `strategy` block.
2023-05-16 14:18:23 -04:00
Sam Ford
263f486806
GithubRelease: Add #generate_input_values method
...
Keeping the logic for generating the API URL in a method makes it
testable, aligns with other strategies, and will help to enable some
future work.
2023-05-16 14:18:23 -04:00
Sam Ford
701f7c5051
GithubRelease: Update type signature
2023-05-16 14:18:23 -04:00
Sam Ford
8a0f63e728
GithubRelease: Omit unnecessary prefix
2023-05-16 14:18:22 -04:00
Sam Ford
a29b5c34d2
GithubRelease: Rework documentation comments
...
The initial documentation comments contained some remaining text
referring to `GithubLatest` and hadn't been updated to incorporate
the recent changes to the aforementioned strategy. This also reworks
some of the language to better explain the strategy's function,
application, etc.
2023-05-16 14:18:22 -04:00
Sam Ford
1dd7556c74
GithubLatest: Tweak documentation comments
2023-05-16 14:18:22 -04:00
Sam Ford
db7a6baa33
GithubLatest: Fix test for GithubRelease changes
...
`GithubLatest` was updated to use parts of `GithubRelease` and this
works fine within `brew livecheck` (since we `require` all the
strategies) but we need to explicitly `require` `GithubRelease` in
the `GithubLatest` test file now. Without this, we encounter errors
in parts of `GithubLatest` where `GithubRelease` is referenced.
2023-05-16 14:18:22 -04:00
Sean Molenaar
5139b9b468
feat: add github_release strategy
2023-05-16 14:18:22 -04:00
Mike McQuaid
cb143b14d0
Merge pull request #15421 from apainintheneck/add-dry-run-for-generate-api-cmds
...
dev-cmd/generate-*-api: add dry run option
2023-05-16 17:32:31 +01:00
Mike McQuaid
59c4bb45e5
Merge pull request #15437 from samford/livecheck/update-curl_headers-args
...
Strategy: Pass --max-redirs to #curl_headers
2023-05-16 17:31:57 +01:00
Markus Reiter
a7cc9a8b41
Fix BundleVersion
comparison.
2023-05-16 14:23:15 +02:00
Markus Reiter
53de9f38a2
Merge pull request #15430 from reitermarkus/cask-inspect
...
Simplify `Cask#inspect`.
2023-05-16 11:08:01 +02:00
Markus Reiter
34dd47d7d4
Merge pull request #15434 from reitermarkus/formula-loaded-from-api
...
Add `Formula#loaded_from_api?`.
2023-05-16 11:07:06 +02:00
apainintheneck
358a2ce788
dev-cmd/generate-*-api: add dry run option
...
There are two reasons for this:
- Makes it easier to run this command as a sanity check without
having to create a temporary directory
- Is somewhat faster since you don't have to write thousands of files
2023-05-15 18:29:49 -07:00
Sam Ford
bcddf99838
Strategy: Pass --max-redirs to #curl_headers
...
The default curl args in `#curl_headers` cover most of
`Livecheck::Strategy::DEFAULT_CURL_ARGS` but `--max-redirs` was
overlooked. This adds an explicit `--max-redirs` argument in
the `#page_headers` `#curl_headers` call but it's worth mentioning
that this approach wouldn't benefit from any changes in
`DEFAULT_CURL_ARGS` and would need to be manually kept in parity.
2023-05-15 13:14:13 -04:00
Markus Reiter
f60612e6b2
Add Formula#loaded_from_api?
.
2023-05-15 13:58:33 +02:00
Markus Reiter
2f9c1868aa
Don't special-case message for outdated casks that aren't installed.
2023-05-15 11:42:01 +02:00
Markus Reiter
89292f47b5
Simplify Cask#inspect
.
2023-05-15 10:17:17 +02:00
Carlo Cabrera
28c593ed6a
simulate_system: fix tap_syntax
job errors
...
Fixes
Error: Cannot simulate :ventura :intel while already simulating :macos.
See https://github.com/Homebrew/homebrew-core/actions/runs/4974116510/jobs/8900390980#step:4:24 .
2023-05-15 13:44:51 +08:00
Markus Reiter
6c80308290
Merge pull request #15419 from reitermarkus/tag-standardized-arch
...
Compare `Tag` using `standardized_arch`.
2023-05-14 21:45:24 +02:00
Markus Reiter
2ae5ae243a
Merge pull request #15414 from reitermarkus/rmdir-sudo
...
Use `sudo` for `rmdir` if necessary.
2023-05-14 21:42:00 +02:00
Markus Reiter
94d6213196
Merge pull request #15418 from reitermarkus/simplify-hash-merge
...
Simplify hash merge.
2023-05-14 21:41:39 +02:00
Markus Reiter
d2231086bd
Merge pull request #15420 from reitermarkus/simulate-system-with
...
Add `SimulateSystem::with`.
2023-05-14 21:41:20 +02:00