5108 Commits

Author SHA1 Message Date
Douglas Eichelberger
8aadd14cea Use block style instead 2023-01-23 11:56:55 -08:00
Douglas Eichelberger
49ca993074 git grep -l rubocop:todo test/ | xargs gsed -i 's|rubocop:todo|rubocop:disable|g' 2023-01-23 11:51:12 -08:00
Douglas Eichelberger
c45efc6eff rubocop --autocorrect --disable-uncorrectable 2023-01-23 11:49:04 -08:00
Douglas Eichelberger
33905405e1 rm test/.rubocop_todo.yml 2023-01-23 11:45:36 -08:00
Mike McQuaid
f22f3eaa0b
Merge pull request #14400 from dduugg/rspec-cop-fix
Resolve RSpec/VerifiedDoubles todos
2023-01-23 13:36:37 +00:00
Douglas Eichelberger
f14cd8960a Remove version_spec violation 2023-01-22 17:26:44 -08:00
Douglas Eichelberger
f365870a42 Resolve utils/analytics_spec violation 2023-01-22 17:26:44 -08:00
Douglas Eichelberger
0bfcf91a16 Resolve software_spec_spec violation 2023-01-22 17:26:44 -08:00
Douglas Eichelberger
b60eba1aa4 Resolve resource_spec violation 2023-01-22 17:26:44 -08:00
Douglas Eichelberger
a346725de2 Resolve linkage_cache_store_spec violation 2023-01-22 17:26:44 -08:00
Douglas Eichelberger
21b4251a67 Resolve language/python/virtualenv_spec violation 2023-01-22 17:26:44 -08:00
Douglas Eichelberger
06d037eadf Resolve formula_spec violation 2023-01-22 17:26:44 -08:00
Douglas Eichelberger
b2ffa09ee9 Resolve formula_pin_spec violation 2023-01-22 17:26:44 -08:00
Douglas Eichelberger
eeac95b98a Resolve exceptions_spec violation 2023-01-22 17:26:44 -08:00
Douglas Eichelberger
72069df68d Resolve description_cache_store_spec violation 2023-01-22 17:26:44 -08:00
Douglas Eichelberger
94effcc64f Resolve dependency_expansion_spec violation 2023-01-22 17:26:44 -08:00
Douglas Eichelberger
89c7117b30 Resolve dependable_spec violation 2023-01-22 17:26:44 -08:00
Douglas Eichelberger
ea832538f7 Resolve compiler_selector_spec violation 2023-01-22 17:26:44 -08:00
Douglas Eichelberger
d30ba99612 Resolve compiler_failure_spec violation 2023-01-22 17:26:44 -08:00
Douglas Eichelberger
bd62afde91 Resolve cmd/update-report_spec violation 2023-01-22 17:09:55 -08:00
Douglas Eichelberger
a83623e4cf Resolve cask/pkg_spec violation 2023-01-22 17:09:55 -08:00
Douglas Eichelberger
585098a9b9 Resolve cask/installer_spec violation 2023-01-22 17:09:55 -08:00
Douglas Eichelberger
357807fbac Resolve cask/artifact/pkg_spec violation 2023-01-22 17:09:55 -08:00
Douglas Eichelberger
d4c550bae7 Resolve cache_store_spec violation 2023-01-22 17:09:55 -08:00
Douglas Eichelberger
6c9d0d5424 remove RSpec/VerifiedDoubles todos 2023-01-22 17:02:29 -08:00
Alexander Regueiro
b2b7072fbe Permit multiple uninstall stanzas in casks (temp)
Longer-term solution is described [here](https://github.com/Homebrew/brew/issues/14365#issuecomment-1398214354).
2023-01-21 18:45:58 +00:00
Mike McQuaid
d1be288418
some needs_network specs: temporarily disable.
These are absurdly flaky right now so let's disable them.
2023-01-20 17:41:07 +00:00
Mike McQuaid
4cf365f6c9
Merge pull request #14371 from dawidd6/os-specific-service
Allow defining service run command per platform
2023-01-20 15:21:47 +00:00
Mike McQuaid
200cf75233
Merge pull request #14389 from samford/add-options-to_s-method
Options: Add #to_s method
2023-01-20 15:21:18 +00:00
Sam Ford
dac82eb2c2
Options: Add #to_s method
`Options` objects are converted to a string in some circumstances but
this produces output like `#<Options:0x0000000102592c90>`.

For example, formulae.brew.sh contains analytics entries with
incomprehensible names like `adns #<Options:0x0000000102592c90>`.
This shortcoming is apparent when compared to other entries like
`adns --HEAD`.

The `Option` class has a `#to_s` method that returns the `flag`, so
this commit simply adds an `Options#to_s` method that calls `#to_s`
on each `Option` object in `@options` and joins them using spaces.
This should produce more useful output when an `Options` object is
converted to a string (e.g., `--first --second`).
2023-01-19 12:40:50 -05:00
Sean Molenaar
59ebdab2b7
analytics: switch to InfluxDB for logging 2023-01-19 18:15:27 +01:00
Dawid Dziurla
0d0c98de29
Allow defining service run command per platform 2023-01-19 11:36:37 +01:00
Mike McQuaid
344d32bf7f
Merge pull request #14368 from Kentzo/fix-cask-backup
cask: fix writability check backing up an artifact
2023-01-19 09:58:03 +00:00
Mike McQuaid
5a4e226b2a
Merge pull request #14372 from samford/rubocops-caveats-disallow-ansi-escape-codes
rubocops/caveats: Disallow ANSI escape codes
2023-01-19 09:56:19 +00:00
Mike McQuaid
653b349c8b
Change HOMEBREW_INSTALL_FROM_API update frequency
This doesn't need to be nearly as often for HOMEBREW_INSTALL_FROM_API users because we're getting the latest information from the API when needed rather than just at `brew update` time.
2023-01-18 15:11:42 +00:00
Sam Ford
a1993b9086
rubocops/caveats: Disallow ANSI escape codes
Formula caveats text appears on formulae.brew.sh but escape
characters, as used in ANSI escape codes, should not appear in HTML.
This commit adds a RuboCop to disallow escape characters in the
caveats text.
2023-01-16 01:30:19 -05:00
Ilya Kulakov
3d16112b14 cask: fix writability check backing up an artifact 2023-01-13 15:30:14 -08:00
Mike McQuaid
aa077d5f86
Merge pull request #14316 from alebcay/reproducible-gzip
utils: add reproducible_gzip helper function
2023-01-12 09:36:06 +00:00
Douglas Eichelberger
b4ed7b9924 Add tests 2023-01-11 09:04:09 -08:00
Kevin
dbf0e28f6b
Merge pull request #14344 from apainintheneck/allow-cask-switch-for-dev-cmds-on-linux
Allow --cask for linux dev cmds
2023-01-09 21:33:04 -08:00
apainintheneck
ad57705029 All --cask for linux dev cmds
This ability was removed around a month
ago but needs to be added back in.

Developers want to be able to use the
`bump` and `audit` commands when on Linux.
This is especially useful for CI.
2023-01-08 17:34:52 -08:00
Caleb Xu
f6474c5048
utils: prepare for deprecation of Utils.gzip 2023-01-06 22:58:53 -05:00
Caleb Xu
c75adc8238
utils/gzip: introduce new module 2023-01-06 22:58:22 -05:00
Rylan Polster
08529c38a6
Expand testing of Homebrew::API 2023-01-06 02:46:21 -05:00
Rylan Polster
a81710542f
Merge pull request #14324 from Rylan12/flight-blocks-cask-api
Include `*flight` block source in cask API
2023-01-03 11:44:53 -05:00
Mike McQuaid
077e9dccaf
Merge pull request #14322 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-1.42.0
build(deps): bump rubocop from 1.41.1 to 1.42.0 in /Library/Homebrew
2023-01-03 13:34:05 +00:00
Rylan Polster
7ca5a5d9a7
Simplify require "method_source" calls 2023-01-02 17:41:36 -05:00
Kevin
2e0b18f762
Merge pull request #14315 from apainintheneck/better-error-cask-on-linux
cli/parser: Better error message for cask on linux
2023-01-02 13:21:56 -08:00
Rylan Polster
2d5d132713
Include *flight block source in cask API 2023-01-02 14:33:33 -05:00
Mike McQuaid
6a25229567
brew style --fix 2023-01-02 19:18:51 +00:00