376 Commits

Author SHA1 Message Date
Mike McQuaid
234e4aec96
Improve use of default_prefix? in tests. 2019-01-21 14:33:56 +00:00
Mike McQuaid
5c7fbaf259
Update RuboCop RSpec rules
Create a new, seperate RuboCop file that uses our RSpec rule
configuration if a specified tap has a `spec` directory.

Also, while we're here, fix up the various rules so that we don't have
any outdated TODOs, disable some rules for good and fix `brew style`
for Homebrew/bundle.
2019-01-21 13:39:11 +00:00
Mike McQuaid
170c5493a4
Update deprecations
- Add some `odeprecated`
- Make some `odeprecated` now `odisabled`
- Remove `odisabled` code.
- Remove old update migrations
- Remove GCC 4.0 compiler
- Remove Tiger-only code
- Remove 32-bit-only code
- Remove use of LD64
- Remove GCC 4.3 - 4.8 support.
2019-01-08 19:13:46 +00:00
Claudia
5be80a78f6
Use Homebrew-controlled domain for Cask dummy URLs
In a number of Cask specs, the value of the `homepage` stanza is currently set
to https://example.com. As of 2018-11-28, the TLS certificate served by
example.com seems to be expired, possibly due to an oversight on ICANN’s side.

While the certificate is certainly going to be renewed soon, it would be
desirable for Homebrew’s test result to be less dependent on ICANN’s actions.
This commit changes the homepages of all test Casks to http://brew.sh, whose
domain and TLS certificate are both controlled by Homebrew.
2018-11-28 20:51:55 +01:00
Mike McQuaid
2562d270b5
Merge pull request #5033 from amyspark/gitjiro-improved
Cask: complete Git-Jiro's HTTPS audit check
2018-11-24 11:43:09 +00:00
L. E. Segovia
5a2743b50d
Merge branch 'master' into gitjiro-improved 2018-11-24 01:01:40 +00:00
Markus Reiter
cea9942a1d Fix code style. 2018-11-13 05:04:35 +01:00
Claudia
7b320fc03b
Move shared Cask examples closer to its clients
In Cask specs, we have recently introduced a couple of specialized
`shared_examples` directories. Those new directories are organized
below their respective packages (for instance,
`cask/artifact/shared_examples` and `cask/cmd/shared_examples`).

This commit moves the rest of the shared examples accordingly.

See also:
https://github.com/Homebrew/brew/pull/5247
2018-11-06 07:19:41 +01:00
Mike McQuaid
737b84b54b
brew style --fix fixes. 2018-11-02 17:29:23 +00:00
Markus Reiter
3dbbcd11cc Remove unused test cask. 2018-11-01 19:46:58 +01:00
L. E. Segovia
70fc2af647
Cask: fix all homepages now that they are audited 2018-10-10 21:36:06 +00:00
commitay
5024efa506
Merge pull request #5059 from commitay/remove-checkpoint
remove appcast checkpoint audit
2018-10-09 15:21:24 +10:00
Markus Reiter
711bb4977f
Merge pull request #5056 from reitermarkus/accessibility_access
Remove the `accessibility_access` stanza.
2018-10-08 18:24:18 +02:00
commitay
da7d46aa14 remove appcast checkpoint audit 2018-10-08 10:54:30 +10:00
Markus Reiter
c4d418e126 Use ActiveSupport’s #second. 2018-10-07 23:10:56 +02:00
Markus Reiter
b7cf925da8 Remove unused methods in Staged module. 2018-10-07 22:00:07 +02:00
Markus Reiter
59e3a532ff Remove the accessibility_access stanza. 2018-10-07 21:53:31 +02:00
Mike McQuaid
ac2aabf287
setup_remote_tap: use system taps.
This saves recloning the taps we use multiple times when already done by
the user.
2018-10-03 19:14:04 +01:00
Markus Reiter
2308f0c571 Skip quitting applications when not logged into GUI. 2018-10-02 16:27:45 +02:00
Markus Reiter
e9b9ea49a1 Update to RuboCop 0.59.1. 2018-09-17 03:45:59 +02:00
Mike McQuaid
7615d3a812
Improve writable directory handling
Consolidate the handling of which directories need to exist and which
need to be writable. Additionally, add a fatal check for formula
installations to ensure that any directories that need to be writable
are so before attempting an installation.

Fixes #4626.
2018-09-06 18:38:43 +01:00
Markus Reiter
a84a1c63db Rename Hbc module to Cask. 2018-09-06 09:30:52 +02:00
Markus Reiter
33ce424399 Remove redundant namespacing. 2018-09-06 06:47:29 +02:00
William Woodruff
eacdca872e
Merge pull request #4819 from woodruffw/error-pipe
utils: Use JSON to marshal child errors
2018-09-04 21:02:29 -04:00
William Woodruff
367629d289
utils: Use JSON to marshal child errors
Replaces our serialization of child process
errors via Marshal with JSON, preventing
unintentional or malicious code execution outside
of the build sandbox.

Additionally, adds tests for the new behavior.
2018-09-04 11:03:32 -04:00
Mike McQuaid
e06f8a8beb
Rename Homebrew-Cask to Homebrew Cask. 2018-09-04 09:56:57 +01:00
Mike McQuaid
90b3a13909
cask: move cask/lib/hbc/* to cask/*.
Fix the load path, requires and some filenames accordingly.
2018-09-04 09:56:57 +01:00
Mike McQuaid
088730c6f1
Revert "Use JSON to marshal errors from children" 2018-09-04 08:37:08 +01:00
Markus Reiter
32ad22395b Remove some #popen_reads. 2018-09-04 05:16:59 +02:00
William Woodruff
1eec585afe
Merge pull request #4752 from woodruffw/error-pipe
Use JSON to marshal errors from children
2018-09-03 18:59:40 -04:00
William Woodruff
86b9647450
utils: Use JSON to marshal child errors
Replaces our serialization of child process
errors via Marshal with JSON, preventing
unintentional or malicious code execution outside
of the build sandbox.

Additionally, adds tests for the new behavior.
2018-09-03 18:42:59 -04:00
Markus Reiter
89dd608766 Deprecate gpg stanza. 2018-09-03 20:47:52 +02:00
L. E. Segovia
f7cafb50ad
Enable quarantining of Homebrew-Cask's downloads 2018-08-31 13:16:11 +00:00
Markus Reiter
55cde526a8 Deprecate brew cask cleanup. 2018-08-13 20:09:34 +02:00
Reto Kromer
f9fb719db7 fix cask files inside fixtures 2018-08-06 18:27:15 +02:00
Markus Reiter
8ae284e871 Use SystemCommand for curl. 2018-08-01 01:04:42 +02:00
ilovezfs
cd2b85c40f
Revert "Use SystemCommand for curl." 2018-07-29 21:45:04 -07:00
Markus Reiter
355df64d93 Use SystemCommand for curl. 2018-07-29 01:23:33 +02:00
Markus Reiter
28384ba518 Rename Hbc::SystemCommand to SystemCommand. 2018-07-22 21:11:47 +02:00
Markus Reiter
5841b992ac Refactor $LOAD_PATH. 2018-07-17 23:38:57 +02:00
Markus Reiter
e5865e7e7f Assimilate Containers with UnpackStrategy. 2018-07-16 23:50:45 +02:00
Markus Reiter
1f56314365 Clear Tap cache before each example. 2018-07-16 10:55:22 +02:00
commitay
6d1f99fa5f cask info: display auto_updates 2018-07-15 11:13:04 +10:00
Markus Reiter
b7e849799f
Merge pull request #4469 from reitermarkus/systemcommand-path
Don’t expand `executable` path in `SystemCommand`.
2018-07-14 22:45:43 +02:00
Vítor Galvão
3742cf892c
Merge pull request #4457 from commitay/latest-autoupdate
cask audit: check for `latest` with `auto_updates`
2018-07-14 14:29:19 +01:00
Markus Reiter
a9e109e31a Don’t expand executable path in SystemCommand. 2018-07-14 02:33:42 +02:00
Mike McQuaid
3e85afc8b7
Merge pull request #4382 from sjackman/keg_relocate
Relocate bottles on Linux using patchelf
2018-07-12 20:33:58 +01:00
Shaun Jackman
1b688a3a25 Relocate bottles on Linux using patchelf
Ensure patchelf is installed to pour bottles and build bottles.
2018-07-12 10:21:26 -07:00
commitay
ba929cd9e1 cask audit: check for latest with auto_updates 2018-07-12 19:22:47 +10:00
Markus Reiter
5b3bbb76c9 Separate staging from download. 2018-07-12 10:39:27 +02:00