Mike McQuaid
0d8fc920d6
tap-new: use latest Travis CI recommended config.
...
Pretty sure no-one cares about this except me but this works
consistently across a variety of different taps and is faster than the
old version.
2016-12-03 13:47:52 +00:00
Mike McQuaid
22b121c4c1
tap-new: cleanup and update Travis configuration.
...
- Use macOS Sierra 10.12 and Xcode 8.
- Add indentation.
2016-11-26 16:30:43 +00:00
Mike McQuaid
1980af52de
audit: allow deprecated options on new @ formulae.
...
As these may be migrations from another tap where we want to migrate
options across correctly.
2016-11-23 11:03:10 +00:00
Mike McQuaid
c3f959d6af
Merge pull request #1542 from woodruffw/deprecate-utils-json
...
compat: deprecate Utils::JSON in favor of corelib JSON.
2016-11-21 18:45:20 +00:00
William Woodruff
d07b9ed7f2
Replace Utils::JSON with corelib JSON calls.
2016-11-20 20:06:25 -05:00
William Woodruff
4a9601ab82
audit: check formula name against blacklisted names.
2016-11-20 00:40:54 -05:00
Mike McQuaid
5e073f1f40
Merge pull request #1528 from MikeMcQuaid/audit-devel-revision
...
audit: don't check devel version_scheme/revision.
2016-11-18 13:53:22 +00:00
Mike McQuaid
f4810e4eb1
Merge pull request #1530 from MikeMcQuaid/audit-homebrew-prefix-test-path
...
audit: check for HOMEBREW_PREFIX test path usage.
2016-11-18 12:37:46 +00:00
Mike McQuaid
e4fb108079
audit: check for HOMEBREW_PREFIX test path usage.
...
This is also not allowed.
As seen in https://github.com/Homebrew/homebrew-core/pull/6996 .
2016-11-18 09:02:39 +00:00
Mike McQuaid
d9ee2d75c5
Merge pull request #1512 from zmwangx/bump-formula-pr-user-supplied-message
...
bump-formula-pr: add --message option
2016-11-18 08:30:22 +00:00
Josh Hagins
0a7307de64
tests: ignore test files in test/vendor/bundle
2016-11-17 19:21:05 -05:00
Zhiming Wang
67999d75f5
bump-formula-pr: add --message option
...
For user-supplied PR message.
2016-11-17 15:29:33 -05:00
Mike McQuaid
b7f0edd1fd
audit: don't check devel version_scheme/revision.
...
These are formulae-wide so doesn't make sense to iterate through these
for specs and get weird results.
As seem in https://github.com/Homebrew/homebrew-core/pull/6952 .
2016-11-17 17:13:52 +00:00
Markus Reiter
7457af2b23
Move test files back directly to test/
.
2016-11-16 23:52:38 +01:00
Markus Reiter
4efdbbde06
Rename fs_leak_log
to fs_leak.log
and move to tmp
.
2016-11-16 23:52:37 +01:00
Markus Reiter
e3be9c068b
Update .rubocop_todo.yml
.
2016-11-16 23:52:37 +01:00
Markus Reiter
6b6b27126d
Reorder and rename test files.
2016-11-16 23:52:37 +01:00
Mike McQuaid
edf042ee97
Merge pull request #1522 from MikeMcQuaid/audit-one-previous-commit
...
audit: only check previous formula version.
2016-11-16 10:25:11 +00:00
Mike McQuaid
31caa8ef93
audit: only check previous formula version.
...
For calculating the stable/devel versions this should be sufficient as
it's looking at `origin/master` so for a e.g. unmerged pull request this
will stop complaining about mistakes outside the pull request itself.
This will silence all warnings for historic version mistakes (i.e.
before these audit checks were all enabled) which is normally a bad
thing but as this case would rely on modifying history to complete is a
good one.
2016-11-16 09:03:20 +00:00
Mike McQuaid
27ea94adb8
audit: check that there are any stable revisions.
...
Fixes the exception if `revision_map[formula.stable.version]` is `nil`.
2016-11-16 08:59:52 +00:00
Mike McQuaid
5e0b3d24e5
audit: fix "version should not decrease" (again).
...
- output the max version and current version to make the message more
obvious.
- Don't compare the development spec version to the formula version and
then complain the formula version is lower (it should always be!)
2016-11-15 09:02:50 +00:00
Markus Reiter
c648518f35
Rename single line block parameters to acc/elem
.
2016-11-13 23:36:04 +01:00
Mike McQuaid
c78aa43386
audit: fix "version should not decrease" check.
...
Fix the "version should not decrease" check so it correctly handles
`version_scheme`s.
Fixes #1489 .
2016-11-13 13:35:25 +00:00
Mike McQuaid
bc67414b9a
Merge pull request #1449 from ilovezfs/bottle-improve-relocatability-check
...
bottle: improve relocatability check
2016-11-06 08:15:13 -05:00
ilovezfs
c5bd5c4aa7
bottle: improve relocatability check
...
Given how common it is for formulae to hard-code `etc` and `var`, check
for those paths (`/usr/local/etc` and `/usr/local/var`) when determing
relocatability.
2016-11-06 04:00:14 -08:00
Baptiste Fontaine
bfa19b3385
audit: Escape interpolated string in regexp
...
This avoids issues with names containing special characters like e.g. [
Fixes #1431
2016-11-03 18:17:11 +01:00
Mandar Gokhale
0e15ffff62
Correct a few typos
...
...and update man pages where applicable
2016-11-03 12:09:44 +00:00
Mike McQuaid
2a865f085e
Merge pull request #1424 from MikeMcQuaid/audit-more-test-system
...
audit: check more unscoped test calls.
2016-11-02 21:50:54 -04:00
Steven Peters
72f889fef0
audit: restore check that was lost in #927
...
This audit check ensures that certain build dependencies
are explicitly marked either as `:build` or `:run`.
It seems to have been lost in #927 .
It was also adjusted in #1290 .
2016-11-02 16:52:09 -07:00
Mike McQuaid
f35a86ff70
audit: stricter test system calls check.
...
Ensure that the name is suffixed with whitespace or quotes.
2016-11-02 15:57:19 -04:00
Mike McQuaid
7aa26f7817
audit: check more unscoped test calls.
...
Also check `def test`, `shell_output`, `pipe_output` and method calls
using parentheses.
2016-11-02 13:23:38 -04:00
Mike McQuaid
b3ef8bd044
Merge pull request #1369 from MikeMcQuaid/boneyard-reason
...
boneyard-formula-pr: add reason argument.
2016-11-02 12:00:33 -04:00
Mike McQuaid
9f382bfd53
boneyard-formula-pr: add reason argument.
...
Used to provide a user-facing reason why this formula was boneyarded.
2016-10-30 15:40:11 -04:00
Baptiste Fontaine
127461d879
audit: don't check new formulae revision/versions.
2016-10-30 13:51:23 -04:00
Mike McQuaid
ef58225749
audit: check the version does not decrease.
...
This will prevent brew upgrade from working correctly.
2016-10-30 13:51:21 -04:00
Mike McQuaid
8d5df2ea87
Merge pull request #1402 from MikeMcQuaid/audit-system-test
...
audit: check test system calls are fully scoped.
2016-10-30 13:30:03 -04:00
Mike McQuaid
20c8c5958e
Merge pull request #1367 from MikeMcQuaid/audit-check-master-branch
...
audit: check for master branch tar/zipballs.
2016-10-30 13:29:47 -04:00
Mike McQuaid
a093c62b16
Revert "audit: check the version does not decrease."
2016-10-30 07:32:20 -04:00
Markus Reiter
5e44184b35
Merge pull request #1400 from reitermarkus/move-bundle-path
...
Move `test/vendor/bundle` to `vendor/bundle`.
2016-10-30 01:41:10 +02:00
Mike McQuaid
0bd0fec6a6
audit: check test system calls are fully scoped.
...
This doesn't matter for everything but it does for the binaries that
are installed. Have a limited name/alias check when not installed and
a better one that iterates bin/sbin if installed.
2016-10-29 17:53:05 -04:00
Mike McQuaid
337810bf3e
audit: check for master branch tar/zipballs.
...
These have unstable checksums and aren't the tagged, stable releases
we require.
2016-10-29 17:52:13 -04:00
Mike McQuaid
9ab38dd751
Merge pull request #1366 from MikeMcQuaid/audit-check-version-decrease
...
audit: check the version does not decrease.
2016-10-29 17:50:41 -04:00
Markus Reiter
f863d61374
Move vendor/bundle
up one level to HOMEBREW_LIBRARY_PATH
.
2016-10-29 18:28:07 +02:00
Mike McQuaid
59933f5cd9
update-test: fix --to-tag failure on new tag.
...
Without this updating to a tag will always have the same start commit
and end commit as there's been no updates to `master` since the tag was
created.
2016-10-29 09:09:00 -04:00
Mike McQuaid
84d1661b9a
Merge pull request #1365 from MikeMcQuaid/audit-stable-url-beta
...
audit: check for alpha/beta/rc usage in URLs.
2016-10-25 08:17:40 -04:00
Zhiming Wang
dd527bfcdc
bottle: fix nonexistent pyc bug
...
We were deleting pyc files *after* replace_locations_with_placeholders
and recording changed_files, meaning that some of the recorded files
were to be deleted. The correct order is the opposite.
A sample failed session: https://bot.brew.sh/job/Homebrew%20Core/10080/version=el_capitan/testReport/junit/brew-test-bot/el_capitan/bottle_buku/ .
2016-10-25 01:44:40 -04:00
Josh Hagins
9c519bbdbc
keg_relocate: refactor relocate_text_files
...
Replace relocate_text_files with three methods that clarify intent:
replace_locations_with_placeholders, replace_placeholders_with_locations
and replace_text_in_files, the first two calling the third.
2016-10-24 16:21:08 -04:00
Josh Hagins
c46155aba4
keg_relocate: cache files rewritten during brew bottle
...
`brew bottle` replaces instances of the Homebrew prefix, cellar, and
repository with placeholders in all text files. Cache these files in
INSTALL_RECEIPT.json so that we don't have to check every single text
file for placeholders on install.
2016-10-24 16:21:08 -04:00
Markus Reiter
b28b21fd7f
Don’t use bare percent literals.
2016-10-24 17:27:20 +02:00
Mike McQuaid
b39f87e710
audit: check for alpha/beta/rc usage in URLs.
...
Stable URLs should not use unstable versions.
2016-10-24 14:54:28 +01:00