2832 Commits

Author SHA1 Message Date
Mike McQuaid
a969ac9a94
Merge pull request #15092 from carlocab/dispatch-build-bottle-cleanup
dispatch-build-bottle: cleanup
2023-03-30 14:02:17 +01:00
Mike McQuaid
7e09a612c4
Merge pull request #15086 from issyl0/buildpulse-system-cmd
dev-cmd/tests: Deal with `TODO` for a BuildPulse bug that's fixed
2023-03-30 08:52:04 +01:00
Carlo Cabrera
c1b4473ed0
dispatch-build-bottle: cleanup
The `upload` input will be made into a boolean in
Homebrew/homebrew-core#127026.

`linux_wheezy` is no longer a valid input to the workflow, so let's get
rid of that.
2023-03-30 13:37:08 +08:00
Carlo Cabrera
0314d73d67
dev-cmd/pr-*: remove --commit-bottles-to-pr-branch
This will be made the default by Homebrew/homebrew-core#127021.
Additionally, branch protection rules will make it so that attempting to
push to master will fail, so we may as well not have to carry this flag
around.
2023-03-30 11:11:15 +08:00
Markus Reiter
bdd6523ce8
Deprecate appcast. 2023-03-30 03:29:06 +02:00
Issy Long
a480982e75
dev-cmd/tests: Deal with TODO for a BuildPulse bug that's fixed
- This does what the comment told us to do, use the bang variant of
  `system_command` to not swallow the errors.
2023-03-29 20:54:42 +01:00
Mike McQuaid
f4ee196f90
Merge pull request #15082 from scientificworld/master
bump-*-pr: fix an issue when using on taps with custom remote
2023-03-29 16:13:39 +01:00
scientificworld
8589ca8d40
bump-*-pr: fix an issue when using on taps with custom remote 2023-03-29 20:05:16 +08:00
Carlo Cabrera
08fb8e441f
dev-cmd/pr-pull: add debug output for merge base 2023-03-29 17:56:05 +08:00
Carlo Cabrera
1ed8b3db2f
dev-cmd/pr-pull: handle non-cherry-picked commits in #autosquash! 2023-03-29 17:13:07 +08:00
Carlo Cabrera
df7331f638
Remove reference to nonexistent --clean flag 2023-03-29 00:17:49 +08:00
Carlo Cabrera
b26d92ca9a
🐛 fixes 2023-03-28 23:07:03 +08:00
Carlo Cabrera
e462b59f7c
pr-automerge: pass --commit-bottles-to-pr-branch by default 2023-03-28 22:20:09 +08:00
Carlo Cabrera
46ac052b3b
dev-cmd/pr-automerge: skip PRs labelled CI-published-bottle-commits
This is based on feedback from @plinnane on Slack.
2023-03-28 22:20:09 +08:00
Carlo Cabrera
f0272b0944
dev-cmd/pr-pu{ll,blish}: handle PRs with an autosquash label
- request `autosquash` from the publish job in `pr-publish` if the PR is
  labelled with `autosquash`
- show a warning in `pr-pull` if called without `--autosquash` on a PR
  with the autosquash label.
2023-03-28 22:20:05 +08:00
Carlo Cabrera
76833dfe40
dev-cmd/pr-publish: support new workflow inputs
This allows us to use the new options without needing to use the GitHub
UI.
2023-03-28 22:14:39 +08:00
Carlo Cabrera
834e4c98fc
dev-cmd/pr-*: replace --no-autosquash with --autosquash
We will now no longer be squashing commits by default, so it makes sense
to default to doing nothing but still autosquash commits when requested
with `--autosquash`.
2023-03-28 21:51:01 +08:00
Mike McQuaid
d69c3ef3df
Vendor more gems
Let's resolve the intermittent issues we've seen when various installed
on demand gems cannot be installed by including them all in the
Gemfile.
2023-03-28 09:12:48 +01:00
Markus Reiter
5e52d415a9
Allow fetching for different arch. 2023-03-25 11:56:09 +01:00
Mike McQuaid
fad8deda56
Merge pull request #15046 from issyl0/rubocop-method-parameter-pr
rubocop: Remove the final `Naming/MethodParameterName` exceptions: `pr`
2023-03-24 08:51:49 +00:00
Issy Long
61dc026fcc
rubocop: Remove the final Naming/MethodParameterName exceptions: pr
- Core RuboCop didn't want this shortening upstreamed, but that's OK!
2023-03-24 00:29:42 +00:00
apainintheneck
6ccf21c2c9 Merge branch 'master' into add-service-block-to-formula-api 2023-03-22 20:06:32 -07:00
apainintheneck
38146893c3 api_hashable: Make API path subs generic
This turns the ability to replace common paths with placeholders
into a mixin that can be used with both Casks and Formulae.

The idea here is to make formula hash generation more consistent.
2023-03-21 23:20:42 -07:00
Dustin Rodrigues
b776fb32de
change includecount to include_count for readability 2023-03-20 07:23:17 -04:00
Dustin Rodrigues
e5fba88035
use includecount argument in pluralize 2023-03-19 23:35:47 -04:00
Mike McQuaid
94eafdb3fe
Merge pull request #15015 from dtrodrigues/contributions-plural
dev-cmd/contributions: appropriately pluralize contribution statement
2023-03-19 18:52:44 -04:00
Dustin Rodrigues
afae58b430
dev-cmd/contributions: fix typecheck errors 2023-03-19 17:34:35 -04:00
Dustin Rodrigues
834740f04c
dev-cmd/contributions: refactor to shorten line length 2023-03-19 17:12:11 -04:00
Dustin Rodrigues
a562d6deee
dev-cmd/contributions: appropriately pluralize contribution statement 2023-03-19 16:55:33 -04:00
Carlo Cabrera
e5b9e97b92
Use git merge-base to determine original_commit 2023-03-20 00:55:20 +08:00
Carlo Cabrera
c669f1d625
pr-pull: add --no-cherry-pick flag
Needed for Homebrew/homebrew-core#125556. Without this, `pr-pull`
attempts to cherry-pick commits from the PR branch onto the PR branch,
and then gets upset that nothing happened.

See https://github.com/Homebrew/homebrew-core/actions/runs/4461335852/jobs/7835095294#step:10:40
2023-03-19 23:44:44 +08:00
Mike McQuaid
ff33d34ae1
Merge pull request #14975 from issyl0/count-issues-handle-hidden-stats
dev-cmd/contributions: Don't fall over if a user's profile is private
2023-03-15 17:52:04 -04:00
Issy Long
a9e31274fc
dev-cmd/contributions: Output why we default to 0 reviews on a validation error 2023-03-15 21:31:41 +00:00
Mike McQuaid
6fd54eba5f
Merge pull request #14985 from dduugg/no-compat
Remove compatibility layer
2023-03-15 13:48:00 -04:00
Mike McQuaid
83aea49d8a
Merge pull request #14981 from dduugg/tab-no-ostruct
Remove OpenStruct use in Tab
2023-03-15 12:16:49 -04:00
Issy Long
b6198cdd07
dev-cmd/contributions: Avoid the /users/#{user}/events API call
- This is wasteful when we can just catch the `ValidationFailedError`
  from the GitHub API from the search query.
2023-03-15 13:00:49 +00:00
Issy Long
0a804e1b38
dev-cmd/contributions: Use the correct variable name 🙄 2023-03-15 12:50:14 +00:00
Issy Long
03bd62ca0d
dev-cmd/contributions: Don't fall over if a user's profile is private
- It's possible to hide your contribution graph and not be searchable on
  GitHub. Let's make sure `brew contributions` doesn't fall over if the
  user's profile is private (determined by the `/events` user endpoint
  returning []).
2023-03-15 12:48:59 +00:00
Bevan Kay
69d03bf6ed
bump-formula-pr: wrap release notes in <pre> tags 2023-03-15 23:03:27 +11:00
Douglas Eichelberger
4d32699f61 Placate rubocop 2023-03-14 23:01:09 -07:00
Douglas Eichelberger
cc5b013cb9 Remove compatibility layer 2023-03-14 14:49:34 -07:00
Douglas Eichelberger
f4c9a96c70 Enable types in dev-cmd 2023-03-14 08:32:03 -07:00
Mike McQuaid
b4aac9d4a0
Merge pull request #14950 from issyl0/sorbet-autogenerate-envconfig-rbi
sorbet: Autogenerate the RBI file for `Homebrew::EnvConfig`
2023-03-13 10:22:16 +00:00
Douglas Eichelberger
1943132cf6 Move i18n out of global 2023-03-11 17:27:53 -08:00
Issy Long
8e13a6e1f4
Merge pull request #14944 from issyl0/more-rubocop-naming-method-parameter-name
rubocop: Further trim `Naming/MethodParameterName` allowlist
2023-03-11 22:59:39 +00:00
Issy Long
8862c33b62
sorbet: Autogenerate the RBI file for Homebrew::EnvConfig
- I'm not as happy with this as I was with my work on `utils/tty.rb`,
  it feels a lot hackier and prone to breaking - especially the
  `T.nilable` "detection".
- However, it generates an RBI file that passes `brew typecheck`, so we
  can clean up some `hidden-definitions` entries, getting further
  towards fully typed.
2023-03-11 02:13:30 +00:00
Issy Long
e9d994622e
rubocop: Drop "f" from Naming/MethodParameterName allowlist
- This either stands for "file" but more often than not "formula".
2023-03-11 00:17:27 +00:00
Douglas Eichelberger
0b04b99e68 brew typecheck --suggest-typed --update 2023-03-09 20:32:46 -08:00
Mike McQuaid
4db1cbbfe0
Merge pull request #14930 from g0t4/cat_mention_brew_info_github
include `--cask` or `--formula` in `brew info --github` suggestion
2023-03-09 09:00:22 +00:00
Wes Higbee
0b7d22a201
inlucde treat as --cask(s)/--formula(e) args in suggestion 2023-03-08 18:53:20 -06:00