Dustin Rodrigues
b776fb32de
change includecount to include_count for readability
2023-03-20 07:23:17 -04:00
Dustin Rodrigues
e5fba88035
use includecount argument in pluralize
2023-03-19 23:35:47 -04:00
Mike McQuaid
94eafdb3fe
Merge pull request #15015 from dtrodrigues/contributions-plural
...
dev-cmd/contributions: appropriately pluralize contribution statement
2023-03-19 18:52:44 -04:00
Dustin Rodrigues
afae58b430
dev-cmd/contributions: fix typecheck errors
2023-03-19 17:34:35 -04:00
Dustin Rodrigues
834740f04c
dev-cmd/contributions: refactor to shorten line length
2023-03-19 17:12:11 -04:00
Dustin Rodrigues
a562d6deee
dev-cmd/contributions: appropriately pluralize contribution statement
2023-03-19 16:55:33 -04:00
Carlo Cabrera
e5b9e97b92
Use git merge-base
to determine original_commit
2023-03-20 00:55:20 +08:00
Carlo Cabrera
c669f1d625
pr-pull: add --no-cherry-pick
flag
...
Needed for Homebrew/homebrew-core#125556 . Without this, `pr-pull`
attempts to cherry-pick commits from the PR branch onto the PR branch,
and then gets upset that nothing happened.
See https://github.com/Homebrew/homebrew-core/actions/runs/4461335852/jobs/7835095294#step:10:40
2023-03-19 23:44:44 +08:00
Mike McQuaid
ff33d34ae1
Merge pull request #14975 from issyl0/count-issues-handle-hidden-stats
...
dev-cmd/contributions: Don't fall over if a user's profile is private
2023-03-15 17:52:04 -04:00
Issy Long
a9e31274fc
dev-cmd/contributions: Output why we default to 0 reviews on a validation error
2023-03-15 21:31:41 +00:00
Mike McQuaid
6fd54eba5f
Merge pull request #14985 from dduugg/no-compat
...
Remove compatibility layer
2023-03-15 13:48:00 -04:00
Mike McQuaid
83aea49d8a
Merge pull request #14981 from dduugg/tab-no-ostruct
...
Remove OpenStruct use in Tab
2023-03-15 12:16:49 -04:00
Issy Long
b6198cdd07
dev-cmd/contributions: Avoid the /users/#{user}/events
API call
...
- This is wasteful when we can just catch the `ValidationFailedError`
from the GitHub API from the search query.
2023-03-15 13:00:49 +00:00
Issy Long
0a804e1b38
dev-cmd/contributions: Use the correct variable name 🙄
2023-03-15 12:50:14 +00:00
Issy Long
03bd62ca0d
dev-cmd/contributions: Don't fall over if a user's profile is private
...
- It's possible to hide your contribution graph and not be searchable on
GitHub. Let's make sure `brew contributions` doesn't fall over if the
user's profile is private (determined by the `/events` user endpoint
returning []).
2023-03-15 12:48:59 +00:00
Bevan Kay
69d03bf6ed
bump-formula-pr: wrap release notes in <pre> tags
2023-03-15 23:03:27 +11:00
Douglas Eichelberger
4d32699f61
Placate rubocop
2023-03-14 23:01:09 -07:00
Douglas Eichelberger
cc5b013cb9
Remove compatibility layer
2023-03-14 14:49:34 -07:00
Douglas Eichelberger
f4c9a96c70
Enable types in dev-cmd
2023-03-14 08:32:03 -07:00
Mike McQuaid
b4aac9d4a0
Merge pull request #14950 from issyl0/sorbet-autogenerate-envconfig-rbi
...
sorbet: Autogenerate the RBI file for `Homebrew::EnvConfig`
2023-03-13 10:22:16 +00:00
Douglas Eichelberger
1943132cf6
Move i18n out of global
2023-03-11 17:27:53 -08:00
Issy Long
8e13a6e1f4
Merge pull request #14944 from issyl0/more-rubocop-naming-method-parameter-name
...
rubocop: Further trim `Naming/MethodParameterName` allowlist
2023-03-11 22:59:39 +00:00
Issy Long
8862c33b62
sorbet: Autogenerate the RBI file for Homebrew::EnvConfig
...
- I'm not as happy with this as I was with my work on `utils/tty.rb`,
it feels a lot hackier and prone to breaking - especially the
`T.nilable` "detection".
- However, it generates an RBI file that passes `brew typecheck`, so we
can clean up some `hidden-definitions` entries, getting further
towards fully typed.
2023-03-11 02:13:30 +00:00
Issy Long
e9d994622e
rubocop: Drop "f" from Naming/MethodParameterName
allowlist
...
- This either stands for "file" but more often than not "formula".
2023-03-11 00:17:27 +00:00
Douglas Eichelberger
0b04b99e68
brew typecheck --suggest-typed --update
2023-03-09 20:32:46 -08:00
Mike McQuaid
4db1cbbfe0
Merge pull request #14930 from g0t4/cat_mention_brew_info_github
...
include `--cask` or `--formula` in `brew info --github` suggestion
2023-03-09 09:00:22 +00:00
Wes Higbee
0b7d22a201
inlucde treat as --cask(s)/--formula(e) args in suggestion
2023-03-08 18:53:20 -06:00
Mike McQuaid
8d71aa02dd
Merge pull request #14918 from SMillerDev/master
...
bump-formula-pr: add release notes if found
2023-03-08 14:02:36 +00:00
Sean Molenaar
2f32da0455
fix syntax
2023-03-08 14:28:34 +01:00
Sean Molenaar
9bd567aab9
Update Library/Homebrew/dev-cmd/bump-formula-pr.rb
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2023-03-08 14:04:28 +01:00
Sean Molenaar
048ed5d683
Update Library/Homebrew/dev-cmd/bump-formula-pr.rb
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2023-03-08 13:59:14 +01:00
Sean Molenaar
8532bb23cc
Update Library/Homebrew/dev-cmd/bump-formula-pr.rb
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2023-03-08 13:58:45 +01:00
Mike McQuaid
e5c0fb4ca6
Merge pull request #14892 from apainintheneck/irb-improvements
...
`brew irb` improvements
2023-03-08 12:46:56 +00:00
apainintheneck
deabd4a5f9
Change history and config file dirs
...
Now both REPL history is written to $HOME.
- Pry: $HOME/.brew_pry_history
- IRB: $HOME/.brew_irb_history
The IRB config file has also been moved to the
library directory.
2023-03-07 19:15:05 -08:00
Nanda H Krishna
3113b44d1f
brew unbottled
: fix XcodeRequirement
handling on Linux
2023-03-07 14:12:40 -05:00
Sean Molenaar
139f90df97
bump-formula-pr: add release notes if found
2023-03-07 19:44:35 +01:00
Mike McQuaid
2fe078d448
Merge pull request #14902 from g0t4/cat_mention_brew_info_github
...
when `brew cat` fails, suggest `brew info --github`
2023-03-07 09:29:06 +00:00
Mike McQuaid
a6b70eee69
Merge pull request #14896 from issyl0/sorbet-autogenerate-tty-rbi
...
sorbet: Autogenerate the RBI file for `utils/tty.rb`
2023-03-07 09:23:02 +00:00
apainintheneck
9f7ab25af5
irb: improve pry config
...
The idea here is that the pry session history
should be separate for homebrew than the global
pry history.
We also ignore any .pryrc files so that they
don't interfere with this config.
2023-03-06 22:37:09 -08:00
apainintheneck
6ab6d7c8ee
irb: save repl history
...
This enables history for `brew irb` sessions.
It saves that history to the repository directory.
2023-03-06 22:24:14 -08:00
Douglas Eichelberger
d56e2884aa
Enable typing in cmd/
2023-03-06 15:01:08 -08:00
Issy Long
48802daf01
sorbet: Regenerate homegrown RBI files with brew typecheck --update
...
- I needed to add some more `require`s to the `tty.rb` generator script
since it failed to recognise `env_config` and Sorbet's `T` setup if I
ran it not via `brew ruby`, and I couldn't get `brew ruby` to work
within `safe_system` in the `typecheck` dev-cmd.
2023-03-06 21:46:05 +00:00
Wes Higbee
66c268b190
rearrange output to easily copy command suggestion
2023-03-06 13:43:28 -06:00
Wes Higbee
12d93c480f
include formula/cask args in brew info --github suggestion
2023-03-06 13:34:05 -06:00
Wes Higbee
1e95de4757
split up suggestions
2023-03-06 07:51:36 -06:00
Wes Higbee
ba7ffb2db8
mention alternative in brew cat failure message
2023-03-06 07:44:27 -06:00
Mike McQuaid
b08029edc9
Merge pull request #14885 from apainintheneck/irb-add-cask-monkey-patch
...
irb: add cask monkey patch
2023-03-06 12:28:12 +00:00
apainintheneck
11a0ea1833
irb: enable global options
...
The --debug and --quiet options weren't working before
with the REPL because IRB didn't recognize them.
2023-03-05 10:22:34 -08:00
Issy Long
edeefebf61
utils/github: Fix double counting of author/committer numbers
...
- The usage of this in `brew contributions` wasn't correct for a user
with 5 authored commits to homebrew/cask that had been committed by
other people, the numbers would turn out as 5 authored, 5 committed.
- I decided to do this properly by getting the SHAs for author and
committer and determine the differences between the two arrays.
This also accounts for when authored commits are 0, or committed
commits, or both.
- Add tests, because I don't want to fix this a third time!
2023-03-05 14:41:04 +00:00
apainintheneck
73f0fc3f1a
brew/irb: add cask monkey patch
...
This makes it easier to load casks in repl sessions
and matches what we already do with formulae.
2023-03-04 12:25:08 -08:00