13146 Commits

Author SHA1 Message Date
Esther W
6325fb88c5 Make behavior clearer by returning false 2017-05-18 15:43:54 -07:00
Esther W
4da2f24b0e Remove to_s method 2017-05-18 13:41:36 -07:00
Esther W
37222c1953 Fix implicit conversion of nil into string error 2017-05-18 13:08:19 -07:00
Markus Reiter
0977b4a17d Merge pull request #2494 from numbermaniac/fix-env
cask manpage: Fix section header link for Environment
2017-05-18 18:40:08 +02:00
Numbermaniac
e02d5f7524 commit new manpages 2017-05-18 18:31:37 +10:00
Markus Reiter
f0dc1d96c5 Merge pull request #2537 from reitermarkus/pathname-to_str
Remove `to_s` from some `Pathname`s.
2017-05-18 09:39:07 +02:00
Mike McQuaid
2b726383f1 info: fix conflicts formatting. 2017-05-16 10:05:05 +01:00
Mike McQuaid
aeaf9af711 Merge pull request #2470 from johnhawkinson/conflicts-info
Display formula conflict reasons
2017-05-16 08:45:45 +01:00
Mike McQuaid
8e2198ff01 info: tweak conflicts output code. 2017-05-15 10:40:07 +01:00
Mike McQuaid
ea8be174f6 Merge pull request #2631 from GauthamGoli/audit_homepage_rubocop
audit: Port audit_homepage method to rubocop and add tests
1.2.1
2017-05-15 10:02:47 +01:00
Mike McQuaid
9889b42ec4 Merge pull request #2628 from GauthamGoli/formula_desc_cop_fix
audit: Detect multiline and interpolated strings in formula desc cop
2017-05-15 10:01:38 +01:00
Mike McQuaid
1e6cf8f270 Merge pull request #2635 from MikeMcQuaid/no-set-blank-vars
bin/brew: don't set blank HOMEBREW_* variables.
2017-05-14 20:38:48 +01:00
John Hawkinson
33d4c95a28 info: use more string interpolation 2017-05-14 15:09:01 -04:00
Mike McQuaid
9c85d737ad bin/brew: don't set blank HOMEBREW_* variables.
When creating the necessary HOMEBREW_* variables ensure that they aren't
set if their value would be empty.
2017-05-14 20:05:26 +01:00
Gautham Goli
91efcb045e Port audit_homepage method to rubocop and add tests 2017-05-14 22:05:46 +05:30
Mike McQuaid
e0ab162f82 Merge pull request #2632 from MikeMcQuaid/sass
docs.brew.sh: use SCSS.
2017-05-14 15:27:06 +01:00
Mike McQuaid
75d230318a Merge pull request #2627 from MikeMcQuaid/audit-fix-option-detection
audit: fix dependency option detection.
2017-05-14 15:09:07 +01:00
Mike McQuaid
80df74893a Merge pull request #2621 from MikeMcQuaid/rubocop-module-length
rubocop: don't always care about module length.
2017-05-14 15:08:58 +01:00
Mike McQuaid
13efa8656e Merge pull request #2620 from MikeMcQuaid/more-env-filtering-tweaks
More environment filtering tweaks
2017-05-14 15:08:47 +01:00
Mike McQuaid
d0e3f3574f Merge pull request #2619 from MikeMcQuaid/more-audit-versioned-aliases
audit: more checks for versioned aliases.
2017-05-14 15:08:27 +01:00
Mike McQuaid
e8ef21252d Merge pull request #2617 from MikeMcQuaid/interactive-home-access
Allow --interactive to access HOME
2017-05-14 15:08:16 +01:00
Mike McQuaid
25e9e658af Merge pull request #2616 from MikeMcQuaid/devel-opt-aliases
keg: skip opt versioned aliases for devel/head.
2017-05-14 15:08:06 +01:00
Mike McQuaid
48d99d1338 docs.brew.sh: use SCSS.
Import style changes from:
https://github.com/Homebrew/homebrew.github.io/pull/166
2017-05-14 15:07:00 +01:00
Mike McQuaid
9f1af01b2f Merge pull request #2630 from iMichka/patch-1
Update to venv.pip_install_and_link in doc
2017-05-14 14:56:12 +01:00
Mike McQuaid
8e4e9d877c Merge pull request #2610 from GauthamGoli/audit_components_autocorrect
Add autocorrect method for ComponentsOrder rubocop and tests
2017-05-14 14:54:14 +01:00
Michka Popoff
43e38dfc01 Update to venv.pip_install_and_link in doc
`venv.link_scripts(bin) { venv.pip_install buildpath }` is now `venv.pip_install_and_link buildpath`
2017-05-13 23:26:09 +02:00
Gautham Goli
80572939b4 Update string_content method to support multiline strings, add test for same 2017-05-13 18:48:40 +05:30
Mike McQuaid
d5006ef012 audit: fix dependency option detection.
Instead of trying to do this all with a single regex give up and do a
two stage process. Eventually I'll end up implementing a full ruby
parser here 🧌.
2017-05-13 13:00:00 +01:00
Mike McQuaid
8205e61e64 More environment filtering tweaks
- only document HOMEBREW_* variables in the manpage (although still
  read from all the original environment variables).
- resort manpage environment variables in alphabetical order
- check the original path for trailing slashes
2017-05-13 11:42:01 +01:00
Gautham Goli
d04f295de3 Add autocorrect method for ComponentsOrder rubocop and tests 2017-05-13 03:09:55 +05:30
Mike McQuaid
459fef3b09 Merge pull request #2615 from mansimarkaur/stat.mode_change_assertion
diagnostic_spec.rb: assertion in check_access_lock_dir test
2017-05-10 18:51:31 -05:00
Mike McQuaid
fa1e23823c Merge pull request #2618 from MikeMcQuaid/issue-troubleshooting-tweaks
Tweak troubleshooting docs and issue template
2017-05-10 11:36:55 -05:00
mansimarkaur
45754a1888 diagnostic_spec.rb: check_access_lock_dir test
Added assertion to check `HOMEBREW_LOCK_DIR.stat.mode` changes after `HOMEBREW_LOCK_DIR.chmod 0555`
2017-05-10 03:02:55 +05:30
Mike McQuaid
7055abc436 Allow --interactive to access HOME
This may result in a slightly varied build but it’s generally just far
less annoying to be able to access all your e.g. shell configuration.
2017-05-09 20:00:11 +01:00
Mike McQuaid
978c121276 Tweak troubleshooting docs and issue template
- Note that Homebrew Cask issues should be filed elsewhere.
- Make `brew`/homebrew-core issue differential in simpler language
- Tell people to fix all `brew doctor` issues
- Refer to the issue checklist and make it even more clear and prominent
  that we may close it out immediately if they don't use it.
- Note that proposed new issues should be widely relevant.
- Don't tell people they need to `brew cask install java`; we handle
  this in most places with a Java requirement and probably want issues
  filed where we don't.
- Remove reference to Homebrew Dupes and replace with reference to
  Homebrew Cask to try and get people filing stuff there instead.

Fixes #2608
2017-05-09 15:21:28 +01:00
Mike McQuaid
76f48d338e keg: skip opt versioned aliases for devel/head.
These versioned aliases don’t correspond to the correct version if not
Installed from stable.

Fixes #2596.
2017-05-09 15:10:57 +01:00
Mike McQuaid
b14f1572b7 audit: more checks for versioned aliases.
Check that a required versioned alias has a valid name (rather than
assuming it’s fine based on it’s existence alone) and check for
the presence of invalid version aliases.

This should handle the case where someone bumps a formula but forgets
to rename the alias that’s mentioned in #2596.
2017-05-09 15:10:29 +01:00
Mike McQuaid
0fb1fb51be rubocop: don't always care about module length.
We don't care about this in external taps as this is more about code
architecture than code style.
2017-05-09 12:58:49 +01:00
Markus Reiter
5828eefd01 Remove to_s from some Pathnames. 2017-05-08 13:37:28 +02:00
Mike McQuaid
f1d4c4be78 Merge pull request #2607 from MikeMcQuaid/travis-ci-tweaks-2
Travis CI tweaks.
2017-05-08 09:51:06 +01:00
Mike McQuaid
9853a78397 Travis CI tweaks.
Attempt to improve Travis CI. This time without any vendoring gems
nonsense.
2017-05-08 08:38:25 +01:00
Mike McQuaid
e4ecf6d6bc Merge pull request #2591 from retokromer/patch-1
fix date-based versioning
2017-05-07 21:13:52 +01:00
Mike McQuaid
0d5956948e Merge pull request #2606 from MikeMcQuaid/revert-vendor-gems
Revert gem vendoring experiment.
2017-05-07 17:31:09 +01:00
Mike McQuaid
57db2e539e Revert "Merge pull request #2597 from MikeMcQuaid/vendor-gems"
This reverts commit 3e4547f52e7ebec633f8bfefc8a396d944edf908, reversing
changes made to 6edf9382bcc1240ad6f97c8b752cfe56cef9965d.
2017-05-07 17:28:39 +01:00
Mike McQuaid
e1bbab6ca6 Revert "Merge pull request #2603 from MikeMcQuaid/tweak-gem-vendoring"
This reverts commit 2372872974d1049c2beafe7dedb7f8f882502058, reversing
changes made to 3e4547f52e7ebec633f8bfefc8a396d944edf908.
2017-05-07 17:28:37 +01:00
Mike McQuaid
a76392dd5f Revert "Merge pull request #2602 from MikeMcQuaid/travis-ci-tweaks"
This reverts commit 8d948e4b0b55912c592d34cb5ea83c649b1f9d5e, reversing
changes made to 2372872974d1049c2beafe7dedb7f8f882502058.
2017-05-07 17:28:34 +01:00
Mike McQuaid
8d948e4b0b Merge pull request #2602 from MikeMcQuaid/travis-ci-tweaks
Travis CI tweaks
2017-05-07 16:15:18 +01:00
Mike McQuaid
5cdb0d0a6d Travis CI tweaks
Tweak our Travis CI configuration and the one we suggest for taps to
be faster and use caching.
2017-05-07 16:00:04 +01:00
Mike McQuaid
2372872974 Merge pull request #2603 from MikeMcQuaid/tweak-gem-vendoring
Tweak Gem vendoring.
2017-05-07 15:38:25 +01:00
Mike McQuaid
33f83be10e Tweak Gem vendoring.
If people have `HOMEBREW_RUBY_PATH` set then things explode in a rather
confusing fashion. Instead, run `bundle` for them with the arguments
that they'd want.

Also, move `macho` requires into the module itself; it's a pain having
to do everything for Bundler before requiring `pathname` which is a core
Ruby class.
2017-05-07 15:33:54 +01:00