admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
36,540 Commits 15 Branches 471 Tags
Commit Graph

36540 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Mike McQuaid
eeadcc8ded
Merge pull request #14632 from bevanjkay/cask-sample-languages-audit 
cask/auditor: only audit 10 languages by default on casks with many languages
 2023-02-28 12:16:51 +00:00
Rylan Polster
f6af334397
Merge pull request #14825 from MikeMcQuaid/more_sharding_fixes 
More Formula/Casks sharding fixes
 2023-02-28 07:08:29 -05:00
Bevan Kay
0589ac427d
Update Library/Homebrew/cask/auditor.rb 
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
 2023-02-28 23:00:43 +11:00
Mike McQuaid
4cbc4f64d1
Merge pull request #14834 from reitermarkus/livecheck-skip-latest 
Allow `version :latest` if `livecheck` is `skip`.
 2023-02-28 11:59:29 +00:00
Mike McQuaid
eea6e1777e
Merge pull request #14837 from Homebrew/sponsors-maintainers-man-completions 
Update maintainers.
 2023-02-28 11:54:27 +00:00
Mike McQuaid
0406279ad3
More Formula/Casks sharding fixes 
- Stop `brew style` from complaining
- Fix message reference in `brew edit`
 2023-02-28 11:52:38 +00:00
Mike McQuaid
d0e03fc425
Merge pull request #14820 from apainintheneck/delay-loading-from-cask-source-api 
Delay loading from cask source api
 2023-02-28 11:50:10 +00:00
Mike McQuaid
b339caf744
Merge pull request #14831 from Homebrew/sorbet-files-update 
sorbet: Update RBI files.
 2023-02-28 11:41:53 +00:00
Mike McQuaid
4986a1aa26
Merge pull request #14830 from samford/livecheck/rework-json-match 
Strategy#from_url: Amend conditions for Json
 2023-02-28 11:41:41 +00:00
Issy Long
0f2270e9ef
Merge pull request #14819 from issyl0/signoffs-were-just-a-stepping-stone-to-reviews 
dev-cmd/contributions: Stop counting signoffs now we have "real" reviews
 2023-02-28 11:37:14 +00:00
Mike McQuaid
0a0479ab0e
Remove Markus from former maintainers. 2023-02-28 11:35:32 +00:00
BrewTestBot
a862c598be
Update maintainers. 
Autogenerated by the [sponsors-maintainers-man-completions](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/sponsors-maintainers-man-completions.yml) workflow.
 2023-02-28 11:21:32 +00:00
Mike McQuaid
5ca4ab0260
Merge pull request #14778 from dduugg/inflection-util 
Replace ActiveSupport inflections with Utils methods
 2023-02-28 11:20:46 +00:00
Issy Long
6b76e5e66f
dev-cmd/contributions: Stop counting signoffs now we have "real" reviews 
- Signoffs were just a stopgap until we implemented getting "real"
  reviews for a user via the GitHub API. They were a suboptimal way of getting
  reviews because they only really exist in Homebrew/homebrew-core where
  BrewTestBot adds signoffs for each maintainer who reviewed the PR.
 2023-02-28 11:12:51 +00:00
Markus Reiter
a2a68292ae
Allow version :latest if livecheck is skip. 2023-02-28 10:35:07 +01:00
Bevan Kay
48a7282458
fix style 2023-02-28 19:02:08 +11:00
Bevan Kay
295a3539a5
Update with-many-languages.rb 2023-02-28 18:55:12 +11:00
Bevan Kay
d1b09a90da
cask/auditor: only audit 10 languages by default on casks with many languages 2023-02-28 18:54:27 +11:00
apainintheneck
b91e93cda0 Load cask source with tap info 
This info is used in the installer to
decide whether to report analytics.
 2023-02-27 23:51:43 -08:00
Douglas Eichelberger
2073e70696 brew style --fix 2023-02-27 21:43:10 -08:00
Douglas Eichelberger
f9f73f3ef6 Tidy up 2023-02-27 21:42:47 -08:00
Douglas Eichelberger
1ab278f74c Fix style/type violations 2023-02-27 20:34:07 -08:00
Douglas Eichelberger
82dad857a8 Restore global 2023-02-27 20:31:01 -08:00
Douglas Eichelberger
6ea501b59f Add tests 2023-02-27 20:30:55 -08:00
Douglas Eichelberger
325994a60c Move inflection utils to Utils module 2023-02-27 20:20:56 -08:00
Douglas Eichelberger
0eccc0e987 git grep -l Utils::Inflection | xargs gsed -i 's|Utils::Inflection|Utils|g' 2023-02-27 20:18:27 -08:00
Douglas Eichelberger
86c500fdcc Try removing inflections require 2023-02-27 20:18:10 -08:00
Douglas Eichelberger
8d788ec98c Try removing String monkey-patched types 2023-02-27 20:18:10 -08:00
Douglas Eichelberger
cfdb0c2e4b Fix type error 2023-02-27 20:18:10 -08:00
Douglas Eichelberger
7f3593e12d inline titleize 2023-02-27 20:18:10 -08:00
Douglas Eichelberger
2c5067ec77 Port dynamic invocation 2023-02-27 20:18:10 -08:00
Douglas Eichelberger
3da68651e5 Port more call sites 2023-02-27 20:18:08 -08:00
Douglas Eichelberger
eb2b990575 Port more call sites 2023-02-27 20:17:33 -08:00
Douglas Eichelberger
2c73d4d9b7 Replace deconstantize inflection with util 2023-02-27 20:17:33 -08:00
Douglas Eichelberger
2400c6daed brew style --fix 2023-02-27 20:17:33 -08:00
Douglas Eichelberger
d62211d3af Replace demodulize inflection with util 2023-02-27 20:17:33 -08:00
Douglas Eichelberger
37015b6b08 Change to pluralize, port more call sites 2023-02-27 20:17:33 -08:00
Douglas Eichelberger
0438a3a538 Draft implementation to replace ActiveSupport inflections 2023-02-27 20:17:33 -08:00
BrewTestBot
ceae9c3485
sorbet: Update RBI files. 
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow.
 2023-02-28 00:30:18 +00:00
Issy Long
033dacac10
rubocop: Tweak Style/Documentation include paths after PR 14805 
- The `Kernel` module, which needed a comment because it has an "@api public"
  method in it, moved.
 2023-02-28 00:19:57 +00:00
Issy Long
93e2f86cf8
ci: Add an Action to check RuboCop filepaths 
- This will stop the `Style/Documentation` filepath includes getting out of
  sync with what we declare as a public API, thus ensuring that everything is
  documented.
- Maybe we could also add a job here to check that _all_ the paths in the
  RuboCop config still exist, but that's for another time.
 2023-02-28 00:18:55 +00:00
Issy Long
9ec74fea2a
rubocop: Reinstate taps ignore for Style/Documentation 2023-02-28 00:18:54 +00:00
Issy Long
27610e0a66
rubocop: Move Style/Documentation stanza 
- This is better in the `Library/Homebrew/.rubocop.yml` since it's
  operating on files that are within that directory.
 2023-02-28 00:18:53 +00:00
Issy Long
316df75da9
utils: Add a comment to module Kernel to appease RuboCop 
- This `Homebrew/utils.rb` file contains one `@api public` method so it's now
  included in `Style/Documentation`.
- This method not having a comment was causing the style specs to fail because
  this file isn't usually failing RuboCop.
- And the test description was confusing so I improved it.
 2023-02-28 00:18:52 +00:00
Issy Long
32e7268596
rubocop: Only enable Style/Documentation for @api public code 
- Suggested in https://github.com/Homebrew/brew/pull/14709#issuecomment-1437461642.
- Found the public API paths with `git grep -l "@api public"`.
 2023-02-28 00:10:06 +00:00
Mike McQuaid
6db7732fa3
Merge pull request #14821 from issyl0/support-date-ranges-in-pr-reviews-query 
dev-cmd/contributions: Support date ranges in PR reviews query
 2023-02-28 00:06:41 +00:00
Sam Ford
ec7fd75934
Strategy#from_url: Replace #from_symbol call 
Passing the strategy symbol into the `#from_url` `select` block
means that we can also get rid of a `#from_symbol` call in a
different conditional branch, as we can directly compare the
`livecheck_strategy` symbol to `strategy_symbol`.
 2023-02-27 18:58:15 -05:00
Sam Ford
03823b5698
Strategy#from_url: Amend conditions for Json 
When the `Json` strategy was introduced, I forgot to also ensure
that it's only treated as usable (in `Strategy#from_url`) if a
`livecheck` block uses `strategy :json`. As a result, `Json` is
incorrectly treated as a usable strategy for all formulae/casks that
contain a `strategy` block.

Since all of these `livecheck` blocks specify a strategy, this bug
doesn't meaningfully impact livecheck's behavior (i.e., these checks
continue to use their explicitly-specified strategy). The only
practical difference is that `Json` incorrectly appears in the list
of usable strategies in livecheck's verbose JSON output.

This commit modifies `Strategy#from_url` to address this issue. The
easiest way to enforce this rule involved passing in the
`@strategies` key (a symbol) into the `select` block, so we can
compare it to `livecheck_strategy` (the strategy symbol specified in
the `livecheck` block).
 2023-02-27 18:58:13 -05:00
Mike McQuaid
86aeac6857
Merge pull request #14805 from dduugg/extend-kernel 
Move Kernel extensions into a separate file
 2023-02-27 19:38:35 +00:00
Douglas Eichelberger
1a0c02ffe0 Move tests too 2023-02-27 11:22:23 -08:00