36540 Commits

Author SHA1 Message Date
Issy Long
e9d994622e
rubocop: Drop "f" from Naming/MethodParameterName allowlist
- This either stands for "file" but more often than not "formula".
2023-03-11 00:17:27 +00:00
Mike McQuaid
5631310653
Auto-update from the API less often
Instead of doing so literally whenever we query for a formula, Instead
do so only when we're in an auto-updateable command.

This better fits the existing behaviour while still updating when it's
most important to do so.
2023-03-10 17:53:15 +00:00
Mike McQuaid
0c1031f2fd
Merge pull request #14937 from dduugg/enable-typing
Enable typing in a few more files
4.0.6
2023-03-10 09:01:41 +00:00
Mike McQuaid
fad4414d7c
Merge pull request #14940 from apainintheneck/fix-irb-test
Cleanup irb history file in tests
2023-03-10 08:59:32 +00:00
Douglas Eichelberger
9446db7720 Typecheck some utils 2023-03-09 21:46:35 -08:00
Douglas Eichelberger
76671ef555 Typecheck ENV extensions 2023-03-09 20:51:01 -08:00
Douglas Eichelberger
0b04b99e68 brew typecheck --suggest-typed --update 2023-03-09 20:32:46 -08:00
Douglas Eichelberger
5030f2bf31
Merge pull request #14941 from dduugg/DescriptionCacheStore-fix
Fix DescriptionCacheStore searching
2023-03-09 19:26:53 -08:00
Douglas Eichelberger
de90ddf07c Fix DescriptionCacheStore searching 2023-03-09 19:10:38 -08:00
apainintheneck
2baaafba92 Cleanup irb history file in tests
This was caused by the irb spec. Note that
$HOME is set during the test setup so will
always be correct.
2023-03-09 17:07:08 -08:00
Issy Long
188466d28e
rubocop: Drop "e" from Naming/MethodParameterName allowlist 2023-03-09 21:58:57 +00:00
Issy Long
f1ab720000
rubocop: Drop "c1" and "c2" from Naming/MethodParameterName allowlist 2023-03-09 21:54:37 +00:00
Douglas Eichelberger
02fd0422aa Enable typing in a few more files 2023-03-09 13:42:06 -08:00
Shane Smith
d8f7e633f2
Fix keep_alive sample code in formula cookbook 2023-03-09 15:28:00 -05:00
Mike McQuaid
cb5e8298a2
Merge pull request #14913 from hyuraku/move-cask/cmd/upgrade-to-cask/upgrade
Move `cask/cmd/upgrade` to `cask/upgrade`
2023-03-09 16:26:09 +00:00
hyuraku
8c1ce514b2 fix style 2023-03-09 22:34:46 +09:00
hyuraku
cd0686d75b move cask/cmd/uninstall_spec to cask/uninstall_spec 2023-03-09 22:33:45 +09:00
hyuraku
db328b59f2 move cask/cmd/uninstall to cask/uninstall 2023-03-09 22:33:29 +09:00
hyuraku
38a62b3a51 repair style 2023-03-09 20:55:33 +09:00
hyuraku
869c8effb5 remocve Cask::Upgrade::OPTIONS 2023-03-09 20:41:26 +09:00
hyuraku
2f870fa670 move cask/cmd/upgrade_spec to cask/upgrade 2023-03-09 20:41:22 +09:00
hyuraku
19f83ef67f move cask/cmd/upgrade to cask/upgrade 2023-03-09 20:40:20 +09:00
Dawid Dziurla
8824fc2c27
Merge pull request #14932 from Homebrew/skopeo-retry-backoff
github_packages: additional retry of skopeo copy with backoff
2023-03-09 10:47:22 +01:00
BrewTestBot
849bb43703
Update sponsors.
Autogenerated by the [sponsors-maintainers-man-completions](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/sponsors-maintainers-man-completions.yml) workflow.
2023-03-09 09:01:22 +00:00
Mike McQuaid
4db1cbbfe0
Merge pull request #14930 from g0t4/cat_mention_brew_info_github
include `--cask` or `--formula` in `brew info --github` suggestion
2023-03-09 09:00:22 +00:00
Mike McQuaid
4bf55c6d03
Merge pull request #14920 from issyl0/rubocop-block-delimiters
rubocop: Clean up `Style/BlockDelimiters` excludes and autofix offenses
2023-03-09 08:53:27 +00:00
Dawid Dziurla
c4cf2d208e
github_packages: reduce skopeo retry times to 2 2023-03-09 09:42:43 +01:00
Mike McQuaid
b3c9b499f7
Merge pull request #14921 from issyl0/sorbet-spoom-bump
sorbet: Run `brew typecheck --update --suggest-typed` on schedule in CI
2023-03-09 08:38:09 +00:00
Dawid Dziurla
de98ad53cc
github_packages: additional retry of skopeo copy with backoff 2023-03-09 09:17:24 +01:00
Wes Higbee
0b7d22a201
inlucde treat as --cask(s)/--formula(e) args in suggestion 2023-03-08 18:53:20 -06:00
Issy Long
3a83b5492c
rubocop: Clean up Style/BlockDelimiters excludes and autofix offenses
- The defaults of using "do ... end" for multi-line blocks everywhere is
  good, better than switching everything to braces everywhere.
2023-03-08 23:54:22 +00:00
Issy Long
20fe371c75
sorbet: More specific git add for --suggest-typed CI autobumps 2023-03-08 23:43:02 +00:00
Nanda H Krishna
58f7cb0d4e
Merge pull request #14929 from Homebrew/dependabot/bundler/Library/Homebrew/parser-3.2.1.1
build(deps): bump parser from 3.2.1.0 to 3.2.1.1 in /Library/Homebrew
2023-03-08 16:41:47 -05:00
BrewTestBot
3d2fc6e0f0
Update RBI files for parser.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
2023-03-08 19:08:34 +00:00
BrewTestBot
c32c0e64ac
brew vendor-gems: commit updates. 2023-03-08 19:00:55 +00:00
dependabot[bot]
8aa27bf765
build(deps): bump parser from 3.2.1.0 to 3.2.1.1 in /Library/Homebrew
Bumps [parser](https://github.com/whitequark/parser) from 3.2.1.0 to 3.2.1.1.
- [Release notes](https://github.com/whitequark/parser/releases)
- [Changelog](https://github.com/whitequark/parser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/whitequark/parser/compare/v3.2.1.0...v3.2.1.1)

---
updated-dependencies:
- dependency-name: parser
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-03-08 18:57:25 +00:00
Issy Long
274729156e
Merge pull request #14927 from issyl0/longer-variable-name
Make `str` variable names longer
2023-03-08 16:00:33 +00:00
Dawid Dziurla
f78a1298b8
Merge pull request #14926 from Homebrew/skopeo-retry-copy
github_packages: retry skopeo copy 5 times
2023-03-08 16:43:07 +01:00
Issy Long
2814d2285a
Make str variable names longer
- Three characters is the RuboCop limit for parameter names, but more
  descriptive is good.
- Requested in
  https://github.com/Homebrew/brew/pull/14922#pullrequestreview-1330848594,
  but the automerge was too quick for me to get to it.
2023-03-08 15:30:25 +00:00
Mike McQuaid
993768106a
Merge pull request #14922 from issyl0/rubocop-naming-method-parameter-name
rubocop: Trim `Naming/MethodParameterName` allowlist
2023-03-08 15:00:28 +00:00
Issy Long
e1c455585b
rubocop: Reinstate TODO for Naming/MethodParameterName
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2023-03-08 14:42:59 +00:00
Issy Long
f52fbaf917
rubocop: Drop "ff" from Naming/MethodParameterName allowlist
- It seems that "ff" was short for plural formula, so formulae.
2023-03-08 14:42:58 +00:00
Issy Long
a3211f4d7f
rubocop: Drop "d" from Naming/MethodParameterName allowlist 2023-03-08 14:42:57 +00:00
Issy Long
e273c25be0
rubocop: Drop "p" from Naming/MethodParameterName allowlist
- It's used to refer to a patch, so use the long name.
2023-03-08 14:42:56 +00:00
Issy Long
0cd616bc66
rubocop: Drop "r" from Naming/MethodParameterName allowlist
- This stands for "resource" in our case, so use the long name.
2023-03-08 14:42:55 +00:00
Issy Long
89fb8c78e8
rubocop: Drop "s" from Naming/MethodParameterName allowlist
- Most usages of this were in the `pretty_duration` method, where "s"
  is better described as "seconds" since we're calculating a duration.
- I also took the executive decision to do the same to "m" which refers
  to "minutes".
2023-03-08 14:42:53 +00:00
Issy Long
87042c0237
rubocop: Drop "rb" from Naming/MethodParameterName allowlist
- It's entirely unused as a parameter name.
2023-03-08 14:40:57 +00:00
Issy Long
6d822d9a62
rubocop: Drop "fn" from Naming/MethodParameterName allowlist
- I originally thought this was short for "function", but upon closer
  inspection all its usages are to do with filenames. So, use "filename",
  it's clearer.
2023-03-08 14:40:56 +00:00
Issy Long
3e7a46f474
rubocop: Drop "v" from Naming/MethodParameterName allowlist
- This was an easy fix, "v" => "version".
2023-03-08 14:40:55 +00:00
Issy Long
23abe37234
rubocop: Trim Naming/MethodParameterName allowlist based on defaults
- These are already included in
  6136ffd91e/config/default.yml (L2834-L2862)
  upstream default allowed method names, so we don't need them here too.
- Practically this makes no difference since the `inherit_mode` is
  `merge` it'll just merge the two, but for tidiness I thought I'd do
  this anyway since the duplication annoyed me.
2023-03-08 14:40:54 +00:00