admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
35,804 Commits 15 Branches 471 Tags
Commit Graph

35804 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Issy Long
274729156e
Merge pull request #14927 from issyl0/longer-variable-name 
Make `str` variable names longer
 2023-03-08 16:00:33 +00:00
Dawid Dziurla
f78a1298b8
Merge pull request #14926 from Homebrew/skopeo-retry-copy 
github_packages: retry skopeo copy 5 times
 2023-03-08 16:43:07 +01:00
Issy Long
2814d2285a
Make str variable names longer 
- Three characters is the RuboCop limit for parameter names, but more
  descriptive is good.
- Requested in
  https://github.com/Homebrew/brew/pull/14922#pullrequestreview-1330848594,
  but the automerge was too quick for me to get to it.
 2023-03-08 15:30:25 +00:00
Mike McQuaid
993768106a
Merge pull request #14922 from issyl0/rubocop-naming-method-parameter-name 
rubocop: Trim `Naming/MethodParameterName` allowlist
 2023-03-08 15:00:28 +00:00
Issy Long
e1c455585b
rubocop: Reinstate TODO for Naming/MethodParameterName 
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
 2023-03-08 14:42:59 +00:00
Issy Long
f52fbaf917
rubocop: Drop "ff" from Naming/MethodParameterName allowlist 
- It seems that "ff" was short for plural formula, so formulae.
 2023-03-08 14:42:58 +00:00
Issy Long
a3211f4d7f
rubocop: Drop "d" from Naming/MethodParameterName allowlist 2023-03-08 14:42:57 +00:00
Issy Long
e273c25be0
rubocop: Drop "p" from Naming/MethodParameterName allowlist 
- It's used to refer to a patch, so use the long name.
 2023-03-08 14:42:56 +00:00
Issy Long
0cd616bc66
rubocop: Drop "r" from Naming/MethodParameterName allowlist 
- This stands for "resource" in our case, so use the long name.
 2023-03-08 14:42:55 +00:00
Issy Long
89fb8c78e8
rubocop: Drop "s" from Naming/MethodParameterName allowlist 
- Most usages of this were in the `pretty_duration` method, where "s"
  is better described as "seconds" since we're calculating a duration.
- I also took the executive decision to do the same to "m" which refers
  to "minutes".
 2023-03-08 14:42:53 +00:00
Issy Long
87042c0237
rubocop: Drop "rb" from Naming/MethodParameterName allowlist 
- It's entirely unused as a parameter name.
 2023-03-08 14:40:57 +00:00
Issy Long
6d822d9a62
rubocop: Drop "fn" from Naming/MethodParameterName allowlist 
- I originally thought this was short for "function", but upon closer
  inspection all its usages are to do with filenames. So, use "filename",
  it's clearer.
 2023-03-08 14:40:56 +00:00
Issy Long
3e7a46f474
rubocop: Drop "v" from Naming/MethodParameterName allowlist 
- This was an easy fix, "v" => "version".
 2023-03-08 14:40:55 +00:00
Issy Long
23abe37234
rubocop: Trim Naming/MethodParameterName allowlist based on defaults 
- These are already included in
  6136ffd91e/config/default.yml (L2834-L2862)
  upstream default allowed method names, so we don't need them here too.
- Practically this makes no difference since the `inherit_mode` is
  `merge` it'll just merge the two, but for tidiness I thought I'd do
  this anyway since the duplication annoyed me.
 2023-03-08 14:40:54 +00:00
Dawid Dziurla
244006f15a
github_packages: retry skopeo copy 5 times 2023-03-08 15:32:31 +01:00
Mike McQuaid
8d71aa02dd
Merge pull request #14918 from SMillerDev/master 
bump-formula-pr: add release notes if found
 2023-03-08 14:02:36 +00:00
Sean Molenaar
2f32da0455
fix syntax 2023-03-08 14:28:34 +01:00
Mike McQuaid
b6b30667f0
Merge pull request #14829 from gibfahn/incorrect_headers 
download_strategy: handle incorrectly quoted filename* headers
 2023-03-08 13:07:07 +00:00
Sean Molenaar
9bd567aab9
Update Library/Homebrew/dev-cmd/bump-formula-pr.rb 
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
 2023-03-08 14:04:28 +01:00
Sean Molenaar
048ed5d683
Update Library/Homebrew/dev-cmd/bump-formula-pr.rb 
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
 2023-03-08 13:59:14 +01:00
Sean Molenaar
8532bb23cc
Update Library/Homebrew/dev-cmd/bump-formula-pr.rb 
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
 2023-03-08 13:58:45 +01:00
Mike McQuaid
97b66d3ae7
download_strategy: add another presence check. 2023-03-08 12:49:25 +00:00
Mike McQuaid
e5c0fb4ca6
Merge pull request #14892 from apainintheneck/irb-improvements 
`brew irb` improvements
 2023-03-08 12:46:56 +00:00
Mike McQuaid
b1801333cb
Merge pull request #14917 from dduugg/string-inflections 
Remove ActiveSupport String inflections
 2023-03-08 12:39:54 +00:00
apainintheneck
deabd4a5f9 Change history and config file dirs 
Now both REPL history is written to $HOME.
- Pry: $HOME/.brew_pry_history
- IRB: $HOME/.brew_irb_history

The IRB config file has also been moved to the
library directory.
 2023-03-07 19:15:05 -08:00
Gibson Fahnestock
160e7da779
download_strategy: handle incorrectly quoted filename* headers 
Some servers erroneously double-quote the filename in the filename*
header. This is (as far as I can tell from the spec) a bug in the
server, and should be fixed there.

In general though using `""` as the filename seems like behaviour worth
handling in brew anyway, as there may be other places where the parser
returns an empty string.

Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
 2023-03-08 01:28:39 +00:00
Issy Long
9c9f6b36b5
sorbet: Oops, missed a * for **/*.rb path wildcards 2023-03-07 23:10:28 +00:00
Issy Long
7053036d93
sorbet: Run brew typecheck --update --suggest-typed on schedule in CI 
- No idea if this works, let's experiment.
- Suggested in https://github.com/Homebrew/brew/pull/14893#issuecomment-1456040533.
 2023-03-07 23:08:16 +00:00
Mike McQuaid
3e2c713c92
Merge pull request #14870 from nandahkrishna/fix-requirement 
Fix `{MacOS,Xcode}Requirement` handling and improve output
 2023-03-07 19:26:47 +00:00
Nanda H Krishna
51329635d9
api: fix merge_variations 2023-03-07 14:12:41 -05:00
Nanda H Krishna
bb4f41ea43
api: fix bottle_tag identification 2023-03-07 14:12:40 -05:00
Nanda H Krishna
3113b44d1f
brew unbottled: fix XcodeRequirement handling on Linux 2023-03-07 14:12:40 -05:00
Nanda H Krishna
f03e462995
xcode_requirement: improve outputs 2023-03-07 14:12:40 -05:00
Nanda H Krishna
56703a49ed
macos_requirement: fix version_specified?, improve outputs 2023-03-07 14:12:40 -05:00
Douglas Eichelberger
6cfab10e2b typecheck 2023-03-07 10:45:53 -08:00
Sean Molenaar
139f90df97
bump-formula-pr: add release notes if found 2023-03-07 19:44:35 +01:00
Douglas Eichelberger
7aab1c2a38 Remove ActiveSupport String inflections 2023-03-07 10:16:52 -08:00
Douglas Eichelberger
6ffda80a8a brew style 2023-03-07 10:14:57 -08:00
Douglas Eichelberger
544960b4fc Replace String#underscore with util 2023-03-07 10:13:38 -08:00
Mike McQuaid
bd309509da
Merge pull request #14916 from dduugg/refactor-searchable 
Refactor searchable
 2023-03-07 17:31:36 +00:00
Douglas Eichelberger
1f742727af Move tests 2023-03-07 09:08:54 -08:00
Douglas Eichelberger
23587b70a1 Port Descriptions 2023-03-07 09:08:54 -08:00
Douglas Eichelberger
1195772b02 Refactor Searchable into Homebrew::Search 2023-03-07 09:08:54 -08:00
Mike McQuaid
fdd7b04ccf
Merge pull request #14914 from dduugg/revert-splat-AbstractUninstall 
Revert splat changes to AbstractUninstall
 2023-03-07 15:35:10 +00:00
Carlo Cabrera
999582f412
Fix typo 2023-03-07 23:34:57 +08:00
Carlo Cabrera
4c4e9369b1
Fix brew style 2023-03-07 23:28:59 +08:00
Douglas Eichelberger
900ee97f95 Revert splat changes to AbstractUninstall 2023-03-07 06:46:59 -08:00
Carlo Cabrera
46c3c86caa
Parse ld version from -version_details 2023-03-07 22:41:07 +08:00
Mike McQuaid
246b36cfb3
Merge pull request #14910 from issyl0/ubuntu-1804-actions-runners-brownout 
ci: Move from Ubuntu 18.04 to Ubuntu 20.04 Actions runners
 2023-03-07 14:25:42 +00:00
Issy Long
b95c549437
ci: Move to Ubuntu 20.04 Actions runners 
- The 18.04 runners are deprecated and going away in less than a month.
  Today was another scheduled brownout from GitHub
  (https://github.blog/changelog/2022-08-09-github-actions-the-ubuntu-18-04-actions-runner-image-is-being-deprecated-and-will-be-removed-by-12-1-22/),
  and they've been unmarked as required checks in the branch protections
  because the images are unavailable and the jobs were failing.
- However, we still need to test that Homebrew works correctly on
  non-latest Ubuntu versions so that we can test that we're correctly
  using brewed gcc/glibc, hence upgrading to 20.04 which is still old.
 2023-03-07 12:48:42 +00:00