30471 Commits

Author SHA1 Message Date
Issy Long
621e51a6c9
Don't require "debug" in brew tests - it's in our RSpec config 2024-04-17 22:25:12 +01:00
Issy Long
f2a64f3808
Fix RuboCop and exclude psych from RBI generation 2024-04-17 22:25:12 +01:00
Issy Long
1daeb5bee0
Set up the debug gem for test debugging
- This processed that we'd requested a debugger, but didn't drop us into
  a debugging console until I
  [stopped the stdin disablement](https://github.com/Homebrew/brew/issues/16708#issuecomment-1953483970).

Usage:

```
❯ git diff
diff --git a/Library/Homebrew/test/migrator_spec.rb b/Library/Homebrew/test/migrator_spec.rb
index 87fadd5e95..db4700810a 100644
--- a/Library/Homebrew/test/migrator_spec.rb
+++ b/Library/Homebrew/test/migrator_spec.rb
@@ -69,6 +69,8 @@ RSpec.describe Migrator do
       tab.source["tap"] = "homebrew/core"
       tab.write

+      binding.break
+
       expect do
         described_class.new(new_formula, "oldname")
       end.to raise_error(Migrator::MigratorDifferentTapsError)

issyl0 at pictor in /opt/homebrew on bye-byebug
❯ brew tests --only=migrator --debug
Randomized with seed 59158
1 process for 1 spec, ~ 1 spec per process
.==> Relinking newname
.==> Unlinking oldname
...==> Moving oldname versions to /private/tmp/homebrew-tests-20240403-85464-3uogqr/cellar/newname
....==> Migrating formula oldname to newname
==> Unlinking oldname
==> Moving oldname versions to /private/tmp/homebrew-tests-20240403-85464-3uogqr/cellar/newname
==> Relinking newname
....[67, 76] in ~/migrator_spec.rb
    67|       tab = Tab.empty
    68|       tab.tabfile = HOMEBREW_CELLAR/"oldname/0.1/INSTALL_RECEIPT.json"
    69|       tab.source["tap"] = "homebrew/core"
    70|       tab.write
    71|
=>  72|       binding.break
    73|
    74|       expect do
    75|         described_class.new(new_formula, "oldname")
    76|       end.to raise_error(Migrator::MigratorDifferentTapsError)
=>#0    block in <top (required)> (3 levels) at ~/migrator_spec.rb:72
  #1    [C] BasicObject#instance_exec at /opt/homebrew/Library/Homebrew/vendor/bundle/ruby/3.1.0/gems/rspec-core-3.13.0/lib/rspec/core/example.rb:263
  # and 68 frames (use `bt' command for all frames)
(rdbg@/opt/homebrew/Library/Homebrew/vendor/bundle/ruby/3.1.0/bin/rspec#85464) p tab
(rdbg@/opt/homebrew/Library/Homebrew/vendor/bundle/ruby/3.1.0/bin/rspec#85464) p    # command(rdbg@/opt/homebrew/Library/Homebrew/vendor/bundle/ruby/3.1.0/bin/rspec#85464) p     # command t    # command ta    # command tab    # command(rdbg@/opt/homebrew/Library/Homebrew/vendor/bundle/ruby/3.1.0/bin/rspec#85464) p tab    # command
=> #<Tab:0x0000000107156be0 @aliases=[], @arch=nil, @built_as_bottle=false, @built_on={"os"=>"Macintosh", "os_version"=>"macOS 14", "cpu_family"=>"arm_firestorm_icestorm"}, @compiler=:clang, @homebrew_version="4.2.16-55-gc8f60ec-dirty", @installed_as_dependency=false, @installed_on_request=false, @loaded_from_api=false, @poured_from_bottle=false, @runtime_dependencies=nil, @source={"path"=>nil, "tap"=>"homebrew/core", "tap_git_head"=>nil, "spec"=>"stable", "versions"=>{"stable"=>nil, "head"=>nil, "version_scheme"=>0}}, @source_modified_time=0, @stdlib=nil, @tabfile=#<Pathname:/private/tmp/homebrew-tests-20240403-85464-3uogqr/cellar/oldname/0.1/INSTALL_RECEIPT.json>, @time=nil, @unused_options=[], @used_options=[]>
(rdbg@/opt/homebrew/Library/Homebrew/vendor/bundle/ruby/3.1.0/bin/rspec#85464)
```
2024-04-17 22:25:12 +01:00
Issy Long
58fbaecedb
Add the debug gem for test debugging 2024-04-17 22:25:10 +01:00
Issy Long
11c1960729
Remove byebug since it doesn't work in tests anymore
- Byebug was introduced in [2020](https://github.com/Homebrew/brew/pull/7577) for hooking into tests for debugging.
- It does not work anymore in so far as it does not stop at breakpoints when following the instructions to trigger them in tests.
2024-04-17 22:24:21 +01:00
Patrick Linnane
929995c810
Merge pull request #17100 from krehel/array-alphabetization-blank-line-fix 2024-04-17 11:33:00 -07:00
Justin Krehel
36cc201616
rubocops/cask/array_alphabetization: skip blank lines when sorting 2024-04-17 14:22:48 -04:00
BrewTestBot
c293f96a80
brew vendor-gems: commit updates. 2024-04-17 18:11:40 +00:00
dependabot[bot]
d33e0e0b09
build(deps): bump sorbet-static-and-runtime and sorbet-runtime
Bumps [sorbet-static-and-runtime](https://github.com/sorbet/sorbet) and [sorbet-runtime](https://github.com/sorbet/sorbet). These dependencies needed to be updated together.

Updates `sorbet-static-and-runtime` from 0.5.11347 to 0.5.11349
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

Updates `sorbet-runtime` from 0.5.11347 to 0.5.11349
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

---
updated-dependencies:
- dependency-name: sorbet-static-and-runtime
  dependency-type: direct:development
  update-type: version-update:semver-patch
- dependency-name: sorbet-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-04-17 18:10:51 +00:00
Ruoyu Zhong
84d731888e
Merge pull request #17097 from ZhongRuoyu/artifact-actions-v4
pr-pull: support globbing artifacts
2024-04-18 00:58:44 +08:00
Ruoyu Zhong
4cf42f7c18
pr-pull: simplify 2024-04-17 07:37:02 +08:00
Ruoyu Zhong
9ad60fe437
utils/github: avoid returning artifacts with the same name 2024-04-17 07:35:40 +08:00
Ruoyu Zhong
dd92ad8e1b
Update default artifact pattern to avoid migration problems 2024-04-17 06:15:14 +08:00
Ruoyu Zhong
1a1a466e9d
pr-pull: support globbing artifacts
Artifact actions v3 is deprecated and will soon be unavailable [^1].
This adds support for v4 by allowing `brew pr-pull` to accept a glob
pattern for artifact names, like actions/download-artifact does [^2].

[^1]: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
[^2]: https://github.com/actions/download-artifact/tree/v4/#usage
2024-04-17 03:36:43 +08:00
Ruoyu Zhong
0df71ea6a3
utils/github: support globbing artifacts 2024-04-17 03:34:42 +08:00
Patrick Linnane
726d65c0ab
Merge pull request #17096 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-1.63.2 2024-04-16 12:13:45 -07:00
BrewTestBot
7b09db5a9b
Update RBI files for rubocop.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
2024-04-16 18:50:50 +00:00
BrewTestBot
b07a76c71b
brew vendor-gems: commit updates. 2024-04-16 18:50:22 +00:00
dependabot[bot]
872c136472
build(deps-dev): bump rubocop from 1.63.1 to 1.63.2 in /Library/Homebrew
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.63.1 to 1.63.2.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop/compare/v1.63.1...v1.63.2)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-04-16 18:49:29 +00:00
BrewTestBot
ec0355beef
brew vendor-gems: commit updates. 2024-04-16 18:48:59 +00:00
dependabot[bot]
50a66652e5
build(deps): bump sorbet-runtime and sorbet-static-and-runtime
Bumps [sorbet-runtime](https://github.com/sorbet/sorbet) and [sorbet-static-and-runtime](https://github.com/sorbet/sorbet). These dependencies needed to be updated together.

Updates `sorbet-runtime` from 0.5.11346 to 0.5.11347
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

Updates `sorbet-static-and-runtime` from 0.5.11346 to 0.5.11347
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

---
updated-dependencies:
- dependency-name: sorbet-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: sorbet-static-and-runtime
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-04-16 18:48:08 +00:00
Ruoyu Zhong
852c5acb65
Revert "os/linux/elf: avoid using ldd for listing dynamic dependencies" 2024-04-16 02:50:12 +08:00
Patrick Linnane
a553f96c96
Merge pull request #17090 from Homebrew/dependabot/bundler/Library/Homebrew/tapioca-0.13.3 2024-04-15 11:32:43 -07:00
BrewTestBot
a4bc5a82ff
Update RBI files for tapioca.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
2024-04-15 18:22:26 +00:00
BrewTestBot
6aa30a99c8
brew vendor-gems: commit updates. 2024-04-15 18:22:12 +00:00
BrewTestBot
f58dc9c6b2
Update RBI files for method_source.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
2024-04-15 18:21:40 +00:00
BrewTestBot
cb1125e137
brew vendor-gems: commit updates. 2024-04-15 18:21:28 +00:00
dependabot[bot]
e2d4097643
build(deps-dev): bump tapioca from 0.13.2 to 0.13.3 in /Library/Homebrew
Bumps [tapioca](https://github.com/Shopify/tapioca) from 0.13.2 to 0.13.3.
- [Release notes](https://github.com/Shopify/tapioca/releases)
- [Commits](https://github.com/Shopify/tapioca/compare/v0.13.2...v0.13.3)

---
updated-dependencies:
- dependency-name: tapioca
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-04-15 18:21:19 +00:00
dependabot[bot]
4689442ede
build(deps-dev): bump method_source in /Library/Homebrew
Bumps [method_source](https://github.com/banister/method_source) from 1.0.0 to 1.1.0.
- [Changelog](https://github.com/banister/method_source/blob/master/CHANGELOG.md)
- [Commits](https://github.com/banister/method_source/compare/v1.0.0...v1.1.0)

---
updated-dependencies:
- dependency-name: method_source
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-04-15 18:20:37 +00:00
Mike McQuaid
40d2f5c23a
Merge pull request #17087 from cho-m/keg-python2.7-refs-deprecate
keg: comment to odeprecated some Python 2 related methods
2024-04-15 08:46:17 +01:00
Mike McQuaid
c44bf6f432
Merge pull request #16817 from cho-m/virtualenv-basic-resource-order-args
language/python: order args for `virtualenv_install_with_resources`
2024-04-15 08:37:08 +01:00
Mike McQuaid
4c0a1c7a02
keg: remove unused python methods. 2024-04-15 08:35:32 +01:00
Mike McQuaid
0fc9c9f81e
Merge pull request #16941 from alebcay/elf-avoid-ldd
os/linux/elf: avoid using ldd for listing dynamic dependencies
2024-04-15 08:29:39 +01:00
Michael Cho
ecb7daba58
language/python: order args for virtualenv_install_with_resources
Add `without`, `start_with`, and `end_with` to allow basic control over
the order that resources are installed so that the situations where we
have to split up `virtualenv_install_with_resources` is reduced.

Co-authored-by: Kevin <apainintheneck@gmail.com>
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Signed-off-by: Michael Cho <michael@michaelcho.dev>
2024-04-14 22:21:32 -04:00
Michael Cho
060fb92527
keg: comment to odeprecated some Python 2 related methods
Signed-off-by: Michael Cho <michael@michaelcho.dev>
2024-04-14 19:58:16 -04:00
Patrick Linnane
9edabf02ce
Merge pull request #17085 from Homebrew/dependabot/bundler/Library/Homebrew/tapioca-0.13.2 2024-04-14 13:27:54 -07:00
Patrick Linnane
97a277a8ca
Merge pull request #17084 from Homebrew/dependabot/bundler/Library/Homebrew/multi-92c7acb997 2024-04-14 13:17:26 -07:00
BrewTestBot
1e56d82af3
Update RBI files for tapioca.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
2024-04-14 20:07:44 +00:00
BrewTestBot
4a0bf78a85
brew vendor-gems: commit updates. 2024-04-14 20:07:30 +00:00
BrewTestBot
93f997b70e
brew vendor-gems: commit updates. 2024-04-14 20:07:11 +00:00
dependabot[bot]
c3c24709a2
build(deps-dev): bump tapioca from 0.13.1 to 0.13.2 in /Library/Homebrew
Bumps [tapioca](https://github.com/Shopify/tapioca) from 0.13.1 to 0.13.2.
- [Release notes](https://github.com/Shopify/tapioca/releases)
- [Commits](https://github.com/Shopify/tapioca/compare/v0.13.1...v0.13.2)

---
updated-dependencies:
- dependency-name: tapioca
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-04-14 20:06:40 +00:00
dependabot[bot]
d8ecad09b0
build(deps): bump sorbet-static-and-runtime and sorbet-runtime
Bumps [sorbet-static-and-runtime](https://github.com/sorbet/sorbet) and [sorbet-runtime](https://github.com/sorbet/sorbet). These dependencies needed to be updated together.

Updates `sorbet-static-and-runtime` from 0.5.11342 to 0.5.11346
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

Updates `sorbet-runtime` from 0.5.11342 to 0.5.11346
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

---
updated-dependencies:
- dependency-name: sorbet-static-and-runtime
  dependency-type: direct:development
  update-type: version-update:semver-patch
- dependency-name: sorbet-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-04-14 20:06:20 +00:00
Caleb Xu
a4e0ccc1f6
os/linux/elf: avoid using ldd for listing dynamic dependencies 2024-04-13 19:35:30 -04:00
Caleb Xu
c6b98d0b8c
os/linux/ld: add functions for querying dynamic linker 2024-04-13 19:35:29 -04:00
Caleb Xu
4b0e950736
utils/path: add child_of? method 2024-04-13 19:35:29 -04:00
Ruoyu Zhong
4820c47bf0
github_runner_matrix: simplify
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
2024-04-14 00:02:37 +08:00
Ruoyu Zhong
3c3ee46f08
github_runner_matrix: increase timeout for self-hosted 12-x86_64
It is usually slower than other Intel runners and has timed out more
often recently.
2024-04-13 20:09:40 +08:00
BrewTestBot
c5d55ae0dc
brew vendor-gems: commit updates. 2024-04-12 17:25:39 +00:00
dependabot[bot]
8226c02803
build(deps): bump sorbet-runtime and sorbet-static-and-runtime
Bumps [sorbet-runtime](https://github.com/sorbet/sorbet) and [sorbet-static-and-runtime](https://github.com/sorbet/sorbet). These dependencies needed to be updated together.

Updates `sorbet-runtime` from 0.5.11340 to 0.5.11342
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

Updates `sorbet-static-and-runtime` from 0.5.11340 to 0.5.11342
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

---
updated-dependencies:
- dependency-name: sorbet-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: sorbet-static-and-runtime
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-04-12 17:24:50 +00:00
Mike McQuaid
4861c6fff0
Merge pull request #17076 from willfaught/master
cmd, cask: info prints whether installed
2024-04-12 18:02:27 +01:00