32336 Commits

Author SHA1 Message Date
Lukas Oberhuber
60831da3b8 DRY up formula prefix 2022-08-02 09:06:28 -07:00
Lukas Oberhuber
88a69b3de2 Restore previous style 2022-08-02 09:06:28 -07:00
Lukas Oberhuber
d35f2e76a7 Move Metrics/Blocklength disable to rubocop.yml 2022-08-02 09:06:28 -07:00
Carlo Cabrera
7be6b8e6d1
update-report: migrate GCC recursive dependents
When GCC 12 ships (Homebrew/homebrew-core#106755) ships, most (all?)
Linux bottles that depend on GCC will break.

Let's fix that by using the same trick for handling divergent formula
revisions when migrating formulae from linuxbrew-core (#11982). We set
the recorded `version_scheme` to -1, which spoofs the formula being
outdated. When `brew upgrade` installs GCC 12, the broken formulae will
have their bottles reinstalled too.

This works because the reinstallation will also rewrite the existing
RPATHs to point to the new version of GCC instead (#13631). This should
handle most of the breakage.
2022-08-02 23:57:16 +08:00
Lukas Oberhuber
07e299760a
mktemp: use "present?" instead of '!nil?"
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2022-08-02 08:33:40 -07:00
Carlo Cabrera
8a153de2bc
Merge pull request #13632 from carlocab/proc
pr-pull: fix typo
2022-08-02 23:26:34 +08:00
Carlo Cabrera
b2cf1822fa
Fix brew style 2022-08-02 22:53:29 +08:00
Carlo Cabrera
8a169364a8
pr-pull: fix typo
Error: tried to create Proc object without a block
    Do not report this issue until you've run `brew update` and tried again.
    /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/pr-pull.rb:372:in `proc'
    /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/pr-pull.rb:372:in `pr_check_conflicts'
    /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/pr-pull.rb:439:in `block in pr_pull'
    /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/pr-pull.rb:429:in `each'
    /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/pr-pull.rb:429:in `pr_pull'
    /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:93:in `<main>'
    Error: Process completed with exit code 1.

https://github.com/Homebrew/homebrew-core/runs/7634004090?check_suite_focus=true#step:10:15
2022-08-02 22:46:30 +08:00
Michka Popoff
3b38695efa
Merge pull request #13512 from iMichka/conflicts
pr-pull: check for conflicts with long running builds
2022-08-02 14:42:08 +02:00
Carlo Cabrera
716136bfc5
Merge pull request #13631 from carlocab/gcc-rpaths
keg_relocate (linux): prepend `gcc/lib/current` to `RPATH` when needed
2022-08-02 19:40:40 +08:00
Carlo Cabrera
1c0eac7874
Exclude GCC formulae from RPATH modification for GCC 2022-08-02 19:09:38 +08:00
Carlo Cabrera
532460c098
keg_relocate: fix new GCC lib directory
Also add comment explaining what this line does, along with a TODO
suggesting a replacement once we've shipped the GCC PR.
2022-08-02 13:29:14 +08:00
Carlo Cabrera
53fdb64113
keg_relocate (linux): prepend gcc/lib/current to RPATH when needed
This should help keep bottles that require GCC working when
Homebrew/homebrew-core#106755 is merged.

This only works on freshly-poured bottles. Previously installed bottles
will still break on systems with a host GCC older than GCC 11.
2022-08-02 11:02:47 +08:00
Lukas Oberhuber
676e3d4923 Change name of option on mktemp
From retain_in_sources to retain_in_cache
2022-08-01 18:30:14 -07:00
Lukas Oberhuber
fdf17f06b1 Test for dSYM directory on Mac 2022-08-01 16:30:00 -07:00
Lukas Oberhuber
5b1724ef33 Fix rubocop warning by ignoring for install_args 2022-08-01 15:27:17 -07:00
Lukas Oberhuber
bee3531090 Improve style 2022-08-01 15:25:34 -07:00
Michka Popoff
374c3985d6
pr-pull: check for conflicts with long running builds
This change will prevent us having to run some long running builds
multiple times and to rely on luck to get things merged without conflicts.

The check takes less than 30 secondes on my local setup.
2022-08-01 23:34:06 +02:00
Mike McQuaid
4baff3eec1
Merge pull request #13624 from iMichka/core
docs: delete Homebrew-linuxbrew-core-Maintainer-Guide.md
2022-08-01 14:03:27 +01:00
Carlo Cabrera
ce8ef89ec0
Merge pull request #13617 from carlocab/bzr-breezy
download_strategy: replace `bazaar` with `breezy`
3.5.7
2022-08-01 20:03:08 +08:00
Rylan Polster
58be76bc9d
Fix on_{system} handling of generic macOS versions 2022-07-31 20:44:51 -04:00
Michka Popoff
e28a102812
docs: delete Homebrew-linuxbrew-core-Maintainer-Guide.md
In e1120549e58dfeb088bcda85897c30e87128229b this file was emptied,
but should have been deleted instead.
Nothing references this file anymore
2022-07-31 23:01:57 +02:00
Lukas Oberhuber
41a5265466 Improve messaging of debug source location 2022-07-31 21:06:33 +01:00
Lukas Oberhuber
93132c6876 Always put source files in the same directory
There's no point in saving old ones because the debug symbols will only
for the newest bulid anyway.

Currently blows away what was there before, which isn't ideal for a dev
workflow. Maybe that should be changed, given a tar file should be a tar
file, so shouldn't change. But there are many different types of files.
2022-07-31 20:54:14 +01:00
Max Eisner
b792a4f645
fix TypeError 2022-07-31 21:48:02 +02:00
Lukas Oberhuber
8b1eb32e99 Sources now retained in Caches/Homebrew/Sources
Full path is ~/Library/Caches/Homebrew/Sources

This creates a brand new directory for each build, but leaves previous.
2022-07-31 20:33:25 +01:00
Max Eisner
b2d94dc897
update arg names in docs and signature 2022-07-31 21:01:42 +02:00
Lukas Oberhuber
4b0d52ef62 debug_symbols passed down to soure dir creator
The flag is now passed down to resource which creates the directory for
unpacking the source.
2022-07-31 19:59:25 +01:00
Lukas Oberhuber
4eea117e84 ofail if debug-symbols cannot be extracted. 2022-07-30 11:41:05 +01:00
Lukas Oberhuber
15f1ac8775 Integration test for --debug-symbols
But only checks that the command works. Not that `dsymutil` is called
or that `-g` is added to the compile args.

(Not sure how to do either in an integration test.)
2022-07-30 11:23:40 +01:00
Lukas Oberhuber
cd9fe97c55 Improve style 2022-07-30 11:10:26 +01:00
Lukas Oberhuber
e46a61e181 rename & inline dsymutil to prepare_debug_symbols 2022-07-30 11:08:52 +01:00
Carlo Cabrera
e217fd35c2
Merge pull request #12770 from carlocab/deprecated-dependencies
formula_auditor: audit for deprecated dependencies
2022-07-30 13:23:57 +08:00
Shaun Jackman
4f02c5de99
Merge pull request #13618 from sjackman/sj/audit_glibc
audit_glibc: Permit glibc 2.27, 2.31, or 2.35 and fix the error message
2022-07-29 14:57:45 -07:00
Shaun Jackman
7d1197e8eb audit_glibc: Permit glibc 2.27, 2.31, or 2.35 2022-07-29 14:06:51 -07:00
Shaun Jackman
1ac5fc05bd audit_glibc: Permit glibc 2.35
See https://github.com/Homebrew/brew/issues/13619
2022-07-29 10:13:09 -07:00
Shaun Jackman
291eacd482 audit_glibc: Fix the error message
"The glibc version must be 2.35" should have read
"The glibc version must be 2.23".
2022-07-29 09:30:18 -07:00
Carlo Cabrera
7c7a92e8fb
formula_auditor: clean up error wording 2022-07-29 20:10:05 +08:00
Carlo Cabrera
467a45421f
dependency_collector: replace bazaar with breezy 2022-07-29 18:10:12 +08:00
Carlo Cabrera
e1ba143d88
download_strategy: replace bazaar with breezy
Bazaar is no longer maintained, and Breezy seems to be a drop-in
replacement.

I've tested the commands used in the download strategy and they seem to
work.

We need this in order to properly deprecate the `bazaar` formula.

See Homebrew/homebrew-core#106848.
2022-07-29 17:02:39 +08:00
Carlo Cabrera
43a34706ed
Merge pull request #13615 from Homebrew/dependabot/bundler/Library/Homebrew/bootsnap-1.13.0
build(deps): bump bootsnap from 1.12.0 to 1.13.0 in /Library/Homebrew
2022-07-29 15:14:10 +08:00
Carlo Cabrera
cbff83898e
formula_auditor: audit for deprecated dependencies
Closes #12748.
2022-07-29 15:07:16 +08:00
Carlo Cabrera
72880dea35
Merge pull request #13586 from carlocab/git-fsmonitor 2022-07-29 04:28:15 +08:00
Rylan Polster
ea1f2098ac
Move HOMEBREW_SIMULATE_MACOS_ON_LINUX handling to SimulateSystem 2022-07-28 15:04:25 -04:00
BrewTestBot
f45114cfae
brew vendor-gems: commit updates. 2022-07-28 18:07:46 +00:00
dependabot[bot]
506daa1a09
build(deps): bump bootsnap from 1.12.0 to 1.13.0 in /Library/Homebrew
Bumps [bootsnap](https://github.com/Shopify/bootsnap) from 1.12.0 to 1.13.0.
- [Release notes](https://github.com/Shopify/bootsnap/releases)
- [Changelog](https://github.com/Shopify/bootsnap/blob/main/CHANGELOG.md)
- [Commits](https://github.com/Shopify/bootsnap/compare/v1.12.0...v1.13.0)

---
updated-dependencies:
- dependency-name: bootsnap
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-07-28 18:03:51 +00:00
Carlo Cabrera
5e60d54e70
update: disable Git fsmonitor for all Homebrew repositories
Stopping the fsmonitor doesn't seem to work, so let's just prevent the
fsmonitor from watching our repositories.
2022-07-28 22:20:07 +08:00
Rylan Polster
ef929a7c28
Merge pull request #13599 from Rylan12/cleanup-simulate-system
`SimulateSystem` improvements
2022-07-28 10:05:13 -04:00
Carlo Cabrera
c42169249e
cmd/update: stop fsmonitor after all Git operations complete
Also, skip the status check, as that doesn't really help us.
2022-07-28 22:02:31 +08:00
Rylan Polster
4cc0e854ce
Rename treat_as_*? to simulating_or_running_on_*? 2022-07-28 09:18:16 -04:00