14069 Commits

Author SHA1 Message Date
Gautham Goli
1caa0c0219 linkage: Fix brew linkage --reverse 2018-06-02 20:58:34 +05:30
Gautham Goli
39a6f7f83f linkage: Use Parser to parse args 2018-06-02 20:45:50 +05:30
commitay
1a4340161c options_cop: formula -> formulae 2018-06-02 16:56:55 +10:00
Markus Reiter
d98c45b2d3 Fix code style in audit spec. 2018-06-02 03:46:55 +02:00
commitay
a48e42e9dd cask fetch and upgrade: print caveats 2018-06-02 11:31:38 +10:00
Mike McQuaid
ca919de13e
Merge pull request #4264 from MikeMcQuaid/more-runtime-dep-tweaks
Further tweak formula installer runtime dep handling
2018-06-01 22:05:58 +01:00
Mike McQuaid
9e2baa3bff Add additional runtime_dependency related tests. 2018-06-01 21:36:28 +01:00
Mike McQuaid
39a036b746
Merge pull request #4259 from GauthamGoli/fix-bump-args
cli_parser: Rename @bump_args to args
2018-06-01 20:47:39 +01:00
Mike McQuaid
4e03bbeefe
Merge pull request #4260 from sjackman/superenv-mac
superenv: Move macOS-specific files to shims/mac/
2018-06-01 20:46:59 +01:00
Mike McQuaid
1cbc78c5dd Further tweak formula installer runtime dep handling
Instead of adding a custom method to `Tab` use `Tab.runtime_deps_hash`
within `FormulaInstaller` to ensure the `runtime_dependencies` are in
the right format.
2018-06-01 20:39:39 +01:00
Mike McQuaid
42e5ef9f89 tab: set runtime_dependencies consistently. 2018-06-01 19:53:26 +01:00
Mike McQuaid
6b817f775f Formula: handle bad tap runtime dependencies.
Also add some better exceptions for the cases that `nil`s end up
getting passed around incorrectly.
2018-06-01 19:22:33 +01:00
Shaun Jackman
a618681cf0 superenv: Move macOS-specific files to shims/mac/super/ 2018-06-01 09:53:26 -07:00
Mike McQuaid
a674a972a5
Merge pull request #4258 from MikeMcQuaid/update_head_version_path
Formula#update_head_version: fix PATH.
2018-06-01 16:59:39 +01:00
Gautham Goli
e21b7618a9 cli_parser: Rename @bump_args to args 2018-06-01 21:13:36 +05:30
Mike McQuaid
f24c77f3dd Formula#update_head_version: fix PATH.
Ensure that all the necessary tools are accessible.
2018-06-01 16:43:11 +01:00
Mike McQuaid
31112934b0
Merge pull request #4257 from MikeMcQuaid/required-recommended
runtime_dependencies: include recommended deps.
2018-06-01 16:38:55 +01:00
Mike McQuaid
63f8455ed3
Merge pull request #4255 from MikeMcQuaid/fix-cache
linkage_cache: cache input data and not results.
2018-06-01 16:38:44 +01:00
Gautham Goli
f5e5a81a7f
Merge pull request #4146 from GauthamGoli/global-args
cli: Store parsed args in Homebrew.args and access @args everywhere else
2018-06-01 20:01:26 +05:30
Mike McQuaid
e9a66bff14 Regenerate runtime_dependencies after installation
This ensures the we’re calculating we’ve run `fix_dynamic_linkage` so
that their results are consistent with what we’re actually pouring.

Combined with the linkage cache (which will be enabled by default in
future) this has very little performance overhead for consistently
Correct tab results.

As a result, don’t bother looking at opportunistically linked
dependencies when creating a tab by default but only do so after
installation has completed.

Finally, only output the caveats and summary after all these
operations have completed.
2018-06-01 14:05:16 +01:00
Mike McQuaid
61617a257e linkage_checker: use default use_cache parameter for callers. 2018-06-01 14:05:16 +01:00
Mike McQuaid
1a2c2f2e1b linkage_cache: cache input data and not results.
Cache all the non-weak dynamic library links for a keg rather than the
result of running `brew linkage`. This means that we correctly handle
changes to e.g. what non-keg files are present on disk.
2018-06-01 14:05:16 +01:00
Mike McQuaid
b66aafc218 runtime_dependencies: include recommended deps.
These previously weren't being generated correctly for dependencies of
formulae that weren't installed.
2018-06-01 14:01:34 +01:00
Markus Reiter
e6648af656
Merge pull request #4251 from reitermarkus/must-succeed
Moving and copying must succeed.
2018-06-01 14:17:21 +02:00
Mike McQuaid
fb0f979279
Merge pull request #4204 from commitay/github-notabilty
audit: github notability
2018-06-01 08:39:26 +01:00
Markus Reiter
e07e036695 Moving and copying must succeed. 2018-06-01 03:31:12 +02:00
commitay
54b4f0c743 audit: github notability 2018-06-01 08:30:03 +10:00
Mike McQuaid
43bb5d28d7
Merge pull request #4247 from MikeMcQuaid/bump-formula-pr-bad-args
bump-formula-pr: improve bad argument handling.
2018-05-31 20:18:06 +01:00
Mike McQuaid
d7dbbf06bf
Merge pull request #4246 from MikeMcQuaid/bzr-downloads
download_strategy: fix bzr --HEAD downloads.
2018-05-31 20:17:55 +01:00
Mike McQuaid
054866653d
Merge pull request #4185 from sjackman/superenv-linux
Add superenv for Linux
2018-05-31 19:56:16 +01:00
Mike McQuaid
33cf882e34 bump-formula-pr: improve bad argument handling. 2018-05-31 19:53:12 +01:00
Mike McQuaid
0bb3d63c56 download_strategy: fix bzr --HEAD downloads.
`bzr` needs `BZR_HOME` set to something that's writable in the sandbox
to be able to write log files.
2018-05-31 19:43:01 +01:00
Shaun Jackman
9f8f8ffb89 superenv: Move Linux-specific bits to extend/os/ 2018-05-30 14:00:26 -07:00
Shaun Jackman
9e57be73ec shims/super/cc: Add support for Linux 2018-05-30 12:14:31 -07:00
lukertty
f308aa4800
Tty.width: use tput cols when stty size returns 0;
bin/brew: add 'COLUMNS' and 'LINES' to env variables

Signed-off-by: lukertty <lukertty@gmail.com>
2018-05-30 12:29:24 +08:00
Gautham Goli
fba52e2f74 cli_parser: Store parsed args in Homebrew.args and access args everywhere else 2018-05-30 00:05:39 +05:30
Mike McQuaid
f8f77ea52d cmd/list: add common ls options.
We need to manually specify these now so let's add a few that we'd
either previously documented or we've caught being used in the wild and
adjust the documentation accordingly.
2018-05-29 18:45:46 +01:00
Vítor Galvão
81d467abba with-languages.rb: remove trailing whitespace 2018-05-29 11:42:05 +01:00
Vítor Galvão
dc1edf6bfc cask --language: have specific match always trump general 2018-05-29 11:42:05 +01:00
Tom Schoonjans
ecbd9b9a26 Add gtk-mac-integration to gnome_devel_whitelist 2018-05-29 10:38:38 +01:00
Markus Reiter
0cb960951f Fix tap unavailable error for migrated Cask taps. 2018-05-29 10:57:33 +02:00
Mike McQuaid
67db701ae5
Merge pull request #4067 from maxim-belkin/fix-multiple
list.rb: use CLI::Parser and improve handling of flags
2018-05-28 20:52:03 +01:00
Mike McQuaid
517d147e33
Merge pull request #4219 from alyssais/version_comparison
Fix comparison with Version::NULL on RHS
2018-05-28 20:35:49 +01:00
Mike McQuaid
513c179e60
Merge pull request #4213 from reitermarkus/refactoring
Refactoring
2018-05-28 20:26:09 +01:00
Mike McQuaid
a276a48253
Merge pull request #4222 from reitermarkus/silence-parser-compatibility
Silence `Parser` compatibility warning.
2018-05-28 20:25:43 +01:00
Markus Reiter
a0ca601a1a Silence Parser compatibility warning. 2018-05-26 16:24:48 +02:00
Markus Reiter
c89ae8c5ab Fall back to CaskLoader.load to get a better error message. 2018-05-26 16:05:51 +02:00
Alyssa Ross
472d1a22c5
Fix comparison with Version::NULL on RHS
This was accounted for in Version::NULL.<=>, but not in Version#<=>,
so these could only be compared if Version::NULL was the left hand
side.

The check had to go above the check that `other` is a version because
`Version::NULL`'s anonymous class does not inherit from `Version`.
(The type check feels like it's probably a smell, but out of scope).
2018-05-26 14:45:53 +02:00
Markus Reiter
579a30c7bf Fix rspec deprecations. 2018-05-25 23:19:13 +02:00
Markus Reiter
df2a40d207 Use remote instead of path.git_origin. 2018-05-25 22:54:34 +02:00