14069 Commits

Author SHA1 Message Date
ilovezfs
f818f0e681 formula: reject dot dirs as racks
Dot directories are not racks because formulae names do not start with
"." so avoid attempting to descend into dot directories, which may not
always be possible (e.g. .Trashes).
2018-01-19 15:07:04 -08:00
ilovezfs
2e1ec02aeb pathname: fix rmdir_if_possible with mount points
Attempting to rmdir a directory that is a mount point results in EBUSY,
not EACCES or ENOENT, so also rescue EBUSY in rmdir_if_possible.
2018-01-19 14:06:22 -08:00
Alyssa Ross
78c829790d
Improve deprecation message for dependency tags
It took me a while to figure out what this deprecation actually did,
because the message wasn't accurate.
2018-01-18 21:16:19 +00:00
Alyssa Ross
d88b50968c
Load formula_support deprecations
We should probably write tests for these going forward. ;)
2018-01-18 21:09:21 +00:00
Alyssa Ross
8874d1fb13
prepend instead of alias hacks for deprecations 2018-01-18 21:08:41 +00:00
Mike McQuaid
02e4cae3d0
Merge pull request #3676 from apjanke/make-apjanke-former-maintainer
README: update list of maintainers
2018-01-18 15:55:36 +00:00
Mike McQuaid
65695885b6 Update other Homebrew maintainers. 2018-01-18 15:45:51 +00:00
Mike McQuaid
8a45467ad9
Merge pull request #3661 from MikeMcQuaid/deprecate-default-formula
Deprecate default_formula Requirement DSL
2018-01-18 15:30:56 +00:00
Mike McQuaid
edc6efd443
Merge pull request #3689 from sjackman/pull-json
publish_bottle_file_on_bintray: Use f.full_name
2018-01-18 15:30:03 +00:00
Mike McQuaid
9201fbde82
Merge pull request #3694 from MikeMcQuaid/more-odisabled
Disable and add more deprecations.
2018-01-18 15:29:40 +00:00
Mike McQuaid
b17672a2b4
Merge pull request #3693 from ilovezfs/info-always-show-spec-options
info: show spec options for optionless formulae
2018-01-18 15:29:29 +00:00
Mike McQuaid
e67b745b2f
Merge pull request #3659 from MikeMcQuaid/deprecated-requirements-harder
Deprecate requirements harder
2018-01-18 15:27:02 +00:00
Mike McQuaid
10384231a2
Merge pull request #3636 from Homebrew/rubocop-bump
rubocop 0.52.1
2018-01-18 15:16:53 +00:00
Mike McQuaid
77f1768108 Disable and add more deprecations.
These have all been deprecated/compat for a while.
2018-01-18 09:47:33 +00:00
Mike McQuaid
e5c82dd3d9 Deprecate requirements harder
Remove more Requirement logic to enable future removal of default
formula logic. Also, output deprecations, convert symbol requirement
usage to deps and simplify the compatibility code for the direct
Requirement usage.
2018-01-18 08:31:20 +00:00
Mike McQuaid
892e1b5b4f
Merge pull request #3652 from MikeMcQuaid/add-more-deprecations-disables
Add more deprecations, disable some existing ones.
2018-01-18 08:29:56 +00:00
ilovezfs
ebd50d136f info: show spec options for optionless formulae
Previsiouly, info would not display --HEAD or --devel for formulae that
had no options other than those spec options.
2018-01-18 00:03:10 -08:00
Mike McQuaid
17c24d040b utils: tell developers to submit odeprecated PRs.
Rather than just telling them to submit an issue as it's likely that
as these folks will be able to submit a PR.
2018-01-17 10:50:48 +00:00
Mike McQuaid
1f48e17f1b rubocop: fix brew style warnings. 2018-01-17 10:42:43 +00:00
Shaun Jackman
3f8dd656d3 publish_bottle_file_on_bintray: Use f.full_name 2018-01-16 10:41:41 -08:00
Mike McQuaid
8cd0d85afb rubocop 0.52.1 2018-01-15 16:17:32 +00:00
Markus Reiter
f90e6f82c8
Merge pull request #3680 from commitay/moved-permissions
cask moved: check target writable for move_back
2018-01-15 15:28:55 +01:00
ilovezfs
17f80a44e6
Revert "Use Homebrew's gitconfig for various commands" 2018-01-15 07:30:56 +00:00
Mike McQuaid
253a41f523
Merge pull request #3670 from MikeMcQuaid/gitconfig
Use Homebrew's gitconfig for various commands
2018-01-14 18:17:06 +00:00
Mike McQuaid
fcec5ad360
Merge pull request #3683 from MikeMcQuaid/vendor-install-mirror
vendor-install: various portable ruby tweaks.
2018-01-14 18:16:52 +00:00
Mike McQuaid
fea90825fb vendor-install: various portable ruby tweaks.
- Rename repository to homebrew-portable-ruby
- Add a new Bintray repository using new name
- Add GitHub releases mirror and try to use it
- Tell people not to file issues if they can't connect to Bintray or
  GitHub: we're not here to provide ISP/proxy support.
2018-01-14 13:49:26 +00:00
Mike McQuaid
b70b5429d0 Deprecate default_formula Requirement DSL
This has been a nightmare in terms of the complexity to our dependency
system and the whack-a-mole required on bugs. If a Requirement resolves
to a Formula it should just use `depends_on "formula"` instead. This
matches the effective behaviour all users of bottles (the vast majority
of users and installs) and what we're doing in Homebrew/homebrew-core.
2018-01-14 13:27:43 +00:00
Kevin Abel
0254605cd5
Handle reaching the top of a URL which searching for file ext
Should never reach this as most URL's will have a domain name that will
be caught as an extname.
2018-01-13 17:06:21 -06:00
commitay
8bf9484823 cask moved: check target writable for move_back 2018-01-13 21:31:00 +10:00
commitay
e870c1783f cask doctor: sip status 2018-01-13 08:47:10 +10:00
Mike McQuaid
228cbd81c9 Use Homebrew's gitconfig for various commands
Git is a transport and storage mechanism for us so we don't want to
allow arbitrary customisation of this due to user issues e.g. #3664
and #3561.

Fixes #3664.
2018-01-11 20:40:59 +00:00
Mike McQuaid
02591bdf34
Merge pull request #3662 from MikeMcQuaid/curl-executable
curl: handle more non-executable curl edge-cases.
2018-01-11 19:41:23 +00:00
Mike McQuaid
924865ec7f curl: handle more non-executable curl edge-cases.
Address some additional issues mentioned in #3624.
2018-01-11 16:33:20 +00:00
Mike McQuaid
e903a5f655
formula: tweak more depends_on examples. 2018-01-11 13:33:54 +00:00
Michihito Shigemura
f5e8b2680e docs: Fix depends_on examples in Formula page
example:

Error: depends_on :mysql
Correct: depends_on "mysql"
2018-01-11 21:05:14 +09:00
Mike McQuaid
838a3f1996 reinstall/upgrade: stop unlinked kegs being sticky
It's not possible to determine the difference between a non-keg-only
keg that failed to link and one that wasn't linked by us intentionally.

To avoid additional complexity of storing this logic in another place
let's back out this relatively new functionality; sticky keg-only links
is a better and more desirable behaviour anyway.
2018-01-10 16:43:21 +00:00
Mike McQuaid
b66010605d
Merge pull request #3651 from MikeMcQuaid/deprecate-git-svn-requirements
Deprecate Git, Subversion requirements.
2018-01-10 13:40:55 +00:00
Mike McQuaid
27be33b245 Deprecate Git, Subversion requirements.
These rely on `default_formula` to be useful and are better following
the `*_dep_if_needed` pattern.
2018-01-10 13:19:50 +00:00
Mike McQuaid
b29213a663
Merge pull request #3655 from MikeMcQuaid/formula-cop-hash-match-array
formula_cop: match any values in hash match.
2018-01-10 09:09:50 +00:00
Mike McQuaid
69b38dd9db
Merge pull request #3654 from sjackman/check_install_sanity
check_install_sanity: Use formula.runtime_dependencies
2018-01-10 09:07:17 +00:00
Kevin Abel
dca8dc5bf5
Fix audit 2018-01-09 20:11:52 -06:00
Kevin Abel
06f2b50ee4
Fix cached download file extension for certain URL
PHP URLs have the downloadable file in the middle of the pathname. If no
extension is detected, continue up the pathname.
2018-01-09 19:56:54 -06:00
Mike McQuaid
7f2fda104a formula_cop: match any values in hash match.
e.g. match an array or symbol or string.
2018-01-09 20:08:22 +00:00
Alyssa Ross
f06b54f1bb
Merge pull request #3653 from alyssais/installed_on_request
Preserve installed_on_request for dependencies
2018-01-09 20:02:45 +00:00
Mike McQuaid
2cbce1fbf0 Add more deprecations, disable some existing ones.
Add more `odeprecated` calls to places that have been deprecated for a
while in the wild and move some of the existing `odeprecated` calls to
be `odisabled` to allow deleting the compatibility code.
2018-01-09 19:52:34 +00:00
Shaun Jackman
95bf23404e check_install_sanity: Use formula.runtime_dependencies
Fix Error: wget contains conflicting version recursive dependencies:
openssl, openssl@1.1
2018-01-09 10:35:59 -08:00
Alyssa Ross
ef82b188f2
Preserve installed_on_request for dependencies
Fixes https://github.com/Homebrew/brew/issues/3642.
2018-01-09 16:37:59 +00:00
Mike McQuaid
50a84f2535 audit: allow env :std in custom taps.
This is a nicer experience than writing `Requirement`s by hand.
2018-01-09 15:26:54 +00:00
Mike McQuaid
9ed1ed3c05 upgrade: fix UnsatisfiedRequirements exit code. 2018-01-09 09:07:37 +00:00
Mike McQuaid
dbeebcaef5 upgrade: skip formula if upgrade fails.
Rather than blocking the rest of the formulae from being installed by
`brew upgrade` print the requirement failure messages (already done) and
an error stating requirements weren't satisfied and then continue to
upgrade the rest of the formulae.
2018-01-08 14:38:10 +00:00