2476 Commits

Author SHA1 Message Date
Mike McQuaid
879b3360d3 Handle missing receipt on brew install.
For example if this is for a really old keg, keg where a user has
manually removed stuff or used `brew diy`.
2017-04-02 17:02:56 +01:00
Eugene Nikolsky
edd9a9717c Fix the 'export PATH' message in link for a keg-only formula
Commit 4cae6a724e6d684eb157dd6d7328755694f228b2 introduced the message,
but it printed the wrong path, e.g. for `brew link sqlite`:

```
If you need to have this software first in your PATH instead consider running:
  echo 'export PATH="/usr/local/opt/sqlite:$PATH"' >> ~/.zshrc/bin
```

where `/bin` is appended at the end, but should be inserted before
`:$PATH`: `echo 'export PATH="/usr/local/opt/sqlite/bin:$PATH"' >> ~/.zshrc`.
This patch fixes that and updates a test to verify it.
2017-04-01 20:12:00 -07:00
JCount
0e1b7ce8ea gpg_spec: make test compatible with gnupg 2.1.x
maintain existing compatibility with gnupg 2.0.x
2017-04-01 21:29:09 -04:00
Vítor Galvão
7c048b6f71 cask: remove pre_bug_report links 2017-03-31 20:24:23 +01:00
Ilya Zverev
f5321d1b0d Remove osmium from blacklisted formulas 2017-03-31 15:59:22 +03:00
Mike McQuaid
80b39bb239 Merge pull request #2374 from joshka/cleanup-command-continue-on-error
Cleanup: Continue on error removing keg
2017-03-31 09:43:47 +01:00
Joshua McKinney
48fdd163bc Brew cleanup: Continue on error removing keg
Fixes #2355
Create unremovable_kegs instance var
Check cellar cleanup failure after full cleanup completes
Use module_function in Homebrew::Cleanup as we never instantiate the
class
2017-03-31 01:44:04 -05:00
Mike McQuaid
a582be06c2 Merge pull request #2421 from MikeMcQuaid/formula-check-alias-exists
formula: check installed_alias_path exists.
2017-03-30 20:25:05 +01:00
Mike McQuaid
b6792fc7be Merge pull request #2401 from wjlroe/print-pinned-on-outdated
Include the pinned version in brew outdated output for pinned formulae
2017-03-30 20:24:30 +01:00
Mike McQuaid
8472d6a40e formula: check installed_alias_path exists.
Otherwise return `nil`.

Fixes https://github.com/Homebrew/brew/issues/2417
2017-03-30 19:39:26 +01:00
Mike McQuaid
51ca9025a5 formula_installer_spec: add default formula test.
Test the situation where a requirement is satisfied by a non-formula
but the `default_formula` is also installed.
2017-03-29 09:34:52 +01:00
William Roe
996dcdee2c Add pinned version to outdated json output
The structure should be consistent, so there are always pinned and
pinned_version fields even if there are no pinned versions for a given formula.
2017-03-27 11:41:08 +01:00
William Roe
70446d9112 Add pinned version to outdated output 2017-03-27 11:30:36 +01:00
William Roe
755d43d46d Add test for verbose brew outdated output
Split the tests up into quiet and verbose output with contexts.
2017-03-27 11:27:48 +01:00
Gautham Goli
a693ca332e Wrap rubocop specific code into methods inside FormulaCop 2017-03-26 15:26:41 +05:30
Gautham Goli
4e57f4279a Add RSpec tests for bottle_block and formula_desc cops 2017-03-26 15:26:41 +05:30
Mike McQuaid
0cc9d93885 formula_installer: tweak req formula additions.
Rather than just checking if a requirement's dependency is installed or
not check if the requirement was actually satisfied by a particular
formula rather than e.g. just having a `default_formula` defined.
2017-03-25 10:59:54 +00:00
Mike McQuaid
f59eb358c2 missing_formula: subsume historic logic.
These methods belong together so combine them in a single class to
provide a simpler API.
2017-03-20 20:37:12 +01:00
Mike McQuaid
80e95b684e blacklist: move to missing_formula class instead.
This will allow extending this class so it can be used by more than
just blacklisting.
2017-03-20 18:20:31 +02:00
Mike McQuaid
623c95b3f8 cmd/log: improve output messaging.
This wasn’t adapted to the new, multiple repository world.
2017-03-20 18:20:31 +02:00
Zhiming Wang
1c10a6260f Hint at new location of migrated formulae
Partial implementation of
https://github.com/Homebrew/brew-evolution/pull/15, along with the ability to
search for deleted formulae in git history (inspired by #1996) which is not
described in the proposal.

See also: #1371.
2017-03-20 18:20:31 +02:00
Joshua McKinney
437db065ca Be a little less specific in cask output tests
These tests seemed a little over-specified and were failing on the CI
server. Reducing the specificity a little to try to get them to pass.
2017-03-19 19:56:41 -05:00
Joshua McKinney
d11e417105 Hide output from brew cask uninstall test
This test showed extraneous info in the test output
2017-03-19 13:14:16 -05:00
Joshua McKinney
3703ef1885 Show messages when (un)installing Casks
Addresses an issue where it can be unclear at times exactly which part
of the (un|re)installation processes is reporting an error. See
https://github.com/caskroom/homebrew-cask/issues/30968
2017-03-19 13:14:16 -05:00
Markus Reiter
ed10135da4 Replace Hbc.load with CaskLoader.load. 2017-03-16 19:16:42 +01:00
Markus Reiter
d7af864be0 Replace Hbc.path with CaskLoader.path. 2017-03-16 12:10:19 +01:00
Markus Reiter
d1995dad4b Use a Formulary-like approach to load Casks. 2017-03-16 12:10:19 +01:00
Markus Reiter
c4d8b1696c Merge pull request #2309 from axiac/cask-outdated
add command 'cask outdated'
2017-03-16 11:37:49 +01:00
Markus Reiter
2c8544832e Add test for command help strings. 2017-03-16 09:00:57 +01:00
Valentin VĂLCIU
7532545140 add command 'cask outdated' 2017-03-15 22:58:25 +02:00
Mike McQuaid
4d88cc4c41 Merge pull request #2326 from vszakats/sprot
secure urls + remove -k from in-doc curl command
2017-03-15 15:11:35 +00:00
Markus Reiter
e9e6dcf893 Merge pull request #2311 from nath/highlightInstalledCasks
Added highlighting of installed casks to cask search
2017-03-15 14:01:28 +01:00
Viktor Szakats
cc8f029f22 secure urls + remove -k from in-doc curl command 2017-03-14 17:27:11 +00:00
Nath Tumlin
48e4463f5b Fixed test case wording 2017-03-13 19:43:08 -05:00
Nath Tumlin
b42ccece49 Style changes 2017-03-13 19:15:41 -05:00
Nath Tumlin
2080c360e2 Added tests for highlight installed and fixed style errors 2017-03-13 17:52:32 -05:00
Markus Reiter
2b4c3ee1d7 Default to sudo: false for installer/uninstall :script. 2017-03-13 11:38:37 +01:00
Numbermaniac
b704b48b2f Change instances of caskroom.io to caskroom.github.io 2017-03-12 23:23:22 +11:00
Markus Reiter
44d367edca Deprecate #plural. 2017-03-11 21:16:37 +01:00
Markus Reiter
00306a4ced Add test for Formatter::pluralize. 2017-03-11 21:12:51 +01:00
Mike McQuaid
717f68eb36 Merge pull request #2292 from MikeMcQuaid/fix-shallow-clone-tests
test: fix tests with a shallow clone.
2017-03-11 18:37:52 +00:00
Markus Reiter
bb3e509ee0 Merge pull request #2315 from reitermarkus/hombrew-typo
Fix “Hombrew” typo.
2017-03-11 15:46:25 +01:00
Markus Reiter
30a2f270b9 Merge pull request #2303 from reitermarkus/fix-pkg-not-uninstalling-apps
Fix `uninstall :pkgutil` leaving empty `.app` directories.
2017-03-11 12:02:24 +01:00
Markus Reiter
49416d10b7 Fix “Hombrew” typo. 2017-03-11 12:00:35 +01:00
ilovezfs
76db07e1b5 env: make prepend_path ignore system paths
`ENV.prepend_path "PATH", which("emacs").dirname` in the emacs
requirement was causing us to end up invoking /usr/bin/clang instead
of /usr/local/Homebrew/Library/Homebrew/shims/super/clang.
2017-03-11 01:59:50 -08:00
Markus Reiter
642e355b4f Save flags in with_full_permissions. 2017-03-11 10:47:39 +01:00
Markus Reiter
9393b16930 Fix uninstall :pkgutil leaving empty .app directories. 2017-03-11 10:47:39 +01:00
Mike McQuaid
0e30d34d27 test: fix tests with a shallow clone.
In this case `HOMEBREW_VERSION` is `>1.1.0 (no git repository)` so these
tests failed. This was the cause of the Homebrew/homebrew-test-bot
Linux CI failures as it was testing a shallow clone.
2017-03-10 16:16:01 +00:00
Markus Reiter
621b67e531 Refactor artifacts. 2017-03-10 09:44:50 +01:00
Markus Reiter
b38c52f930 Merge pull request #2289 from reitermarkus/cask-refactor-uninstall
Refactor `pkg`, `uninstall`, and `zap` artifacts.
2017-03-08 20:03:56 +01:00