admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
15,907 Commits 15 Branches 471 Tags
Commit Graph

603 Commits

Author SHA1 Message Date
Rafael Kitover
74b18bfe12 put caveats in finish after post_install Homebrew/homebrew#42565 
When running brew -v install, long post_install output from the formula,
presumably from upstream, may hide the important instructions in the
caveats and confuse the user. For example, postgresql runs initdb which
prints its own instructions for running the database, making the caveats
scroll off screen.

Per xu-cheng's instructions in Homebrew/homebrew#42565 :

Remove the explicit call to caveats from the install, reinstall, and
upgrade commands, as well as the dependency installer code in
FormulaInstaller#install_dependency , and call caveats right before the
summary code in FormulaInstaller#finish .

Closes Homebrew/homebrew#42565.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-08-09 20:08:42 +08:00
Xu Cheng
e60dc64828 only run post_install if it's defined 
Closes Homebrew/homebrew#42593.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-08-08 17:50:49 +08:00
BrewTestBot
13d544e11e Core files style updates. 
Closes Homebrew/homebrew#42354.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-08-03 13:22:35 +01:00
Xu Cheng
2ebd1c974b print sandbox message 
Closes Homebrew/homebrew#42293.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-07-31 19:52:36 +08:00
Xu Cheng
8c7b629149 formula_installer: relocate bottle immediately after it's poured 
Closes Homebrew/homebrew#42268.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-07-30 20:11:19 +08:00
Xu Cheng
1845706187 formula_installer: better priority for pour_bottle? 2015-07-24 16:08:44 +08:00
Dominyk Tiller
2751449abb formula_installer: tweak priority of true 
Closes Homebrew/homebrew#41913.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
 2015-07-23 22:29:31 +01:00
Dominyk Tiller
b06af00d76 formula_installer: don't flag fs builds 2015-07-23 22:28:07 +01:00
Xu Cheng
8cebb64eec auto disable sandbox for interactive shell 
Closes Homebrew/homebrew#38792.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-07-22 15:12:15 +08:00
Alex Dunn
da2e4d417d fetch/build formula from source when modified 
closes Homebrew/homebrew#36068

Closes Homebrew/homebrew#41397.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-07-18 19:30:30 -07:00
Xu Cheng
05c0fcb5ee formula_installer: remove duplicated hold_locks check 
It'll be checked inside `FormulaInstaller#unlock` method.

Closes Homebrew/homebrew#41820.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-07-18 13:59:52 +08:00
Jack Nagel
7690a00d04 Stdlib check should use the compiler used to build the bottle 2015-06-27 20:04:45 -04:00
Jack Nagel
f13ac9b0c8 Decouple the local bottle strategy from the formula 2015-06-15 21:32:15 -04:00
Misty De Meo
6d5632cd8f Formula: always print keg_only_text 
Fixes Homebrew/homebrew#40724.

Closes Homebrew/homebrew#40725.

Signed-off-by: Misty De Meo <mistydemeo@gmail.com>
 2015-06-15 08:21:08 -07:00
Mike McQuaid
a631ae1983 formula_installer: don't install runtime dependencies from bottles. 
They haven't been linked against so we don't care.

Closes Homebrew/homebrew#40410.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-06-10 15:25:28 +01:00
Xu Cheng
12f0472a7d formula_installer: use Formula#full_name 2015-05-29 17:02:23 +08:00
Mike McQuaid
fc5070c252 formula_installer: set tap source for bottles. 
This defaults to the value that's in the bottle but that isn't
necessarily correct. For example, some Boxen modules will reuse our
old bottles and so if they are installed from there we should be sure
to set the tab's tap to the tap we've installed from rather than the one
set inside the bottle's tarball.

Closes Homebrew/homebrew#40096.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-05-27 10:21:46 +01:00
Jack Nagel
e04e898d5c Avoid explicit control flow 2015-05-12 20:33:34 -04:00
Jack Nagel
71f4e90cdb Handle deprecated options in dependency specifications 
Fixes Homebrew/homebrew#38069.
 2015-05-11 22:07:14 -04:00
Xu Cheng
272d68740f Use TapFormulaUnavailableError instead of HOMEBREW_TAP_FORMULA_REGEX 
Closes Homebrew/homebrew#39307.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-05-03 22:53:22 +08:00
Jack Nagel
2ca8172fe9 Let the test environment inject its own load path 2015-04-29 19:15:11 -04:00
Jack Nagel
16dfe3dd40 Add Formula#logs 2015-04-25 23:14:05 -04:00
Xu Cheng
adedbb86f1 sandbox: record log 
Closes Homebrew/homebrew#38711.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-04-17 14:09:24 +08:00
Jack Nagel
c2dcd91bd1 Eliminate a place where ARGV is mutated 2015-04-16 22:20:59 -04:00
Xu Cheng
d1617e86d0 sandbox postinstall 
Closes Homebrew/homebrew#38479.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-04-15 19:51:54 +08:00
Xu Cheng
a6be0b5bb8 sandbox: redesign API 2015-04-15 19:51:54 +08:00
Xu Cheng
06f72ab38f move safe_fork into a standalone method 2015-04-15 19:51:54 +08:00
Xu Cheng
2f529220e7 preliminary write control only sandbox 
Closes Homebrew/homebrew#38361.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-04-09 17:42:54 +08:00
Xu Cheng
f5c8e3fdbd Use UNIXSocket to pass file descriptor 
This is a more standard way to pass fd in UNIX world.
At the same time, it helps to remove a few hacks and
simplifies the code in the sandbox.

Closes Homebrew/homebrew#38434.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-04-09 15:31:47 +08:00
Xu Cheng
1539fda3e8 Silently ignore FormulaUnavailableError in check_conflicts 
If the formula name is in full-qualified name. Let's silently
ignore it as we don't care about things used in taps that aren't
currently tapped.

Closes Homebrew/homebrew#38089.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-03-28 13:08:08 +08:00
Xu Cheng
4fccab615f install_plist: create var/log path 
Let homebrew create var/log path to avoid permission problem.

Closes Homebrew/homebrew#37966

Closes Homebrew/homebrew#37967.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-03-23 18:35:58 +08:00
Jack Nagel
cd522b1719 Always respect build options when invoking post_install 
Fixes Homebrew/homebrew#36335.
 2015-02-07 11:02:35 -05:00
Jack Nagel
909a5af075 Omit post-install warning unless formula defines it 
Closes Homebrew/homebrew#34744.
 2015-01-12 21:57:47 -05:00
Jack Nagel
318c103802 Remove unnecessary encoding comments 
These files do not contain any non-ASCII characters.
 2015-01-03 23:44:26 -05:00
Jack Nagel
a52143c63c Remove readline and zlib hacks 2015-01-03 22:39:07 -05:00
Jack Nagel
77a1c6f166 One less external call to #active_spec 2014-12-27 14:26:56 -05:00
Jack Nagel
dd90030213 Fix "possible reference to past scope" warnings on 2.2 2014-12-26 11:58:09 -05:00
Mike McQuaid
85f9883329 formula_installer: don't always post_install. 
We don't want to do so when building bottles or we can end up with some weird stuff being bottled unintentionally (and it'll run twice; once before bottling, once afterwards).

Fixes Homebrew/homebrew#34349.

Closes Homebrew/homebrew#34397.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2014-11-23 21:24:00 +00:00
aereal
91ccd8435c Regard any installation of the formula as conflicts 
Closes Homebrew/homebrew#34159.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2014-11-17 13:30:54 -06:00
Jack Nagel
5d1dc0a5db Revert "Revert "FormulaInstaller: make mode reader methods private"" 
This reverts commit c622f27e525de4a9cc9a209a6cc0e26be60b5919.
 2014-11-03 21:43:11 -06:00
Jack Nagel
e1bfbad810 Make quieter an installer mode 2014-11-03 21:43:11 -06:00
Jack Nagel
3421308bd4 Make git an installer mode 2014-11-03 21:39:11 -06:00
Jack Nagel
34c0b40abf Revert "FormulaInstaller: make mode reader methods private" 
This reverts commit 44bff238434a48c4a8531bc2d1a29c81f18f8fab.

Conflicts:
	Library/Homebrew/formula_installer.rb

Fixes Homebrew/homebrew#33882.
 2014-11-03 18:58:49 -06:00
Jack Nagel
bebfcfe2fd FormulaInstaller: make mode predicate methods private 2014-11-02 19:11:46 -06:00
Jack Nagel
4b2347ef60 FormulaInstaller: make mode reader methods private 2014-11-02 19:11:18 -06:00
Jack Nagel
9a356fc609 Remove FormulaAlreadyInstalledError 
install is the only command that can trigger this warning, so it should
be handled before instantiating the installer.
 2014-10-31 18:33:39 -05:00
Jack Nagel
1a487fa2b3 Add predicate methods for specs and stop testing internals 2014-10-29 23:32:38 -05:00
Jack Nagel
1195718d0e Rename "f" to "formula" in the installer 2014-10-29 22:41:03 -05:00
Jack Nagel
6545e6dad3 Remove unreachable branch 
Requirements meeting this condition are skipped by the first branch
on the caller side:

6c54de812f/Library/Homebrew/formula_installer.rb
 2014-10-29 00:52:23 -05:00
Jack Nagel
f90e303fb9 Test default formula requirements against correct dependent 2014-10-29 00:37:51 -05:00