3352 Commits

Author SHA1 Message Date
Mike McQuaid
59238cd343 commands: tweak find_internal_commands.
Use a more typical Ruby style.
2017-10-20 10:19:11 +01:00
Mike McQuaid
460048bcb6 Merge pull request #3302 from maxim-belkin/readall-multiple-taps
readall: allow readall-ing multiple taps at once
2017-10-20 10:16:32 +01:00
richiethomas
b135a70c57 Fix brew style warnings 2017-10-18 20:21:49 -04:00
richiethomas
e5e84eec7d PR feedback- replace '#{HOMEBREW_LIBRARY}/Homebrew/**/*.rb' with '#{HOMEBREW_LIBRARY_PATH}/**/*.rb' 2017-10-18 18:20:44 -04:00
richiethomas
99bccaae13 Remove /cask/ from readall file filter 2017-10-18 17:44:09 -04:00
Maxim Belkin
ad3886b462
readall: update documentation 2017-10-18 14:50:44 -05:00
Markus Reiter
9bee9ca575 Use “squiggly” heredocs. 2017-10-18 14:39:09 +02:00
Dominyk Tiller
2063e0fc52
commands: filter out dotfiles from output 2017-10-18 11:44:12 +01:00
Mike McQuaid
270b752f5d Merge pull request #3326 from sjackman/portable-ruby
portable-ruby: use rebuild with coverage support for Linux.
2017-10-18 11:04:56 +01:00
Mike McQuaid
1d541804c8 Merge pull request #3316 from DomT4/handle_apfs_love_of_hash_order
Handle APFS returning hash order.
2017-10-18 10:55:22 +01:00
richiethomas
dfaaada8b6 Memoize recursive dependency checks; reduces calls to 'f.recursive_dependencies' by an order of magnitude 2017-10-17 20:52:18 -04:00
Mike McQuaid
d601edaf57 vendor-install: use full shasum PATH.
Otherwise things can explode if there's a random `shasum`.

See #3281.
2017-10-17 20:51:32 +01:00
Shaun Jackman
90ca552ba6 portable-ruby: use rebuild with coverage support for Linux.
This will allow `simplecov` to generate coverage by rebuilding portable
Ruby with coverage support.
2017-10-16 12:26:55 -07:00
Dominyk Tiller
9a323c5107
info: pass explicit sort to handle APFS 2017-10-14 06:44:37 +01:00
Dominyk Tiller
c9684c3727
deps: pass explicit sort to handle APFS 2017-10-14 06:42:53 +01:00
Dominyk Tiller
f1b183b287
list: pass explicit sort to handle APFS 2017-10-14 06:35:33 +01:00
Dominyk Tiller
d9074b80b7
options: pass explicit sort to handle APFS 2017-10-14 06:35:33 +01:00
Dominyk Tiller
795c7170e3
leaves: pass explicit sort to handle APFS 2017-10-14 06:18:49 +01:00
Dominyk Tiller
7b8ba77ed2
missing: pass explicit sort to handle APFS 2017-10-14 06:18:09 +01:00
Dominyk Tiller
35fae7ce6a
tap-info: pass explicit sort to handle APFS 2017-10-14 06:14:27 +01:00
Dominyk Tiller
e308df25a9
commands: pass explicit sort to handle APFS 2017-10-14 04:24:10 +01:00
Dominyk Tiller
ca69d65456
update-report: pass explicit sort to handle APFS 2017-10-14 04:22:22 +01:00
Dominyk Tiller
60eb7c6216
uses: pass explicit sort to handle APFS 2017-10-14 04:17:48 +01:00
Dominyk Tiller
f6bc7dc4c6
search: pass explicit sort to handle APFS 2017-10-14 04:17:03 +01:00
Richie Thomas
9ef82ae1e2 In 'readall.rb', replaced multi-step 'each' loop with one-line method chain of Ruby enumerator methods 2017-10-12 17:38:02 -04:00
Maxim Belkin
4c0e623bd4
readall: allow readall-ing multiple taps at once 2017-10-10 17:54:42 -05:00
Markus Reiter
71b6e239d7 Set RuboCop maximum to current maximum. 2017-10-10 17:00:04 +02:00
Markus Reiter
175ca909ee Clean up code style and remove .rubocop_todo.yml. 2017-10-08 16:10:37 +02:00
Mike McQuaid
bcca2a7c6b brew: handle Ruby 2.3 more gracefully.
- `brew.rb` needed updated to fail unless on Ruby 2.3
- `brew update` should unset `HOMEBREW_RUBY_PATH` to ensure that this
  doesn't "stick" on a Ruby 2.0 version after a portable Ruby has been
  installed.
2017-09-29 19:53:50 +01:00
Maxim Belkin
b8d8049f70
install.rb: stop early if there are no formulae to be installed 2017-09-28 14:17:42 -05:00
Mike McQuaid
a589303616 Merge pull request #3183 from MikeMcQuaid/rubocop-upgrade
Rubocop: 0.50.0 and Ruby 2.3
2017-09-25 21:29:03 +01:00
Mike McQuaid
222da9de1c portable-ruby: use rebuild with coverage support.
This will allow `simplecov` to generate coverage by rebuilding portable
Ruby with coverage support.
2017-09-25 19:15:58 +01:00
Mike McQuaid
9697c8638c vendor-install: output only to stderr.
This avoids causing errors in scripts that call e.g. `brew --prefix`.
2017-09-25 06:53:23 +01:00
Mike McQuaid
cf5fdeef1d Rubocop: manual rule fixes. 2017-09-24 21:23:59 +01:00
Mike McQuaid
01e9ec9a9f Rubocop: automatic rule fixes. 2017-09-24 21:23:59 +01:00
Mike McQuaid
3343467475 Merge pull request #3189 from MikeMcQuaid/portable-ruby-messaging
portable-ruby: improve installation messaging.
2017-09-23 10:58:26 +01:00
Mike McQuaid
aa665b9458 portable-ruby: improve installation messaging.
- Use “Pouring” to be more consistent with our normal messaging.
- Don’t be silent by default.
2017-09-22 15:54:29 +01:00
Shaun Jackman
353810d934 Upgrade vendored Ruby to 2.3.3 for Linux. 2017-09-21 17:02:42 -07:00
Mike McQuaid
7d720e8fac Merge pull request #3164 from MikeMcQuaid/portable-ruby-2.3.3
Upgrade vendored Ruby to 2.3.3.
2017-09-21 15:32:41 +01:00
Mike McQuaid
b2b413165f Upgrade vendored Ruby to 2.3.3.
Use this version whenever 2.3.3 isn't installed. Also, remove the Linux
portable Ruby for now until it's built to be the same version.
2017-09-21 14:27:17 +01:00
Gautham Goli
17e2753053 audit: Use version pinned by brew while executing rubocop cli 2017-09-20 13:26:50 +05:30
Dan Wendorf
acf1b278ae List cask full-names
`brew cask list` supports the `--full-name` flag which will include the tap
name for casks not part of the core caskroom/cask tap. For example, if
cask "foo-beta" is installed from the caskroom/versions cask, `brew cask
list --full-name` will report the name as "caskroom/versions/foo-beta".
2017-09-16 10:00:06 -07:00
Mike McQuaid
ffdda0eb9f Tweaks for older Mac OS X versions.
- `brew update` should try to install `curl` before `git` on older
  versions of Mac OS X where it is needed for accessing modern SSL
  certificates.
- We don't need an HTTP mirror for `git` because `curl` will already be
  installed before it is downloaded.
- Don't recommend GCC on Mac OS X versions where it can't be built with
  the default system compiler.
- Start using the Homebrew `curl` on Mac OS X versions where it is
  needed as soon as it is installed.
2017-09-16 12:41:08 +01:00
Markus Reiter
ae27cd7f79 Always load Cask in brew irb. 2017-09-11 09:09:05 +02:00
Alyssa Ross
b6d36003b3
Always output when tapping core
Hiding all output makes it look like Homebrew is hanging while the tap
operation (which can take a long time!) is running.

Closes #3053.
2017-09-07 12:12:22 +01:00
Mike McQuaid
35de091bae Merge pull request #3111 from alyssais/migrate_empty_homebrew_directory
Don't fail to migrate repo because of empty dir
2017-08-31 19:14:37 +01:00
Alyssa Ross
a6fa2f367b
Don't fail to migrate repo because of empty dir
I just ran into an issue where a colleague's Homebrew couldn't update.
It seems to have been because it failed once just after the new repo
directory was created. Since there was nothing in this directory, there
really isn't any reason for us to fail here, so to avoid this problem in
the future, try to `rmdir` the directory before failing because it already
exists.
2017-08-31 12:17:01 +01:00
Mike McQuaid
f0605f4a30 audit: don't output when searching taps.
This messaging was added for the `brew search` command and having it in
audit is annoying:
(https://github.com/Homebrew/brew/pull/3059#issuecomment-323638672)

As a side note: this is why randomly including `cmd/*` is a bad idea.
2017-08-23 18:40:30 +01:00
Viktor Szakats
b44c7a1022 upgrade more urls to https 2017-08-22 10:31:21 +00:00
Markus Reiter
3b92f69869 Merge pull request #3054 from BenMusch/github-refactor
Clean-up code in GitHub module to reduce duplication & coupling w/ Github API
2017-08-18 16:26:30 +02:00