442 Commits

Author SHA1 Message Date
Mike McQuaid
7095738d1d Remove config/doctor checks we no longer need
A bunch of these were needed before superenv, environment filtering or
on now long-unsupported versions of macOS.
2018-04-02 09:40:39 +01:00
EricFromCanada
1d2b4ed321 docs: add more missing option descriptions
and improve wording or formatting where necessary.
2018-02-01 16:06:17 -05:00
Mike McQuaid
5f471ee289 doctor: tell people not to file issues.
This stuff doesn't matter.
2017-12-11 15:27:18 +00:00
Markus Reiter
9bee9ca575 Use “squiggly” heredocs. 2017-10-18 14:39:09 +02:00
Markus Reiter
cafe149780 Merge pull request #1145 from reitermarkus/module-function
Use `module_function` for `Homebrew` module.
2016-10-04 10:31:49 +02:00
Markus Reiter
0ab750bf24 Use module_function for commands. 2016-10-02 00:24:47 +02:00
Markus Reiter
75e8b59aad Add Formatter module. 2016-10-01 20:00:49 +02:00
Markus Reiter
6d8ee395fa Refactor Tty. 2016-10-01 20:00:49 +02:00
Mike McQuaid
2405c3e205 doctor: remove outdated Homebrew check.
This is no longer relevant in the bright, new tagged future.

Fixes #1151.
2016-09-26 12:13:18 +01:00
Mike McQuaid
c45e36ffde cmd/doctor: fix Rubocop warnings. 2016-09-11 17:58:59 +01:00
Mike McQuaid
984ed836bd doctor: print check on --debug. 2016-08-16 11:16:37 +01:00
Andrew Janke
a3b70d38a7 brew-audit: pull style checks in to main audit output
This collects all violations for each formula in a single place, instead
of doing `brew style` outputs for all formulae first, and then the other
audit checks.

Closes #112.

Signed-off-by: Andrew Janke <andrew@apjanke.net>
2016-04-21 14:45:33 -04:00
Max Nordlund
fa1fd70a37 Add all the top level comments 2016-04-10 22:59:25 +02:00
Martin Afanasjew
bcedfe64e8 doctor: simplify handling of slow checks
Some (rather slow) checks should run after all other checks. Make that
more obvious by removing them from the sorted list of all checks and
then re-appending them to the resulting list. (Should be slightly more
efficient than the `<array>.reverse.uniq.reverse` incantation, though
that hardly matters given the cumulated run time of all the checks.)

Slightly extend the list after verifying what the slowest checks are for
various Homebrew installations (slowest check last).

Closes Homebrew/homebrew#47753.

Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
2016-01-09 18:52:41 +01:00
Baptiste Fontaine
0472b3f340 doctor: use respond_to? instead of NoMethodError
Closes Homebrew/homebrew#47715.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
2016-01-05 17:51:54 +01:00
Baptiste Fontaine
9f1442db14 doctor: move code away from cmd/
Closes Homebrew/homebrew#47665.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
2016-01-05 14:33:06 +01:00
Dominyk Tiller
dafa11af9a doctor: add explicit anaconda warning
Closes Homebrew/homebrew#47540.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
2016-01-04 17:22:53 +00:00
Dominyk Tiller
821dbab5f8 doctor: extend curl warning 2016-01-04 03:10:10 +00:00
Baptiste Fontaine
169b8fc039 Revert "minor perf improvements"
This reverts commit 16a2a8274a7808e63a6c78475e12a7c0ef5812ef.
2015-12-26 23:00:38 +01:00
Baptiste Fontaine
48681c3f3a minor perf improvements
Closes Homebrew/homebrew#47224.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
2015-12-26 22:58:26 +01:00
Joao Antunes
61a47a4c0f doctor: check_access_usr_local mention Cocktail.
Added mention to Cocktail app cleanup/repair/optimizations, that has
some features that when run they restore the /usr/local directory to
the original 'not writable' state in OS X 10.11 .

Closes Homebrew/homebrew#47379.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-12-26 07:37:44 +00:00
Misty De Meo
a8476c0dbe doctor: remove Xcode 7 on 10.10 warning 2015-12-07 13:17:43 -08:00
Xu Cheng
2f50d3a279 doctor: use installed_prefixes 2015-11-29 20:24:30 +08:00
Dominyk Tiller
c7b0173688 doctor: tweak tmp sticky bit check 2015-11-04 12:53:31 +00:00
Dominyk Tiller
85469b99b1 doctor: fix typo
Fixes Homebrew/homebrew#45623.
2015-11-02 21:04:03 +00:00
Dominyk Tiller
7d0c57cc9e doctor: whitelist Paragon ExtFS dylib 2015-11-02 18:27:13 +00:00
Dominyk Tiller
8acac5aa71 doctor: unify chown messages
Closes Homebrew/homebrew#45398.
2015-10-30 18:42:19 +00:00
Ben White
f7e649831d doctor: Fix typo in uncommitted modifications warning message
Closes Homebrew/homebrew#45443.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
2015-10-29 13:34:36 +01:00
Martin Afanasjew
30cad0608f os: centralize check for pre-release OS X versions
Provide `OS::Mac.prerelease?` for pre-release checks and use it where
appropriate. This should simplify updating the test once a new OS X
release lands.

This also fixes a bug in `BuildError#dump`, where an empty warning
message was printed on El Capitan after a failed from-source build,
because the check there and the one in `check_for_unsupported_osx` were
out of sync.

Closes Homebrew/homebrew#45257.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-10-23 12:34:44 +01:00
Xu Cheng
ee332c4550 handle TapFormulaWithOldnameAmbiguityError
Closes Homebrew/homebrew#44705.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-10-08 16:02:33 +08:00
Dominyk Tiller
bdd27d7cc0 doctor: whitelist Paragon NTFS dylib
Closes Homebrew/homebrew#44542.
2015-10-02 23:43:14 +01:00
Charlie Egan
a90363b605 doctor: minor grammar correction: 'pluralize' breakage
Closes Homebrew/homebrew#44497.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
2015-10-02 19:06:05 +02:00
Xu Cheng
6b3704162f doctor: point Xcode download to App Store for El Capitan 2015-10-01 14:39:25 +08:00
Xu Cheng
6240e896b2 doctor: always print to stderr
This can help to solve the broken layout of doctor.out in brew gist-logs
2015-09-30 16:20:18 +08:00
Xu Cheng
30795ddc29 doctor: temporary add -R flag in chown instruction
Will replace it when we implemented `brew repair-permission`
2015-09-30 13:55:32 +08:00
Xu Cheng
ff132a9ddb doctor: add check_access_homebrew_repository 2015-09-30 13:54:04 +08:00
Xu Cheng
3c54d12cec doctor: official supporting El Capitan 2015-09-30 13:54:04 +08:00
Dominyk Tiller
359cdafb86 doctor: don't false-flag sdk with clt 2015-09-18 15:55:21 +01:00
Dominyk Tiller
722a43aabe doctor: add xcode 7 SDK check 2015-09-18 15:11:48 +01:00
Xu Cheng
c8efb05826 doctor: use Utils.git_available? instead of git? 2015-09-09 12:21:08 +08:00
Xu Cheng
bff03ee5ba doctor: use Homebrew.git_origin 2015-09-09 12:19:17 +08:00
Mike McQuaid
adc077f188 doctor: don't always fail on 10.11.
Do this just for Homebrew developers (and the bot) currently.
2015-09-07 15:06:11 +01:00
Xu Cheng
488aa19d8f doctor: use inject_file_list
Also simplify the condition branch by early return

Closes Homebrew/homebrew#43574.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-09-06 20:02:31 +08:00
Dominyk Tiller
c992749986 doctor: add system curl <10.7 check
Closes Homebrew/homebrew#43283.

Closes Homebrew/homebrew#43298.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
2015-08-26 23:56:10 +01:00
Dominyk Tiller
94bb92b4c1 doctor: add check for SSL_CERT_DIR
Closes Homebrew/homebrew#43154.

Closes Homebrew/homebrew#43277.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
2015-08-26 17:30:36 +01:00
Xu Cheng
a88c40b8c8 core file style update 2015-08-22 13:15:33 +08:00
Misty De Meo
727239e12f Merge bottle install without Xcode branch
Merge branch 'bottle_hooks'
2015-08-21 11:04:22 -07:00
William Woodruff
04a0b2aafe Mark TODO in brew doctor (future PR) 2015-08-21 11:02:33 -07:00
Baptiste Fontaine
8ba0fb9fcf unnecessary calls to .select simplified
These are minor perf optimizations.

Closes Homebrew/homebrew#43028.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
2015-08-18 00:18:22 +02:00
Baptiste Fontaine
3d7c38c736 doctor: suggest to install git if the system one is outdated
Closes Homebrew/homebrew#42934.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
2015-08-14 12:06:57 +02:00