628 Commits

Author SHA1 Message Date
Markus Reiter
84b2276fd8 Use guard clauses. 2016-11-13 23:00:47 +01:00
Markus Reiter
8241bbb15b Merge pull request #1475 from reitermarkus/fix-locations
Fix `Hbc::Locations` in tests.
2016-11-11 13:43:38 +01:00
Markus Reiter
8fea516dcd Merge pull request #1481 from reitermarkus/sudo-askpass
Support `SUDO_ASKPASS` environment variable in `brew cask`.
2016-11-11 10:56:05 +01:00
Markus Reiter
0b8a8cce28 Support SUDO_ASKPASS environment variable. 2016-11-11 00:30:05 +01:00
Mike McQuaid
c2815fbb9a Merge pull request #1381 from adzenith/patch-1
`brew doctor` recommends using cask to upgrade XQuartz
2016-11-10 21:05:21 +00:00
Markus Reiter
a0f9963391 Disallow running brew cask as root. 2016-11-10 15:01:29 +01:00
Markus Reiter
8dd8273d5e Remove unnecessary Hbc::Locations aliases. 2016-11-10 14:48:53 +01:00
Nikolaus Wittenstein
969ac3a9c6 brew doctor recommends using cask to upgrade XQuartz
Also changes exceptions.rb to use Formatter.url
2016-11-09 22:21:21 -05:00
Dorian
702d07917e Update the CaskAlreadyInstalledError with new reinstall command
e.g. this changes:

```
To re-install google-chrome, run:
  brew cask uninstall --force google-chrome && brew cask install google-chrome
```

To:

```
To re-install google-chrome, run:
  brew cask reinstall google-chrome
```
2016-11-09 15:08:12 +01:00
Mandar Gokhale
0e15ffff62 Correct a few typos
...and update man pages where applicable
2016-11-03 12:09:44 +00:00
Josh Hagins
2605521ca9 Merge pull request #1361 from jawshooah/cask/refactor-auditor
hbc/auditor: refactor and fix bug
2016-10-29 11:40:39 -04:00
buo
6a406763f3 Open incomplete download in append mode
Open the incomplete download in append mode instead of write mode.
Opening in write mode truncates the existing file, so curl keeps
restarting downloads instead of resuming the incomplete downloads.
2016-10-25 16:46:59 +09:00
Josh Hagins
3f3fa4d0f7 Merge pull request #1334 from jawshooah/cask/fix-tap-regex
hbc/qualified_token: simplify token parsing
2016-10-24 10:38:02 -04:00
Josh Hagins
b2870c2480 hbc/qualified_token: use regex captures instead of String#split 2016-10-24 09:50:33 -04:00
Josh Hagins
4ed51d8240 hbc/auditor: refactor and fix bug
Use instance methods to DRY things up, and fix a bug discovered in
caskroom/homebrew-cask#26067 where Casks with language blocks would
always fail audit.
2016-10-24 04:27:21 -04:00
Josh Hagins
b481ed73a0 Merge pull request #1252 from niw/fix_cask_command_changes_entire_directory_ownership
FIX: cask changes /usr/local ownership recursively
2016-10-24 01:21:08 -04:00
Josh Hagins
606a762344 Merge pull request #1248 from Git-Jiro/add_reinstall_cmd_to_cask
add cask reinstall command
2016-10-24 01:11:48 -04:00
Josh Hagins
44f1354d63 hbc/qualified_token: simplify token parsing
- Stop supporting archaic "user-repo/token" syntax
- Move regex for parsing tapped Cask token to tap_constants
2016-10-23 21:48:11 -04:00
Josh Hagins
512a0c950e Merge pull request #1355 from reitermarkus/fix-depends-on-test
Fix locally failing `depends_on` test.
2016-10-23 21:42:48 -04:00
Markus Reiter
c7a535de22 Refactor Hbc::UrlChecker test. 2016-10-23 22:58:01 +02:00
Markus Reiter
7cae29d3d7 Fix locally failing depends_on test. 2016-10-23 21:22:38 +02:00
Martin Schimandl
95d4a25891 Fix linting errors 2016-10-23 20:39:53 +02:00
Eitot
0b176f9cc8 Add dictionary artifact 2016-10-23 17:43:06 +02:00
Markus Reiter
cb8af6d751 Fix failing test caused by repo_info. 2016-10-23 17:07:29 +02:00
Markus Reiter
8d15bddedb Auto-correct block delimiters. 2016-10-23 14:44:14 +02:00
Markus Reiter
8c488de3f6 Remove unnecessary string interpolation. 2016-10-23 14:32:34 +02:00
Markus Reiter
ceec5a82c1 Use guard clauses. 2016-10-23 14:32:04 +02:00
Markus Reiter
9f513cc60c Remove redundant selfs. 2016-10-23 14:32:04 +02:00
Markus Reiter
ad8ae33c1f Fix spacing and indentation. 2016-10-23 14:32:04 +02:00
Markus Reiter
2b7e6c1dcb Don’t use %i literal. 2016-10-23 14:32:04 +02:00
Markus Reiter
ae7b944238 Align end with beginning of line where if/unless is. 2016-10-23 14:32:03 +02:00
Markus Reiter
8e9eae695a Use () as delimiters for %Q and %q literals. 2016-10-23 14:32:03 +02:00
Markus Reiter
1a0f8b8a02 Use slash-delimited regular expressions. 2016-10-23 14:32:03 +02:00
Markus Reiter
40b7e36746 Use 0-only prefix for octal numbers. 2016-10-23 14:13:16 +02:00
Martin Schimandl
31fb996800 Remove unncessary semicolon 2016-10-23 09:57:28 +02:00
Josh Hagins
3bc2c2d087 hbc/cli/list: don't print empty line if nothing to list 2016-10-19 22:15:03 -04:00
Josh Hagins
32f2231cdf hbc/cli/list: don't require Caskroom to be initialized 2016-10-19 22:15:03 -04:00
Josh Hagins
f79cb2ba30 Merge pull request #1325 from vin047/numbered-usernames
fix 'cask info' for external repos with numbers
2016-10-19 20:44:55 -04:00
Markus Reiter
fb29a31c72 Merge pull request #1320 from reitermarkus/which-lsar
Also use `which` to find `lsar` in PATH.
2016-10-19 22:01:06 +02:00
Yoshimasa Niwa
60c4328a17 Use Ruby 2.x style for named arguments. 2016-10-19 11:14:30 -07:00
Josh Hagins
c18441e81b Merge pull request #1315 from jawshooah/cask/load-only-rb
hbc/locations: arg is file only if absolute or .rb file
2016-10-19 12:36:42 -04:00
Markus Reiter
1e92f997c1 Also use which to find lsar in PATH. 2016-10-19 18:20:34 +02:00
Vinoth Ramiah
154237ba8e fix 'cask info' for external repos with numbers
fixes 2 issues: error when username has a number, correct url for repos not on github
2016-10-19 14:59:57 +01:00
Josh Hagins
d08f61a704 Merge pull request #1317 from reitermarkus/refactor-rubocop-cask
Refactor `brew cask style` not to require `.rubocop.yml`.
2016-10-18 19:22:12 -04:00
Josh Hagins
b4fc4acc09 hbc/locations: arg is file only if absolute or .rb file
Handle the case when an argument passed to `brew cask` is both the name
of a Cask and a non-Cask file in the current working directory.

Fixes https://github.com/caskroom/homebrew-cask/issues/25611.
2016-10-18 19:19:33 -04:00
Markus Reiter
6e1c132f99 Remove Cask’s which method. 2016-10-18 17:22:08 +02:00
Markus Reiter
8d83516577 Look for container extraction programs in PATH. 2016-10-18 17:17:19 +02:00
Markus Reiter
143c3ac5c8 Force the use of rubocop-cask’s default configuration. 2016-10-18 16:40:25 +02:00
Markus Reiter
3a22aff1b6 Refactor brew cask style not to require .rubocop.yml. 2016-10-18 16:39:08 +02:00
Naren
5f2929788c following to follow 2016-10-18 09:52:55 -04:00