39 Commits

Author SHA1 Message Date
Issy Long
8319c8f9b9
Make audit_casks return [path, { errors:, warnings:}] for CI
- This was failing but only in CI because the annotations require
  "errors" and "warnings" hash elements. Since formulae have this
  despite formulae not having warnings (probably for compatibility with
  casks), I decided to reinstate `errors` and `warnings` hash for Casks
  _right at the end_ and we can clean this up another time (famous last
  words).
2023-04-07 14:31:12 +01:00
Issy Long
d636d2de37
Apply suggestions from review comments
- Rename `strictish` to `strict_only` in `add_error` method.
- Return just `errors`, a Set, not `{ errors: errors }`, a Hash,
  from `Auditor.audit`.
2023-04-06 00:10:28 +01:00
Issy Long
2b8127d518
Turn cask warnings into errors when --strict is passed (or implied)
- Ignore them and don't show them otherwise.
- Part three of issue 15074:
  > As a result, I propose that all current cask audit warnings are never
  > displayed as warnings but the underlying audit checks turned into
  > errors displayed only with --strict (or one of the other relevant
  > flags).
2023-04-01 01:56:46 +01:00
Issy Long
a4e8f9e22b
audit: Make --display-failures-only the default for Casks
- Cask warnings are really noisy and numerous. Let's only show them if
  the user passes `--strict` or something implying `--strict`, like
  `--new-cask`.
- Additionally remove `display_passes` since we would like silence if
  nothing is wrong with the cask, the same as with formula audits.
2023-04-01 01:56:45 +01:00
Markus Reiter
bdd6523ce8
Deprecate appcast. 2023-03-30 03:29:06 +02:00
Markus Reiter
b821a00bc5
Pass only and except to cask audits. 2023-02-08 08:38:32 +01:00
Sean Molenaar
e90371f8ab
cask: add audit for incorrect signing 2022-08-11 09:11:29 +02:00
Rylan Polster
2e6b6ab3a2
Fix style 2021-12-24 21:15:21 -05:00
Markus Reiter
72a79d934e
Fix audit annotations for casks. 2021-04-03 04:27:32 +02:00
Rylan Polster
2b8d19e0bd
audit: limit non-failure cask output 2021-03-22 22:16:54 -04:00
Bo Anderson
8e98ce69f3
Stricter handling of CLI args 2021-03-18 16:41:57 +00:00
Mike McQuaid
d6957a3acb
Homebrew 3.0.0 deprecations/disables 2021-01-29 19:50:24 +00:00
Mike McQuaid
d8a5e467e8
audit: quieten down and make casks audit consistent with formulae.
The current casks audit is very noisy in the no-op case (i.e. no errors)
https://github.com/Homebrew/brew/pull/10234/checks?check_run_id=1655630568#step:15:7

This means when there are errors and you're querying all casks it's
pretty hard to quickly identify the problems.

This commit silences the `passing`, `warning` and header/summary output
when you're querying all casks (rather than a specific cask or tap).

This is more consistent with `brew audit` for formulae which is silent
unless there are audit failures.
2021-01-07 13:31:14 +00:00
Markus Reiter
24cef5c2ce Support casks in brew audit. 2020-11-18 13:21:49 +01:00
Markus Reiter
e54e719e38 Add Cask::Cmd::Audit.audit_casks method. 2020-11-18 10:25:32 +01:00
Markus Reiter
1b732ec7b2 Fix RuboCop offenses. 2020-11-16 02:05:29 +01:00
Rylan Polster
50890ebd51 fix Lint/DuplicateBranch style 2020-11-16 02:02:52 +01:00
Markus Reiter
da9289eff0 Add more type signatures. 2020-11-13 12:26:36 +01:00
Markus Reiter
24ae318a3d Move type annotations into files. 2020-10-10 14:59:39 +02:00
Markus Reiter
5f005f67cf Refactor global Cask::Config. 2020-10-01 00:57:10 +02:00
Markus Reiter
141be12234 Allow passing tap to brew cask audit. 2020-09-24 23:32:17 +02:00
Markus Reiter
b72e7ee34d Only treat cask audit warnings as errors if --strict is passed. 2020-09-14 13:12:38 +02:00
Markus Reiter
769fa066e2 Output annotations for brew cask audit. 2020-09-09 21:50:32 +02:00
Markus Reiter
7c05b2f231 Support --no-appcast for brew cask audit. 2020-09-04 04:47:31 +02:00
Markus Reiter
e5b56e485f Move cask audit implications into Audit. 2020-09-04 04:47:31 +02:00
Markus Reiter
8fc4ac0ad7 Document Cask::Cmd. 2020-08-26 03:13:59 +02:00
Bo Anderson
e3372e2a14 Lazily require some heavy files 2020-08-20 02:05:17 +01:00
Vítor Galvão
eb095eb899 Cask audit help: breakup desc string 2020-08-18 16:21:23 +01:00
Markus Reiter
b48bc316e0 Use CLI::Parser for cask commands. 2020-08-13 05:15:15 +02:00
Markus Reiter
8a32954940 Move cask/all to just cask. 2020-08-09 01:34:07 +02:00
Markus Reiter
5cf7ffd93e Make Cask::Auditor return a Hash with warnings and errors. 2020-07-28 09:50:15 +02:00
Sean Molenaar
3567892802
Add notibility checks for casks 2020-05-26 14:21:25 +02:00
Julian Mayer
a061a8d9f7 add optional checking whether appcast contains the version stanza to "brew cask audit" 2019-05-07 17:06:54 +02:00
Mike McQuaid
36dbad3922
Add frozen_string_literal to all files. 2019-04-20 13:27:36 +09:00
Mike McQuaid
737b84b54b
brew style --fix fixes. 2018-11-02 17:29:23 +00:00
Markus Reiter
e9b9ea49a1 Update to RuboCop 0.59.1. 2018-09-17 03:45:59 +02:00
Markus Reiter
a84a1c63db Rename Hbc module to Cask. 2018-09-06 09:30:52 +02:00
Mike McQuaid
1ae2326984
Rename Cask::CLI to Cask::Cmd. 2018-09-04 09:56:58 +01:00
Mike McQuaid
1d86d7a7c7
cask: move cask/cli to cask/cmd. 2018-09-04 09:56:57 +01:00