- flip the messaging to refer to `HOMEBREW_NO_INSTALL_FROM_API` where relevant
- remove some duplicate checks
- better scope checks to just core tap formulae
Currently we only check for closed PRs in
`bump-cask-pr`. This adds that check to `bump`
and `bump-formula-pr`. The idea is that this
check can warn users about already updated
packages or those that can't be updated
easily and should be updated manually instead.
Before this change, this would fail every time, even when available on
disk (which was not the case for formulae).
With this change, it will attempt to find it from a tap on disk and only
fail if it cannot be found in any.
This allows us to remove all the manual timestamp fiddling and lets
`gnu-tar` handle it for us instead (as-per the most recent
recommendations on https://reproducible-builds.org/docs/archives/).
- Change name of rubocop warning
- Disable linting on remaining offending lines
- Add todos to move lines with disabled linting
checks to extend/os in the future
- I was wondering why `brew bump` PRs have descriptions with both commands, like:
```
Created with `brew bump`.
---
Created by `brew bump-formula-pr`.
```
- Then I read the code and realised that "append" was the wrong word for the
`--message` arg description.
- Turns out we do need this. I lulled us into a false sense of security
by not deleting `sorbet/rbi/hidden-defintions/hidden.rbi` previously.
- If we do delete that file then Sorbet reveals >200 typechecking
issues.
- The docs on moving from `srb rbi` to `tapioca` say that we don't need
`hidden-definitions` anymore, but clearly we do. The blog post goes
into a lot of detail on why `rbi hidden-defintions` exists and the
fact that there's not an analogous command in Tapioca:
https://sorbet.org/blog/2022/07/27/srb-tapioca#whats-happening-with-srb-rbi-hidden-definitions
- Eventually we should try out `tapioca dsl`, since that's said to be a
"partial replacement" for `hidden-definitions`, and removing our
reliance on deprecated commands can only be a good thing?
- This was done with `brew typecheck --update --suggest-typed` which
(as of the previous commit) uses Spoom, yet another gem. I thought I'd
see how well it works. There are no Sorbet errors after these changes!
