Issy Long
d636d2de37
Apply suggestions from review comments
...
- Rename `strictish` to `strict_only` in `add_error` method.
- Return just `errors`, a Set, not `{ errors: errors }`, a Hash,
from `Auditor.audit`.
2023-04-06 00:10:28 +01:00
Carlo Cabrera
87373ff12a
Move more code out of dev-cmd
2023-04-06 02:13:15 +08:00
Carlo Cabrera
ffcc4cd75f
Merge remote-tracking branch 'origin/master' into test-runners
2023-04-05 23:55:01 +08:00
Mike McQuaid
61efc7076d
Merge pull request #15156 from dduugg/enable-types
2023-04-05 15:43:53 +01:00
Douglas Eichelberger
c5ffec1a11
Enable types in dev-cmd, etc.
2023-04-04 22:23:46 -07:00
Douglas Eichelberger
a237a1ff9f
Update call sites
2023-04-04 18:14:54 -07:00
Carlo Cabrera
868f9395b6
Extract code to GitHubRunnerMatrix
class
...
The `GitHubRunnerMatrix` takes a list of testing formulae, deleted
formulae, and the available runners and constructs the matrix of active
runners for any given test job.
2023-04-05 03:52:26 +08:00
Carlo Cabrera
49e8d088ae
Move TestRunnerFormula
class into a separate file
2023-04-05 01:18:11 +08:00
Carlo Cabrera
26726adc21
determine-test-runners: refactor
...
This supports extraction into separate modules/files.
2023-04-05 01:09:56 +08:00
Issy Long
53a17b921f
Make --display-failures-only
help hidden as it's deprecated
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2023-04-04 17:17:19 +01:00
Carlo Cabrera
5194e5c65e
Check for --eval-all
before using HOMEBREW_EVAL_ALL
2023-04-05 00:03:58 +08:00
Carlo Cabrera
a4ebb96fe6
Remove MacOS
definition from generic OS
...
We don't want to define `MacOS` in the generic OS, so let's make sure we
refer to it as `OS::Mac` in the places we need it.
This reverts commit 575cb0263cb1428c63b9428bbd913ffde83bd317.
2023-04-04 23:10:51 +08:00
Carlo Cabrera
506f6c81a7
Support --dependents
flag on macOS
2023-04-04 16:20:37 +08:00
Mike McQuaid
7b336ed8cd
Revert "Split prof gems into their own group"
2023-04-04 08:49:27 +01:00
Carlo Cabrera
c125079d0f
determine-test-runners: allow usage on macOS without --dependents
2023-04-04 13:54:35 +08:00
Douglas Eichelberger
f3a8241e69
Remove useless T.unsafe wrappers
2023-04-03 17:34:39 -07:00
Carlo Cabrera
45fdbbd1c1
determine-test-runners: add type-checking
2023-04-03 22:27:46 +08:00
Carlo Cabrera
89cd55c287
dev-cmd/determine-test-runners: add command to set test runners
...
This is based on feedback from Homebrew/homebrew-core#127236 .
2023-04-03 20:36:45 +08:00
Mike McQuaid
aa894fbfcd
Merge pull request #15127 from issyl0/tap-workflows-bump-actions-cache-version
...
dev-cmd/tap-new: Use `actions/cache@v3` as v1 is very deprecated
2023-04-03 08:47:16 +01:00
Mike McQuaid
830ec2847b
Merge pull request #15114 from dduugg/ignorable-type
...
Enable typing in Ignorable
2023-04-03 08:37:34 +01:00
Issy Long
09ce7a1da6
dev-cmd/tap-new: Use actions/cache@v3
as v1 is very deprecated
...
- We forgot about this workflow when we bumped the versions of our
actual workflows as part of issue 14692.
2023-04-02 15:43:24 +01:00
Issy Long
a4e8f9e22b
audit: Make --display-failures-only
the default for Casks
...
- Cask warnings are really noisy and numerous. Let's only show them if
the user passes `--strict` or something implying `--strict`, like
`--new-cask`.
- Additionally remove `display_passes` since we would like silence if
nothing is wrong with the cask, the same as with formula audits.
2023-04-01 01:56:45 +01:00
Ruoyu Zhong
e3eb632034
dev-cmd/bump-cask-pr: fix sha265
typo
2023-04-01 01:07:21 +08:00
Markus Reiter
244359f314
Merge pull request #15088 from reitermarkus/cask-commit-format
...
Make `bump-cask-pr` commit format more concise.
2023-03-31 17:45:53 +02:00
Douglas Eichelberger
7dcabd466e
Remove unnecessary T.let
2023-03-31 08:38:02 -07:00
Bo Anderson
8bafbcd65a
Split prof gems into their own group
2023-03-31 13:32:38 +01:00
Mike McQuaid
0d17bbbec6
Merge pull request #15104 from dduugg/enable-io-types
...
Enable IO and UpdateTest types
2023-03-31 09:12:25 +01:00
Nanda H Krishna
b8fb963516
dev-cmd/tests: temporary fix for BuildPulse failure
2023-03-31 03:50:05 -04:00
Douglas Eichelberger
f9e512bf83
Enable update-test types
2023-03-30 17:31:07 -07:00
Douglas Eichelberger
4f5fc770f6
rm popen sigs
2023-03-30 17:22:02 -07:00
Douglas Eichelberger
80091b8a58
Fix tests
2023-03-30 16:39:10 -07:00
Douglas Eichelberger
15582dd031
Add Utils popen sigs, enable IO types
2023-03-30 16:39:10 -07:00
Markus Reiter
593c37de26
Merge pull request #15085 from reitermarkus/appcast
...
Deprecate `appcast`.
2023-03-31 00:13:08 +02:00
Markus Reiter
71e0d9c382
Make bump-cask-pr
commit format more concise.
2023-03-30 20:04:21 +02:00
Mike McQuaid
a969ac9a94
Merge pull request #15092 from carlocab/dispatch-build-bottle-cleanup
...
dispatch-build-bottle: cleanup
2023-03-30 14:02:17 +01:00
Mike McQuaid
7e09a612c4
Merge pull request #15086 from issyl0/buildpulse-system-cmd
...
dev-cmd/tests: Deal with `TODO` for a BuildPulse bug that's fixed
2023-03-30 08:52:04 +01:00
Carlo Cabrera
c1b4473ed0
dispatch-build-bottle: cleanup
...
The `upload` input will be made into a boolean in
Homebrew/homebrew-core#127026 .
`linux_wheezy` is no longer a valid input to the workflow, so let's get
rid of that.
2023-03-30 13:37:08 +08:00
Carlo Cabrera
0314d73d67
dev-cmd/pr-*: remove --commit-bottles-to-pr-branch
...
This will be made the default by Homebrew/homebrew-core#127021 .
Additionally, branch protection rules will make it so that attempting to
push to master will fail, so we may as well not have to carry this flag
around.
2023-03-30 11:11:15 +08:00
Markus Reiter
bdd6523ce8
Deprecate appcast
.
2023-03-30 03:29:06 +02:00
Issy Long
a480982e75
dev-cmd/tests: Deal with TODO
for a BuildPulse bug that's fixed
...
- This does what the comment told us to do, use the bang variant of
`system_command` to not swallow the errors.
2023-03-29 20:54:42 +01:00
Mike McQuaid
f4ee196f90
Merge pull request #15082 from scientificworld/master
...
bump-*-pr: fix an issue when using on taps with custom remote
2023-03-29 16:13:39 +01:00
scientificworld
8589ca8d40
bump-*-pr: fix an issue when using on taps with custom remote
2023-03-29 20:05:16 +08:00
Carlo Cabrera
08fb8e441f
dev-cmd/pr-pull: add debug output for merge base
2023-03-29 17:56:05 +08:00
Carlo Cabrera
1ed8b3db2f
dev-cmd/pr-pull: handle non-cherry-picked commits in #autosquash!
2023-03-29 17:13:07 +08:00
Carlo Cabrera
df7331f638
Remove reference to nonexistent --clean
flag
2023-03-29 00:17:49 +08:00
Carlo Cabrera
b26d92ca9a
🐛 fixes
2023-03-28 23:07:03 +08:00
Carlo Cabrera
e462b59f7c
pr-automerge: pass --commit-bottles-to-pr-branch
by default
2023-03-28 22:20:09 +08:00
Carlo Cabrera
46ac052b3b
dev-cmd/pr-automerge: skip PRs labelled CI-published-bottle-commits
...
This is based on feedback from @plinnane on Slack.
2023-03-28 22:20:09 +08:00
Carlo Cabrera
f0272b0944
dev-cmd/pr-pu{ll,blish}: handle PRs with an autosquash label
...
- request `autosquash` from the publish job in `pr-publish` if the PR is
labelled with `autosquash`
- show a warning in `pr-pull` if called without `--autosquash` on a PR
with the autosquash label.
2023-03-28 22:20:05 +08:00
Carlo Cabrera
76833dfe40
dev-cmd/pr-publish: support new workflow inputs
...
This allows us to use the new options without needing to use the GitHub
UI.
2023-03-28 22:14:39 +08:00