21382 Commits

Author SHA1 Message Date
Lionell Loh Jian An
5b3530b23d
Apply suggestions from code review
Code review changes

Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2020-06-30 22:11:36 +08:00
Lionell
da2a426ec8 update-license-data: use curl_download instead of curl 2020-06-30 15:18:10 +08:00
lionellloh
4dcbe8790f update-license-data: use of unlink to remove existing file 2020-06-30 01:29:45 +08:00
lionellloh
0ea6245094 Revert "Pathname::write: allow optional override"
This reverts commit 93d46c6d6c69d5279404bce211cb2f48120076f9.
2020-06-30 01:28:58 +08:00
lionellloh
5b3ac1fcb2 update-license-data: modify arguments when calling methods 2020-06-30 01:14:05 +08:00
lionellloh
02bc870e91 curl: modified curl to allow optional print_stdout 2020-06-30 01:13:02 +08:00
lionellloh
074f66f912 write .stdout instead of SystemCommand::Result 2020-06-30 01:08:29 +08:00
lionellloh
93d46c6d6c Pathname::write: allow optional override 2020-06-30 01:08:09 +08:00
lionellloh
7d4fadc2bb Update man pages 2020-06-30 01:06:59 +08:00
Lionell Loh Jian An
da007134c4
Apply suggestions from code review
Code review changes

Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2020-06-29 16:20:07 +08:00
Lionell
688a9ade0d change .nil? to .blank? 2020-06-29 16:12:05 +08:00
Lionell
5f6917ae7c Merge branch 'master' into license 2020-06-28 02:07:53 +08:00
lionellloh
4d4f6a8fac audit: remove unnecessary nil assignment 2020-06-28 02:07:32 +08:00
Lionell Loh Jian An
759708fae7
Apply suggestions from code review
Code Review Changes

Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2020-06-28 01:54:41 +08:00
Mike McQuaid
ba62b988e1
Merge pull request #7840 from Rylan12/remove-iso-8601-hyphen
Remove hyphen in ISO 8601 in rubocops/deprecate_spec.rb
2020-06-27 13:15:55 +01:00
Mike McQuaid
1dac6272f7
Merge pull request #7832 from iMichka/backtrace
install: add backtrace on failure
2020-06-27 13:12:12 +01:00
Mike McQuaid
58de51f2ce
Merge pull request #7837 from FTLam11/7392-migrate-audit-rules-to-rubocop
audit: Move patch checks from brew audit to rubocop
2020-06-27 13:11:51 +01:00
Mike McQuaid
21069e3797
Merge pull request #7696 from Rylan12/audit-shell-variables
style: set shell variables in hash
2020-06-27 13:10:35 +01:00
Michka Popoff
6eb80c67a4 install: add backtrace on failure
The error message might be useless alone
2020-06-27 09:59:56 +02:00
Rylan Polster
9c44e39a39 Remove hyphen in ISO 8601 in rubocops/deprecate_spec.rb 2020-06-26 21:32:18 -04:00
Rylan Polster
e82084583a style: set shell variables in hash
When running Utils.popen (or similar popen command), having a line like
"SHELL=bash ..." doesn't work properly. Instead, use:
`Utils.popen({ "SHELL" => "bash" }, "...")`
2020-06-26 16:39:39 -04:00
Rylan Polster
1df0a62532
Merge pull request #7835 from Rylan12/rubocop-deprecation-date
style: enforce ISO 8601 in deprecation date
2020-06-26 16:19:37 -04:00
Frank Lam
ffb1cc8e19
Find patch nodes nested inside blocks 2020-06-27 03:13:50 +08:00
Frank Lam
b2eafdf11d
Remove patch checks from audit 2020-06-27 02:37:57 +08:00
Frank Lam
afb8445380
Add inline patch checks to patches cop 2020-06-27 01:10:52 +08:00
Rylan Polster
9520eabc35 style: enforce ISO-8601 in deprecation date 2020-06-26 11:53:42 -04:00
Mike McQuaid
8546dc5daf
Merge pull request #7766 from marlonrichert/zsh-completion
Improve zsh completion performance
2020-06-26 15:00:47 +01:00
Mike McQuaid
ac27a98d07
Merge pull request #7836 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-ast-0.1.0
build(deps): bump rubocop-ast from 0.0.3 to 0.1.0 in /Library/Homebrew
2020-06-26 14:59:39 +01:00
William Woodruff
b725d65e9e
Merge pull request #7797 from rmNULL/interpreter-method-for-elfshim
Refactoring keg_relocate to use ELFShim#interpreter
2020-06-26 09:48:22 -04:00
Marlon Richert
b558eb342f Improve zsh completion performance
* Move main completion cache handling to `brew update`.
* Enable completion caching by default.
2020-06-26 09:11:11 +03:00
dependabot-preview[bot]
33a86ba247
build(deps): bump rubocop-ast from 0.0.3 to 0.1.0 in /Library/Homebrew
Bumps [rubocop-ast](https://github.com/rubocop-hq/rubocop-ast) from 0.0.3 to 0.1.0.
- [Release notes](https://github.com/rubocop-hq/rubocop-ast/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop-ast/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop-ast/compare/v0.0.3...v0.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-06-26 05:20:09 +00:00
rmnull
35328ed535
[draft] refactoring keg_relocate to use ELFShim#interpreter instead of .with_interpreter? 2020-06-26 05:34:41 +05:30
Eric Knibbe
db998860f1
Merge pull request #7831 from EricFromCanada/fix-help-output
docs: fixes for help output
2020-06-25 13:08:48 -04:00
Dawid Dziurla
942722ad64
Merge pull request #7830 from vladimyr/crystal
create: add --crystal option
2020-06-25 18:50:26 +02:00
Dario Vladovic
519c339261
create: add --crystal option 2020-06-25 18:23:06 +02:00
Rylan Polster
59f622d4ba
Merge pull request #7823 from Rylan12/rubocop-dstr-string-content
RuboCop string_content keep string interpolation
2020-06-25 12:19:27 -04:00
EricFromCanada
910c85f782 docs: improve commands' help output 2020-06-25 12:01:52 -04:00
EricFromCanada
e62137133e docs: fix comment help output 2020-06-25 11:59:42 -04:00
Rylan Polster
12b49127bb
Merge pull request #7829 from Rylan12/clarify-maintainer-docs
Clarify docs for how PRs should be completed by maintainers
2020-06-25 11:52:31 -04:00
Rylan Polster
32f77955e5 Clarify how PRs should be completed for maintainers 2020-06-25 10:41:52 -04:00
Frank Lam
644ae115f5
Prepare inline patch specs 2020-06-25 22:29:34 +08:00
Lionell
ff7a80ebf5 Merge branch 'master' into license 2020-06-25 21:51:39 +08:00
lionellloh
6a05e3663a Remove Homebrew.failed=true 2020-06-25 21:06:29 +08:00
Rylan Polster
cb187f6846 RuboCop string_content keep string interpolation 2020-06-25 09:05:43 -04:00
lionellloh
2cf0ac9ed5 update-spdx-data: use a more specific file path 2020-06-25 20:34:06 +08:00
Mike McQuaid
adbc50f151
Merge pull request #7826 from MikeMcQuaid/HEAD-default-branch
Refer to default branch in links with HEAD
2020-06-25 12:56:12 +01:00
lionellloh
77a8ff51da single quotes -> double quotes 2020-06-25 19:20:26 +08:00
lionellloh
1b9cbf1bf1 changed method of fetching license data 2020-06-25 19:05:41 +08:00
Mike McQuaid
ac0665daff
Refer to default branch in links with HEAD
Anywhere we can use `blob/master` we can use `blob/HEAD` instead. This
will make life easier if we ever rename our default branch in future
(once/if Git and GitHub provides the necessary tooling to do so).
2020-06-25 11:38:40 +01:00
Lionell
5aa0eb487e rename spec file 2020-06-25 17:51:47 +08:00