Mike McQuaid
ea2892f8ee
brew.rb: handle missing args.
2024-03-07 16:20:20 +00:00
Issy Long
f4218a6316
Fix RuboCop Performance/MapCompact
offenses
...
- Rename an iterator variable since it would make the line too long.
2024-02-25 22:59:59 +00:00
Douglas Eichelberger
eb7c3e52a0
Require SystemInclude only where needed
2024-01-31 11:42:01 -08:00
Douglas Eichelberger
f6c7eb7124
Add hash/keys to extend/
2024-01-19 13:36:17 -08:00
Mike McQuaid
228b1d62ed
cask/artifact/abstract_uninstall: handle signal failures.
...
If the process is running as another user: this will always fail.
2023-12-20 19:43:46 +00:00
Patrick Linnane
9dee80cb2d
various: fix style errors
2023-12-18 09:34:01 -08:00
Mike McQuaid
eb1355e624
Add HOMEBREW_SUDO_THROUGH_SUDO_USER
...
This environment variable allows telling Homebrew to use the `SUDO_USER`
variable to `sudo` through that user when Homebrew (Cask) attempts to
run `sudo`.
While we're here, clarify in some messaging that we're running `sudo`
and that that's the password we're asking for; the specific password is
configuration dependent and not the specific password for the user.
Similarly, remove the `Package installers may write to any location`
output; it's kinda spammy and doesn't feel like the right place.
2023-09-29 18:49:44 +01:00
Bo Anderson
af7d744af0
Fixes for Ruby 3
2023-09-29 05:25:48 +01:00
Markus Reiter
935c5efaf8
Use sudo
for rmdir
if necessary.
2023-05-13 06:46:59 +02:00
Mike McQuaid
0e387fee8c
Merge pull request #15138 from JBYoshi/cask-move-contents
...
Don't remove cask directories when upgrading.
2023-05-04 11:43:44 +01:00
Ilya Kulakov
476d97934f
sudo: change sudo_user to sudo_as_root.
2023-04-28 11:22:54 -07:00
Ilya Kulakov
d470661b37
sudo: add the sudo_user arg to SystemCommand.
2023-04-28 11:11:53 -07:00
Ilya Kulakov
563387a7b4
sudo: explicitly specify the root user where necessary
...
With sudoers one may override default sudo user. This mostly works
provided the admin configured the replacement appropriately. However
there are exceptions that absolutely must be run by root such as
/usr/sbin/installer and, under certain circumstances, /bin/launchctl.
2023-04-28 11:11:53 -07:00
JBYoshi
a1571702d3
Merge remote-tracking branch 'origin/master' into cask-move-contents
2023-04-25 15:44:29 -05:00
Douglas Eichelberger
08af78a2a5
brew style --fix
2023-04-25 09:26:24 -07:00
Douglas Eichelberger
24cf6076e8
brew style --fix
2023-04-24 20:42:39 -07:00
JBYoshi
f97bce040f
Update for feedback.
2023-04-24 10:50:01 -05:00
JBYoshi
9fedaee462
Only keep empty directories when the new version also has them.
2023-04-08 16:13:12 -05:00
JBYoshi
dcc4ae76e8
Also keep app directories with "brew reinstall".
2023-04-04 11:36:27 -05:00
Douglas Eichelberger
4dcd5ac47f
Remove HashValidator
2023-03-19 17:37:58 -07:00
Douglas Eichelberger
516c61057b
Use ActiveSupport Hash#assert_valid_keys instend of refinement
2023-03-19 17:37:58 -07:00
Ruoyu Zhong
e9ce4a5a4e
Update path to system settings on Ventura
...
"System Preferences" has been renamed to "System Settings" on Ventura.
Privacy and security settings have moved, too. This commit makes sure
these changes are reflected. (Some adjustments were already made in
#14092.)
Signed-off-by: Ruoyu Zhong <zhongruoyu@outlook.com>
2023-03-17 19:24:07 +08:00
Douglas Eichelberger
900ee97f95
Revert splat changes to AbstractUninstall
2023-03-07 06:46:59 -08:00
Douglas Eichelberger
d98b7845d3
Enable typing in misc files
2023-03-03 08:29:26 -08:00
apainintheneck
c19017c6bd
Make Cask#to_h work without the API
...
Set metadata when we load casks from the source API.
Set `@tap_git_head` manually.
Also, allow `auto_update` to receive false.
This is only done for consistency.
Stop double printing the `kext` caveat.
Handle Array elements correctly when substituting
path elements in artifacts. This affected how the
Uninstall Signal keys were evaluated (they are
represented as arrays of arrays).
2023-02-28 19:36:20 -08:00
Douglas Eichelberger
29c6baeed1
Enable typing in Cask::Artifact
2023-02-22 09:11:29 -08:00
Bevan Kay
3869bf156c
change line splitting method
2022-12-29 12:54:59 +11:00
Bevan Kay
db9d48a7ec
fix tests
2022-12-28 12:50:16 +11:00
Bevan Kay
2614a29419
fix style
2022-12-19 14:43:16 +11:00
Bevan Kay
84f288be79
fix style
2022-12-19 14:39:48 +11:00
Bevan Kay
1ddd130ef9
add comment to .drop(), don't add blank lines to services array
2022-12-19 14:35:20 +11:00
Bevan Kay
e8e6ee30b4
add initial tests
2022-12-13 00:00:43 +11:00
Bevan Kay
836efe621f
cask/artifiact/abstract_uninstall: allow wildcard entries for launchctl
2022-12-05 15:08:23 +11:00
Bevan Kay
33d3a5d728
cask/artifiact/abstract_uninstall: allow wildcard entries for launchctl
2022-11-09 13:21:49 +11:00
Bo Anderson
eac32f0b20
Additional fixes for Ruby 3 compatibility
2022-10-18 01:54:59 +01:00
Rylan Polster
90d22bc7b1
Include dsl key in cask artifact hash
2022-08-25 03:04:48 -04:00
Bo Anderson
e78665f4f7
Replace ENV["HOME"] with Dir.home
2022-06-17 19:47:57 +01:00
Nanda H Krishna
eecbd5887c
Apply suggestion from review
...
Co-authored-by: Markus Reiter <me@reitermark.us>
2021-03-26 02:28:51 +05:30
nandahkrishna
94737ef41d
cask: add password warning for pkg uninstall
2021-03-26 00:11:39 +05:30
EricFromCanada
6fc116318e
fixes for grammar and wording
2021-01-26 16:19:47 -05:00
EricFromCanada
d0ad829e43
use arrow character for UI prompts
2021-01-26 15:36:43 -05:00
EricFromCanada
571179ff0e
pass second argument to ohai when applicable
2021-01-26 15:36:43 -05:00
Markus Reiter
a01deaaf52
Handle running apps in application.<bundle_id>.<number>.<number>
format.
2020-12-26 14:02:49 +01:00
Carlos Sanchez
278bc77f2d
fix: launchctl list can return empty id
...
causing
Error: undefined method `match?' for nil:NilClass
Seen in macOS Big Sur
2020-11-24 18:12:10 +01:00
Markus Reiter
da9289eff0
Add more type signatures.
2020-11-13 12:26:36 +01:00
EricFromCanada
3768b7a6e9
apidoc: update comment wording, punctuation, formatting
2020-11-06 00:21:02 -05:00
Markus Reiter
24ae318a3d
Move type annotations into files.
2020-10-10 14:59:39 +02:00
Mike McQuaid
fb4d08a49a
Fix brew style
2020-09-11 10:29:22 +01:00
Markus Reiter
5426e47579
Document Artifact
.
2020-08-26 03:13:59 +02:00
Maxime Garcia
65bb03a7db
Fix uninitialized constant Cask::Pkg
2020-07-27 18:04:29 +02:00