Mike McQuaid
5718e87e5e
cmd/upgrade: fix ofail/opoo call.
...
This method doesn't exist on `Kernel` any more. While we're here, let's
avoid `public_send` and use `if` instead for a bit more safety.
2025-08-22 12:54:26 +01:00
Mike McQuaid
3bbff84ff1
Merge pull request #20525 from Homebrew/utils_output
...
Move `o*` output methods to `Utils::Output`
2025-08-22 09:10:29 +00:00
Ruoyu Zhong
625a6c08eb
test/cli/parser: add one more test
2025-08-22 02:04:55 +08:00
Ruoyu Zhong
33a2f410af
cli/parser: convert switch env values to boolean
...
Since switch values are boolean, we should be returning the environment
variable's presence instead of its string value.
Fixes #20531 .
2025-08-22 01:59:54 +08:00
Ruoyu Zhong
6c663837c7
manpages: typed: strict
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2025-08-21 17:27:42 +08:00
Ruoyu Zhong
a03aaef339
bundle/dumper: typed: strict
2025-08-21 17:27:36 +08:00
Ruoyu Zhong
579c31f001
bundle/mac_app_store_dumper: typed: strict
2025-08-21 17:27:36 +08:00
Ruoyu Zhong
1a45660194
bundle/vscode_extension_dumper: typed: strict
2025-08-21 17:27:36 +08:00
Ruoyu Zhong
19d160bfc2
bundle/tap_dumper: typed: strict
2025-08-21 17:27:36 +08:00
Ruoyu Zhong
16bc592e08
settings: typed: strict
2025-08-21 14:19:34 +08:00
Mike McQuaid
a1f112f3fe
Move o*
output methods to Utils::Output
...
This reduces the surface area of our `Kernel` monkeypatch and removes
the need to `include Kernel` in a bunch of modules.
While we're here, also move `Kernel#require?` to `Homebrew` and fully
scope the calls to it.
2025-08-20 19:20:19 +01:00
Ruoyu Zhong
dde6703237
services/formulae: typed strict
...
Co-authored-by: Bo Anderson <mail@boanderson.me>
2025-08-21 01:52:56 +08:00
Ruoyu Zhong
214a88e434
os/mac: typed: strict
...
Co-authored-by: Bo Anderson <mail@boanderson.me>
2025-08-21 01:52:51 +08:00
Ruoyu Zhong
c98505baf7
os/linux/glibc: typed: strict
2025-08-21 01:28:16 +08:00
Mike McQuaid
e4e6185272
Merge pull request #20524 from Homebrew/fetch_api_files_refactoring
...
Refactor Homebrew::API.fetch_api_files! to not take arguments.
2025-08-20 15:26:44 +00:00
Mike McQuaid
d2de1d5b7d
Refactor Homebrew::API.fetch_api_files! to not take arguments.
...
Was thinking about this a bit and feels a bit nicer to DRY this up.
2025-08-20 08:51:11 +01:00
Justin Krehel
1f0ddcc791
formula-analytics: reduce noise from Linux builds
...
Frequent Linux builds add a number of low count unique OS variations to
analytics, so compress into a major version for displaying
2025-08-19 21:42:19 -04:00
Mike McQuaid
88d2b74ee5
dev-cmd/tests: fetch JSON API files if needed.
...
If HOMEBREW_NO_INSTALL_FROM_API was set, we hadn't fetched JSON API
files so will need to fetch them for a valid test environment.
2025-08-19 19:18:31 +01:00
Bo Anderson
5decda29b8
Merge pull request #20518 from Homebrew/doctor-verbose-fix
...
diagnostic: fix error on verbose
2025-08-19 16:45:42 +00:00
Bo Anderson
1ae7394b2c
diagnostic: fix error on verbose
2025-08-19 17:29:44 +01:00
copilot-swe-agent[bot]
8b10231085
Fix conflicts_with stanza odeprecated method call issue
...
Co-authored-by: MikeMcQuaid <125011+MikeMcQuaid@users.noreply.github.com>
2025-08-19 17:07:37 +01:00
copilot-swe-agent[bot]
7f6b4bee93
Implement SHA256 architecture audit as RuboCop rule
...
Co-authored-by: p-linnane <105994585+p-linnane@users.noreply.github.com>
Co-authored-by: MikeMcQuaid <125011+MikeMcQuaid@users.noreply.github.com>
2025-08-19 14:45:01 +01:00
Eric Knibbe
b33443d655
Formula-Cookbook: document stable path variables
2025-08-19 09:04:12 -04:00
Mike McQuaid
a71d5e835f
More Sorbet typed: strict
files
...
Add the necessary changes for Sorbet `typed: strict` in more files.
Co-authored-by: Ruoyu Zhong <zhongruoyu@outlook.com>
2025-08-19 13:03:08 +01:00
Ruoyu Zhong
1eb070e257
diagnostic: don't expand tildes in cask env vars
...
We double quote them so they don't get expanded. Also, use `sh_quote` to
quote the variable values properly.
2025-08-19 16:42:06 +08:00
Ruoyu Zhong
31598ca8ef
diagnostic: improve tilde expansion logic
...
This is a bit pedantic, but the tilde expansion only occurs if the tilde
is at the beginning of the string (if we only take the current user into
account) [1].
[1]: https://pubs.opengroup.org/onlinepubs/9799919799/utilities/V3_chap02.html#tag_19_06_01
2025-08-19 16:42:06 +08:00
Ruoyu Zhong
b749cbcffd
diagnostic: fix cask env var output
...
With `each`, we don't actually output the processed values. We should
therefore be using `filter_map` instead.
2025-08-19 16:42:06 +08:00
Mike McQuaid
6db1f6a052
**/diagnostic.rb: add Sorbet strict sigil.
...
Making more files `typed: strict` slowly but surely.
2025-08-19 09:10:24 +01:00
Mike McQuaid
df589f47cb
Merge pull request #20511 from Homebrew/check_for_symlinked_home_doctor_only
...
os/linux/diagnostic: make check_for_symlinked_home doctor-only.
2025-08-19 07:45:58 +00:00
Mike McQuaid
dc8d920d37
Merge pull request #20510 from Homebrew/cask-env-var-diagnostic-fix
...
diagnostic: fix `check_cask_environment_variables` check
2025-08-19 07:42:27 +00:00
Rylan Polster
f4445d2fba
Merge pull request #20509 from Homebrew/formula-analytics-os-names
...
Fix `formula-analytics` pretty OS name logic
2025-08-19 07:30:46 +00:00
Mike McQuaid
59f0197450
os/linux/diagnostic: make check_for_symlinked_home doctor-only.
...
This avoids printing it every time a `brew install` is run.
2025-08-19 08:30:06 +01:00
Mike McQuaid
e29749fcc2
Merge pull request #20496 from Homebrew/update-report-desc-non-api
...
cmd/update-report: show new formula/cask desc for non-API users too
2025-08-19 07:25:39 +00:00
Ruoyu Zhong
10ec91cdeb
diagnostic: fix check_cask_environment_variables
check
...
Fixes #20505 .
2025-08-19 15:22:58 +08:00
Rylan Polster
4b4378943a
Fix formula-analytics
pretty OS name logic
2025-08-19 03:12:32 -04:00
Ruoyu Zhong
b45f0ecd2e
test/cmd/update-report: fix test
2025-08-19 14:59:40 +08:00
Rylan Polster
b04b0971a1
Enable loading stubbed formulae
2025-08-19 02:47:07 -04:00
Ruoyu Zhong
c481e71092
cmd/update-report: rework
2025-08-19 14:27:05 +08:00
Bo Anderson
99cdd7d8c0
Merge pull request #20507 from Homebrew/api-source-forbid-fix
...
api/formula: use correct method for allowing source path loads
2025-08-19 05:48:01 +00:00
Carlo Cabrera
64e548fb80
Merge pull request #20508 from Homebrew/wrapper-source
...
utils/wrapper.sh: fix `source` calls
2025-08-19 04:50:40 +00:00
Carlo Cabrera
17435f583f
utils/wrapper.sh: fix source
calls
...
We need to `source utils/helpers.sh` before calling `odie`. We also
don't need to `source utils/wrapper.sh` again here, because we are
already in `utils/wrapper.sh`.
2025-08-19 12:21:03 +08:00
Bo Anderson
1fa872f46b
api/formula: use correct method for allowing source path loads
2025-08-19 03:59:08 +01:00
Bo Anderson
60a75e87dd
Merge pull request #20506 from Homebrew/sorbet-files-update
...
sorbet: Update RBI files.
2025-08-19 02:54:23 +00:00
Bevan Kay
69145c911d
cask/dsl/rename: add api support
2025-08-19 11:47:15 +10:00
BrewTestBot
53659cbaa0
sorbet: Update RBI files.
...
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/sorbet.yml ) workflow.
2025-08-19 00:29:42 +00:00
Bo Anderson
a7e338d520
Merge pull request #20501 from Homebrew/formula-no-tab-fix
...
Fix formula installs without a tab
2025-08-18 20:23:33 +00:00
Bo Anderson
4d43063060
Fix formula installs without a tab
2025-08-18 20:23:19 +01:00
Mike McQuaid
3518983f42
Merge pull request #20499 from Homebrew/deprecate_conflicts_with_formula
...
Deprecate `conflicts_with formula:` in Cask DSL.
2025-08-18 18:48:42 +00:00
Ruoyu Zhong
7cec7586ff
cmd/update-report: remove unused methods
2025-08-19 02:39:26 +08:00
Ruoyu Zhong
ee515fd5e0
cmd/update-report: show new formula/cask desc for non-API users too
...
This will make non-API users like myself happy.
2025-08-19 02:35:44 +08:00