admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
9,386 Commits 15 Branches 471 Tags
Commit Graph

424 Commits

Author SHA1 Message Date
Baptiste Fontaine
774a508d1a audit: warn about unknown bottle modifiers 
This prevents typos like `bottle :uneeded` or `bottle :disable`

Closes Homebrew/homebrew#45264.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-10-23 19:44:19 +08:00
Baptiste Fontaine
abfaa59e06 MacOS: full_version added 
Closes Homebrew/homebrew#44988.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-10-18 22:57:42 +08:00
Xu Cheng
8c4bd3dae2 audit: use ARGV.resolved_formula 
There are audit rules which check cellar. Therefore, we need
`ARGV.resolved_formula` to get proper spec and prefix.

Closes Homebrew/homebrew#44781.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-10-10 01:34:43 +08:00
Xu Cheng
ee332c4550 handle TapFormulaWithOldnameAmbiguityError 
Closes Homebrew/homebrew#44705.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-10-08 16:02:33 +08:00
Daniel Lee Harple
6b3b398858 audit: fix GitHub repository audit 
In the data returned from the GitHub API, “watchers_count” is actually the
number of stars.

See https://developer.github.com/v3/activity/starring/#starring-vs-watching

Closes Homebrew/homebrew#44477.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-10-07 19:48:24 +08:00
Andrew Janke
4c80bf4324 audit: add check for 'head' and 'head do' both present 
Closes Homebrew/homebrew#44626.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
 2015-10-07 09:41:24 +02:00
Xu Cheng
bd4525b64a mpich2 is renamed as mpich 2015-09-13 20:57:43 +08:00
Xu Cheng
002f8f2eb7 audit: handle tap aliases 2015-09-13 17:33:35 +08:00
Xu Cheng
67c3f8ff27 audit: cache formula names during audit_formula_name 
Before `audit_formula_name: 15.094845999999986`
After `audit_formula_name: 0.5617120000000043`

Closes Homebrew/homebrew#43663.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-09-08 11:04:49 +08:00
Xu Cheng
e370f005c0 audit: simplify remote_official_taps 2015-09-08 11:04:49 +08:00
Daniel Lee Harple
4e5d92dc10 audit: spelling fix 
Closes Homebrew/homebrew#43273.

Signed-off-by: Tim D. Smith <git@tim-smith.us>
 2015-08-25 08:24:04 -07:00
Xu Cheng
a88c40b8c8 core file style update 2015-08-22 13:15:33 +08:00
Baptiste Fontaine
8ba0fb9fcf unnecessary calls to .select simplified 
These are minor perf optimizations.

Closes Homebrew/homebrew#43028.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
 2015-08-18 00:18:22 +02:00
Viktor Szakats
0d4da4234a audit: enforce https on [*.]archive.org 
Also:
* one minor regexp tweak

Closes Homebrew/homebrew#42761.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-08-11 19:04:23 +01:00
Dominyk Tiller
64bcb5a07f audit: catch insecure bitbucket 2015-08-10 19:12:24 +01:00
Vlad Shablinsky
556ab3bcd6 audit: add rules for naming 
- restrict old names as names of new formulae
- warn about dependencies on old names
 2015-08-10 13:57:58 +01:00
Dominyk Tiller
970992d5bf audit: prune redundant code 2015-08-10 02:39:38 +01:00
Dominyk Tiller
d25d3b07da audit: flag insecure launchpad 2015-08-10 02:25:59 +01:00
Mike McQuaid
3518cda792 audit: allow assert !.*.include?. 
Came up on Homebrew/homebrew#34573.
 2015-08-09 09:33:33 +01:00
Alexis Hildebrandt
f78a63984b audit: add check for indefinite article 
at the beginning of desc.

Closes Homebrew/homebrew#42404.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
 2015-08-06 18:10:48 +01:00
Xu Cheng
ae0e270727 favor flat_map over map...flatten 2015-08-06 22:33:46 +08:00
Xu Cheng
b121e5fd7b more core file style updated by rubocop 2015-08-06 17:23:56 +08:00
Alexis Hildebrandt
e9180b39f5 audit: simplify command-line spelling check 
Closes Homebrew/homebrew#42403.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
 2015-08-05 20:19:40 +01:00
Dominyk Tiller
150a9fe514 audit: flag plaintext mirrorservice 2015-08-05 19:45:24 +01:00
BrewTestBot
13d544e11e Core files style updates. 
Closes Homebrew/homebrew#42354.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-08-03 13:22:35 +01:00
Baptiste Fontaine
79678cb109 online audit: use GET instead of HEAD 
I also removed the `-L` flag which is already present in
`HOMEBREW_CURL_ARGS`.

Closes Homebrew/homebrew#42352.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
 2015-08-02 11:15:52 +02:00
Xu Cheng
ea21f9bc4d audit: more fix on no-compat mode 2015-07-22 16:41:10 +08:00
Xu Cheng
2648684b3b audit: rename audit_patches to audit_legacy_patches 2015-07-22 16:34:08 +08:00
Xu Cheng
51810ae1ea audit: fix for no-compat mode 2015-07-22 15:27:58 +08:00
Rainer M. Krug
86d04e94e9 audit: recognise head-only and devel-only taps. 
add wildcard into expressions to identify head-only and dev-only taps
to avoid "head-only" and "devel-only" errors when formula is in
*head-only or *devel-only tap

Closes Homebrew/homebrew#41289.
Closes Homebrew/homebrew#41413.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-07-18 20:50:12 -07:00
Baptiste Fontaine
6303ff7e28 audit: missing spaces added in blocks order report 
Closes Homebrew/homebrew#41783.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
 2015-07-18 10:45:47 +02:00
Mike McQuaid
24b0639e27 audit: recommend use of assert_match. 
It produces significantly easier output to debug than doing `assert` and
`.include?` (which just shows if it passed or failed).

Closes Homebrew/homebrew#41662.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-07-14 11:54:38 -07:00
Dominyk Tiller
b554c8bcca audit: clarify desc calculation 2015-07-14 17:15:51 +01:00
Baptiste Fontaine
3ba3ecba9d audit --online: check homepage reachability 
Closes Homebrew/homebrew#41607.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
 2015-07-12 20:32:15 +02:00
Mike McQuaid
4f74e891aa audit: deprecate sha1 always. 
Rather than just when --strict is set. We're asking people to do these
on most PRs now anyway so feels better to let them find this out with
`brew audit`.

Closes Homebrew/homebrew#41523.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-07-09 17:45:53 +01:00
Mike McQuaid
8e7f15eff4 audit: include date for Ruby 1.8. 2015-07-09 15:28:49 +01:00
Xu Cheng
f68869cc70 audit: better way to handle --online for audit_formula_name 2015-07-09 22:06:53 +08:00
Mike McQuaid
3ac6005931 audit: add --online flag. 
Also add it to the manpage and brew-test-bot.

Closes Homebrew/homebrew#41516.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-07-09 14:50:55 +01:00
Mike McQuaid
804f1431d4 audit: github repo: verify stable formula is set . 2015-07-08 16:28:51 +01:00
Mike McQuaid
333c3d700f audit: slightly loosen GitHub repo audit. 2015-07-08 15:29:55 +01:00
Mike McQuaid
c0c68b2b3f audit: handle some GitHub repo audit edge cases. 2015-07-08 15:19:36 +01:00
Mike McQuaid
51a1792e7a Audit GitHub repository notability. 
This stuff seems to be taken better when coming from a script rather
than from a human. Feel free to disagree about the specific numbers
chosen here.
 2015-07-08 14:53:48 +01:00
Viktor Szakats
c443fe139d audit: fix/extend ietf.org https rules 
Domains known to be covered by certificates: https://crt.sh/?q=%25ietf.org

Closes Homebrew/homebrew#41244.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-07-02 21:31:10 +01:00
Dominyk Tiller
986a62ebe9 audit: flag re-added tap migrations 
Re 411c217844 (commitcomment-11714539)

Closes Homebrew/homebrew#40806.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
 2015-06-30 03:00:32 +01:00
Jack Nagel
22269b7007 Fix audit when tap is nil 
This is the case when a formula is passed as a filename.
 2015-06-23 19:58:37 -04:00
Xu Cheng
b363175401 improve audit_formula_name performance 
Closes Homebrew/homebrew#40939.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-06-22 21:24:50 +08:00
Xu Cheng
d770a874e4 audit: add benchmark inject code 
Closes Homebrew/homebrew#40847.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-06-18 20:30:33 +08:00
Xu Cheng
2f44990ea9 Revert "audit: add benchmark inject code" 
This reverts commit fb23d603ded2796299ed7fc2f4ffee22870b7ea6.
 2015-06-18 15:26:11 +08:00
Xu Cheng
7a59a3ee37 audit: add benchmark inject code 2015-06-18 14:46:29 +08:00
Mike McQuaid
1e86730289 Rename requirements named *Dependency. 
Dependency is another similar, related class and it's super confusing
to have some Requirements that are named *Dependency.

Closes Homebrew/homebrew#38891.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-06-16 08:12:01 +01:00